hsmhsm added a comment. In D110257#3133934 <https://reviews.llvm.org/D110257#3133934>, @JonChesterfield wrote:
> In D110257#3133895 <https://reviews.llvm.org/D110257#3133895>, @hsmhsm wrote: > >> In D110257#3133879 <https://reviews.llvm.org/D110257#3133879>, >> @JonChesterfield wrote: >> >>> In D110257#3133866 <https://reviews.llvm.org/D110257#3133866>, @hsmhsm >>> wrote: >>> >>>> This is not something specific to AMDGPU backend, but AMDGPU backend at >>>> present requires this canonical form. >>> >>> Undocumented and not checked by the IR verifier. Canonical form seems to be >>> overstating it until at least one of those is addressed. >> >> We already discussed that this canonical form is not something that IR >> verifier can verify, but it is good enough for better code >> transformation/optimization. Please refer llvm-dev email discussion w.r.t it. > > If the new invariant is that all alloca must be adjacent to one another, > that's a trivial thing for the verifier to check. So I guess it's something > else? Please write down what this new invariant is intended to be, preferably > in the documentation, perhaps of the alloca instruction. Please check with llvm-dev. > What llvm-dev discussion do you refer to? I do not remember, please search for keywords, like static allocas, and figure out. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110257/new/ https://reviews.llvm.org/D110257 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
