[PATCH] D113738: [LTO] Allow passing -Os/-Oz as the optimization level

thevinster added inline comments. Comment at: lld/Common/Args.cpp:29 +OptimizationLevel args::getOptLevel(llvm::opt::InputArgList &args, +unsigned int key, nit: `getOptLevel` seems a bit too generic for something that's LTO s

[PATCH] D113558: [clang-tidy] Fix cppcoreguidelines-virtual-base-class-destructor in macros

whisperity accepted this revision. whisperity added a comment. This revision is now accepted and ready to land. The fix is concise, thank you for observing and untangling the crash! As the check was originally introduced in the ongoing release, we can go without a release notes entry. ===

[PATCH] D64454: [clang-tidy] Adding static analyzer check to list of clang-tidy checks

whisperity added a comment. In D64454#3124423 , @carlosgalvezp wrote: > I was a bit confused as well about the ClangSA support in clang-tidy. What's > the current status? Is clang-tidy running *all* checks from StaticAnalyzer? If your package is built w

[PATCH] D113863: [clang-tidy] Make `readability-container-data-pointer` more robust

whisperity added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/ContainerDataPointerCheck.cpp:20-23 +static const char ContainerExprName[] = "container-expr"; +static const char DerefContainerExprName[] = "deref-container-expr"; +static const char AddrofCo

[PATCH] D113779: [Clang] Add mfp16, mfp16fml and mdotprod flags for ARM target features.

SjoerdMeijer added a comment. This introduces another way of setting (optional) architecture extensions and having two ways to do the same is nearly always a bad thing, which is how one of my colleagues phrased it. This was already a complex area and thus I don't think introducing another is g

[PATCH] D113848: [clang-tidy][NFC] Refactor ClangTidyDiagnosticConsumer files

whisperity added a comment. What is the motivation behind the change? Can we be sure that these classes that were moved out weren't details to the context itself, and are understandable, usable, and can be relied upon without the context object? In D113848#3130542

[PATCH] D113847: [clang-tidy][NFC] Simplify ClangTidyStats

whisperity added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.h:50 struct ClangTidyStats { - ClangTidyStats() - : ErrorsDisplayed(0), ErrorsIgnoredCheckFilter(0), ErrorsIgnoredNOLINT(0), -ErrorsIgnoredNonUserCode(0), Errors

[PATCH] D113847: [clang-tidy][NFC] Simplify ClangTidyStats

carlosgalvezp added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.h:50 struct ClangTidyStats { - ClangTidyStats() - : ErrorsDisplayed(0), ErrorsIgnoredCheckFilter(0), ErrorsIgnoredNOLINT(0), -ErrorsIgnoredNonUserCode(0), Err

[PATCH] D113848: [clang-tidy][NFC] Refactor ClangTidyDiagnosticConsumer files

carlosgalvezp added a comment. > What is the motivation behind the change? The motivation is cleaning the file to make it easier to find things. As a n00b to clang-tidy I find it a bit hard to navigate the code and find the different classes - they are not where I expect them to be. The `ClangT

[PATCH] D113779: [Clang] Add mfp16, mfp16fml and mdotprod flags for ARM target features.

fhahn added a comment. In D113779#3130701 , @SjoerdMeijer wrote: > This introduces another way of setting (optional) architecture extensions and > having two ways to do the same is nearly always a bad thing, which is how one > of my colleagues phrased

[PATCH] D113776: [Clang][SVE] Properly enable/disable dependant SVE target features based upon +(no)sve.* options

peterwaller-arm added inline comments. Comment at: llvm/unittests/Support/TargetParserTest.cpp:908 + AArch64::AEK_I8MM | AArch64::AEK_SVE | + AArch64::AEK_SVE2 | AArch64::AEK_SVE2BITPERM | AArch

[PATCH] D113779: [Clang] Add mfp16, mfp16fml and mdotprod flags for ARM target features.

DavidSpickett added subscribers: manojgupta, DavidSpickett. DavidSpickett added a comment. There was a similar proposal for crypto https://reviews.llvm.org/D60472. Quoting @manojgupta for the pitch for that: > The motivation for this change is to make "crypto" setting an additive option > e.g.

[PATCH] D113118: [clang][AST] Check context of record in structural equivalence.

balazske added a comment. In the last case the the RecordDecl's `a` and `b` can be matched (not internal statements in a function) and this is similar to the existing test cases. The `struct a` and `struct b` already fails to match because different name. Comment at: clang/li

[PATCH] D113779: [Clang] Add mfp16, mfp16fml and mdotprod flags for ARM target features.

DavidSpickett added a comment. (I should note that crytpo isn't the best example because it means different things to different base architectures, that part doesn't apply here) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113779/new/ https://rev

[PATCH] D113779: [Clang] Add mfp16, mfp16fml and mdotprod flags for ARM target features.

fhahn added a comment. In D113779#3130744 , @DavidSpickett wrote: > There was a similar proposal for crypto https://reviews.llvm.org/D60472. > > Quoting @manojgupta for the pitch for that: > >> The motivation for this change is to make "crypto" setting a

[PATCH] D113201: [clang-tidy] Fix a crash in modernize-loop-convert around conversion operators

whisperity added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/LoopConvertUtils.cpp:155-167 +/// Look through conversion/copy constructors and operators to find the explicit /// initialization expression, returning it is found. /// /// The main idea is t

[PATCH] D113148: Add new clang-tidy check for string_view(nullptr)

whisperity added a comment. In D113148#3109190 , @CJ-Johnson wrote: > In D113148#3108993 , @aaron.ballman > wrote: > >> Generally speaking, we prefer to improve the existing checks. I think >> `bugprone-string-

[PATCH] D111100: enable plugins for clang-tidy

whisperity added a comment. Wait... Is the diff //really// supposed to be this small? You didn't include code... that one header takes care of **everything**? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D00/new/ https://reviews.llvm.org/D

[PATCH] D113118: [clang][AST] Check context of record in structural equivalence.

balazske updated this revision to Diff 387181. balazske added a comment. Updated tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113118/new/ https://reviews.llvm.org/D113118 Files: clang/lib/AST/ASTStructuralEquivalence.cpp clang/unittest

[PATCH] D113752: [Parse] Use empty RecoveryExpr when if/while/do/switch conditions fail to parse

hokein added a comment. this looks great, some nits and questions. Comment at: clang/lib/Parse/ParseStmt.cpp:1194 SourceLocation Loc, - Sema::ConditionKind CK, +

[PATCH] D113779: [Clang] Add mfp16, mfp16fml and mdotprod flags for ARM target features.

paulwalker-arm added a comment. Rather than adding connivence options after the fact what about allowing `-march=` to be specified multiple times? The first must be the usual format with later ones required to start with `+`. The defined parsing behaviour would be as if there was a single `-ma

[PATCH] D113489: [AArch64][SVE] Instcombine SVE LD1/ST1 to stock LLVM IR

peterwaller-arm added inline comments. Comment at: clang/test/CodeGen/aarch64-sve-intrinsics/acle_sve_st1w.c:235 +// CHECK-NEXT:ret void +// void test_svst1w_scatter_u64base_index_u64(svbool_t pg, svuint64_t bases, int64_t index, svuint64_t data) Unfortunat

[PATCH] D113489: [AArch64][SVE] Instcombine SVE LD1/ST1 to stock LLVM IR

peterwaller-arm added a comment. It looks like some auto-generation lines were added in 91eda9c30f33da6ec6da70b59a5f5da6c6397039 , but the tests using CHECK-DAG were not actually auto-generated. It seems we could either clean

[PATCH] D109703: [DebugInfo] Fix scope for local static variables

krisb abandoned this revision. krisb added a comment. Abandon in favor of https://reviews.llvm.org/D113741. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109703/new/ https://reviews.llvm.org/D109703 ___

[PATCH] D113558: [clang-tidy] Fix cppcoreguidelines-virtual-base-class-destructor in macros

steakhal updated this revision to Diff 387189. steakhal marked 2 inline comments as done. steakhal added a comment. Add fixme comment for: class FooBar2 { protected: virtual CONCAT(~Foo, Bar2()); // FIXME: We should have a fixit for this. }; CHANGES SINCE LAST ACTION https://reviews

[PATCH] D113489: [AArch64][SVE] Instcombine SVE LD1/ST1 to stock LLVM IR

peterwaller-arm added a comment. My current thinking is that the route forward is to update the tests without update test checks, which affects only the st1{b,h,w} files, and possibly to remove the false header implying these files were autogenerated. Repository: rG LLVM Github Monorepo CHA

[clang] 9fec50f - [cmake] use project relative paths when generating ASTNodeAPI.json

Author: Matheus Izvekov Date: 2021-11-15T12:35:34+01:00 New Revision: 9fec50f001b1ab86ff36c6e92336ae1c1d3fcdef URL: https://github.com/llvm/llvm-project/commit/9fec50f001b1ab86ff36c6e92336ae1c1d3fcdef DIFF: https://github.com/llvm/llvm-project/commit/9fec50f001b1ab86ff36c6e92336ae1c1d3fcdef.dif

[PATCH] D113664: [cmake] use project relative paths when generating ASTNodeAPI.json

This revision was automatically updated to reflect the committed changes. Closed by commit rG9fec50f001b1: [cmake] use project relative paths when generating ASTNodeAPI.json (authored by mizvekov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113664

[PATCH] D113880: [clang][modules] Infer framework modules in explicit builds

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith, vsapsai. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When the dependency scanner discovers dependency on an inferred module, it corre

[PATCH] D113775: [clang][modules] Umbrella with missing submodule: unify implicit & explicit

jansvoboda11 added inline comments. Comment at: clang/test/Modules/missing-submodule.m:3 // RUN: %clang_cc1 -fmodules -fimplicit-module-maps -fmodules-cache-path=%t -F %S/Inputs %s -verify +// RUN: %clang_cc1 -fmodules -fimplicit-module-maps -F %S/Input

[PATCH] D113828: [clang-tidy] Fix false positives in `fuchsia-trailing-return` check involving deduction guides

juliehockett resigned from this revision. juliehockett added a comment. Apologies, i's been a good long while since I was active in this area. @phosek is the most likely to know who would be the best contact in the future. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D113775: [clang][modules] Umbrella with missing submodule: unify implicit & explicit

jansvoboda11 updated this revision to Diff 387199. jansvoboda11 added a comment. Add `-fno-implicit-modules` to test case to make it more obvious. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113775/new/ https://reviews.llvm.org/D113775 Files:

[PATCH] D113422: [clang-tidy][NFC] Move CachedGlobList to GlobList.h

carlosgalvezp added a comment. Kind ping @aaron.ballman @whisperity Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113422/new/ https://reviews.llvm.org/D113422 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D113844: [clang-format] [NFC] build clang-format with -Wall

MyDeveloperDay added a comment. In D113844#3130186 , @HazardyKnusperkeks wrote: > Is okay, but I think the compiler is a bit overreacting, since there is only > one call (chain). I agree, but I think I saw that one of the buildbot was running with -Wal

[clang-tools-extra] 29a8d45 - [clang-tidy] Fix a crash in modernize-loop-convert around conversion operators

Author: Kristóf Umann Date: 2021-11-15T13:11:29+01:00 New Revision: 29a8d45c5a239c9fa6b8634a9de3d655064816d1 URL: https://github.com/llvm/llvm-project/commit/29a8d45c5a239c9fa6b8634a9de3d655064816d1 DIFF: https://github.com/llvm/llvm-project/commit/29a8d45c5a239c9fa6b8634a9de3d655064816d1.diff

[PATCH] D113201: [clang-tidy] Fix a crash in modernize-loop-convert around conversion operators

This revision was automatically updated to reflect the committed changes. Szelethus marked 2 inline comments as done. Closed by commit rG29a8d45c5a23: [clang-tidy] Fix a crash in modernize-loop-convert around conversion operators (authored by Szelethus). Changed prior to commit: https://reviews

[PATCH] D113776: [Clang][SVE] Properly enable/disable dependant SVE target features based upon +(no)sve.* options

bsmith updated this revision to Diff 387212. bsmith edited the summary of this revision. bsmith added a comment. Herald added a subscriber: kristof.beyls. - Fix duplicate arch feature in unit test - Use enum class instead of plain enum with typedef Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D113422: [clang-tidy][NFC] Move CachedGlobList to GlobList.h

whisperity added inline comments. Comment at: clang-tools-extra/clang-tidy/GlobList.h:50-52 +/// A \p GlobList that caches search results, so that search is performed only +/// once for the same query. +class CachedGlobList { If `CachedGlobList` //is-a// `GlobLis

[PATCH] D113489: [AArch64][SVE] Instcombine SVE LD1/ST1 to stock LLVM IR

paulwalker-arm accepted this revision. paulwalker-arm added a comment. This revision is now accepted and ready to land. There's an issue with the a `Value*` being named `VecPtrTy` but otherwise this looks good to me. I'll leave it up to you to decide whether it's worth breaking out the usage of

[PATCH] D113804: [clang-tidy] Fix behavior of `modernize-use-using` with nested structs/unions

whisperity added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/UseUsingCheck.h:27 SourceLocation LastReplacementEnd; - SourceRange LastTagDeclRange; + std::map LastTagDeclRanges; + Considering the pointer is just a number that hashes we

[PATCH] D113847: [clang-tidy][NFC] Simplify ClangTidyStats

aaron.ballman added a comment. Btw, I'm in WG14 (C) standards meetings all week this week and on vacation next week, so my availability for code reviews is pretty limited for the next while. So despite my comments here, if you don't get a response back from me in a timely manner, don't hold up

[PATCH] D113148: Add new clang-tidy check for string_view(nullptr)

aaron.ballman added a comment. In D113148#3130779 , @whisperity wrote: > In D113148#3109190 , @CJ-Johnson > wrote: > >> In D113148#3108993 , >> @aaron.ballman wrote: >>

[PATCH] D112143: [X86][ABI] Do not return float/double from x87 registers when x87 is disabled

pengfei added inline comments. Comment at: clang/test/Driver/x86-target-features.c:5 // RUN: %clang -target i386-unknown-linux-gnu -march=i386 -mno-80387 %s -### -o %t.o 2>&1 | FileCheck -check-prefix=NO-X87 %s +// RUN: %clang -target i386-unknown-linux-gnu -march=i386 -mno-fp-

[PATCH] D109751: [Clang] Support conversion between PPC double-double and IEEE float128

nemanjai requested changes to this revision. nemanjai added a comment. This revision now requires changes to proceed. Please provide a description for this patch which includes justification for why we want to allow conversion between the two types. I am of the impression that allowing the two ty

[PATCH] D113847: [clang-tidy][NFC] Simplify ClangTidyStats

carlosgalvezp added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.h:50 struct ClangTidyStats { - ClangTidyStats() - : ErrorsDisplayed(0), ErrorsIgnoredCheckFilter(0), ErrorsIgnoredNOLINT(0), -ErrorsIgnoredNonUserCode(0), Err

[PATCH] D113847: [clang-tidy][NFC] Simplify ClangTidyStats

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.h:50 struct ClangTidyStats { - ClangTidyStats() - : ErrorsDisplayed(0), ErrorsIgnoredCheckFilter(0), ErrorsIgnoredNOLINT(0), -ErrorsIgnoredNonUserCode(0), Err

[PATCH] D107994: Making the code compliant to the documentation about Floating Point support default values for C/C++. FPP-MODEL=PRECISE enables FFP-CONTRACT (FMA is enabled).

zahiraam added a comment. In D107994#3130494 , @wristow wrote: > The Release Note change here says: > > Floating Point Support in Clang > --- > - The -ffp-model=precise now implies -ffp-contract=on rather than > -ffp-

[PATCH] D113847: [clang-tidy][NFC] Simplify ClangTidyStats

carlosgalvezp updated this revision to Diff 387231. carlosgalvezp edited the summary of this revision. carlosgalvezp added a comment. - Use = initialization. - Revert to unsigned. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113847/new/ https://reviews.llvm.org/D113847 Files: clang-

[PATCH] D113847: [clang-tidy][NFC] Simplify ClangTidyStats

carlosgalvezp added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.h:50 struct ClangTidyStats { - ClangTidyStats() - : ErrorsDisplayed(0), ErrorsIgnoredCheckFilter(0), ErrorsIgnoredNOLINT(0), -ErrorsIgnoredNonUserCode(0), Err

[PATCH] D113422: [clang-tidy][NFC] Move CachedGlobList to GlobList.h

carlosgalvezp added inline comments. Comment at: clang-tools-extra/clang-tidy/GlobList.h:50-52 +/// A \p GlobList that caches search results, so that search is performed only +/// once for the same query. +class CachedGlobList { whisperity wrote: > If `CachedGlob

[PATCH] D108301: [MSP430][Clang] Update hard-coded MCU data

jozefl added a comment. Ping. Thanks, Jozef Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108301/new/ https://reviews.llvm.org/D108301 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

[PATCH] D109174: [MSP430][Clang] Infer CPU type from -mcpu= or -mmcu=

jozefl added a comment. Ping. Thanks, Jozef Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109174/new/ https://reviews.llvm.org/D109174 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

[PATCH] D110216: [clang] retain type sugar in auto / template argument deduction

mstorsjo added a comment. This broke building ANGLE as part of Qt 5.15 for a mingw target, with the following error: ../../../3rdparty/angle/src/libANGLE/renderer/d3d/d3d11/ResourceManager11.cpp:532:38: error: explicit instantiation of 'allocate' does not refer to a function template, varia

[PATCH] D110216: [clang] retain type sugar in auto / template argument deduction

mstorsjo added a comment. In D110216#3130193 , @mizvekov wrote: > In D110216#3130184 , @mstorsjo > wrote: > >> Do you happen to know what's going on here? The files mentioned are >> https://code.qt.io/cgit/qt/qt

[PATCH] D110216: [clang] retain type sugar in auto / template argument deduction

mizvekov added a comment. In D110216#3130184 , @mstorsjo wrote: > Do you happen to know what's going on here? The files mentioned are > https://code.qt.io/cgit/qt/qtbase.git/tree/src/3rdparty/angle/src/libANGLE/renderer/d3d/d3d11/ResourceManager11.cpp?h=

[PATCH] D110216: [clang] retain type sugar in auto / template argument deduction

RobRich999 added a comment. Hit libANGLE in Chromium today, too. https://bugs.chromium.org/p/chromium/issues/detail?id=1270154 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110216/new/ https://reviews.llvm.org/D110216

[PATCH] D110216: [clang] retain type sugar in auto / template argument deduction

mizvekov reopened this revision. mizvekov added a comment. Reverting for now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110216/new/ https://reviews.llvm.org/D110216 ___ cfe-commits mailing list cfe-c

[PATCH] D112430: [ARM][libunwind] add PACBTI-M support for libunwind

stuij updated this revision to Diff 387237. stuij added a comment. addressed review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112430/new/ https://reviews.llvm.org/D112430 Files: clang/lib/Headers/unwind.h libunwind/include/libunwi

[PATCH] D113422: [clang-tidy][NFC] Move CachedGlobList to GlobList.h

carlosgalvezp added inline comments. Comment at: clang-tools-extra/clang-tidy/GlobList.h:50-52 +/// A \p GlobList that caches search results, so that search is performed only +/// once for the same query. +class CachedGlobList { carlosgalvezp wrote: > whisperity

[PATCH] D113889: [NFC] disabling clang-tidy check readability-identifier-naming in Protocol.h

kuhnel created this revision. Herald added subscribers: carlosgalvezp, usaxena95, kadircet, arphaman. kuhnel added subscribers: sammccall, hokein, adamcz, kbobyrev. kuhnel published this revision for review. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. The fil

[PATCH] D113889: [NFC] disabling clang-tidy check readability-identifier-naming in Protocol.h

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/Protocol.h:39 +/* This file is using the LSP syntax for identifier names which is different + from the LLVM coding standard. To avoid the clang-tidy warnings, we're Nit: we're only using C-sty

[clang-tools-extra] d896c9f - Fix an unused variable warning

Author: Kirstóf Umann Date: 2021-11-15T15:45:43+01:00 New Revision: d896c9f40a22690d80cdf88152adbe591fd83d90 URL: https://github.com/llvm/llvm-project/commit/d896c9f40a22690d80cdf88152adbe591fd83d90 DIFF: https://github.com/llvm/llvm-project/commit/d896c9f40a22690d80cdf88152adbe591fd83d90.diff

[PATCH] D113891: [NFC][clangd] cleaning up unused "using"

kuhnel created this revision. Herald added subscribers: carlosgalvezp, usaxena95, kadircet, arphaman. kuhnel added subscribers: hokein, sammccall, adamcz, kbobyrev. kuhnel published this revision for review. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clan

[clang] 485c193 - Regenerate acle_st1*.c tests

Author: Matt Devereau Date: 2021-11-15T15:07:52Z New Revision: 485c193aa12addea13a0db12f4c6bc6252244319 URL: https://github.com/llvm/llvm-project/commit/485c193aa12addea13a0db12f4c6bc6252244319 DIFF: https://github.com/llvm/llvm-project/commit/485c193aa12addea13a0db12f4c6bc6252244319.diff LOG:

[PATCH] D113896: [NFC][clangd] cleanup of header guard names

kuhnel created this revision. Herald added subscribers: carlosgalvezp, wenlei, usaxena95, kadircet, arphaman. kuhnel added subscribers: sammccall, adamcz, kbobyrev. kuhnel published this revision for review. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clan

[PATCH] D113898: [NFC][clangd] cleaning up llvm-qualified-auto

kuhnel created this revision. Herald added subscribers: carlosgalvezp, usaxena95, kadircet, arphaman, javed.absar. kuhnel added subscribers: sammccall, adamcz, kbobyrev. kuhnel published this revision for review. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project

[PATCH] D113891: [NFC][clangd] cleaning up unused "using"

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113891/new/ https://reviews.llvm.org/D113891

[PATCH] D113776: [Clang][SVE] Properly enable/disable dependant SVE target features based upon +(no)sve.* options

mgabka added inline comments. Comment at: clang/test/Driver/aarch64-implied-sve-features.c:28 + +// RUN: %clang -target aarch64-linux-gnu -march=armv8-a+nosve2-bitperm %s -### |& FileCheck %s --check-prefix=NOSVE2-BITPERM +// NOSVE2-BITPERM-NOT: "-target-feature" "+sve2-bitperm"

[PATCH] D113779: [Clang] Add mfp16, mfp16fml and mdotprod flags for ARM target features.

manojgupta added a comment. Yes, the current approach of "-march=+feature" is terrible and does not work with developers who want flexibility of features. This being pitched as a feature imo is akin to promoting a design bug as a feature. Any additive or subtractive alternative is welcome. Re

[PATCH] D113896: [NFC][clangd] cleanup of header guard names

sammccall added a comment. Mostly LG, just a few files are test inputs and one is empty Comment at: clang-tools-extra/clangd/test/Inputs/background-index/sub_dir/foo.h:1 -#ifndef FOO_H -#define FOO_H +#ifndef LLVM_CLANG_TOOLS_EXTRA_CLANGD_TEST_INPUTS_BACKGROUND_INDEX_SUB_DIR_

[PATCH] D112430: [ARM][libunwind] add PACBTI-M support for libunwind

danielkiss accepted this revision. danielkiss added a comment. LGTM, Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112430/new/ https://reviews.llvm.org/D112430 ___ cfe-commits mailing list cfe-co

[clang] da168dd - [clang] Allow clang-check to customize analyzer output file or dir name

Author: Ella Ma Date: 2021-11-15T16:49:41+01:00 New Revision: da168dd875bf0392e8e88834009d776bfbaae376 URL: https://github.com/llvm/llvm-project/commit/da168dd875bf0392e8e88834009d776bfbaae376 DIFF: https://github.com/llvm/llvm-project/commit/da168dd875bf0392e8e88834009d776bfbaae376.diff LOG:

[PATCH] D97265: [clang] Allow clang-check to customize analyzer output file or dir name

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGda168dd875bf: [clang] Allow clang-check to customize analyzer output file or dir name (authored by OikawaKirie, committed by kbobyrev). Herald added

[PATCH] D97265: [clang] Allow clang-check to customize analyzer output file or dir name

kbobyrev added a comment. Hey, I'm really sorry, I missed this, too but I just landed the patch for you, apologies for such a huge delay. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97265/new/ https://reviews.llvm.org/D97265 ___

[clang] 0e73832 - [openmp][amdgpu] Add comment warning that libm may be broken

Author: Jon Chesterfield Date: 2021-11-15T15:56:01Z New Revision: 0e738323a9c445e31b4e1b1dcb2beb19d6f103ef URL: https://github.com/llvm/llvm-project/commit/0e738323a9c445e31b4e1b1dcb2beb19d6f103ef DIFF: https://github.com/llvm/llvm-project/commit/0e738323a9c445e31b4e1b1dcb2beb19d6f103ef.diff L

[PATCH] D112639: [openmp][amdgpu] Add comment warning that libm may be broken

This revision was automatically updated to reflect the committed changes. Closed by commit rG0e738323a9c4: [openmp][amdgpu] Add comment warning that libm may be broken (authored by JonChesterfield). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D11263

[PATCH] D113898: [NFC][clangd] cleaning up llvm-qualified-auto

sammccall added a comment. There is a reasonable style rule here, but: - the suggested fixes spell out `const` in ways we generally prefer not to. (And the rule doesn't require). - Strings are a special case. `auto*` for string literals makes no sense to me, the check should be modified to eith

[PATCH] D113902: [NFC][clangd] exclude test data from clang-tidy

kuhnel created this revision. Herald added subscribers: usaxena95, kadircet, arphaman. kuhnel added subscribers: sammccall, adamcz, kbobyrev. kuhnel published this revision for review. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov, aheejin. Herald added a project: clang-tools-extra.

[PATCH] D113899: [NFC][clangd] fix clang-tidy finding on isa_and_nonnull

kuhnel created this revision. Herald added subscribers: carlosgalvezp, usaxena95, kadircet, arphaman. kuhnel added subscribers: sammccall, kbobyrev, adamcz. kadircet added inline comments. kuhnel published this revision for review. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Hera

[PATCH] D113895: [NFC][clangd] fix llvm-namespace-comment finding

kuhnel created this revision. Herald added subscribers: carlosgalvezp, usaxena95, kadircet, arphaman. kuhnel published this revision for review. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Fixing the clang-tidy finding. Repository:

[PATCH] D113892: [NFC][clangd] cleanup llvm-else-after-return findings

kuhnel created this revision. Herald added subscribers: carlosgalvezp, usaxena95, kadircet, arphaman, javed.absar. kuhnel added subscribers: sammccall, hokein, adamcz, kbobyrev. kuhnel published this revision for review. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a

[PATCH] D113902: [NFC][clangd] exclude test data from clang-tidy

sammccall added a comment. Hmm, clang-tidy should only be running on entries in compile_commands.json. are these files listed somehow? (I don't like the idea that every test inputs dir may need to contain a scattering of files to disable tools. At most we should be able to do this under test/)

[PATCH] D110216: [clang] retain type sugar in auto / template argument deduction

mizvekov added a comment. FYI this is a minimal repro taken from Martin's preprocessed source (Thanks!): template struct a { using b = const float; }; template using d = typename a::b; template void e(d *, c) {} template void e(typename a::b *, int); Repository: rG LLVM Github

[PATCH] D113892: [NFC][clangd] cleanup llvm-else-after-return findings

sammccall added a comment. Mostly looks good. There's a bunch of ifs that are now trivial (condition and body each fit on one line, no else) and we'd usually drop braces there, but it's probably not worth the hassle. I have to say that this rule slightly improves "early exit after error condit

[PATCH] D113847: [clang-tidy][NFC] Simplify ClangTidyStats

carlosgalvezp updated this revision to Diff 387290. carlosgalvezp added a comment. Fix refactoring bug. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113847/new/ https://reviews.llvm.org/D113847 Files: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.h Index: clang-tools-ex

[PATCH] D113779: [Clang] Add mfp16, mfp16fml and mdotprod flags for ARM target features.

fhahn added a comment. In D113779#3130853 , @paulwalker-arm wrote: > Rather than adding connivence options after the fact what about allowing > `-march=` to be specified multiple times? The first must be the usual format > with later ones required to s

[clang] f0bc7d2 - [analyzer] Fix region cast between the same types with different qualifiers.

Author: Denys Petrov Date: 2021-11-15T19:23:00+02:00 New Revision: f0bc7d24882ab84f6398a1ea614dd0bf6e2a1085 URL: https://github.com/llvm/llvm-project/commit/f0bc7d24882ab84f6398a1ea614dd0bf6e2a1085 DIFF: https://github.com/llvm/llvm-project/commit/f0bc7d24882ab84f6398a1ea614dd0bf6e2a1085.diff

[PATCH] D113480: [analyzer] Fix region cast between the same types with different qualifiers.

This revision was automatically updated to reflect the committed changes. Closed by commit rGf0bc7d24882a: [analyzer] Fix region cast between the same types with different qualifiers. (authored by ASDenysPetrov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D113306: [PowerPC] Allow MMA built-ins to accept non-void pointers and arrays

nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land. LGTM. Thank you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113306/new/ https://reviews.llvm.org/D113306 ___

[PATCH] D113847: [clang-tidy][NFC] Simplify ClangTidyStats

carlosgalvezp added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.h:61-64 - unsigned errorsIgnored() const { + int errorsIgnored() const { return ErrorsIgnoredNOLINT + ErrorsIgnoredCheckFilter + ErrorsIgnoredNonUserCode +

[PATCH] D113422: [clang-tidy][NFC] Move CachedGlobList to GlobList.h

carlosgalvezp updated this revision to Diff 387304. carlosgalvezp added a comment. - Replace composition with private inheritance. - Fix namespaces. Public inheritance is not possible due to the base class' function being const-qualified; the derived class cannot be const since it updates state

[PATCH] D107994: Making the code compliant to the documentation about Floating Point support default values for C/C++. FPP-MODEL=PRECISE enables FFP-CONTRACT (FMA is enabled).

wristow added a comment. In D107994#3131268 , @zahiraam wrote: > In D107994#3130494 , @wristow wrote: > >> The Release Note change here says: >> >> Floating Point Support in Clang >> --

[clang] 0b9d3a6 - [analyzer][NFC] Separate CallDescription from CallEvent

Author: Balazs Benics Date: 2021-11-15T19:10:46+01:00 New Revision: 0b9d3a6e53e6c6488b531f3c8c281b485ca3b14a URL: https://github.com/llvm/llvm-project/commit/0b9d3a6e53e6c6488b531f3c8c281b485ca3b14a DIFF: https://github.com/llvm/llvm-project/commit/0b9d3a6e53e6c6488b531f3c8c281b485ca3b14a.diff

[PATCH] D113587: [analyzer][NFC] Separate CallDescription from CallEvent

This revision was automatically updated to reflect the committed changes. Closed by commit rG0b9d3a6e53e6: [analyzer][NFC] Separate CallDescription from CallEvent (authored by steakhal). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D112646: [clang-tidy] Add `readability-container-contains` check

avogelsgesang updated this revision to Diff 387318. avogelsgesang added a comment. Update docs to also mention `container.find() != container.end()` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112646/new/ https://reviews.llvm.org/D112646 Files:

[PATCH] D113917: Add infrastructure to support matcher names.

jcking1034 created this revision. jcking1034 added reviewers: ymandel, tdl-g, aaron.ballman. jcking1034 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This contains changes to the AST Matcher infrastructure in order to provide contextual i

[PATCH] D112646: [clang-tidy] Add `readability-container-contains` check

avogelsgesang added a comment. @xazax.hun / @whisperity could you review this change for me, please :) Or, alternatively: can you direct me to somebody who could review? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112646/new/ https://reviews.llv

[PATCH] D113917: Add infrastructure to support matcher names.

jcking1034 added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchersInternal.h:1021 + std::string getName() const override { +return "HasOverloadedOperatorNameMatcher"; Here and below, we have the option to use the name of the matcher

[PATCH] D112648: [clang-tidy] Improve fix-its for `modernize-pass-by-value` check

avogelsgesang added subscribers: ymandel, whisperity, aaron.ballman. avogelsgesang added a comment. @ymandel, @whisperity, @aaron.ballman could one of you review this/point me in the direction of a good reviewer for this change? (Sorry for the spam - I am new to the LLVM project, and I guess I s

[PATCH] D113847: [clang-tidy][NFC] Simplify ClangTidyStats

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.h:61-64 - unsigned errorsIgnored() const { + int errorsIgnored() const { retur

  1   2   >