thevinster added inline comments.

================
Comment at: lld/Common/Args.cpp:29
 
+OptimizationLevel args::getOptLevel(llvm::opt::InputArgList &args,
+                                    unsigned int key,
----------------
nit: `getOptLevel` seems a bit too generic for something that's LTO specific. 
The MachO port has the concept of passing an opt level that generates more 
efficient opcodes. Suggestions are welcome here - perhaps `getLTOOptLevel` 
would be better here? 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113738/new/

https://reviews.llvm.org/D113738

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to