[PATCH] D112996: [CodeCompletion] Generally consider header files without extension

sammccall added a comment. In D112996#3102925 , @ckandeler wrote: >> WDYT about detecting QT headers specifically? It seems hacky, but I don't >> see a way out of this that doesn't involve hardcoding some filenames. Are >> they in a directory like `"qt-

[PATCH] D112768: [ARM] implement support for TLS register based stack protector

ardb added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3177-3179 + if (!Args.hasArg(options::OPT_mstack_protector_guard_offset_EQ)) { +D.Diag(diag::err_drv_ssp_missing_offset_argument) +<< A->getOption().getName() << Value;

[PATCH] D112664: [clang-format][docs] fix indentation of rst code block

HazardyKnusperkeks added a comment. In D112664#3101142 , @MyDeveloperDay wrote: > This should be Format.h, didn't we recently fix this? Yes we did, this is from before. :) So it is now obsolete. Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[clang] 5c8d305 - Fix complex types declared using mode TC

Author: Elizabeth Andrews Date: 2021-11-02T12:00:26-07:00 New Revision: 5c8d3053fa0c183ea4f908e51a111ada3d4031f2 URL: https://github.com/llvm/llvm-project/commit/5c8d3053fa0c183ea4f908e51a111ada3d4031f2 DIFF: https://github.com/llvm/llvm-project/commit/5c8d3053fa0c183ea4f908e51a111ada3d4031f2.d

[PATCH] D112975: Fix complex types declared using mode TC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5c8d3053fa0c: Fix complex types declared using mode TC (authored by eandrews). Herald added a project: clang. Repository: rG LLVM Github Monorepo

[PATCH] D95168: [clang-format] Add InsertBraces option

HazardyKnusperkeks added a comment. In D95168#3102247 , @owenpan wrote: > In D95168#3100969 , @MyDeveloperDay > wrote: > >> In D95168#3099920 , @owenpan wrote: >> >>> In D95

[PATCH] D113000: [clang-format] NOT FOR COMMIT - Demo of AutomaticBraces: Remove

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:3230 return false; - } else if (Style.isCSharp()) { -// Require spaces around '{' and before '}' unless they appear in -// interpolated strings. Interpolated strings are mer

[PATCH] D110833: [clang-format] Refactor SpaceBeforeParens to add options

HazardyKnusperkeks added a comment. Looks good, and I really need this to land, to expand it. ;) Comment at: clang/include/clang/Format/Format.h:3369 +/// \endcode +bool AfterForeachMacros; +/// If ``true``, put a space before opening parentheses only if the ---

[PATCH] D112921: [clang] Enable sized deallocation by default in C++14 onwards

rnk accepted this revision. rnk added a comment. Looks good from my end. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112921/new/ https://reviews.llvm.org/D112921 ___ cfe-commits mailing list cfe-commit

[PATCH] D109496: [clang] deprecate frelaxed-template-template-args, make it on by default

mizvekov added a comment. Thanks for reporting this! This change in the standard was worked a long time ago, and there was some expectation that there would be follow up work to add new partial ordering rules so that reasonable code would keep working. But the person behind that effort stopped

[PATCH] D109496: [clang] deprecate frelaxed-template-template-args, make it on by default

mizvekov added a comment. Feel free to revert it if this is blocking you. I don't seem to find a way to do it via web interface, so I need more time to have access to a machine that can do it Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109496/ne

[PATCH] D107049: [clang-repl] Re-implement clang-interpreter as a test case.

lhames added a comment. In D107049#3101456 , @dblaikie wrote: > In D107049#3100630 , @rnk wrote: > >> So, to back up a bit, do I understand correctly that this change adds tests >> to the check-clang test suite t

[PATCH] D113043: "[mlir][sparse]Rename SparseUtils.cpp library to SparseTensorUtils.cpp"

HarrietAkot updated this revision to Diff 384203. HarrietAkot marked an inline comment as done. HarrietAkot added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. - "Updating clang-formatted-files" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D109496: [clang] deprecate frelaxed-template-template-args, make it on by default

yaxunl added a comment. In D109496#3103963 , @mizvekov wrote: > Thanks for reporting this! > > This change in the standard was worked a long time ago, and there was some > expectation that there would be follow up work to add new partial ordering > rule

[PATCH] D109496: [clang] deprecate frelaxed-template-template-args, make it on by default

yaxunl added a comment. In D109496#3103978 , @mizvekov wrote: > Feel free to revert it if this is blocking you. I don't seem to find a way to > do it via web interface, so I need more time to have access to a machine that > can do it I will revert it s

[PATCH] D113043: "[mlir][sparse]Rename SparseUtils.cpp library to SparseTensorUtils.cpp"

aartbik added a comment. One last question, I just noticed you started a whole new revision (instead of updating https://reviews.llvm.org/D112995). Was that intentional? If you use arc, then arc diff first time creates one, but subsequent updates should use arc diff ... --update D to

[PATCH] D113043: "[mlir][sparse]Rename SparseUtils.cpp library to SparseTensorUtils.cpp"

HarrietAkot added a comment. In D113043#3103979 , @aartbik wrote: > Did you see my comment on clang/docs/tools/clang-formatted-files.txt? > You will need to update that file too (SparseUtils.cpp -> > SparseTensorUtils.cpp) > > after that this revision is

[PATCH] D113043: [mlir][sparse] Rename SparseUtils.cpp file to SparseTensorUtils.cpp

aartbik accepted this revision. aartbik added a comment. This revision is now accepted and ready to land. I removed the quotes from the title, no need for these. Also, please address the last open question (on arc diff --update). But good to go as revision. I have approved the revision and will

[PATCH] D113049: [AIX] Disable tests that fail because of no 64-bit XCOFF object file support

Jake-Egan created this revision. Herald added subscribers: ormris, lxfind, pengfei, arphaman, steven_wu, hiraditya. Jake-Egan requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Repository: rG LLVM Github Monorepo https://

[clang] 8a91bc7 - [mlir][sparse] Rename SparseUtils.cpp file to SparseTensorUtils.cpp

Author: HarrietAkot Date: 2021-11-02T13:54:33-07:00 New Revision: 8a91bc7bf436d345cc1b26d0073753a7f5e66e10 URL: https://github.com/llvm/llvm-project/commit/8a91bc7bf436d345cc1b26d0073753a7f5e66e10 DIFF: https://github.com/llvm/llvm-project/commit/8a91bc7bf436d345cc1b26d0073753a7f5e66e10.diff L

[PATCH] D113043: [mlir][sparse] Rename SparseUtils.cpp file to SparseTensorUtils.cpp

This revision was automatically updated to reflect the committed changes. Closed by commit rG8a91bc7bf436: [mlir][sparse] Rename SparseUtils.cpp file to SparseTensorUtils.cpp (authored by HarrietAkot, committed by aartbik). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D113049: [AIX] Disable tests that fail because of no 64-bit XCOFF object file support

Jake-Egan updated this revision to Diff 384220. Jake-Egan added a comment. Fix llvm/test/DebugInfo/omit-empty.ll. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113049/new/ https://reviews.llvm.org/D113049 Files: clang/test/ASTMerge/anonymous-fie

[clang] 60a085b - Revert "[clang] deprecate frelaxed-template-template-args, make it on by default"

Author: Yaxun (Sam) Liu Date: 2021-11-02T17:02:19-04:00 New Revision: 60a085beb04b055cf44c379c56cb247cb3587658 URL: https://github.com/llvm/llvm-project/commit/60a085beb04b055cf44c379c56cb247cb3587658 DIFF: https://github.com/llvm/llvm-project/commit/60a085beb04b055cf44c379c56cb247cb3587658.dif

[PATCH] D112646: [clang-tidy] Add `readability-container-contains` check

avogelsgesang added a comment. > [...] If we want to follow container-size-empty's convention, we should > include the replaced method in the name [...] Note that this commit is slightly different from `container-size-empty`: it doesn't only replace `count(...)` by `contains(...)` but also repl

[PATCH] D105169: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and turn it off by default

eugenis added a comment. You are absolutely right. X86 variant uses an "=a" constraint (rax register), others pin the output variable to a specific register with __asm__ declaration. It appears we've missed it in Aarch64. Could you check if __asm__("x0") in the declaration of res helps? Repos

[PATCH] D112913: Misleading bidirectional detection

rsmith added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/MisleadingBidirectional.cpp:59 +// If conversion fails, utf-8 is designed so that we can just try next char. +if (Result != llvm::conversionOK) { + ++CurPtr; Is there a guar

[PATCH] D112914: Misleading identifier detection

rsmith added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/MisleadingIdentifier.h:2 +//===--- MisleadingIdentifierCheck.h - clang-tidy *- C++ +//-*-===// +// This needs fixing too. CHANGES SINCE LAST ACTION https://re

[PATCH] D112647: [clang-apply-replacements] Correctly handle relative paths

avogelsgesang updated this revision to Diff 384239. avogelsgesang marked 2 inline comments as done. avogelsgesang added a comment. Use `llvm::Optional` instead of pointer as suggested by @ymandel Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112647/

[PATCH] D112883: [bazel] Re-introduce `copts` hacks for lib/AST includes.

GMNGeoffrey added a comment. In D112883#3101685 , @GMNGeoffrey wrote: > In D112883#3101665 , @chandlerc > wrote: > >> However, I thought with Bazel having a consistent repo name was important to >> allow cross-

[PATCH] D112349: [Verifier] Add verification logic for GlobalIFuncs

ibookstein added a comment. Hmm. When I try to compile an object file where the resolver is a declaration, both clang-13, clang-14, and gcc-9.3 complain that the ifunc must point to a defined function: void *foo_resolver(); void foo(void) __attribute__((ifunc("foo_resolver"))); clang (13 a

[PATCH] D107049: [clang-repl] Re-implement clang-interpreter as a test case.

dblaikie added a comment. In D107049#3103984 , @lhames wrote: > In D107049#3101456 , @dblaikie > wrote: > >> In D107049#3100630 , @rnk wrote: >> >>> So, to back up a bit,

[PATCH] D112941: [clang] Add support for the new pointer authentication builtins.

apazos added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:839 +def err_ptrauth_disabled : + Error<"pointer authentication is disabled for the current target">; +def err_ptrauth_invalid_key : These two error types are confusing.

[PATCH] D112941: [clang] Add support for the new pointer authentication builtins.

apazos added a comment. The plan to push support for ptrauth_sign_constant, and ptrauth_type_discriminator/ptrauth_string_discriminator in a separate patch is good. This current patch is already big. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[clang] ee4634f - [NFC][asan] Fix confusing variable name

Author: Vitaly Buka Date: 2021-11-02T16:49:15-07:00 New Revision: ee4634f7feb38982bd90192e3d2866c07db3e065 URL: https://github.com/llvm/llvm-project/commit/ee4634f7feb38982bd90192e3d2866c07db3e065 DIFF: https://github.com/llvm/llvm-project/commit/ee4634f7feb38982bd90192e3d2866c07db3e065.diff L

[PATCH] D113072: [NFC][asan] Use AddressSanitizerOptions in ModuleAddressSanitizerPass

vitalybuka created this revision. Herald added subscribers: ormris, hiraditya. vitalybuka requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D113072 Files: cl

[PATCH] D107049: [clang-repl] Re-implement clang-interpreter as a test case.

lhames added a comment. In D107049#3104558 , @dblaikie wrote: > In D107049#3103984 , @lhames wrote: > >> In D107049#3101456 , @dblaikie >> wrote: >> >>> Yeah, seems we've

[PATCH] D112971: [NFC] Remove LinkAll*.h

aeubanks added a comment. Turns out the comments are misleading, they aren't to prevent specific functions from being removed, they're to force an odr usage of various functions, which in turn makes sure that globals in the corresponding translation units with the function definition are initia

[PATCH] D113072: [NFC][asan] Use AddressSanitizerOptions in ModuleAddressSanitizerPass

vitalybuka updated this revision to Diff 384292. vitalybuka added a comment. unused var Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113072/new/ https://reviews.llvm.org/D113072 Files: clang/lib/CodeGen/BackendUtil.cpp llvm/include/llvm/Trans

[PATCH] D111199: [Clang][LLVM][Attr] support btf_type_tag attribute

yonghong-song added a comment. @aaron.ballman I checked the source. Looks like we can easily get TypeLoc from TypeSourceInfo, but not from TypeSourceInfo to TypeLoc. But We need TypeLoc so we can get attr information and also traverse TypeLoc's.. We might be able to pass TypeSourceInfo in a few

[PATCH] D113072: [NFC][asan] Use AddressSanitizerOptions in ModuleAddressSanitizerPass

vitalybuka updated this revision to Diff 384302. vitalybuka added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113072/new/ https://reviews.llvm.org/D113072 Files: clang/lib/CodeGen/BackendUtil.cpp llvm/include/llvm/Transform

[PATCH] D112732: [ASan] Process functions in Asan module pass

vitalybuka updated this revision to Diff 384303. vitalybuka added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112732/new/ https://reviews.llvm.org/D112732 Files: clang/lib/CodeGen/BackendUtil.cpp llvm/lib/Passes/PassBuilder

[PATCH] D112732: [ASan] Process functions in Asan module pass

vitalybuka accepted this revision. vitalybuka added a comment. This revision is now accepted and ready to land. Lets keep AddressSanitizerPass for a while, we don't have to remove it in the same patch Comment at: llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp:1289 +

[PATCH] D112915: WIP: [clang][modules] Granular tracking of includes

vsapsai added a comment. I'm not going to cover the entire change, some parts I need to consider more carefully. There can be other reasons to keep `IncludeMap` out of `SubmoduleState` but I'm not sure the local submodule visibility is the right reason. I might be reading the code incorrectly

[PATCH] D112941: [clang] Add support for the new pointer authentication builtins.

rjmccall added a comment. Mostly LGTM, although I am not the most unbiased reviewer. :) Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:839 +def err_ptrauth_disabled : + Error<"pointer authentication is disabled for the current target">; +def err_ptrauth_invalid_k

[PATCH] D104601: [Preprocessor] Implement -fminimize-whitespace.

manmanren added a comment. This commit seems to cause some regression for "-save-temps" as there is no new line before the pragma. See the below test case, -E will output int test();#pragma clang assume_nonnull It will fail the compilation on the preprocessed output with error: expected unqualifi

[PATCH] D111866: [RISCV] Support Zfhmin extension

achieveartificialintelligence updated this revision to Diff 384337. achieveartificialintelligence added a comment. Address @asb 's comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111866/new/ https://reviews.llvm.org/D111866 Files: clang/t

[PATCH] D111866: [RISCV] Support Zfhmin extension

achieveartificialintelligence marked 4 inline comments as done. achieveartificialintelligence added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111866/new/ https://reviews.llvm.org/D111866 _

[PATCH] D113080: [Support] Improve Caching conformance with Support library behavior

noajshu created this revision. Herald added subscribers: ormris, dexonsmith, steven_wu, hiraditya, arichardson, sbc100, emaste. Herald added a reviewer: MaskRay. Herald added a reviewer: gkm. Herald added a project: lld-macho. Herald added a reviewer: lld-macho. noajshu requested review of this re

[PATCH] D112921: [clang] Enable sized deallocation by default in C++14 onwards

pcwang-thead updated this revision to Diff 384344. pcwang-thead marked an inline comment as done. pcwang-thead added a comment. Adds `ADDITIONAL_COMPILE_FLAGS` and guard macros to: - `libcxx\test\std\language.support\support.dynamic\new.delete\new.delete.single\sized_delete14.pass.cpp` - `libcx

[PATCH] D113087: [VE] Change to omitting the frame pointer on leaf functions

kaz7 created this revision. kaz7 added reviewers: simoll, k-ishizaka. kaz7 added projects: clang, VE. kaz7 requested review of this revision. Herald added a subscriber: cfe-commits. Change to omitting the frame pointer on leaf functions by default for VE. Repository: rG LLVM Github Monorepo h

[PATCH] D93164: [AST] Add generator for source location introspection

smeenai added inline comments. Comment at: clang/lib/Tooling/CMakeLists.txt:29-30 +if (NOT Python3_EXECUTABLE +OR WIN32 +OR APPLE +OR GENERATOR_IS_MULTI_CONFIG I'm looking at this commit in the context of https://bugs.llvm.org/show_bug.cgi?id=52106.

<    1   2