[clang] 7890afd - [clang-offload-bundler][docs][NFC] invalid indentation cause build issue

Author: mydeveloperday Date: 2021-09-24T08:03:52+01:00 New Revision: 7890afddecff01119f4d5e8825b43dd2c8361648 URL: https://github.com/llvm/llvm-project/commit/7890afddecff01119f4d5e8825b43dd2c8361648 DIFF: https://github.com/llvm/llvm-project/commit/7890afddecff01119f4d5e8825b43dd2c8361648.diff

[PATCH] D110083: [clang-offload-bundler][docs][NFC] Add archive unbundling documentation

MyDeveloperDay added a comment. Thanks... https://github.com/llvm/llvm-project/commit/7890afddecff01119f4d5e8825b43dd2c8361648 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110083/new/ https://reviews.llvm.org/D110083

[PATCH] D69764: [clang-format] Add Left/Right Const fixer capability

MyDeveloperDay added a comment. In D69764#3019409 , @nemanjai wrote: > This broke buildbots that have -Werror specified. I pushed in a fix in > https://reviews.llvm.org/rG76d845cb169f048cb6f2176c3e7a6534dc5af097. > Also, please consider formatting your co

[PATCH] D110386: [clangd] Refactor IncludeStructure: use File (unsigned) for most computations

kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: usaxena95, arphaman. kbobyrev requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Preparation for D108194

[clang] 87ab958 - [clang-format] ensure clang-format command-line argument sets up the default left/right qualifier ordering

Author: mydeveloperday Date: 2021-09-24T08:11:53+01:00 New Revision: 87ab958641fa30ed1e5880aaf43b909c552af0dc URL: https://github.com/llvm/llvm-project/commit/87ab958641fa30ed1e5880aaf43b909c552af0dc DIFF: https://github.com/llvm/llvm-project/commit/87ab958641fa30ed1e5880aaf43b909c552af0dc.diff

[PATCH] D110359: [clang-format] ensure clang-format command-line argument sets up the default left/right qualifier ordering

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG87ab958641fa: [clang-format] ensure clang-format command-line argument sets up the default… (authored by MyDeveloperDay). Changed prior to commit:

[clang] 9e8fff2 - [clang-format][docs] Fix documentation of clang-format BasedOnStyle type

Author: Ludovic Jozeau Date: 2021-09-24T08:15:55+01:00 New Revision: 9e8fff26f374766b76aad9531ee5e6860f67e46c URL: https://github.com/llvm/llvm-project/commit/9e8fff26f374766b76aad9531ee5e6860f67e46c DIFF: https://github.com/llvm/llvm-project/commit/9e8fff26f374766b76aad9531ee5e6860f67e46c.diff

[PATCH] D108765: [docs] Fix documentation of clang-format BasedOnStyle type

This revision was automatically updated to reflect the committed changes. Closed by commit rG9e8fff26f374: [clang-format][docs] Fix documentation of clang-format BasedOnStyle type (authored by FederAndInk, committed by MyDeveloperDay). Changed prior to commit: https://reviews.llvm.org/D108765?

[PATCH] D109557: Adds a BreakBeforeClosingParen option

MyDeveloperDay added a comment. We would need your name and email address to commit this for you in the form git commit --amend --author="John Doe " See https://llvm.org/docs/DeveloperPolicy.html Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D10955

[PATCH] D110386: [clangd] Refactor IncludeStructure: use File (unsigned) for most computations

sammccall added inline comments. Comment at: clang-tools-extra/clangd/Headers.h:115 public: + using File = unsigned; + this concept needs documentation. Comment at: clang-tools-extra/clangd/Headers.h:115 public: + using File = unsigned; + -

[PATCH] D110387: [Analyzer][NFC] Move RangeConstraintManager's def before ConstraintAssignor's def

martong created this revision. martong added reviewers: NoQ, vsavchenko, Szelethus, steakhal, ASDenysPetrov. Herald added subscribers: manas, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun, whisperity. martong requested review of this re

[PATCH] D110357: [Analyzer] Extend ConstraintAssignor to handle remainder op

martong updated this revision to Diff 374741. martong added a comment. - Break out the movement of RangeConstraintManager into a parent patch, this way the diff here is clearly visible and makes the review easier. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[clang] 03142c5 - [Driver] Correctly handle static C++ standard library

Author: Petr Hosek Date: 2021-09-24T00:40:16-07:00 New Revision: 03142c5f67788bcc1573f76732d0fccd75c6b965 URL: https://github.com/llvm/llvm-project/commit/03142c5f67788bcc1573f76732d0fccd75c6b965 DIFF: https://github.com/llvm/llvm-project/commit/03142c5f67788bcc1573f76732d0fccd75c6b965.diff LO

[PATCH] D110128: [Driver] Correctly handle static C++ standard library

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG03142c5f6778: [Driver] Correctly handle static C++ standard library (authored by phosek). Changed prior to commit: https://reviews.llvm.org/D11012

[PATCH] D106102: [analyzer][solver] Introduce reasoning for not equal to operator

manas added a comment. I haven't tried specializing that `VisitBinaryOperator` method which converts Ranges from RangeSets (as @vsavchenko mentioned). Should this case for NE stay here in the switch or move? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D106102: [analyzer][solver] Introduce reasoning for not equal to operator

manas updated this revision to Diff 374746. manas added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106102/new/ https://reviews.llvm.org/D106102 Files: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp clang/test/Ana

[clang] efb284c - [clang-format] Fixed an unused variable warning

Author: Dmitri Gribenko Date: 2021-09-24T10:37:04+02:00 New Revision: efb284c07e97776e01933f470afb5215a561db3e URL: https://github.com/llvm/llvm-project/commit/efb284c07e97776e01933f470afb5215a561db3e DIFF: https://github.com/llvm/llvm-project/commit/efb284c07e97776e01933f470afb5215a561db3e.dif

[PATCH] D110392: [clang-format] Left/Right alignment fixer can cause false positive replacements when they don't actually change anything

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: curdeius, HazardyKnusperkeks. MyDeveloperDay added projects: clang, clang-format. MyDeveloperDay requested review of this revision. Earlier during the development of D69764: [clang-format] Add Left/Right Const fixer capability

[PATCH] D108765: [docs] Fix documentation of clang-format BasedOnStyle type

FederAndInk added a comment. Thanks for the merge, I now understand more how this all works and what we want from these scripts. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108765/new/ https://reviews.llvm.org/D108765 __

[PATCH] D95588: [RISCV] Implement the MC layer support of P extension

Jim marked 7 inline comments as done. Jim added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoP.td:909 + +// kmar64 has a aliased instruction kmada32 belong to zpn sub-extension on RV64. +let DecoderNamespace = "RISCV32Zpsfoperand_", jrtc27 wr

[clang-tools-extra] 45617e1 - [clang-doc] Pass Record argument by const-ref. NFCI.

Author: Simon Pilgrim Date: 2021-09-24T10:06:13+01:00 New Revision: 45617e1dd8a1b9791f3bd15aee2614383e25b298 URL: https://github.com/llvm/llvm-project/commit/45617e1dd8a1b9791f3bd15aee2614383e25b298 DIFF: https://github.com/llvm/llvm-project/commit/45617e1dd8a1b9791f3bd15aee2614383e25b298.diff

[PATCH] D108765: [docs] Fix documentation of clang-format BasedOnStyle type

FederAndInk added a comment. Also, don't we want to change the title and summary of the commit/revision? Because it does not reflect the real changes now in the repo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108765/new/ https://reviews.llvm.or

[PATCH] D105092: [RISCV] (1/2) Add the tail policy argument to builtins/intrinsics.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7d39a8a92122: [RISCV] (1/2) Add the tail policy argument to builtins/intrinsics. (authored by HsiangKai). Changed prior to commit: https://reviews

[PATCH] D109322: [RISCV] (2/2) Add the tail policy argument to builtins/intrinsics.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7afa61e71877: [RISCV] (2/2) Add the tail policy argument to builtins/intrinsics. (authored by HsiangKai). Changed prior to commit: https://reviews

[clang] 98a95d4 - [analyzer] Retrieve a value from list initialization of constant array declaration in a global scope.

Author: Denys Petrov Date: 2021-09-24T12:37:58+03:00 New Revision: 98a95d4844caf8edfabd9352393a5546049b54e8 URL: https://github.com/llvm/llvm-project/commit/98a95d4844caf8edfabd9352393a5546049b54e8 DIFF: https://github.com/llvm/llvm-project/commit/98a95d4844caf8edfabd9352393a5546049b54e8.diff

[PATCH] D104285: [analyzer] Retrieve a value from list initialization of constant array declaration in a global scope.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG98a95d4844ca: [analyzer] Retrieve a value from list initialization of constant array… (authored by ASDenysPetrov). Repository: rG LLVM Github Mono

[PATCH] D110395: [clang][ASTImporter] Import InheritedConstructor and ConstructorUsingShadowDecl.

balazske created this revision. Herald added subscribers: whisperity, martong, teemperor, gamesh411, Szelethus, dkrupp. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. balazske requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-com

[PATCH] D110398: [clang][ASTImporter] Import ConstructorUsingShadowDecl correctly.

balazske created this revision. Herald added subscribers: whisperity, martong, teemperor, gamesh411, Szelethus, dkrupp. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. balazske requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-com

[PATCH] D109557: Adds a BreakBeforeClosingParen option

csmulhern added a comment. In D109557#3019847 , @MyDeveloperDay wrote: > We would need your name and email address to commit this for you in the form > git commit --amend --author="John Doe " > > See https://llvm.org/docs/DeveloperPolicy.html Sure, it'

[PATCH] D108560: [clang-tidy] Add support for NOLINTBEGIN ... NOLINTEND comments to suppress clang-tidy warnings over multiple lines

salman-javed-nz added a comment. In D108560#3012755 , @aaron.ballman wrote: > Sorry for not thinking of this sooner, but there is another diagnostic we > might want to consider. > > // NOLINTBEGIN(check) > // NOLINTEND(other-check) > > where the fil

[PATCH] D108560: [clang-tidy] Add support for NOLINTBEGIN ... NOLINTEND comments to suppress clang-tidy warnings over multiple lines

salman-javed-nz updated this revision to Diff 374803. salman-javed-nz added a comment. `lineIsWithinNolintBegin()`: Put `NOLINTBEGIN` comments into 2 buckets: 1. Comments that apply to a specific check - `NOLINTBEGIN(check)` 2. Comments that apply to all checks - `NOLINTBEGIN(*)` and `NOLINTBEGIN

[PATCH] D110386: [clangd] Refactor IncludeStructure: use File (unsigned) for most computations

kbobyrev updated this revision to Diff 374806. kbobyrev marked 9 inline comments as done. kbobyrev added a comment. Resolve review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110386/new/ https://reviews.llvm.org/D110386 Files: clang-

[PATCH] D110386: [clangd] Refactor IncludeStructure: use File (unsigned) for most computations

kbobyrev updated this revision to Diff 374807. kbobyrev added a comment. s/ToVector/Flatten/g Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110386/new/ https://reviews.llvm.org/D110386 Files: clang-tools-extra/clangd/CodeComplete.cpp clang-too

[PATCH] D110128: [Driver] Correctly handle static C++ standard library

nemanjai added a comment. In D110128#3018992 , @phosek wrote: > @MaskRay Do you think we should gate the use of this feature on > `-fbinutils-version=` or `-fuse-ld=lld`? It'd be nice if the owner of > `clang-ppc64le-rhel` builder could update the binut

[PATCH] D110041: [clang] Use portable "#!/usr/bin/env bash" shebang for tools and utils.

fcambus added a comment. > I can push this for you @fcambus. Thanks for committing this. I also have a similar diff for compiler-rt, in D110039 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110041/new/ https://

[PATCH] D42225: libcxx: Provide overloads for basic_filebuf::open() et al that take wchar_t* filenames on Windows.

CaseyCarter added a comment. In D42225#2963216 , @ldionne wrote: > In D42225#2963190 , @mstorsjo wrote: > >> In D42225#2962348 , @ldionne wrote: >> >>> @pcc @mstorsjo Are we

[PATCH] D110386: [clangd] Refactor IncludeStructure: use File (unsigned) for most computations

kbobyrev updated this revision to Diff 374841. kbobyrev added a comment. Update non-working test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110386/new/ https://reviews.llvm.org/D110386 Files: clang-tools-extra/clangd/CodeComplete.cpp clang-

[PATCH] D110386: [clangd] Refactor IncludeStructure: use File (unsigned) for most computations

kbobyrev added a comment. I resolved the comments we discussed offline, there's a weird SIGSEGV (out of boundary error) somewhere in the tests but it looks fine otherwise. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110386/new/ https://reviews.l

[PATCH] D42225: libcxx: Provide overloads for basic_filebuf::open() et al that take wchar_t* filenames on Windows.

mstorsjo added a comment. In D42225#3020688 , @CaseyCarter wrote: > In D42225#2963216 , @ldionne wrote: > >> In D42225#2963190 , @mstorsjo wrote: >> >>> In D42225#2962348

[PATCH] D106959: [PowerPC] swdiv builtins for XL compatibility

quinnp updated this revision to Diff 374847. quinnp marked 7 inline comments as done. quinnp added a comment. Updatign the patch to emit a fdiv for each of the builtins without any fast math flags. This will be safe and will still emit a software estimate when `-Ofast` is used. Repository: r

[PATCH] D106959: [PowerPC] swdiv builtins for XL compatibility

quinnp added inline comments. Comment at: llvm/test/CodeGen/PowerPC/LowerCheckedFPArith.ll:36 +; CHECK-NEXT: %2 = fdiv fast float %0, %1 +; CHECK-NEXT: %3 = fcmp une float %2, %2 +; CHECK-NEXT: br i1 %3, label %swdiv_HWDIV, label %swdiv_MERGE efriedma wrote: >

[PATCH] D108370: [clang-tidy] Fix wrong FixIt about union in cppcoreguidelines-pro-type-member-init

Sockke added a comment. In D108370#3017800 , @aaron.ballman wrote: > LGTM! Thanks for your review! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108370/new/ https://reviews.llvm.org/D108370 ___ cfe

[PATCH] D108370: [clang-tidy] Fix wrong FixIt about union in cppcoreguidelines-pro-type-member-init

Sockke added a comment. In D108370#3017800 , @aaron.ballman wrote: > LGTM! Thanks for your review! I don't have commit access, here is my information: Name: liuke Email: liuke.ge...@bytedance.com CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D110386: [clangd] Refactor IncludeStructure: use File (unsigned) for most computations

kbobyrev updated this revision to Diff 374853. kbobyrev added a comment. Herald added a subscriber: mgrang. Fix the last failing test. All tests are green now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110386/new/ https://reviews.llvm.org/D1103

[PATCH] D109780: [PowerPC] Add range check for vec_genpcvm builtins

quinnp updated this revision to Diff 374854. quinnp added a comment. Rebased with main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109780/new/ https://reviews.llvm.org/D109780 Files: clang/lib/Sema/SemaChecking.cpp clang/test/CodeGen/builti

[PATCH] D110421: Write test for CWG1772/CWG1779, mark them 'done', and update cxx_dr_status.html

erichkeane created this revision. erichkeane added reviewers: rsmith, aaron.ballman. erichkeane requested review of this revision. I noticed that these two DRs are currently working correctly, so I added a pair of lit tests that check the AST (which is most useful for CWG1779, since 'dependent' is

[PATCH] D110386: [clangd] Refactor IncludeStructure: use File (unsigned) for most computations

kbobyrev updated this revision to Diff 374863. kbobyrev added a comment. Clean tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110386/new/ https://reviews.llvm.org/D110386 Files: clang-tools-extra/clangd/CodeComplete.cpp clang-tools-extra

[PATCH] D110422: [AIX] Enable PGO without LTO

jsji created this revision. jsji added reviewers: PowerPC, Whitney, w2yehia, MaskRay. Herald added subscribers: wenlei, hiraditya, inglorion. jsji requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. On AIX, we relied on LTO to

[PATCH] D95588: [RISCV] Implement the MC layer support of P extension

jrtc27 added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVRegisterInfo.td:219 +def GPR32Pairs : RegisterTuples<[gpr32_pair_lo, gpr32_pair_hi], +[(add X0, X2, X4, X6, + X8, X10, X12, X14, -

[PATCH] D110386: [clangd] Refactor IncludeStructure: use File (unsigned) for most computations

tschuett added a comment. Do you want to wrap the `unsigned` in a struct to make it slightly safer, but more complicated to use? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110386/new/ https://reviews.llvm.org/D110386 __

[PATCH] D109437: [PowerPC] FP compare and test XL compat builtins.

lei accepted this revision as: lei. lei added a comment. LGTM Pleases address nit on commit. Comment at: clang/lib/Sema/SemaChecking.cpp:3495-3496 +ArgType != QualType(Context.DoubleTy)) { + Diag(TheCall->getBeginLoc(), diag::err_ppc_invalid_test_data_class_type);

[PATCH] D110422: [AIX] Enable PGO without LTO

jsji updated this revision to Diff 374867. jsji added a comment. Restore the limitation of sample profiling. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110422/new/ https://reviews.llvm.org/D110422 Files: clang/lib/Driver/ToolChains/AIX.cpp

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

frasercrmck added a comment. In D93298#3014160 , @jrtc27 wrote: > The amount of duplication here really depresses me and is only going to get > worse once codegen is added, but TableGen isn't able to have operands that > use different register classes ba

[PATCH] D110304: [HIP] Fix linking of asanrt.bc

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/include/clang/Driver/ToolChain.h:116-117 + // Enums corresponding to clang options for linking bitcode, i.e., + // -mlink-builtin-bitcode or -mlink-bitcode-file + enum BitCodeLinkOpt { -

[PATCH] D110257: [CFE][Codegen] Do not break the contiguity of static allocas.

hsmhsm updated this revision to Diff 374869. hsmhsm added a comment. Remove "!llvm.access.group" metadata from check lines in test files. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110257/new/ https://reviews.llvm.org/D110257 Files: clang/lib

[PATCH] D110304: [HIP] Fix linking of asanrt.bc

yaxunl updated this revision to Diff 374868. yaxunl marked an inline comment as done. yaxunl edited the summary of this revision. yaxunl added a comment. Revised by Artem's comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110304/new/ https://reviews.llvm.org/D110304 Files: clan

[PATCH] D110273: [PowerPC] Fix lharx and lbarx builtin signatures

NeHuang added inline comments. Comment at: clang/test/CodeGen/builtins-ppc-xlcompat-LoadReseve-StoreCond.c:27 char test_lbarx(volatile unsigned char *a) { // CHECK-LABEL: @test_lbarx Do you also need to update the input argument type here as well to match t

[clang] 3b0240e - [PowerPC] Add range check for vec_genpcvm builtins

Author: Quinn Pham Date: 2021-09-24T11:15:44-05:00 New Revision: 3b0240e6c89d9201430ee83b09fe7c94256e8838 URL: https://github.com/llvm/llvm-project/commit/3b0240e6c89d9201430ee83b09fe7c94256e8838 DIFF: https://github.com/llvm/llvm-project/commit/3b0240e6c89d9201430ee83b09fe7c94256e8838.diff LO

[PATCH] D109780: [PowerPC] Add range check for vec_genpcvm builtins

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3b0240e6c89d: [PowerPC] Add range check for vec_genpcvm builtins (authored by quinnp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D110257: [CFE][Codegen] Do not break the contiguity of static allocas.

rnk added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:103 +if (!ArraySize) { + auto *EBB = AllocaInsertPt->getParent(); + auto Iter = AllocaInsertPt->getIterator(); hsmhsm wrote: > jdoerfert wrote: > > arsenm wrote: > > > Why is there

[PATCH] D110422: [AIX] Enable PGO without LTO

MaskRay requested changes to this revision. MaskRay added inline comments. This revision now requires changes to proceed. Comment at: llvm/lib/Transforms/Instrumentation/InstrProfiling.cpp:869 + // symbol, so we can not ensure the correctness of the relative CounterPtr, so + /

[PATCH] D110422: [AIX] Enable PGO without LTO

MaskRay added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/InstrProfiling.cpp:978 if (NS == 0 && !(DataReferencedByCode && NeedComdat && !Renamed) && - (TT.isOSBinFormatELF() || + (TT.isOSBinFormatELF() || TT.isOSBinFormatXCOFF() || (!Data

[PATCH] D110422: [AIX] Enable PGO without LTO

jsji updated this revision to Diff 374879. jsji added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110422/new/ https://reviews.llvm.org/D110422 Files: clang/lib/Driver/ToolChains/AIX.cpp clang/lib/Driver/ToolChain

[PATCH] D106959: [PowerPC] swdiv builtins for XL compatibility

NeHuang added a comment. Do we already have a backend test case for `fdiv` emitting a software estimate when `-Ofast` is used? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106959/new/ https://reviews.llvm.org/D106959

[PATCH] D110422: [AIX] Enable PGO without LTO

jsji added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/InstrProfiling.cpp:869 + // symbol, so we can not ensure the correctness of the relative CounterPtr, so + // we have to use private linkage for counter and data symbols. + if (TT.isOSBinFormatXCOFF())

[PATCH] D43002: [CodeView] Emit S_OBJNAME record

aganea updated this revision to Diff 374884. aganea marked 5 inline comments as done. aganea edited reviewers, added: akhuang; removed: zturner, gratianlup. aganea edited subscribers, added: zturner, gratianlup; removed: aganea. aganea added a comment. Herald added subscribers: dang, mgorny. As su

[PATCH] D43002: [CodeView] Emit S_OBJNAME record

aganea added inline comments. Comment at: llvm/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp:752 +static void unescapeSlashes(SmallVectorImpl &Str) { + auto Read = Str.begin(); rnk wrote: > aganea wrote: > > rnk wrote: > > > This isn't unescaping them, it's just ca

[PATCH] D109437: [PowerPC] FP compare and test XL compat builtins.

quinnp updated this revision to Diff 374888. quinnp added a comment. Addressing nit in SemaChecking. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109437/new/ https://reviews.llvm.org/D109437 Files: clang/include/clang/Basic/BuiltinsPPC.def cl

[PATCH] D109599: [PowerPC][MMA] Allow MMA builtin types in pre-P10 compilation units

NeHuang added inline comments. Comment at: clang/test/Sema/ppc-mma-builtins.c:1 +// RUN: %clang_cc1 -triple powerpc64le-unknown-unknown -target-cpu pwr10 \ +// RUN: -target-feature -mma -fsyntax-only %s -verify can you please add `// REQUIRES: powerpc-register

[PATCH] D109437: [PowerPC] FP compare and test XL compat builtins.

quinnp updated this revision to Diff 374891. quinnp added a comment. Rebase with main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109437/new/ https://reviews.llvm.org/D109437 Files: clang/include/clang/Basic/BuiltinsPPC.def clang/include/cl

[PATCH] D110304: [HIP] Fix linking of asanrt.bc

tra accepted this revision. tra added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Driver/ToolChains/HIP.cpp:413 } else -BCLibs.push_back(AsanRTL.str()); +BCLibs.push_back({AsanRTL.str(), false}); } --

[PATCH] D110421: Write test for CWG1772/CWG1779, mark them 'done', and update cxx_dr_status.html

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from some nits, thank you! Comment at: clang/test/CXX/drs/dr17xx.cpp:75 // Direct-list-initialization of a non-class object - int a{0}; -

[PATCH] D110428: [AIX] Define WCHAR_T_TYPE as unsigned short on AIX for wchar.c test case.

amyk created this revision. amyk added reviewers: hubert.reinterpretcast, daltenty, thakis. amyk added projects: clang, PowerPC. amyk requested review of this revision. The default wchar type is different on AIX vs. Linux. When this test is run on AIX, WCHAR_T_TYPE ends up being set to `int`. Thi

[PATCH] D108823: [PowerPC] Mark splat immediate instructions as rematerializable

This revision was automatically updated to reflect the committed changes. Closed by commit rG6e1aaf18af6c: [PowerPC] Mark splat immediate instructions as rematerializable (authored by NeHuang). Changed prior to commit: https://reviews.llvm.org/D108823?vs=369101&id=374892#toc Repository: rG L

[PATCH] D110422: [AIX] Enable PGO without LTO

jsji added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/InstrProfiling.cpp:869 + // symbol, so we can not ensure the correctness of the relative CounterPtr, so + // we have to use private linkage for counter and data symbols. + if (TT.isOSBinFormatXCOFF())

[PATCH] D110429: [OpenMP] Introduce a new worksharing RTL function for distribute

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, tianshilei1992. Herald added subscribers: guansong, yaxunl. jhuber6 requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, sstefan1. Herald added projects: clang, LLVM. This patch adds a new RTL fun

[PATCH] D110431: Explicitly specify -fintegrated-as to clang/test/Driver/compilation_database.c test case.

amyk created this revision. amyk added reviewers: hubert.reinterpretcast, daltenty, sammccall. amyk added a project: clang. amyk requested review of this revision. It appears that this test assumes that the toolchain utilizes the integrated assembler by default, since the expected output in the

[clang-tools-extra] e490248 - Fix wrong FixIt about union in cppcoreguidelines-pro-type-member-init

Author: liuke Date: 2021-09-24T13:15:21-04:00 New Revision: e4902480f1e2f12f73c2b504e3d717536653dd7b URL: https://github.com/llvm/llvm-project/commit/e4902480f1e2f12f73c2b504e3d717536653dd7b DIFF: https://github.com/llvm/llvm-project/commit/e4902480f1e2f12f73c2b504e3d717536653dd7b.diff LOG: Fi

[PATCH] D108370: [clang-tidy] Fix wrong FixIt about union in cppcoreguidelines-pro-type-member-init

aaron.ballman closed this revision. aaron.ballman added a comment. In D108370#3020793 , @Sockke wrote: > In D108370#3017800 , @aaron.ballman > wrote: > >> LGTM! > > Thanks for your review! I don't have commit acc

[PATCH] D110304: [HIP] Fix linking of asanrt.bc

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/lib/Driver/ToolChains/HIP.cpp:413 } else -BCLibs.push_back(AsanRTL.str()); +BCLibs.push_back({AsanRTL.str(), false}); } tra wrote: > Nit: I'd add

[PATCH] D110422: [AIX] Enable PGO without LTO

MaskRay added a comment. > we can NOT guarantee that the relocations get resolved to the intended weak > symbol, so we can not ensure the correctness of the relative CounterPtr, so > we have to use private linkage for counter and data symbols. In other binary formats the first weak definition i

[PATCH] D105191: [Clang][OpenMP] Add partial support for Static Device Libraries

saiislam updated this revision to Diff 374897. saiislam marked an inline comment as done. saiislam added a comment. Added nvptx test cases, simplified amdgpu test case, modified commit message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105191/ne

[clang] 77d200a - Add test for DR1307, which we have already implemented.

Author: Erich Keane Date: 2021-09-24T10:24:32-07:00 New Revision: 77d200a546136c2855063613ff4bca1f682fb23a URL: https://github.com/llvm/llvm-project/commit/77d200a546136c2855063613ff4bca1f682fb23a DIFF: https://github.com/llvm/llvm-project/commit/77d200a546136c2855063613ff4bca1f682fb23a.diff L

[clang] e8e2edd - Fix test from 8dd42f, capitalization in test

Author: Erich Keane Date: 2021-09-24T10:24:32-07:00 New Revision: e8e2edd8ca88f8b0a7dba141349b2aa83284f3af URL: https://github.com/llvm/llvm-project/commit/e8e2edd8ca88f8b0a7dba141349b2aa83284f3af DIFF: https://github.com/llvm/llvm-project/commit/e8e2edd8ca88f8b0a7dba141349b2aa83284f3af.diff L

[PATCH] D110432: [clang-format][docs] mark new clang-format configuration options based on which version they would GA

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: HazardyKnusperkeks, curdeius, krasimir. MyDeveloperDay added projects: clang, clang-format. MyDeveloperDay requested review of this revision. Sometimes I see people unsure about which versions they can use in clang-format becau

[PATCH] D110432: [clang-format][docs] mark new clang-format configuration options based on which version they would GA

MyDeveloperDay added a comment. This is just a very rough idea, feel free to pull it apart. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110432/new/ https://reviews.llvm.org/D110432 ___ cfe-commits mail

[PATCH] D110431: Explicitly specify -fintegrated-as to clang/test/Driver/compilation_database.c test case.

daltenty accepted this revision. daltenty added a comment. This revision is now accepted and ready to land. LGTM (without the integrated assembler there will be an assembler invocation in the compilation database that actually produces the `.o` instead of the clang invocation we are looking for)

[PATCH] D110386: [clangd] Refactor IncludeStructure: use File (unsigned) for most computations

sammccall added a comment. Just nits left really. In D110386#3020890 , @tschuett wrote: > Do you want to wrap the `unsigned` in a struct to make it slightly safer, but > more complicated to use? I like this idea, though it's probably not a huge deal ei

[PATCH] D110128: [Driver] Correctly handle static C++ standard library

phosek added a comment. In D110128#3020468 , @nemanjai wrote: > In D110128#3018992 , @phosek wrote: > >> @MaskRay Do you think we should gate the use of this feature on >> `-fbinutils-version=` or `-fuse-ld=lld`?

[PATCH] D110422: [AIX] Enable PGO without LTO

jsji added a comment. > In other binary formats the first weak definition is selected and other weak > definitions are discarded. > Do you mean that AIX ld doesn't pick the first weak definition? No. I think this is exactly what is causing problem here. eg: if we have two weak symbols （weak_fun

[PATCH] D109541: Increase expected line number for ExtDebugInfo.cpp

aprantl added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109541/new/ https://reviews.llvm.org/D109541 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D109902: [PowerPC] Improved codegen related to xscvdpsxws/xscvdpuxws

Conanap updated this revision to Diff 374906. Conanap added a comment. This modifies a test case introduced in this commit: https://github.com/llvm/llvm-project/commit/3678df5ae6618eec656ae0ea0dab3be09d73bc9a CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109902/new/ https://reviews.llv

[PATCH] D109557: Adds a BreakBeforeClosingParen option

MyDeveloperDay added a comment. FYI, this is a very aggressive change, I highly recommend you run this over a large code base before landing. to double check, here is one slight oddity which I cannot determine if its correct or not. void foo() { if (quitelongarg != (alsolongarg - 1)) {

[PATCH] D110273: [PowerPC] Fix lharx and lbarx builtin signatures

Conanap updated this revision to Diff 374908. Conanap added a comment. Fixed an old test case CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110273/new/ https://reviews.llvm.org/D110273 Files: clang/include/clang/Basic/BuiltinsPPC.def clang/test/CodeGen/builtins-ppc-xlcompat-LoadRes

[PATCH] D110257: [CFE][Codegen] Do not break the contiguity of static allocas.

hsmhsm added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:103 +if (!ArraySize) { + auto *EBB = AllocaInsertPt->getParent(); + auto Iter = AllocaInsertPt->getIterator(); rnk wrote: > hsmhsm wrote: > > jdoerfert wrote: > > > arsenm wrote:

[clang] e09a1dc - [SystemZ][z/OS] Add GOFF Support to the DataLayout

Author: Anirudh Prasad Date: 2021-09-24T14:09:01-04:00 New Revision: e09a1dc47515d27ba5ca572a225208bb0d79fb3f URL: https://github.com/llvm/llvm-project/commit/e09a1dc47515d27ba5ca572a225208bb0d79fb3f DIFF: https://github.com/llvm/llvm-project/commit/e09a1dc47515d27ba5ca572a225208bb0d79fb3f.diff

[PATCH] D109362: [SystemZ][z/OS] Add GOFF Support to the DataLayout

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. anirudhp marked an inline comment as done. Closed by commit rGe09a1dc47515: [SystemZ][z/OS] Add GOFF Support to the DataLayout (authored by anirudhp). Repository: rG

[PATCH] D101868: [clang-format] Adds a formatter for aligning arrays of structs

MyDeveloperDay added a comment. There are a number of bugs logged against this feature, are you still around to look into them? https://bugs.llvm.org/show_bug.cgi?id=51926 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101868/new/ https://reviews.

[clang] 8ec7d9b - DebugInfo: Move the '=' version of -gsimple-template-names to the frontend

Author: David Blaikie Date: 2021-09-24T11:18:10-07:00 New Revision: 8ec7d9b8f875368a5f92596332cd05059df6bbd2 URL: https://github.com/llvm/llvm-project/commit/8ec7d9b8f875368a5f92596332cd05059df6bbd2 DIFF: https://github.com/llvm/llvm-project/commit/8ec7d9b8f875368a5f92596332cd05059df6bbd2.diff

Re: [clang] 38c09ea - DebugInfo: Add (initially no-op) -gsimple-template-names={simple, mangled}

On Thu, Sep 23, 2021 at 7:12 AM wrote: > Resending to cfe-commits instead of llvm-commits (doh!). > > > -Original Message- > > From: Robinson, Paul > > Sent: Thursday, September 23, 2021 10:05 AM > > To: David Blaikie ; 'llvm-comm...@lists.llvm.org' > > > > Cc: Adrian Prantl ; Jonas Devl

  1   2   >