MaskRay requested changes to this revision.
MaskRay added inline comments.
This revision now requires changes to proceed.
================
Comment at: llvm/lib/Transforms/Instrumentation/InstrProfiling.cpp:869
+ // symbol, so we can not ensure the correctness of the relative CounterPtr,
so
+ // we have to use private linkage for counter and data symbols.
+ if (TT.isOSBinFormatXCOFF()) {
----------------
Then you can just keep the existing weak symbols.
The weak symbols will not be selected due to linker semantics.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D110422/new/
https://reviews.llvm.org/D110422
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
