[PATCH] D110130: [clangd] Semantic highlighting for lambda init-capture

nridge updated this revision to Diff 374130. nridge added a comment. address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110130/new/ https://reviews.llvm.org/D110130 Files: clang-tools-extra/clangd/SemanticHighlighting.cpp cl

[PATCH] D110130: [clangd] Ensure lambda init-capture gets semantic token

nridge marked an inline comment as done. nridge added a comment. In D110130#3012748 , @kadircet wrote: > Naming of the patch is a little bit confusing. We're actually dropping the > semantic highlighting for the type of lambdacaptures, which was showing

[PATCH] D109517: [Clang][ARM][AArch64] Add support for Armv9-A, Armv9.1-A and Armv9.2-A

SjoerdMeijer accepted this revision. SjoerdMeijer added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/Driver/ToolChains/Arch/AArch64.cpp:419 + + // Enable SVE2 by default on Armv9-A + // It can still be disabled if +nosve2 is present -

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

achieveartificialintelligence updated this revision to Diff 374131. achieveartificialintelligence added a comment. Address @jrtc27 's comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93298/new/ https://reviews.llvm.org/D93298 Files: llvm/l

[PATCH] D109967: Simplify handling of builtin with inline redefinition

serge-sans-paille marked 3 inline comments as done. serge-sans-paille added a comment. In D109967#3013552 , @nickdesaulniers wrote: > Looks reasonable. Can you give us some time to test this on the Linux kernel? Sure, who can refuse some extra testing?

[clang] 7ce6385 - [clang][ASTImporter] Generic attribute import handling (first step).

Author: Balázs Kéri Date: 2021-09-22T10:14:03+02:00 New Revision: 7ce638538bcf323cd15ed5dfbc43013312b0e3e3 URL: https://github.com/llvm/llvm-project/commit/7ce638538bcf323cd15ed5dfbc43013312b0e3e3 DIFF: https://github.com/llvm/llvm-project/commit/7ce638538bcf323cd15ed5dfbc43013312b0e3e3.diff L

[PATCH] D109608: [clang][ASTImporter] Generic attribute import handling (first step).

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7ce638538bcf: [clang][ASTImporter] Generic attribute import handling (first step). (authored by balazske). Repository: rG LLVM Github Monorepo CH

[PATCH] D110128: [Driver] Correctly handle static C++ standard library

phosek updated this revision to Diff 374154. phosek marked 5 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110128/new/ https://reviews.llvm.org/D110128 Files: clang/lib/Driver/ToolChains/Fuchsia.cpp clang/lib/Driver/Tool

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

pdhaliwal added a comment. It looks like from IR diff that this patch is adding use of kmpc_alloc_shared method. These methods likely won't work on AMDGPU as device malloc is not available. Not sure what could be done apart from marking those tests as XFAIL on amdgcn. :( Repository: rG LLVM

[PATCH] D106876: Remove non-affecting module maps from PCM files.

ilyakuteev updated this revision to Diff 374156. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106876/new/ https://reviews.llvm.org/D106876 Files: clang/include/clang/Serialization/ASTWriter.h clang/lib/Serialization/ASTWriter.cpp clang/test/Modules/Inputs/AddRemoveIrrelevantModule

[PATCH] D104285: [analyzer] Retrieve a value from list initialization of constant array declaration in a global scope.

ASDenysPetrov added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RegionStore.cpp:1696 + const llvm::APSInt &Idx = CI->getValue(); + const uint64_t I = static_cast(Idx.getExtValue()); + // Use `getZExtValue` because array extent

[PATCH] D109517: [Clang][ARM][AArch64] Add support for Armv9-A, Armv9.1-A and Armv9.2-A

vhscampos updated this revision to Diff 374162. vhscampos added a comment. Add missing . to end of sentences in comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109517/new/ https://reviews.llvm.org/D109517 Files: clang/lib/Basic/Targets/A

[PATCH] D109818: [HIPSPV] Convert HIP kernels to SPIR-V kernels

Anastasia added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:10221 +ABIArgInfo SPIRABIInfo::classifyKernelArgumentType(QualType Ty) const { + if (getContext().getLangOpts().HIP && getTarget().getTriple().isSPIRV()) { +// Coerce pointer arguments with default

[PATCH] D110184: [OpenCL] Constructor address space test adjusted for C++ for OpenCL 2021

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110184/new/ https://reviews.llvm.org/D110184 _

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

JonChesterfield added a comment. In D102107#3014599 , @pdhaliwal wrote: > It looks like from IR diff that this patch is adding use of kmpc_alloc_shared > method. These methods likely won't work on AMDGPU as device malloc is not > available. Not sure wha

[PATCH] D102478: [Matrix] Emit assumption that matrix indices are valid.

fhahn added a comment. All required changes to make use of this have recently landed or are ready to land. So I am going to commit this momentarily. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102478/new/ https://reviews.llvm.org/D102478 __

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

pdhaliwal added a comment. I got this after changing __kmpc_impl_malloc to return 0xdeadbeef. So, this confirms that missing malloc implementation is the root cause. > Memory access fault by GPU node-4 (Agent handle: 0x1bc5000) on address > 0xdeadb000. Reason: Page not present or supervisor pri

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

JonChesterfield added a comment. In D102107#3014743 , @pdhaliwal wrote: > I got this after changing __kmpc_impl_malloc to return 0xdeadbeef. So, this > confirms that missing malloc implementation is the root cause. > >> Memory access fault by GPU node-4

[PATCH] D106876: Remove non-affecting module maps from PCM files.

ilyakuteev updated this revision to Diff 374173. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106876/new/ https://reviews.llvm.org/D106876 Files: clang/include/clang/Serialization/ASTWriter.h clang/lib/Serialization/ASTWriter.cpp clang/test/Modules/Inputs/AddRemoveIrrelevantModule

[PATCH] D108194: [clangd] IncludeCleaner: Mark used headers

kbobyrev updated this revision to Diff 374174. kbobyrev marked 4 inline comments as done. kbobyrev added a comment. Improve structure, address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108194/new/ https://reviews.llvm.org/D1081

[PATCH] D108194: [clangd] IncludeCleaner: Mark used headers

kbobyrev added a comment. Hey, sorry for the gigantic turn around. I still need to cover the code with few tests and polish it a bit more but I've updated the majority of it and pushed to get some early feedback before I do that. Please let me know if you have any concerns/see some problems wit

[PATCH] D109818: [HIPSPV] Convert HIP kernels to SPIR-V kernels

bader added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:10224 +// pointers for HIPSPV. When the language mode is HIP, the SPIRTargetInfo +// maps cuda_device to SPIR-V's CrossWorkGroup address space. +llvm::Type *LTy = CGT.ConvertType(Ty); --

[clang] ea21d68 - [Matrix] Emit assumption that matrix indices are valid.

Author: Florian Hahn Date: 2021-09-22T12:27:37+01:00 New Revision: ea21d688dc0a420b9fc385562a46017fb39b13e5 URL: https://github.com/llvm/llvm-project/commit/ea21d688dc0a420b9fc385562a46017fb39b13e5 DIFF: https://github.com/llvm/llvm-project/commit/ea21d688dc0a420b9fc385562a46017fb39b13e5.diff

[PATCH] D102478: [Matrix] Emit assumption that matrix indices are valid.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGea21d688dc0a: [Matrix] Emit assumption that matrix indices are valid. (authored by fhahn). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 1ee851c - Revert "[CodeGen] regenerate test checks; NFC"

Author: Sanjay Patel Date: 2021-09-22T07:45:21-04:00 New Revision: 1ee851c5859fdb36eca57a46347a1e7b8e1ff236 URL: https://github.com/llvm/llvm-project/commit/1ee851c5859fdb36eca57a46347a1e7b8e1ff236 DIFF: https://github.com/llvm/llvm-project/commit/1ee851c5859fdb36eca57a46347a1e7b8e1ff236.diff

[PATCH] D108567: Implement #pragma clang final extension

aaron.ballman added inline comments. Comment at: clang/docs/LanguageExtensions.rst:3979 + #undef FINAL_MACRO // warning: FINAL_MACRO is marked final and should not be undefined + #define FINAL_MACRO // warning: FINAL_MACRO is marked final and should not be redefined +

[PATCH] D104285: [analyzer] Retrieve a value from list initialization of constant array declaration in a global scope.

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang/lib/StaticAnalyzer/Core/RegionStore.cpp:1696-1697 + const auto I = static_cast(Idx.getExtValue()); + // Use `getZExtValue`

[PATCH] D106102: [analyzer][solver] Introduce reasoning for not equal to operator

martong added a comment. This is promising! Gentle ping @manas @vsavchenko Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106102/new/ https://reviews.llvm.org/D106102 ___ cfe-commits mailing list cfe-comm

[PATCH] D97874: [analyzer] Improve SVal cast from integer to bool using known RangeSet

martong added a comment. Herald added a subscriber: manas. @ASDenysPetrov I think the dependent patch https://reviews.llvm.org/D97296 is too much and contains unnecessary things for this change. If you could you please incorporate the minimum needed changes from that patch to here then this pat

[PATCH] D97960: [clang-tidy] bugprone-signal-handler improvements: display call chain

martong added a comment. So, about the tests, gentle ping @njames93 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97960/new/ https://reviews.llvm.org/D97960 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D110130: [clangd] Ensure lambda init-capture gets semantic token

kadircet added a comment. thanks, LGTM! Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:518 + SourceLocation StartLoc = D->getTypeSpecStartLoc(); + // The AutoType may not have a corresponding token, e.g. in the case of + // init-captures, so there'

[PATCH] D86295: [analyzer] Reorder the layout of MemRegion and cache by hand for optimal size

martong added a comment. Herald added a subscriber: manas. In D86295#2539431 , @steakhal wrote: > In D86295#2519851 , @ASDenysPetrov > wrote: > >> What about this change? Did you make more measurements? > > IMO it

[PATCH] D86295: [analyzer] Reorder the layout of MemRegion and cache by hand for optimal size

steakhal added a comment. In D86295#3014990 , @martong wrote: > @steakhal Since then we have our fancy csa-testbench based jenkins job(s) to > do measurement even on huge projects. Do you think it would make sense to > give it another measure with that?

[PATCH] D108301: [MSP430][Clang] Update hard-coded MCU data

jozefl updated this revision to Diff 374200. jozefl added a comment. Herald added subscribers: llvm-commits, ormris, hiraditya. Herald added a project: LLVM. Rebase to fix patch application failure for clang/test/Misc/target-invalid-cpu-note.c. Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D110241: [docs] List support for Armv9-A, Armv9.1-A and Armv9.2-A in LLVM and Clang

vhscampos created this revision. Herald added a subscriber: kristof.beyls. vhscampos requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D110241 Files: clang/d

[PATCH] D105191: [Clang][OpenMP] Add support for Static Device Libraries

pdhaliwal added inline comments. Comment at: clang/test/Driver/fat_archive.cpp:9 +// could be resolved correctly. +// RUN: env LIBRARY_PATH=%T/../../../../../runtimes/runtimes-bins/openmp/libomptarget %clang -O2 -target x86_64-pc-linux-gnu -fopenmp -fopenmp-targets=amdgcn-amd-

[PATCH] D110241: [docs] List support for Armv9-A, Armv9.1-A and Armv9.2-A in LLVM and Clang

vhscampos updated this revision to Diff 374207. vhscampos added a comment. Added 'the' for better phrasing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110241/new/ https://reviews.llvm.org/D110241 Files: clang/docs/ReleaseNotes.rst llvm/docs

[PATCH] D110241: [docs] List support for Armv9-A, Armv9.1-A and Armv9.2-A in LLVM and Clang

pratlucas accepted this revision. pratlucas added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110241/new/ https://reviews.llvm.org/D110241

[PATCH] D110226: [InstCombine] Update InstCombine to use poison instead of undef for shufflevector's placeholder (1/3)

hyeongyukim updated this revision to Diff 374210. hyeongyukim added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fix comment, update test file(wasm.c) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110226/new/ ht

[PATCH] D110226: [InstCombine] Update InstCombine to use poison instead of undef for shufflevector's placeholder (1/3)

hyeongyukim updated this revision to Diff 374212. hyeongyukim added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110226/new/ https://reviews.llvm.org/D110226 Files: llvm/lib/CodeGen/SelectionDAG/LegalizeIntegerTypes.cpp llvm

[PATCH] D110226: [InstCombine] Update InstCombine to use poison instead of undef for shufflevector's placeholder (1/3)

hyeongyukim updated this revision to Diff 374213. hyeongyukim added a comment. Herald added subscribers: aheejin, sbc100. Correct the wrong rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110226/new/ https://reviews.llvm.org/D110226 Files:

[PATCH] D105014: added some example code for llvm::Expected

kuhnel added a comment. > Out of interest, did you see > https://llvm.org/docs/ProgrammersManual.html#error-handling ? If not (and if > you find it helpful) then maybe we need to make that document more > discoverable. If that document is not helpful then we should improve it. No I wasn't awar

[PATCH] D108194: [clangd] IncludeCleaner: Mark used headers

kbobyrev updated this revision to Diff 374219. kbobyrev added a comment. Populate Inclusion.ID, add a test (failing for now). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108194/new/ https://reviews.llvm.org/D108194 Files: clang-tools-extra/cla

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

jdoerfert added a comment. In D102107#3014759 , @JonChesterfield wrote: > In D102107#3014743 , @pdhaliwal > wrote: > >> I got this after changing __kmpc_impl_malloc to return 0xdeadbeef. So, this >> confirms th

[PATCH] D110252: Added note about Whatstyle and Unformat

Volker-Weissmann created this revision. Volker-Weissmann added a reviewer: sdesmalen. Volker-Weissmann requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. I added a note about Whatstyle and Unformat

[PATCH] D110029: [OpenMP][Offloading] Use bitset to indicate execution mode instead of value

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110029/new/ https://reviews.llvm.org/D110029 ___

[clang] e5aaf03 - [InstCombine] Update InstCombine to use poison instead of undef for shufflevector's placeholder (1/3)

Author: hyeongyu kim Date: 2021-09-22T23:18:51+09:00 New Revision: e5aaf0332670577cc19ac67b07b10261da6fc1e1 URL: https://github.com/llvm/llvm-project/commit/e5aaf0332670577cc19ac67b07b10261da6fc1e1 DIFF: https://github.com/llvm/llvm-project/commit/e5aaf0332670577cc19ac67b07b10261da6fc1e1.diff

[PATCH] D110226: [InstCombine] Update InstCombine to use poison instead of undef for shufflevector's placeholder (1/3)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe5aaf0332670: [InstCombine] Update InstCombine to use poison instead of undef for… (authored by hyeongyukim). Repository: rG LLVM Github Monorepo

[PATCH] D108194: [clangd] IncludeCleaner: Mark used headers

kbobyrev updated this revision to Diff 374226. kbobyrev added a comment. Make sure FileEntry* is not nullptr Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108194/new/ https://reviews.llvm.org/D108194 Files: clang-tools-extra/clangd/Headers.cpp

[PATCH] D110255: Change error for storage-class to mean linkage, fix lang-linkage diag

erichkeane created this revision. erichkeane added a reviewer: aaron.ballman. erichkeane requested review of this revision. Allow multiversioning declarations to match when the actual formal linkage matches, not just when the storage class is identical. Additionally, change the ambiguous 'linkage'

[PATCH] D110129: [DebugInfo] Support typedef with btf_tag attributes

probinson accepted this revision. probinson added a comment. This revision is now accepted and ready to land. In D110129#3013946 , @yonghong-song wrote: > - The only thing left is for llvm/test/DebugInfo/X86/attr-btf_tag-typedef.ll > for which I didn't

[PATCH] D110257: [CFE][Codegen] Do not the break contiguity of static allocas.

hsmhsm created this revision. hsmhsm added reviewers: arsenm, rampitec, jdoerfert, lebedev.ri, nhaehnle, rjmccall, yaxunl, AndreyChurbanov. Herald added a subscriber: jvesely. hsmhsm requested review of this revision. Herald added subscribers: cfe-commits, sstefan1, wdng. Herald added a project: c

[PATCH] D110258: [AArch64][Clang] Always add -tune-cpu argument to -cc1 driver

david-arm created this revision. david-arm added reviewers: sdesmalen, c-rhodes, peterwaller-arm, dmgreen. Herald added a subscriber: kristof.beyls. david-arm requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch ensures that we always

[PATCH] D108370: [clang-tidy] Fix wrong FixIt about union in cppcoreguidelines-pro-type-member-init

Sockke added a comment. Hi, Could you please take some time to review this diff again? @aaron.ballman Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108370/new/ https://reviews.llvm.org/D108370 ___ cfe-co

[PATCH] D110258: [AArch64][Clang] Always add -tune-cpu argument to -cc1 driver

dmgreen added a comment. My understanding is that -mtune doesn't work sensibly for Arm backends. The tuning features and architecture features are not separated out at the subtarget level. Is the idea to teach people to start using it? That sounds dangerous without fixing the issues with it fi

[PATCH] D110142: [clang][Driver] Correct runtime path for Arm hard float targets

DavidSpickett added a comment. So would you expect to see libraries in `lib/clang/14.0.0/lib/armv8l-unknown-linux-gnueabihf` and not change clang's logic? The output dir is worked out in cmake by `get_compiler_rt_output_dir` which calls `get_compiler_rt_target` which takes the arch given and a

[PATCH] D110258: [AArch64][Clang] Always add -tune-cpu argument to -cc1 driver

david-arm added a comment. Hi @dmgreen, this is specifically being introduced for SVE targets to help make informed cost model decisions regarding the value of vscale - see D110259 . We thought that using the "tune-cpu" attribute might be a good way of doing th

[clang] ca999f7 - [OpenMP][Offloading] Use bitset to indicate execution mode instead of value

Author: Shilei Tian Date: 2021-09-22T11:40:52-04:00 New Revision: ca999f719117f916b333a794cc8c59984ae40dd2 URL: https://github.com/llvm/llvm-project/commit/ca999f719117f916b333a794cc8c59984ae40dd2 DIFF: https://github.com/llvm/llvm-project/commit/ca999f719117f916b333a794cc8c59984ae40dd2.diff L

[PATCH] D110029: [OpenMP][Offloading] Use bitset to indicate execution mode instead of value

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGca999f719117: [OpenMP][Offloading] Use bitset to indicate execution mode instead of value (authored by tianshilei1992). Repository: rG LLVM Github

[PATCH] D110230: [InstCombine] Update InstCombine to use poison instead of undef for shufflevector's placeholder (3/3)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG98e96663f6a7: [InstCombine] Update InstCombine to use poison instead of undef for… (authored by hyeongyukim). Herald added a project: clang. Herald a

[clang] 98e9666 - [InstCombine] Update InstCombine to use poison instead of undef for shufflevector's placeholder (3/3)

Author: hyeongyu kim Date: 2021-09-23T00:48:24+09:00 New Revision: 98e96663f6a77ee06c5db3f25cdcf19b56ac8f04 URL: https://github.com/llvm/llvm-project/commit/98e96663f6a77ee06c5db3f25cdcf19b56ac8f04 DIFF: https://github.com/llvm/llvm-project/commit/98e96663f6a77ee06c5db3f25cdcf19b56ac8f04.diff

[PATCH] D110260: [ORC] Minor renaming and typo fixes (NFC)

sgraenitz created this revision. sgraenitz added a reviewer: lhames. Herald added subscribers: hiraditya, mgorny. sgraenitz requested review of this revision. Herald added projects: clang, LLVM. Herald added a subscriber: cfe-commits. One typo, one unsused include and some leftovers from the Targe

[PATCH] D110257: [CFE][Codegen] Do not break the contiguity of static allocas.

hsmhsm updated this revision to Diff 374252. hsmhsm added a comment. Update source comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110257/new/ https://reviews.llvm.org/D110257 Files: clang/lib/CodeGen/CGExpr.cpp clang/test/CodeGenCUDA/b

[clang] d9b511d - [CSSPGO] Set PseudoProbeInserter as a default pass.

Author: Hongtao Yu Date: 2021-09-22T09:09:48-07:00 New Revision: d9b511d8e8c43f79e0e277be287656693dd6563f URL: https://github.com/llvm/llvm-project/commit/d9b511d8e8c43f79e0e277be287656693dd6563f DIFF: https://github.com/llvm/llvm-project/commit/d9b511d8e8c43f79e0e277be287656693dd6563f.diff LO

[PATCH] D110209: [CSSPGO] Set PseudoProbeInserter as a default pass.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd9b511d8e8c4: [CSSPGO] Set PseudoProbeInserter as a default pass. (authored by hoy). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D110257: [CFE][Codegen] Do not break the contiguity of static allocas.

arsenm added a comment. I do think it's cleaner/more canonical IR to cluster these at the top of the block, but I don't understand this comment: > otherwise, inliner's attempt to move static allocas from callee to caller > will fail, The inliner successfully moves allocas to the caller's entry

[PATCH] D108301: [MSP430][Clang] Update hard-coded MCU data

jozefl updated this revision to Diff 374255. jozefl added a comment. Undo incorrect rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108301/new/ https://reviews.llvm.org/D108301 Files: clang/include/clang/Basic/MSP430Target.def clang/lib/

[PATCH] D109174: [MSP430][Clang] Infer CPU type from -mcpu= or -mmcu=

jozefl updated this revision to Diff 374257. jozefl added a comment. Rebase to fix patch application failure for clang/test/Misc/target-invalid-cpu-note.c. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109174/new/ https://reviews.llvm.org/D109174

[PATCH] D110111: [WebAssembly] Add relaxed-simd feature

ngzhian updated this revision to Diff 374262. ngzhian marked an inline comment as done. ngzhian added a comment. Herald added subscribers: llvm-commits, hiraditya. Herald added a project: LLVM. Fix fallthrough, add feature to WebAssembly subtarget Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D110111: [WebAssembly] Add relaxed-simd feature

ngzhian added a comment. In D110111#3013948 , @tlively wrote: > Nice! Thanks for writing this :D Do you know what happens when you actually > try to compile some code with `-mrelaxed-simd`? I'm concerned that it will > throw an error because the "relaxe

[PATCH] D110142: [clang][Driver] Correct runtime path for Arm hard float targets

MaskRay added a comment. In D110142#3015482 , @DavidSpickett wrote: > So would you expect to see libraries in > `lib/clang/14.0.0/lib/armv8l-unknown-linux-gnueabihf` and not change clang's > logic? I'd hope that it works this way (`armv8l-*`) :) > Th

[PATCH] D99797: [analyzer] Implemented RangeSet::Factory::unite function to handle intersections and adjacency

ASDenysPetrov updated this revision to Diff 374265. ASDenysPetrov added a comment. Rebased. Review, please. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99797/new/ https://reviews.llvm.org/D99797 Files: clang/include/clang/StaticAnalyzer/Core/PathSensitive/RangedConstraintManager.h

[PATCH] D103094: [analyzer] Implemented RangeSet::Factory::castTo function to perform promotions, truncations and conversions.

ASDenysPetrov updated this revision to Diff 374267. ASDenysPetrov added a comment. Rebased. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103094/new/ https://reviews.llvm.org/D103094 Files: clang/include/clang/StaticAnalyzer/Core/PathSensitive/APSIntType.h clang/include/clang/Stat

[PATCH] D110257: [CFE][Codegen] Do not break the contiguity of static allocas.

hsmhsm added a comment. In D110257#3015553 , @arsenm wrote: > I do think it's cleaner/more canonical IR to cluster these at the top of the > block, but I don't understand this comment: > >> otherwise, inliner's attempt to move static allocas from callee

[PATCH] D110258: [AArch64][Clang] Always add -tune-cpu argument to -cc1 driver

dmgreen added a comment. In D110258#3015484 , @david-arm wrote: > Hi @dmgreen, this is specifically being introduced for SVE targets to help > make informed cost model decisions regarding the value of vscale - see > D110259

[PATCH] D105340: [analyzer] Produce SymbolCast symbols for integral types in SValBuilder::evalCast

ASDenysPetrov updated this revision to Diff 374270. ASDenysPetrov added a comment. Rebased. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105340/new/ https://reviews.llvm.org/D105340 Files: clang/include/clang/StaticAnalyzer/Checkers/SValExplainer.h clang/include/clang/StaticAnalyz

[PATCH] D110257: [CFE][Codegen] Do not break the contiguity of static allocas.

jdoerfert added a comment. In D110257#3015641 , @hsmhsm wrote: > In D110257#3015553 , @arsenm wrote: > >> I do think it's cleaner/more canonical IR to cluster these at the top of the >> block, but I don't underst

[clang] fe16d33 - Add document numbers for the C99 status page.

Author: Aaron Ballman Date: 2021-09-22T13:02:25-04:00 New Revision: fe16d331d345acfb06a01da15100d5899efb0c51 URL: https://github.com/llvm/llvm-project/commit/fe16d331d345acfb06a01da15100d5899efb0c51 DIFF: https://github.com/llvm/llvm-project/commit/fe16d331d345acfb06a01da15100d5899efb0c51.diff

[PATCH] D104285: [analyzer] Retrieve a value from list initialization of constant array declaration in a global scope.

ASDenysPetrov added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RegionStore.cpp:1696-1697 + const auto I = static_cast(Idx.getExtValue()); + // Use `getZExtValue` because array extent can not be negative. + const uint64_t Exte

[PATCH] D104285: [analyzer] Retrieve a value from list initialization of constant array declaration in a global scope.

ASDenysPetrov added a comment. @martong Thank you for your time! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104285/new/ https://reviews.llvm.org/D104285 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[PATCH] D110089: [CUDA] Implement experimental support for texture lookups.

tra added a comment. In D110089#3014388 , @jlebar wrote: >> One alternative would be to use run-time dispatch, but, given that texture >> lookup is a single instruction, the overhead would be >> substantial-to-prohibitive. > > I guess I'm confused... I

[PATCH] D109951: [clang-format] Constructor initializer lists format with pp directives

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109951/new/ https://reviews.llvm.org/D109951 ___ cfe-commits mailing list cfe-com

[PATCH] D109658: [X86][FP16] Change the order of the operands in complex FMA intrinsics to allow swap between the mul operands.

craig.topper added inline comments. Comment at: clang/lib/Headers/avx512fp16intrin.h:2972 #define _mm_mask_fcmadd_round_sch(A, U, B, C, R) \ ((__m128h)__builtin_ia32_selectps_128( \ (__mmask8)(U & 1)

[PATCH] D103314: [Analyzer][solver] Simplify existing constraints when a new constraint is added

chrish_ericsson_atx added a comment. I believe this commit exposed a new false-positive bug in [core.DivideZero]. I've filed the report here: https://bugs.llvm.org/show_bug.cgi?id=51940 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103314/new/ ht

[PATCH] D109951: [clang-format] Constructor initializer lists format with pp directives

guitard0g added a comment. @MyDeveloperDay @HazardyKnusperkeks I don't have commit access, could one of you commit this for me? Thanks so much for your review! Name: Josh Learn Email: joshua_le...@apple.com (The test failures seem to be unrelated, but I'm fine waiting until they start passing

[PATCH] D109967: Simplify handling of builtin with inline redefinition

serge-sans-paille updated this revision to Diff 374290. serge-sans-paille added a comment. Set default as suggested by @nickdesaulniers CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109967/new/ https://reviews.llvm.org/D109967 Files: clang/lib/CodeGen/CodeGenFunction.cpp clang/lib/

[PATCH] D36850: [ThinLTO] Add norecurse function attribute propagation

tejohnson added a comment. Thanks for your patience, finally had a chance to go through everything much more carefully. Looks good, mostly a bunch of small or nitpicky final suggestions. The main comment/question of significance relates to where hasUnknownCall is being set currently. Patch tit

[PATCH] D36850: [ThinLTO] Add norecurse function attribute propagation

tejohnson added inline comments. Comment at: llvm/include/llvm/IR/ModuleSummaryIndex.h:575 unsigned AlwaysInline : 1; +unsigned NoUnwind : 1; +// Indicate if function contains instructions that mayThrow tejohnson wrote: > No Unwind needs a comment. A

[clang] af99236 - Don't diagnose unused but set when the Cleanup attribute is used.

Author: Michael Benfield Date: 2021-09-22T17:48:09Z New Revision: af99236747872af7e77092cbf6ddd18fa8623a2f URL: https://github.com/llvm/llvm-project/commit/af99236747872af7e77092cbf6ddd18fa8623a2f DIFF: https://github.com/llvm/llvm-project/commit/af99236747872af7e77092cbf6ddd18fa8623a2f.diff L

[PATCH] D109862: Don't diagnose unused but set when the Cleanup attribute is used.

This revision was automatically updated to reflect the committed changes. Closed by commit rGaf9923674787: Don't diagnose unused but set when the Cleanup attribute is used. (authored by mbenfield). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109862

[PATCH] D110255: Change error for storage-class to mean linkage, fix lang-linkage diag

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110255/new/ https://reviews.llvm.org/D110255 ___ cfe-commits mailing lis

[clang] 97b2f20 - Change error for storage-class to mean linkage, fix lang-linkage diag

Author: Erich Keane Date: 2021-09-22T10:51:05-07:00 New Revision: 97b2f20a446e54f4354d8f950dfab62c37e6ddf4 URL: https://github.com/llvm/llvm-project/commit/97b2f20a446e54f4354d8f950dfab62c37e6ddf4 DIFF: https://github.com/llvm/llvm-project/commit/97b2f20a446e54f4354d8f950dfab62c37e6ddf4.diff L

[PATCH] D69764: [clang-format] Add Left/Right Const fixer capability

MyDeveloperDay updated this revision to Diff 374294. MyDeveloperDay marked 3 inline comments as done. MyDeveloperDay added a comment. Remove use of Typenamemacros (we'll solve this a different way later) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69764/new/ https://reviews.llvm.org/D

[PATCH] D69764: [clang-format] Add Left/Right Const fixer capability

MyDeveloperDay updated this revision to Diff 374298. MyDeveloperDay added a comment. Use better vector initialization CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69764/new/ https://reviews.llvm.org/D69764 Files: clang/docs/ClangFormatStyleOptions.rst clang/docs/ReleaseNotes.rst

[PATCH] D110273: [PowerPC] Fix lharx and lbarx builtin signatures

Conanap created this revision. Conanap added reviewers: PowerPC, nemanjai, stefanp, saghir. Conanap added projects: clang, LLVM, PowerPC. Herald added subscribers: steven.zhang, kbarton. Conanap requested review of this revision. The signatures for the PowerPC builtins `lharx` and `lbarx` are inco

[clang] 38c09ea - DebugInfo: Add (initially no-op) -gsimple-template-names={simple,mangled}

Author: David Blaikie Date: 2021-09-22T11:11:49-07:00 New Revision: 38c09ea2d279eabe3602e2002f8cdfcc5380 URL: https://github.com/llvm/llvm-project/commit/38c09ea2d279eabe3602e2002f8cdfcc5380 DIFF: https://github.com/llvm/llvm-project/commit/38c09ea2d279eabe3602e2002f8cdfcc5380.diff

[PATCH] D110257: [CFE][Codegen] Do not break the contiguity of static allocas.

arsenm added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:102-106 + auto *EBB = AllocaInsertPt->getParent(); + auto Iter = AllocaInsertPt->getIterator(); + if (Iter != EBB->end()) +++Iter; + Builder.SetInsertPoint(EBB, Iter); -

[PATCH] D110273: [PowerPC] Fix lharx and lbarx builtin signatures

nemanjai added a comment. The description says it causes issues but there is no test case. Please add the test case that causes issues. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110273/new/ https://reviews.llvm.org/D110273 ___

[PATCH] D110257: [CFE][Codegen] Do not break the contiguity of static allocas.

jdoerfert added a subscriber: rnk. jdoerfert added a comment. In D110257#3015712 , @jdoerfert wrote: > In D110257#3015641 , @hsmhsm wrote: > >> In D110257#3015553 , @arsen

[PATCH] D110276: Clean up large copies of binaries copied into temp directories in tests

tejohnson created this revision. tejohnson added reviewers: thakis, scott.linder. tejohnson requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In looking at the disk space used by a ninja check-all, I found that a few of the largest files were

  1   2   >