tejohnson added inline comments.
================
Comment at: llvm/include/llvm/IR/ModuleSummaryIndex.h:575
unsigned AlwaysInline : 1;
+ unsigned NoUnwind : 1;
+ // Indicate if function contains instructions that mayThrow
----------------
tejohnson wrote:
> No Unwind needs a comment. And probably a note that it will be updated by
> function attr propagation. Depends on how we want to handle inline asm calls
> and other cases that currently set this true below (see my comment there).
Woops, the second sentence here "Depends on how we want to handle inline asm
calls and other cases that currently set this true below (see my comment
there)." I meant to add to the comment further below about the name of
hasUnknownCall.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D36850/new/
https://reviews.llvm.org/D36850
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
