[PATCH] D109950: [Clang] Enable IC/IF mode for __ibm128

qiucf created this revision. qiucf added reviewers: nemanjai, hubert.reinterpretcast, rjmccall, PowerPC, aaron.ballman. qiucf requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. As for 128-bit floating points on PPC, compiler should have three

[PATCH] D109517: [Clang][ARM][AArch64] Add support for Armv9-A, Armv9.1-A and Armv9.2-A

SjoerdMeijer accepted this revision. SjoerdMeijer added a comment. This revision is now accepted and ready to land. Thanks, looks reasonable to me. Comment at: llvm/unittests/Support/TargetParserTest.cpp:495 ARMBuildAttrs::CPUArch::v8_A)); + EXPECT_T

[PATCH] D109951: [clang-format] Constructor initializer lists format with pp directives

guitard0g created this revision. guitard0g requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Currently constructor initializer lists sometimes format incorrectly when there is a preprocessor directive in the middle of the list. This patch fix

[PATCH] D109951: [clang-format] Constructor initializer lists format with pp directives

MyDeveloperDay added a comment. was there a bug report against this? what was it doing before? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109951/new/ https://reviews.llvm.org/D109951 ___ cfe-commits m

[clang] 0195f86 - [Clang] Fix long double availability check

Author: Qiu Chaofan Date: 2021-09-17T15:24:06+08:00 New Revision: 0195f8621f1814967f9cd3ef51ee61117e914299 URL: https://github.com/llvm/llvm-project/commit/0195f8621f1814967f9cd3ef51ee61117e914299 DIFF: https://github.com/llvm/llvm-project/commit/0195f8621f1814967f9cd3ef51ee61117e914299.diff L

[PATCH] D109951: [clang-format] Constructor initializer lists format with pp directives

guitard0g added a comment. @MyDeveloperDay This is an issue a coworker pointed out to me. Previously this code: Foo::Foo(int x) : _x { x } #if DEBUG , _y { 0 } #endif { } would format into the following: Foo::Foo(int x) : _x { x } #if DEBUG , _y {

[PATCH] D109951: [clang-format] Constructor initializer lists format with pp directives

guitard0g updated this revision to Diff 373158. guitard0g added a comment. Removing useless line from test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109951/new/ https://reviews.llvm.org/D109951 Files: clang/lib/Format/UnwrappedLineParser.cp

[PATCH] D109799: [RISCV] add Half-precision test for load/store

achieveartificialintelligence updated this revision to Diff 373161. achieveartificialintelligence added a comment. add more Half-precision tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109799/new/ https://reviews.llvm.org/D109799 Files: cl

[PATCH] D109894: [clangd] Bail-out when an empty compile flag is encountered

kadircet added a comment. > I do half wonder whether we're going to get 3 steps further and then crash > again when we call Command.front() :-) I actually couldn't find any other places this could happen today (we seem to check for non-emptiness of compile commands most of the time). But I hadn

[PATCH] D109894: [clangd] Bail-out when an empty compile flag is encountered

kadircet updated this revision to Diff 373163. kadircet added a comment. Herald added a project: clang. - Also handle OOB access while creating compiler invocation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109894/new/ https://reviews.llvm.org/

[PATCH] D109951: [clang-format] Constructor initializer lists format with pp directives

guitard0g updated this revision to Diff 373167. guitard0g added a comment. Fix failing tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109951/new/ https://reviews.llvm.org/D109951 Files: clang/lib/Format/UnwrappedLineParser.cpp clang/unit

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

achieveartificialintelligence updated this revision to Diff 373170. achieveartificialintelligence added a comment. fix CI error Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93298/new/ https://reviews.llvm.org/D93298 Files: llvm/lib/Target/RISCV

[clang] 37cdc7e - [OpenCL] Supports optional pipe types in C++ for OpenCL 2021

Author: Justas Janickas Date: 2021-09-17T09:56:20+01:00 New Revision: 37cdc7ebd9a373100cbbe39f5b9be7a4e4f7813d URL: https://github.com/llvm/llvm-project/commit/37cdc7ebd9a373100cbbe39f5b9be7a4e4f7813d DIFF: https://github.com/llvm/llvm-project/commit/37cdc7ebd9a373100cbbe39f5b9be7a4e4f7813d.dif

[PATCH] D109306: [OpenCL] Supports optional pipe types in C++ for OpenCL 2021

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG37cdc7ebd9a3: [OpenCL] Supports optional pipe types in C++ for OpenCL 2021 (authored by Topotuna). Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D108832: [Builtins] Support ext_vector_type args for __builtin_fminf.

fhahn planned changes to this revision. fhahn added a comment. In D108832#2969538 , @erichkeane wrote: > Codewise I'm ok, but I don't feel comfortable making the direction decision. > I'd like to see some level of 'state of things' on the vector types

[PATCH] D109956: Fix CodeGen/pgo-sample-thinlto-summary.c with old PM

thopre created this revision. thopre added reviewers: gregmiller, tejohnson, davide, danielcdh. Herald added subscribers: ormris, wenlei, steven_wu, hiraditya, inglorion. thopre requested review of this revision. Herald added a project: clang. Re-add -fexperimental-new-pass-manager to Clang::CodeG

[PATCH] D109234: [PGO] Change ThinLTO test for targets with loop unrolling disabled

thopre added a comment. In D109234#3004253 , @gregmiller wrote: > Hello, > We are maintaining a downstream version of the monorepo based on the LLVM > main branch. We have not transitioned to the new PM yet. In a recent attempt > to merge the latest u

[PATCH] D106262: [clang][analyzer] Use generic note tag in alpha.unix.Stream .

balazske added a comment. > I'd like to test cases where the very same function call gets a different > note message depending on the BugType: These tests are doing this: void check_indeterminate_notes_fseek_no_feof_no_ferror() { FILE *F; char Buf[10]; F = fopen("foo1.c", "r");

[PATCH] D109608: [clang][ASTImporter] Generic attribute import handling (first step).

martong added a reviewer: steakhal. martong added a subscriber: steakhal. martong added a comment. @steakhal, could you please take a look? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109608/new/ https://reviews.llvm.org/D109608

[PATCH] D106876: Remove non-affecting module maps from PCM files.

ilyakuteev updated this revision to Diff 373179. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106876/new/ https://reviews.llvm.org/D106876 Files: clang/include/clang/Serialization/ASTWriter.h clang/lib/Serialization/ASTWriter.cpp clang/test/Modules/Inputs/AddRemoveIrrelevantModule

[PATCH] D109943: [Clang] Fix long double availability check

ronlieb accepted this revision. ronlieb added a comment. This revision is now accepted and ready to land. thank you for the fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109943/new/ https://reviews.llvm.org/D109943 ___

[PATCH] D109943: [Clang] Fix long double availability check

This revision was automatically updated to reflect the committed changes. Closed by commit rG0195f8621f18: [Clang] Fix long double availability check (authored by qiucf). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109943/new/ https://reviews.llvm

[PATCH] D109960: [clang] [ARM] Don't set the strict alignment flag for armv7 on Windows

mstorsjo created this revision. mstorsjo added reviewers: DavidSpickett, simon_tatham. Herald added subscribers: kristof.beyls, dschuff. mstorsjo requested review of this revision. Herald added a project: clang. Windows on armv7 is as alignment tolerant as Linux. The alignment considerations in t

[PATCH] D109951: [clang-format] Constructor initializer lists format with pp directives

MyDeveloperDay added a comment. I see, let me add some other prominent reviewers I do see what you mean SomeClass::Constructor() : x { x } #if DEBUG , y { 0 } #endif {} SomeClass::Constructor() : x{x} , y{0} {} Repository: rG LLVM Github Monorepo CHANG

[PATCH] D109951: [clang-format] Constructor initializer lists format with pp directives

MyDeveloperDay added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:19299 + ", d{d} {\n}", + Style); +} I think its good to add what you expect without the CONDITION too! Repository: rG LLVM Github Monorepo CHA

[PATCH] D109608: [clang][ASTImporter] Generic attribute import handling (first step).

steakhal added a comment. I like the adapter layer idea. However, I agree with @martong that it should be more 'abstract' ~ terse. It's remarkable how compact the test is. Good job. Comment at: clang/lib/AST/ASTImporter.cpp:8417-8418 +template struct AttrArgImporter { + Attr

[PATCH] D109951: [clang-format] Constructor initializer lists format with pp directives

MyDeveloperDay added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:19299 + ", d{d} {\n}", + Style); +} MyDeveloperDay wrote: > I think its good to add what you expect without the CONDITION too! Can you add doubly n

[PATCH] D106804: [test-suite] Add tests for FP classification intrinsics

sepavloff added a comment. Thanks! Repository: rT test-suite CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106804/new/ https://reviews.llvm.org/D106804 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/

[PATCH] D106804: [test-suite] Add tests for FP classification intrinsics

This revision was automatically updated to reflect the committed changes. Closed by commit rTb983131b7e46: [test-suite] Add tests for FP classification intrinsics (authored by sepavloff). Repository: rT test-suite CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106804/new/ https://revie

[PATCH] D109960: [clang] [ARM] Don't set the strict alignment flag for armv7 on Windows

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. LGTM with the comment updated. Comment at: clang/lib/Driver/ToolChains/Arch/ARM.cpp:771 // Linux targets support unaligned accesses. The same goes for NaCl

[PATCH] D109234: [PGO] Change ThinLTO test for targets with loop unrolling disabled

gregmiller added a comment. The test patch worked and test is now passing again. Thanks for the quick help on this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109234/new/ https://reviews.llvm.org/D109234 __

[clang] e3b1052 - Make multiversioning work with internal linkage

Author: Erich Keane Date: 2021-09-17T05:56:38-07:00 New Revision: e3b10525b489b604d6a1e540be78bda80afb5868 URL: https://github.com/llvm/llvm-project/commit/e3b10525b489b604d6a1e540be78bda80afb5868 DIFF: https://github.com/llvm/llvm-project/commit/e3b10525b489b604d6a1e540be78bda80afb5868.diff L

[PATCH] D109960: [clang] [ARM] Don't set the strict alignment flag for armv7 on Windows

mstorsjo updated this revision to Diff 373201. mstorsjo added a comment. Updated the comment too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109960/new/ https://reviews.llvm.org/D109960 Files: clang/lib/Driver/ToolChains/Arch/ARM.cpp clang/

[clang] b7e9d20 - [OpenCL] Supports optional same image reads and writes in C++ for OpenCL 2021

Author: Justas Janickas Date: 2021-09-17T14:14:31+01:00 New Revision: b7e9d203c6793873f72dd3ffaf7c9365ce03007e URL: https://github.com/llvm/llvm-project/commit/b7e9d203c6793873f72dd3ffaf7c9365ce03007e DIFF: https://github.com/llvm/llvm-project/commit/b7e9d203c6793873f72dd3ffaf7c9365ce03007e.dif

[PATCH] D109307: [OpenCL] Supports optional same image reads and writes in C++ for OpenCL 2021

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb7e9d203c679: [OpenCL] Supports optional same image reads and writes in C++ for OpenCL 2021 (authored by Topotuna). Changed prior to commit: https

[clang] 197a3d1 - Fix test failure from e3b10525b489b604d6a1e540be78bda80afb5868

Author: Erich Keane Date: 2021-09-17T06:21:55-07:00 New Revision: 197a3d183b8b2a8452d816a1b0fcfc1093ef76ab URL: https://github.com/llvm/llvm-project/commit/197a3d183b8b2a8452d816a1b0fcfc1093ef76ab DIFF: https://github.com/llvm/llvm-project/commit/197a3d183b8b2a8452d816a1b0fcfc1093ef76ab.diff L

[PATCH] D105516: [clang][PassManager] Add -falways-mem2reg CC1 flag to run mem2reg at -O0

jrtc27 added a comment. @rjmccall Ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105516/new/ https://reviews.llvm.org/D105516 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[PATCH] D109956: Fix CodeGen/pgo-sample-thinlto-summary.c with old PM

tejohnson accepted this revision. tejohnson added a comment. This revision is now accepted and ready to land. lgtm. And I just was informed in a recent review of one of my patches that we are now removing old PM tests, so if you want you could also go ahead and remove the first 2 lines here. R

[PATCH] D109956: Fix CodeGen/pgo-sample-thinlto-summary.c with old PM

thopre updated this revision to Diff 373214. thopre added a comment. Remove old PM tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109956/new/ https://reviews.llvm.org/D109956 Files: clang/test/CodeGen/pgo-sample-thinlto-summary.c Index: c

[PATCH] D109956: Fix CodeGen/pgo-sample-thinlto-summary.c with old PM

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8a7a28075b7f: Fix CodeGen/pgo-sample-thinlto-summary.c with old PM (authored by thopre). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[clang] 8a7a280 - Fix CodeGen/pgo-sample-thinlto-summary.c with old PM

Author: Thomas Preud'homme Date: 2021-09-17T15:21:22+01:00 New Revision: 8a7a28075b7fa70d56b131c10a4d1add777d5830 URL: https://github.com/llvm/llvm-project/commit/8a7a28075b7fa70d56b131c10a4d1add777d5830 DIFF: https://github.com/llvm/llvm-project/commit/8a7a28075b7fa70d56b131c10a4d1add777d5830.

[PATCH] D109609: [C++4OpenCL] Add support for multiple address spaced destructors

olestrohm updated this revision to Diff 373218. olestrohm added a comment. I made the implicit destructor always be created in __generic address space. I couldn't manage to properly figure a case that would trigger `LookupSpecialMember`, so I couldn't figure out how or if address spaces are hand

[PATCH] D109609: [C++4OpenCL] Add support for multiple address spaced destructors

olestrohm marked 2 inline comments as done. olestrohm added inline comments. Comment at: clang/lib/Sema/SemaLookup.cpp:3082 ID.AddInteger(VolatileThis); + ID.AddInteger((unsigned)AS); Anastasia wrote: > Btw ctors and assignments don't seem to need this but

[PATCH] D109609: [C++4OpenCL] Add support for multiple address spaced destructors

olestrohm updated this revision to Diff 373225. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109609/new/ https://reviews.llvm.org/D109609 Files: clang/include/clang/AST/DeclCXX.h clang/include/clang/Sema/Sema.h clang/lib/AST/DeclCXX.cpp clang/lib/Sema/SemaDeclCXX.cpp clang/lib

[PATCH] D109967: Simplify handling of builtin with inline redefinition

serge-sans-paille created this revision. serge-sans-paille added reviewers: rnk, nickdesaulniers, efriedma. serge-sans-paille requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. It is a common practice in glibc header to provide an inline redef

[PATCH] D109609: [C++4OpenCL] Add support for multiple address spaced destructors

keryell added a comment. In D109609#3006225 , @olestrohm wrote: > > re: @keryell > This might work, though I have no idea how that `SomeAPIReturningAddrSpace` > would work, since at this point the variable would likely be cast to be in > __generic

[PATCH] D109862: Don't diagnose unused but set when the Cleanup attribute is used.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109862/new/ https://reviews.llvm.org/D109862 _

[PATCH] D109847: [DFSan] Add force_zero_label abilist option to DFSan. This can be used as a work-around for overtainting.

morehouse accepted this revision. morehouse added inline comments. This revision is now accepted and ready to land. Comment at: clang/docs/DataFlowSanitizer.rst:141 +For instrumented functions, the ABI list supports a ``force_zero_labels`` +category, which will make all shadow st

[PATCH] D109975: [CMake] Consistently use the LibXml2::LibXml2 target instead of LIBXML2_LIBRARIES

zero9178 created this revision. zero9178 added reviewers: phosek, hans, MaskRay, compnerd. Herald added subscribers: arphaman, mgorny. zero9178 requested review of this revision. Herald added projects: clang, LLDB. Herald added subscribers: lldb-commits, cfe-commits. Linking against the LibXml2::L

[PATCH] D109707: [HIP] [AlwaysInliner] Disable AlwaysInliner to eliminate undefined symbols

gandhi21299 added a comment. @yaxunl I think we have two ways to go from here: 1. If appropriate, reset the maximum number of scalar registers allowed in `@kernel3` (inline-calls.ll) to fix the test. 2. Determine a stronger condition for inlining. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D109967: Simplify handling of builtin with inline redefinition

kees added a comment. Does this address https://bugs.llvm.org/show_bug.cgi?id=50322 ? (I assume this is a new version of https://reviews.llvm.org/D92657 ?) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109967/new/ https://reviews.llvm.org/D109967

[PATCH] D109632: [clang] de-duplicate methods from AST files

rmaz added a comment. In D109632#3005512 , @vsapsai wrote: > Thanks for the explanation! I'm still curious to reproduce the problem > locally and have created a test case generator > https://gist.github.com/vsapsai/f9d3603dde95eebd23248da4d7b4f5ec It cr

[PATCH] D103938: Diagnose -Wunused-value in constant evaluation context

aaron.ballman added a comment. There were a few behavioral changes to tests that I had questions about. Also, can you add an additional test case that shows the behavior when the left operand of the comma expression is volatile (or do we already have that covered and I missed it)? e.g., int

[PATCH] D109977: LLVM Driver Multicall tool

beanz created this revision. beanz added reviewers: leonardchan, phosek, MaskRay, compnerd, mehdi_amini. Herald added subscribers: rupprecht, mgorny. Herald added a reviewer: JDevlieghere. Herald added a reviewer: alexander-shaposhnikov. Herald added a reviewer: rupprecht. Herald added a reviewer:

[PATCH] D109975: [CMake] Consistently use the LibXml2::LibXml2 target instead of LIBXML2_LIBRARIES

Quuxplusone added a comment. Herald added a subscriber: JDevlieghere. Serendipitously, I just yesterday upgraded from OSX 10.14 to 10.15, and have been unable to build clang because, even with a totally-empty-and-brand-new build directory, CMake says: CMake Error in lib/WindowsManifest/CMakeL

[PATCH] D109707: [HIP] [AlwaysInliner] Disable AlwaysInliner to eliminate undefined symbols

arsenm added a comment. In D109707#3004869 , @gandhi21299 wrote: > Internal linkage detection works great for our purposes but it causes a > failure in llvm/test/CodeGen/AMDGPU/inline-calls.ll due to `@func_alias` > unable to be casted into a `Function

[PATCH] D109707: [HIP] [AlwaysInliner] Disable AlwaysInliner to eliminate undefined symbols

gandhi21299 updated this revision to Diff 373257. gandhi21299 marked an inline comment as done. gandhi21299 added a comment. - Prevent removing alias if the GlobalAlias does not have internal linkage Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109

[PATCH] D109979: [Clang] [Fix] Clang build fails when build directory contains space character

xgupta created this revision. xgupta added reviewers: aaron.ballman, t.p.northover. Herald added a subscriber: mgorny. xgupta requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Clang build fails when build directory contains space character.

[PATCH] D109632: [clang] de-duplicate methods from AST files

rmaz added inline comments. Comment at: clang/include/clang/Sema/Sema.h:1434-1436 +bool addMethod(ObjCMethodDecl *Method) { + return AddedMethods.insert(Method).second; +} dexonsmith wrote: > Hmm, I was imagining that the set would be more encapsulat

[PATCH] D109975: [CMake] Consistently use the LibXml2::LibXml2 target instead of LIBXML2_LIBRARIES

zero9178 added a comment. In D109975#3006580 , @Quuxplusone wrote: > Serendipitously, I just yesterday upgraded from OSX 10.14 to 10.15, and have > been unable to build clang because, even with a totally-empty-and-brand-new > build directory, CMake say

[PATCH] D109977: LLVM Driver Multicall tool

mehdi_amini added a comment. That's pretty nice! Have you thought about looking into a lit option (triggered by a cmake flag maybe) that would change the substitution for the tools that are enabled by llvm-driver to use the latter instead when running the tests? Repository: rG LLVM Github Mo

[PATCH] D109967: Simplify handling of builtin with inline redefinition

serge-sans-paille added a comment. @kees this does fix https://bugs.llvm.org/show_bug.cgi?id=50322 , but only if the memcpy "inline definition" is flagged as a `__attribute__((always_inline))` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109967/n

[PATCH] D109981: [Diagnostics] Don't drop a statically set NoWarningAsError flag during option processing

wolfgangp created this revision. wolfgangp added a reviewer: dexonsmith. wolfgangp requested review of this revision. Fixes PR 51837. When a -W option is given on the command line, and the corresponding diangostic has the NoWarnOnError flag set, the flag is dropped when the severity is reevalua

[PATCH] D109847: [DFSan] Add force_zero_label abilist option to DFSan. This can be used as a work-around for overtainting.

browneee updated this revision to Diff 373271. browneee added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109847/new/ https://reviews.llvm.org/D109847 Files: clang/docs/DataFlowSanitizer.rst compiler-rt/test/dfsan/Inputs/fl

[PATCH] D109847: [DFSan] Add force_zero_label abilist option to DFSan. This can be used as a work-around for overtainting.

browneee updated this revision to Diff 373274. browneee marked 3 inline comments as done. browneee added a comment. Update comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109847/new/ https://reviews.llvm.org/D109847 Files: clang/docs/Dat

[PATCH] D109977: LLVM Driver Multicall tool

phosek added inline comments. Comment at: llvm/tools/llvm-driver/CMakeLists.txt:17 + +add_llvm_tool(llvm-driver + llvm-driver.cpp As was already suggested on D104686, I'd prefer naming this just `llvm` so you can invoke tools with `llvm name` which doesn't requ

[PATCH] D99439: Update @llvm.powi to handle different int sizes for the exponent

xbolva00 added a comment. Herald added a subscriber: ctetreau. Just to mention, 'llvm.experimental.constrained.powi' uses i32. Probably not a big deal, just small inconsistency with llvm.powi. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99439/new

[PATCH] D91944: OpenMP 5.0 metadirective

cchen updated this revision to Diff 373277. cchen added a comment. Fix tests for Windows Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91944/new/ https://reviews.llvm.org/D91944 Files: clang/include/clang-c/Index.h clang/include/clang/AST/Recu

[PATCH] D91944: OpenMP 5.0 metadirective

ABataev added inline comments. Comment at: clang/include/clang/AST/StmtOpenMP.h:5412 + + void setIfStmt(Stmt *stmt) { IfStmt = stmt; } + Stmt *getIfStmt() const { return IfStmt; } 1. Make it private, please 2. Var names must start from capital letter `stmt`->`S

[PATCH] D109975: [CMake] Consistently use the LibXml2::LibXml2 target instead of LIBXML2_LIBRARIES

Quuxplusone added a comment. I was inspired to dig down and find the `LLVM_ENABLE_LIBXML2` option (which is on by default) and turn it off, so now I can build clang with the following commands: cmake -G Ninja -DLLVM_ENABLE_LIBXML2=0 -DDEFAULT_SYSROOT="$(xcrun --show-sdk-path)" -DLLVM_ENABLE_

[clang] 101c3de - Add information about C99 to the C status page.

Author: Aaron Ballman Date: 2021-09-17T13:49:17-04:00 New Revision: 101c3de39fbcdd7d47b25aaf6d972e435f017077 URL: https://github.com/llvm/llvm-project/commit/101c3de39fbcdd7d47b25aaf6d972e435f017077 DIFF: https://github.com/llvm/llvm-project/commit/101c3de39fbcdd7d47b25aaf6d972e435f017077.diff

[PATCH] D109977: LLVM Driver Multicall tool

beanz added a comment. In D109977#3006687 , @mehdi_amini wrote: > That's pretty nice! Have you thought about looking into a lit option > (triggered by a cmake flag maybe) that would change the substitution for the > tools that are enabled by llvm-drive

[PATCH] D109977: LLVM Driver Multicall tool

beanz added inline comments. Comment at: llvm/tools/llvm-driver/CMakeLists.txt:17 + +add_llvm_tool(llvm-driver + llvm-driver.cpp phosek wrote: > As was already suggested on D104686, I'd prefer naming this just `llvm` so > you can invoke tools with `llvm name` w

[PATCH] D102449: [WIP][Clang][OpenMP] Add the support for compare clause in atomic directive

carlo.bertolli added a comment. In D102449#2977711 , @tianshilei1992 wrote: > Another thing is how we deal with a corner case. Say the OpenMP code is > written in the following way: > > #pragma omp atomic compare > x = e < x ? e : x; > > That's ho

[PATCH] D109437: [PowerPC] FP compare and test XL compat builtins.

Conanap added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:3490 + SemaBuiltinConstantArgRange(TheCall, 1, 0, 127) || + CheckPPCTestDataClassType(TheCall); #define CUSTOM_BUILTIN(Name, Intr, Types, Acc) \ If you're making a fun

[PATCH] D109632: [clang] de-duplicate methods from AST files

rmaz added inline comments. Comment at: clang/include/clang/Sema/Sema.h:1434-1436 +bool addMethod(ObjCMethodDecl *Method) { + return AddedMethods.insert(Method).second; +} rmaz wrote: > dexonsmith wrote: > > Hmm, I was imagining that the set would be

[clang] d13d9da - [clang] [ARM] Don't set the strict alignment flag for armv7 on Windows

Author: Martin Storsjö Date: 2021-09-17T21:39:25+03:00 New Revision: d13d9da1fbe1a750f9c4fc3f4da31c9d16a530d3 URL: https://github.com/llvm/llvm-project/commit/d13d9da1fbe1a750f9c4fc3f4da31c9d16a530d3 DIFF: https://github.com/llvm/llvm-project/commit/d13d9da1fbe1a750f9c4fc3f4da31c9d16a530d3.diff

[PATCH] D109960: [clang] [ARM] Don't set the strict alignment flag for armv7 on Windows

This revision was automatically updated to reflect the committed changes. Closed by commit rGd13d9da1fbe1: [clang] [ARM] Don't set the strict alignment flag for armv7 on Windows (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D10

[PATCH] D109990: [OpenMP][Docs] Update clang support based on community discussion

jdoerfert created this revision. jdoerfert added reviewers: ABataev, grokos, JonChesterfield, gregrodgers, ronl, RaviNarayanaswamy, dreachem. Herald added subscribers: guansong, bollu, yaxunl. jdoerfert requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald adde

[PATCH] D109951: [clang-format] Constructor initializer lists format with pp directives

HazardyKnusperkeks added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:19271 +TEST_F(FormatTest, ConstructorInitializersWithPreprocessorDirective) { + FormatStyle Style = getLLVMStyle(); From the name I would expect also to check ```SomeCl

[PATCH] D109977: LLVM Driver Multicall tool

beanz updated this revision to Diff 373300. beanz added a comment. Renaming llvm-driver binary to llvm. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109977/new/ https://reviews.llvm.org/D109977 Files: clang/cmake/modules/AddClang.cmake clang/

[PATCH] D109990: [OpenMP][Docs] Update clang support based on community discussion

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109990/new/ https://reviews.llvm.org/D109990 ___

[clang] 80d6299 - [clang][darwin] Add support for --emit-static-lib

Author: Keith Smiley Date: 2021-09-17T12:11:05-07:00 New Revision: 80d62993d0720bc36523e39e64cc36da6e445e64 URL: https://github.com/llvm/llvm-project/commit/80d62993d0720bc36523e39e64cc36da6e445e64 DIFF: https://github.com/llvm/llvm-project/commit/80d62993d0720bc36523e39e64cc36da6e445e64.diff

[PATCH] D91944: OpenMP 5.0 metadirective

cchen added inline comments. Comment at: clang/include/clang/AST/StmtOpenMP.h:5412 + + void setIfStmt(Stmt *stmt) { IfStmt = stmt; } + Stmt *getIfStmt() const { return IfStmt; } ABataev wrote: > 1. Make it private, please > 2. Var names must start from capital

[PATCH] D109461: [clang][darwin] Add support for --emit-static-lib

This revision was automatically updated to reflect the committed changes. Closed by commit rG80d62993d072: [clang][darwin] Add support for --emit-static-lib (authored by keith). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109461/new/ https://revie

[PATCH] D91944: OpenMP 5.0 metadirective

ABataev added inline comments. Comment at: clang/include/clang/AST/StmtOpenMP.h:5412 + + void setIfStmt(Stmt *stmt) { IfStmt = stmt; } + Stmt *getIfStmt() const { return IfStmt; } cchen wrote: > ABataev wrote: > > 1. Make it private, please > > 2. Var names mus

[PATCH] D91944: OpenMP 5.0 metadirective

cchen added inline comments. Comment at: clang/include/clang/AST/StmtOpenMP.h:5412 + + void setIfStmt(Stmt *stmt) { IfStmt = stmt; } + Stmt *getIfStmt() const { return IfStmt; } ABataev wrote: > cchen wrote: > > ABataev wrote: > > > 1. Make it private, please >

[PATCH] D91944: OpenMP 5.0 metadirective

ABataev added inline comments. Comment at: clang/include/clang/AST/StmtOpenMP.h:5412 + + void setIfStmt(Stmt *stmt) { IfStmt = stmt; } + Stmt *getIfStmt() const { return IfStmt; } cchen wrote: > ABataev wrote: > > cchen wrote: > > > ABataev wrote: > > > > 1. Ma

[PATCH] D91944: OpenMP 5.0 metadirective

cchen updated this revision to Diff 373312. cchen added a comment. Fix tests and coding style Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91944/new/ https://reviews.llvm.org/D91944 Files: clang/include/clang-c/Index.h clang/include/clang/AST

[PATCH] D109996: [PowerPC] Fix signature of lxvp and stxvp builtins

quinnp created this revision. Herald added subscribers: shchenz, kbarton, nemanjai. quinnp requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch changes the signature of the load and store vector pair builtins to match their documentat

[PATCH] D109800: [clang] don't mark as Elidable CXXConstruct expressions used in NRVO

mizvekov added a comment. In D109800#3004288 , @Quuxplusone wrote: > Getting rid of that extra bool parameter throughout //looks// awesome, > though. :) It will come back later, this patch is just a quick thing we need in order to ship clang-13. But p

[PATCH] D109997: [OpenMP] Change debugging symbol to weak_odr linkage

jhuber6 created this revision. jhuber6 added a reviewer: jdoerfert. Herald added subscribers: guansong, hiraditya, yaxunl. jhuber6 requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, sstefan1. Herald added projects: clang, LLVM. The new device runtime uses an in

[PATCH] D109847: [DFSan] Add force_zero_label abilist option to DFSan. This can be used as a work-around for overtainting.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc533b88a6dc9: [DFSan] Add force_zero_label abilist option to DFSan. This can be used as a… (authored by browneee). Repository: rG LLVM Github Mono

[PATCH] D109977: LLVM Driver Multicall tool

aganea added a comment. This is really a great change, thanks @beanz! Comment at: llvm/tools/llvm-objcopy/llvm-objcopy.cpp:404 -int main(int argc, char **argv) { +int llvm_objcopy_main(int argc, char **argv) { InitLLVM X(argc, argv); Shouldn't we say: ```

[PATCH] D109800: [clang] don't mark as Elidable CXXConstruct expressions used in NRVO

mizvekov updated this revision to Diff 373323. mizvekov edited the summary of this revision. mizvekov added a comment. add a couple more FIXMEs and a couple of asserts in the constexpr path for rvalue copy elision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D109997: [OpenMP] Change debugging symbol to weak_odr linkage

jdoerfert added a comment. You checked that this works with the usage in the RT, right? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109997/new/ https://reviews.llvm.org/D109997 ___ cfe-commits mailing

[clang] 2908fc0 - [OpenMP] Use irbuilder as default for masked and master construct

Author: cchen Date: 2021-09-17T15:54:11-05:00 New Revision: 2908fc0d3f16f873b5019f1c62a24482c2b75e36 URL: https://github.com/llvm/llvm-project/commit/2908fc0d3f16f873b5019f1c62a24482c2b75e36 DIFF: https://github.com/llvm/llvm-project/commit/2908fc0d3f16f873b5019f1c62a24482c2b75e36.diff LOG: [O

[PATCH] D100874: [OpenMP] Use irbuilder as default for masked and master construct

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2908fc0d3f16: [OpenMP] Use irbuilder as default for masked and master construct (authored by cchen). Repository: rG LLVM Github Monorepo CHANGES

[clang] c7d7b98 - OpenMP 5.0 metadirective

Author: cchen Date: 2021-09-17T16:03:13-05:00 New Revision: c7d7b98e5263472f05b2f3cb767b5d16e1349e9a URL: https://github.com/llvm/llvm-project/commit/c7d7b98e5263472f05b2f3cb767b5d16e1349e9a DIFF: https://github.com/llvm/llvm-project/commit/c7d7b98e5263472f05b2f3cb767b5d16e1349e9a.diff LOG: Op

[PATCH] D91944: OpenMP 5.0 metadirective

This revision was automatically updated to reflect the committed changes. Closed by commit rGc7d7b98e5263: OpenMP 5.0 metadirective (authored by cchen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91944/new/ https://reviews.llvm.org/D91944 Files:

  1   2   >