MyDeveloperDay added inline comments.
================ Comment at: clang/unittests/Format/FormatTest.cpp:19299 + ", d{d} {\n}", + Style); +} ---------------- MyDeveloperDay wrote: > I think its good to add what you expect without the CONDITION too! Can you add doubly nested test ``` SomeClass::Constructor() : x { x } #if WINDOWS #if DEBUG , y { 0 } #else , y { 1 } #endif #else #if DEBUG , y { 2 } #else , y { 3 } #endif #endif {} ``` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109951/new/ https://reviews.llvm.org/D109951 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits