[PATCH] D108905: [ItaniumCXXABI] Set nounwind on __cxa_begin_catch/__cxa_end_catch nounwind

MaskRay added a comment. In D108905#2971761 , @ChuanqiXu wrote: > Thanks for looking into this! > I am not familiar with exception handling. But from the comments, I worried > that if it is a problem if there are exceptions whose destructor could throw

[PATCH] D108905: [ItaniumCXXABI] Set nounwind on __cxa_begin_catch/__cxa_end_catch

ChuanqiXu accepted this revision. ChuanqiXu added a comment. This revision is now accepted and ready to land. In D108905#2971773 , @MaskRay wrote: > In D108905#2971761 , @ChuanqiXu > wrote: > >> Thanks for lookin

[PATCH] D108905: [ItaniumCXXABI] Set nounwind on __cxa_begin_catch/__cxa_end_catch

MaskRay added a comment. I confirm that GCC has had this behavior since 2000 (3.0). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108905/new/ https://reviews.llvm.org/D108905 ___ cfe-commits mailing list

[PATCH] D108905: [ItaniumCXXABI] Set nounwind on __cxa_begin_catch/__cxa_end_catch

ChuanqiXu added inline comments. Comment at: clang/lib/CodeGen/ItaniumCXXABI.cpp:4435-4448 struct CallEndCatch final : EHScopeStack::Cleanup { CallEndCatch(bool MightThrow) : MightThrow(MightThrow) {} bool MightThrow; void Emit(CodeGenFunction &CGF, Flags flag

[PATCH] D108905: [ItaniumCXXABI] Set nounwind on __cxa_begin_catch/__cxa_end_catch

rjmccall added a reviewer: rsmith. rjmccall added a comment. Yes, this seems extremely reasonable; it was really just an oversight. Patch is semantically fine, although what we do in several other places is use `EmitNounwindRuntimeCall` to emit the call, and I think I'd like to do that here: I

[PATCH] D108908: [clang] Add gcc-toolset-10 support (RHEL/CentOS 8)

simoll created this revision. simoll added a project: clang. simoll requested review of this revision. Herald added a subscriber: cfe-commits. Clang only adds GCC paths for RHEL <= 7 'devtoolset-' Software Collections (SCL). This generalizes this support to also include the 'gcc-toolset-10' SCL

[PATCH] D108908: [clang] Add gcc-toolset-10 support (RHEL/CentOS 8)

stephan.dollberg accepted this revision. stephan.dollberg added a comment. This revision is now accepted and ready to land. LGTM but probably want to apply clang-format suggestion. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:2055 if (SysRoot.empty() && TargetTriple.getOS

[PATCH] D108625: [Test][Time profiler] Fix test time checking

lebedev.ri accepted this revision. lebedev.ri added a comment. This revision is now accepted and ready to land. Everything timing-based is pretty much guaranteed to be flaky. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108625/new/ https://reviews

[PATCH] D102325: [clang-tidy] cppcoreguidelines-virtual-base-class-destructor: a new check

whisperity added a comment. In D102325#2970683 , @mgartmann wrote: > @aaron.ballman Thanks a lot for your review! > > Can somebody help me merging this change? I do not have the rights to do so. > Thanks in advanve! Sure, just please specify what name an

[PATCH] D108912: [release][analyzer] Add 13.0.0 release notes

Szelethus created this revision. Szelethus added reviewers: tstellar, NoQ, vsavchenko, dcoughlin, RedDocMD, xazax.hun, baloghadamsoftware, martong, balazske, steakhal, dkrupp, gamesh411, ASDenysPetrov. Szelethus added a project: clang. Herald added subscribers: manas, donat.nagy, mikhail.ramalho,

[PATCH] D108912: [release][analyzer] Add 13.0.0 release notes

Szelethus added inline comments. Comment at: clang/docs/ReleaseNotes.rst:294 --- +- Add a new analyzer output type, ``sarif-html``, that outputs both HTML and Oops, should add this comment before commiting. ```lang=sphinx .. 2407eb08a574 [analyzer

[clang] a5791ba - [clang] Add gcc-toolset-10 support (RHEL/CentOS 8)

Author: Simon Moll Date: 2021-08-30T13:33:30+02:00 New Revision: a5791badde32cf794edbddf737cbc8344257449b URL: https://github.com/llvm/llvm-project/commit/a5791badde32cf794edbddf737cbc8344257449b DIFF: https://github.com/llvm/llvm-project/commit/a5791badde32cf794edbddf737cbc8344257449b.diff LO

[PATCH] D108908: [clang] Add gcc-toolset-10 support (RHEL/CentOS 8)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. simoll marked an inline comment as done. Closed by commit rGa5791badde32: [clang] Add gcc-toolset-10 support (RHEL/CentOS 8) (authored by simoll). Changed prior to com

[PATCH] D108482: [Clang] Fix instantiation of OpaqueValueExprs (Bug #45964)

aaron.ballman added a reviewer: rjmccall. aaron.ballman added a subscriber: rjmccall. aaron.ballman added inline comments. Comment at: clang/lib/Sema/TreeTransform.h:10515-10525 + // Note that SourceExpr can be nullptr. + ExprResult SourceExpr = TransformExpr(E->getSourceExpr()

[PATCH] D107290: [PoC][RISCV] Add support for the vscale_range attribute

frasercrmck updated this revision to Diff 369416. frasercrmck marked 2 inline comments as done. frasercrmck added a comment. Herald added a subscriber: dexonsmith. - rebase - move V VLEN bits-per-block (64), min (128), max (65536) defines into TargetParser.h - clean up assertions Repository:

[PATCH] D107290: [PoC][RISCV] Add support for the vscale_range attribute

frasercrmck added inline comments. Comment at: clang/lib/Basic/Targets/RISCV.cpp:349 + unsigned VLENMax = 65536; + return std::make_pair(VLENMin / 64, VLENMax / 64); +} craig.topper wrote: > Should we move RVVBitsPerBlock to RISCVTargetParser.def? Or some other

[PATCH] D108308: Cleanup identifier parsing.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. The changes LGTM, modulo a commenting request. Let's wait a bit before landing in case @rsmith has concerns. Comment at: clang/include/clang/Lex/Lexer.h:702

[PATCH] D93769: [clang] Add support for option -ffp-eval-method and extend #pragma float_control similarly

zahiraam added a comment. In D93769#2970097 , @matthewtff wrote: > This CL breaks -E flow. I've created a repro: https://pastebin.com/fFuUdsfp > If you build it on linux with ToT clang like this: clang++ -target > i386-unknown-linux-gnu repro.cc -o repro.

[PATCH] D93769: [clang] Add support for option -ffp-eval-method and extend #pragma float_control similarly

matthewtff added a comment. > It looks like Melanie asked the questions but it wasn't resolved. Can this CL be reverted and relanded later with a fix? This breakage is crucial for a lot of remote/distributed compilation systems. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D108765: [docs] Fix documentation of clang-format BasedOnStyle type

FederAndInk added a comment. Ok, here is my proposal for plurals, I have some ideas, I think the safest/most complete would be to have a file tracking generated plurals and tell the user of the script to check newly generated plurals then add them to git, this would also allow reviewers to see

[PATCH] D108765: [docs] Fix documentation of clang-format BasedOnStyle type

FederAndInk updated this revision to Diff 369431. FederAndInk added a comment. generate plurals, for now supporting -y ending (-y to -ies/-ys), track generated plurals and show new ones to be checked Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D10

[PATCH] D108912: [release][analyzer] Add 13.0.0 release notes

steakhal added a comment. Maybe a couple other noteworthy commits: efa7df1682c2859dabe3646ee7dc01e68629417f : better R-value tracking. aa454dda2eed4e71081bc57b1f32dfce2486b177

[PATCH] D93769: [clang] Add support for option -ffp-eval-method and extend #pragma float_control similarly

erichkeane added a comment. In D93769#2972151 , @matthewtff wrote: >> It looks like Melanie asked the questions but it wasn't resolved. > > Can this CL be reverted and relanded later with a fix? This breakage is > crucial for a lot of remote/distributed c

[PATCH] D93769: [clang] Add support for option -ffp-eval-method and extend #pragma float_control similarly

aaron.ballman added a comment. In D93769#2972151 , @matthewtff wrote: >> It looks like Melanie asked the questions but it wasn't resolved. > > Can this CL be reverted and relanded later with a fix? This breakage is > crucial for a lot of remote/distribute

[PATCH] D107960: [clang][analyzer] Make ReturnPtrRange checker warn at negative index.

martong added a comment. Would it make sense to tweak `assumeInBound` in a way to handle symbolic regions differently than concrete regions? I mean static int arr[10]; return arr - 1; // we want a warning here ... int *p = conjure(); return p - 1; // no warning here Repository:

[PATCH] D104285: [analyzer][AST] Retrieve value by direct index from list initialization of constant array declaration.

martong added a comment. @ASDenysPetrov Denis, do you think it would make sense to handle the non-multi-dimensional cases first? I see that you have useful patches in the stack that depends on this change (i.e handling a StringLiteral or a CompoundLiteralExpr) but perhaps they would be meaningf

[PATCH] D93769: [clang] Add support for option -ffp-eval-method and extend #pragma float_control similarly

erichkeane added a comment. In D93769#2972203 , @erichkeane wrote: > In D93769#2972151 , @matthewtff > wrote: > >>> It looks like Melanie asked the questions but it wasn't resolved. >> >> Can this CL be reverted an

[PATCH] D93769: [clang] Add support for option -ffp-eval-method and extend #pragma float_control similarly

matthewtff added a comment. > Did someone perhaps fix this in trunk? I don't see it on godbolt: > https://godbolt.org/z/r76rx5Evd You've missed the -target argument. It still reproduces with correct arguments: https://godbolt.org/z/1ozhjYvhf Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D106644: [clang][analyzer] Add standard streams to alpha.unix.Stream checker.

martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:504 + + OrigStdin = findStdStream("stdin", C); + OrigStdout = findStdStream("stdout", C); steakhal wrote: > balazske wrote: > > steakhal wrote: > > > balazske wrote:

[PATCH] D106713: Thread safety analysis: Warn when demoting locks on back edges

aaronpuchert added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106713/new/ https://reviews.llvm.org/D106713 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D108917: Define __powerpc and __PPC macros

Jake-Egan created this revision. Herald added subscribers: shchenz, kbarton, nemanjai. Jake-Egan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D108917 Files: clang/lib/Bas

[PATCH] D108918: [clang] NFC: Extract DiagnosticOptions parsing

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith, arphaman. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The way we parse `DiagnosticOptions` is a bit involved. `DiagnosticOptions` are

[PATCH] D108441: [clang] Fix JSON AST output when a filter is used

woodruffw added a comment. Gentle ping for review on this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108441/new/ https://reviews.llvm.org/D108441 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D108919: [clan-repl] Install clang-repl

v.g.vassilev created this revision. v.g.vassilev added reviewers: teemperor, rsmith, tstellar. Herald added a subscriber: mgorny. v.g.vassilev requested review of this revision. This patch installs clang-repl in the install directory. https://reviews.llvm.org/D108919 Files: clang/tools/clang-

[PATCH] D108919: [clan-repl] Install clang-repl

v.g.vassilev added a comment. @tstellar, is there a hope to get that in the llvm13 branch? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108919/new/ https://reviews.llvm.org/D108919 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[clang] 2e5c17d - [PowerPC][NFC] Rename P10 builtins vec_clrl, vec_clrr to vec_clr_first and vec_clr_last

Author: Victor Huang Date: 2021-08-30T09:52:15-05:00 New Revision: 2e5c17d19e370c4d4f17ee89ca645113692f5407 URL: https://github.com/llvm/llvm-project/commit/2e5c17d19e370c4d4f17ee89ca645113692f5407 DIFF: https://github.com/llvm/llvm-project/commit/2e5c17d19e370c4d4f17ee89ca645113692f5407.diff

[PATCH] D108702: [PowerPC][NFC] Rename P10 builtins vec_clrl, vec_clrr to vec_clr_first and vec_clr_last

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2e5c17d19e37: [PowerPC][NFC] Rename P10 builtins vec_clrl, vec_clrr to vec_clr_first and… (authored by NeHuang). Repository: rG LLVM Github Monore

[PATCH] D104647: [analyzer] Support SVal::getType for pointer-to-member values

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. This looks good to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104647/new/ https://reviews.llvm.org/D104647 ___

[PATCH] D108308: Cleanup identifier parsing.

cor3ntin updated this revision to Diff 369446. cor3ntin added a comment. Move a comment to the header file per Aaron request Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108308/new/ https://reviews.llvm.org/D108308 Files: clang-tools-extra/clan

[PATCH] D104285: [analyzer][AST] Retrieve value by direct index from list initialization of constant array declaration.

ASDenysPetrov added a comment. In D104285#2972215 , @martong wrote: > @ASDenysPetrov Denis, do you think it would make sense to handle the > non-multi-dimensional cases first? I see that you have useful patches in the > stack that depends on this change

[PATCH] D108919: [clan-repl] Install clang-repl

teemperor added a comment. This is essentially what D106813 was supposed to do, so this is also LGTM. You probably want to file a bugreport for @tstellar to cherry-pick this to the release. The biggest impact from this seems to be that it increases the release

[PATCH] D108905: [ItaniumCXXABI] Set nounwind on __cxa_begin_catch/__cxa_end_catch

wenlei added subscribers: modimo, wenlei. wenlei added a comment. +@modimo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108905/new/ https://reviews.llvm.org/D108905 ___ cfe-commits mailing list cfe-comm

[PATCH] D108893: clang-tidy: introduce readability-containter-data-pointer check

compnerd marked 2 inline comments as done. compnerd added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:87 + + Finds cases where code could use ``data`` rather than the address of an element. + Eugene.Zelenko wrote: > It'll be good idea t

[PATCH] D108893: clang-tidy: introduce readability-containter-data-pointer check

compnerd updated this revision to Diff 369453. compnerd marked 2 inline comments as done. compnerd added a comment. Update release notes to incorporate feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108893/new/ https://reviews.llvm.org/D10

[PATCH] D108886: Add RISC-V sifive-s51 cpu

craig.topper added a comment. Please upload patches with full context. Using -U99 as documented here https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108886/new/ htt

[PATCH] D108765: [docs] Fix documentation of clang-format BasedOnStyle type

MyDeveloperDay added inline comments. Comment at: clang/docs/tools/dump_format_style.py:26 +def register_plural(singular: str, plural: str): + if plural not in plurals: This failed for me with invalid syntax Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D108765: [docs] Fix documentation of clang-format BasedOnStyle type

FederAndInk added inline comments. Comment at: clang/docs/tools/dump_format_style.py:26 +def register_plural(singular: str, plural: str): + if plural not in plurals: MyDeveloperDay wrote: > This failed for me with invalid syntax Oh, ok, sorry, I might be using

[PATCH] D108905: [ItaniumCXXABI] Make __cxa_end_catch calls unconditionally nounwind

MaskRay updated this revision to Diff 369467. MaskRay retitled this revision from "[ItaniumCXXABI] Set nounwind on __cxa_begin_catch/__cxa_end_catch" to "[ItaniumCXXABI] Make __cxa_end_catch calls unconditionally nounwind". MaskRay edited the summary of this revision. MaskRay added a comment. Her

[clang] 1724a16 - [NFC][clang] Move IR-independent parts of target MV support to X86TargetParser.cpp

Author: Andrei Elovikov Date: 2021-08-30T09:48:48-07:00 New Revision: 1724a164378f1fb5210771680eb577ddf13c5a47 URL: https://github.com/llvm/llvm-project/commit/1724a164378f1fb5210771680eb577ddf13c5a47 DIFF: https://github.com/llvm/llvm-project/commit/1724a164378f1fb5210771680eb577ddf13c5a47.dif

[PATCH] D108423: [NFC][clang] Move IR-independent parts of target MV support to X86TargetParser.cpp

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1724a164378f: [NFC][clang] Move IR-independent parts of target MV support to X86TargetParser. (authored by a.elovikov). Changed prior to commit: h

[PATCH] D108905: [ItaniumCXXABI] Make __cxa_end_catch calls unconditionally nounwind

Quuxplusone added a comment. Peanut gallery says: Does this godbolt demonstrate the situation where "destroying an exception can throw an exception"? https://godbolt.org/z/Ghjz53rrj You're not proposing to change the behavior of this program, are you? (If you're proposing to change it: I don't th

[clang] 0e42ec1 - DebugInfo: Correct printing empty template parameter packs

Author: David Blaikie Date: 2021-08-30T10:20:12-07:00 New Revision: 0e42ec1add336e7fbf6cc1f82f663cabe48bf55e URL: https://github.com/llvm/llvm-project/commit/0e42ec1add336e7fbf6cc1f82f663cabe48bf55e DIFF: https://github.com/llvm/llvm-project/commit/0e42ec1add336e7fbf6cc1f82f663cabe48bf55e.diff

[PATCH] D108424: [NFC][clang] Move multiversion resolver code generation to llvm/ subdirectory

a.elovikov updated this revision to Diff 369485. a.elovikov added a comment. Rebase + ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108424/new/ https://reviews.llvm.org/D108424 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/lib/CodeGen/Code

[PATCH] D108893: clang-tidy: introduce readability-containter-data-pointer check

compnerd added a comment. @Eugene.Zelenko I'd like to have @aaron.ballman weigh in on the naming, and assuming that he's okay with `modernize.container-data-pointer`, I'll change it to that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108893/new

[PATCH] D108893: clang-tidy: introduce readability-containter-data-pointer check

Eugene.Zelenko added a comment. In D108893#2972634 , @compnerd wrote: > @Eugene.Zelenko I'd like to have @aaron.ballman weigh in on the naming, and > assuming that he's okay with `modernize.container-data-pointer`, I'll change > it to that. Sure, Aaron

[PATCH] D102943: [modules] Use `HashBuilder` and `MD5` for the module hash.

arames updated this revision to Diff 369489. arames added a comment. Fix to native endianness. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102943/new/ https://reviews.llvm.org/D102943 Files: clang/include/clang/Basic/ObjCRuntime.h clang/incl

[PATCH] D102943: [modules] Use `HashBuilder` and `MD5` for the module hash.

arames added inline comments. Comment at: clang/include/clang/Basic/ObjCRuntime.h:486 + template + friend void addHash(llvm::HashBuilderImpl &HBuilder, + const ObjCRuntime &OCR) { I have added these in the same line as existing `hash_value

[PATCH] D43002: [CodeView] Emit S_OBJNAME record

dpaoliello added a comment. Herald added a subscriber: ormris. @rnk @aganea Ping... Just wanted to see what was happening with this change, and if there is anything I can do to help get it merged in. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D43

[PATCH] D107024: [DIBuilder] Do not replace empty enum types

ellis updated this revision to Diff 369496. ellis added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107024/new/ https://reviews.llvm.org/D107024 Files: clang/test/CodeGen/debug-info-codeview-heapallocsite.c clang/test/CodeG

[PATCH] D108905: [ItaniumCXXABI] Make __cxa_end_catch calls unconditionally nounwind

rjmccall added a comment. Well, I'm saying two things. First, it is not clear to me what the expected behavior of that code is under the standard. The fact that it appears to work in one particular implementation is not in any way conclusive; we have to look at the specification. Second, I t

[PATCH] D108893: clang-tidy: introduce readability-containter-data-pointer check

aaron.ballman added a comment. In D108893#2972651 , @Eugene.Zelenko wrote: > In D108893#2972634 , @compnerd > wrote: > >> @Eugene.Zelenko I'd like to have @aaron.ballman weigh in on the naming, and >> assuming

[PATCH] D108905: [ItaniumCXXABI] Make __cxa_end_catch calls unconditionally nounwind

Quuxplusone added a comment. > Well, I'm saying two things. First, it is not clear to me what the expected > behavior of that code is under the standard. The fact that it appears to work > in one particular implementation is not in any way conclusive; we have to > look at the specification. Ah

[PATCH] D108482: [Clang] Fix instantiation of OpaqueValueExprs (Bug #45964)

rjmccall added inline comments. Comment at: clang/lib/Sema/TreeTransform.h:10515-10525 + // Note that SourceExpr can be nullptr. + ExprResult SourceExpr = TransformExpr(E->getSourceExpr()); + if (SourceExpr.isInvalid()) +return ExprError(); + if (SourceExpr.get() == E->ge

[PATCH] D108881: [clang][driver] Honor the last -flto= flag even if an earlier -flto is present

mnadeem updated this revision to Diff 369498. mnadeem marked 3 inline comments as done. mnadeem edited the summary of this revision. mnadeem added a subscriber: apazos. mnadeem added a comment. Herald added subscribers: kerbowa, nhaehnle, jvesely. Address comments. CHANGES SINCE LAST ACTION ht

[PATCH] D108881: [clang][driver] Honor the last -flto= flag even if an earlier -flto is present

mnadeem added a comment. Combined with the code in `else if (Triple.isAMDGPU())` since the code is identical. Removed the code to add `-flto` in favour of `-flto=full` since both are equivalent: https://clang.llvm.org/docs/CommandGuide/clang.html#cmdoption-flto CHANGES SINCE LAST ACTION http

[PATCH] D106876: Remove non-affecting module maps from PCM files.

ilyakuteev added a comment. Hello everyone! We have very slow remote compilations without this patch. :(. I'll be very grateful for your review. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106876/new/ https://reviews.llvm.org/D106876 ___

[PATCH] D108765: [docs] Fix documentation of clang-format BasedOnStyle type

HazardyKnusperkeks added a comment. In D108765#2972159 , @FederAndInk wrote: > And again, I don't really understand if we are allowed or not to pull in a > dependency such as pluralizer or inflect, this would be another idea My Python knowledge is very

[PATCH] D108765: [docs] Fix documentation of clang-format BasedOnStyle type

FederAndInk marked an inline comment as done. FederAndInk added inline comments. Comment at: clang/docs/tools/dump_format_style.py:26 +def register_plural(singular: str, plural: str): + if plural not in plurals: HazardyKnusperkeks wrote: > FederAndInk wrote: >

[PATCH] D106994: [modules] Fix miscompilation when using two RecordDecl definitions with the same name.

vsapsai added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106994/new/ https://reviews.llvm.org/D106994 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D108765: [docs] Fix documentation of clang-format BasedOnStyle type

FederAndInk marked 2 inline comments as done. FederAndInk added inline comments. Comment at: clang/docs/tools/dump_format_style.py:9 import re +import inspect +import subprocess HazardyKnusperkeks wrote: > I think these should be sorted. ok, it will be done ==

[PATCH] D108765: [docs] Fix documentation of clang-format BasedOnStyle type

FederAndInk updated this revision to Diff 369519. FederAndInk marked an inline comment as done. FederAndInk added a comment. add common plural rules, use python3 explicitly, reorder imports Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108765/new/

[PATCH] D106876: Remove non-affecting module maps from PCM files.

rsmith added a comment. This should have a testcase. I would imagine you can test this by constructing a situation where you build a module twice with different sets of module map files being considered and checking that you get bit-for-bit identical outputs. (For example: set up a temporary ar

[clang] 47b239e - [DIBuilder] Do not replace empty enum types

Author: Ellis Hoag Date: 2021-08-30T12:33:03-07:00 New Revision: 47b239eb5a17065d13c317600c46e56ffe2d6c75 URL: https://github.com/llvm/llvm-project/commit/47b239eb5a17065d13c317600c46e56ffe2d6c75 DIFF: https://github.com/llvm/llvm-project/commit/47b239eb5a17065d13c317600c46e56ffe2d6c75.diff LO

[PATCH] D107024: [DIBuilder] Do not replace empty enum types

This revision was automatically updated to reflect the committed changes. Closed by commit rG47b239eb5a17: [DIBuilder] Do not replace empty enum types (authored by ellis, committed by kyulee). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107024/new/

[PATCH] D106994: [modules] Fix miscompilation when using two RecordDecl definitions with the same name.

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/Serialization/ASTReaderDecl.cpp:3328-3331 // If there's no definition yet, then DC's definition is added by an update // record, but we'v

[PATCH] D108905: [ItaniumCXXABI] Make __cxa_end_catch calls unconditionally nounwind

modimo added a comment. In D108905#2971861 , @rjmccall wrote: > I'm not really sure what the standard expects to happen if an exception > destructor throws. The standard tells us when the destruction happens — the > latest point it can — but that claus

[PATCH] D108905: [ItaniumCXXABI] Make __cxa_end_catch calls unconditionally nounwind

rjmccall added a comment. In D108905#2973066 , @modimo wrote: > In D108905#2971861 , @rjmccall > wrote: > >> I'm not really sure what the standard expects to happen if an exception >> destructor throws. The sta

[PATCH] D108905: [ItaniumCXXABI] Make __cxa_end_catch calls unconditionally nounwind

modimo added a comment. In D108905#2973099 , @rjmccall wrote: > Yeah, I think this is the most natural interpretation of the current > standard. But that would be a very unfortunate rule, because people who > write `catch (...) {}` do reasonably expect

[PATCH] D108302: [PowerPC] Fixed the crash due to early if conversion with fixed CR fields.

NeHuang updated this revision to Diff 369531. NeHuang added a comment. Address review comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108302/new/ https://reviews.llvm.org/D108302 Files: llvm/lib/Target/PowerPC/PPCInstrInfo.cpp llvm/test

[PATCH] D108905: [ItaniumCXXABI] Make __cxa_end_catch calls unconditionally nounwind

rjmccall added a comment. In D108905#2973172 , @modimo wrote: > In D108905#2973099 , @rjmccall > wrote: > >> Yeah, I think this is the most natural interpretation of the current >> standard. But that would be a

[PATCH] D108881: [clang][driver] Honor the last -flto= flag even if an earlier -flto is present

steven_wu added a comment. I agree that it might be good to change to the behavior that last arg wins but it might be simpler to set `-flto` to be an alias of `-flto=full`: diff --git a/clang/include/clang/Driver/Options.td b/clang/include/clang/Driver/Options.td index 1a3d1dcceec7..a796fb7

[PATCH] D104386: [PowerPC][Builtins] Added a number of builtins for compatibility with XL.

dim added subscribers: emaste, dim. dim added a comment. Note that this unexpectedly broke FreeBSD's powerpc64 builds, as we've long used the following in our `lib/libc/powerpc64/string/bcopy.S`: #ifndef FN_NAME #ifdef MEMMOVE #define FN_NAME __memmove WEAK_REFERE

[PATCH] D101759: [PowerPC] Scalar IBM MASS library conversion pass

bmahjour added a comment. In D101759#2971567 , @efriedma wrote: > errno handling for math library functions is a mess. Currently, we don't > model it properly; we just mark the calls "readnone" and hope for the best. > If you don't want to fix that, j

[PATCH] D106191: [clang] Option control afn flag

bmahjour added inline comments. Comment at: clang/include/clang/Driver/Options.td:1732-1733 NegFlag>; -def fapprox_func : Flag<["-"], "fapprox-func">, Group, Flags<[CC1Option, NoDriverOption]>, - MarshallingInfoFlag>, ImpliedByAnyOf<[menable_unsafe_fp_math.KeyPath]>; defm

[PATCH] D101759: [PowerPC] Scalar IBM MASS library conversion pass

efriedma added a comment. > I agree. I think the problem is that this patch is trying to decide on a > global lowering strategy for llvm.* math intrinsics in > llvm/lib/Target/PowerPC/PPCISelLowering.cpp but such global decision making > does not go well with finer granularity of fast-math flag

[PATCH] D104386: [PowerPC][Builtins] Added a number of builtins for compatibility with XL.

nemanjai added a comment. In D104386#2973245 , @dim wrote: > Note that this unexpectedly broke FreeBSD's powerpc64 builds, as we've long > used the following in our `lib/libc/powerpc64/string/bcopy.S`: > > #ifndef FN_NAME > #ifdef MEMMOVE > #define

[PATCH] D108881: [clang][driver] Honor the last -flto(=.*)? argument

mnadeem updated this revision to Diff 369558. mnadeem retitled this revision from "[clang][driver] Honor the last -flto= flag even if an earlier -flto is present" to "[clang][driver] Honor the last -flto(=.*)? argument". mnadeem edited the summary of this revision. mnadeem added a comment. Herald

[PATCH] D105759: [WIP] Implement P2361 Unevaluated string literals

cor3ntin added a comment. At @aaron.ballman request, here are some data collection trying to assert the amount of breakage On a corpus of 78M lines of C++ code corresponding to all the packages in vcpkg - Number of strings with encoding prefix in `_Pragma`: 3/3383 (all in test suits) - Number

[PATCH] D108905: [ItaniumCXXABI] Make __cxa_end_catch calls unconditionally nounwind

rsmith added a comment. I've forwarded the question here onto CWG, with Arthur's example and the suggestion that maybe we shouldn't allow throwing an exception with a non-noexcept destructor. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108905/ne

[PATCH] D108881: [clang][driver] Honor the last -flto(=.*)? argument

steven_wu added a comment. I will do a cleanup of `parseLTOMode` function since we don't need a `OptPos` parameter anymore. There are few minor places references `OPT_flto` or `OPT_foffload_lto` can be cleaned up too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D107049: [clang-repl] Re-implement clang-interpreter as a test case.

rsmith added inline comments. Comment at: clang/unittests/Interpreter/ExceptionTests/InterpreterExceptionTest.cpp:73-76 +#ifdef _MSC_VER +// Tell the windows linker to export the type_info symbol required by exceptions +#pragma comment(linker, "/export:??_7type_info@@6B@") +#en

[PATCH] D108958: [OpenMP] Make CUDA math library functions SPMD amenable

jhuber6 created this revision. jhuber6 added a reviewer: jdoerfert. Herald added subscribers: guansong, yaxunl. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. This patch adds the SPMD amenable assumption to the CUDA math l

[PATCH] D105937: [OpenMP] Encode `omp [...] assume[...]` assumptions with `omp[x]` prefix

jhuber6 accepted this revision. jhuber6 added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105937/new/ https://reviews.llvm.org/D105937 _

[PATCH] D108881: [clang][driver] Honor the last -flto(=.*)? argument

tejohnson added a comment. In D108881#2973516 , @steven_wu wrote: > I will do a cleanup of `parseLTOMode` function since we don't need a `OptPos` > parameter anymore. There are few minor places references `OPT_flto` or > `OPT_foffload_lto` can be cleane

[PATCH] D105671: [Intrinsics][ObjC] Mark objc_retain and friends as thisreturn.

jroelofs updated this revision to Diff 369584. jroelofs added a comment. Herald added a subscriber: dexonsmith. Rebased. Also, turns out that `stripPointerCasts()` can see through the `thisreturn` attribute, which defeats a self retain optimization, breaking one of the clang tests. I tweaked a

[PATCH] D108045: [clangd] Fix clangd crash when including a header

qdelacru updated this revision to Diff 369581. qdelacru added a comment. Create macro directive only preamble patch for code completion CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108045/new/ https://reviews.llvm.org/D108045 Files: clang-tools-extra/clangd/CodeComplete.cpp clang-

[PATCH] D107764: [OpenMP][OpenMPIRBuilder] Implement loop unrolling.

Meinersbur added inline comments. Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:2055 +/// Attach loop metadata \p Properties to the loop described by \p Loop. If the +/// loop already has metadata, the loop properties are appended. +static void addLoopMetadata(CanonicalLo

[clang] 93764ff - [modules] Fix miscompilation when using two RecordDecl definitions with the same name.

Author: Volodymyr Sapsai Date: 2021-08-30T17:51:38-07:00 New Revision: 93764ff6e2005b92057cffa9b3866307e2de260f URL: https://github.com/llvm/llvm-project/commit/93764ff6e2005b92057cffa9b3866307e2de260f DIFF: https://github.com/llvm/llvm-project/commit/93764ff6e2005b92057cffa9b3866307e2de260f.di

[PATCH] D106994: [modules] Fix miscompilation when using two RecordDecl definitions with the same name.

This revision was automatically updated to reflect the committed changes. Closed by commit rG93764ff6e200: [modules] Fix miscompilation when using two RecordDecl definitions with the… (authored by vsapsai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D106994: [modules] Fix miscompilation when using two RecordDecl definitions with the same name.

vsapsai added a comment. Thanks for the review! Comment at: clang/lib/Serialization/ASTReaderDecl.cpp:3328-3331 // If there's no definition yet, then DC's definition is added by an update // record, but we've not yet loaded that update record. In this case, we //

  1   2   >