[clang] 1c829ce - [clang][codegen] Set CurLinkModule in CodeGenAction::ExecuteAction

Author: Bob Haarman Date: 2021-08-24T21:25:49Z New Revision: 1c829ce1e3627cf9b22da33943dc2e423ded11c4 URL: https://github.com/llvm/llvm-project/commit/1c829ce1e3627cf9b22da33943dc2e423ded11c4 DIFF: https://github.com/llvm/llvm-project/commit/1c829ce1e3627cf9b22da33943dc2e423ded11c4.diff LOG: [

[PATCH] D108603: [clang][codegen] Set CurLinkModule in CodeGenAction::ExecuteAction

This revision was automatically updated to reflect the committed changes. Closed by commit rG1c829ce1e362: [clang][codegen] Set CurLinkModule in CodeGenAction::ExecuteAction (authored by inglorion). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D10860

[PATCH] D67429: Improve code generation for thread_local variables:

rsmith added a comment. In D67429#2961873 , @rjmccall wrote: > @rsmith, can you fix or revert? Sorry for the long delay here. Looking now. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67429/new/ https://reviews.llvm.org/

[PATCH] D108661: The maximal representable alignment in LLVM IR is 1GiB, not 512MiB

arsenm added a comment. Could use some MIR tests to make sure that parser doesn't explode Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108661/new/ https://reviews.llvm.org/D108661 ___ cfe-commits mailin

[PATCH] D108544: [clang][deps] Avoid generating arguments for missing module map files

dexonsmith added a comment. In D108544#2962890 , @jansvoboda11 wrote: > I created D108647 to more > directly/correctly address the issues I'm seeing at the moment in explicit > builds. > > I think dealing with the pos

[PATCH] D108647: [clang][deps] Use top-level modules as precompiled dependencies

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. This LGTM. > The documentation of Module::PresumedModuleMapFile says this field is > non-empty only when building from preprocessed source. This means there can > still be cases where

[PATCH] D108482: [Clang] Fix instantiation of OpaqueValueExprs (Bug #45964)

ricejasonf updated this revision to Diff 368485. ricejasonf added a comment. I added a simple lit test. The case is the reduced case mentioned in the bug. I spent some time trying to reproduce this outside decomposition. The only other way (I know of) to produce an ArrayInitLoopExpr is an implic

[clang] df7b6b9 - Extend diagnostic for out of date AST input file.

Author: Richard Smith Date: 2021-08-24T17:03:06-07:00 New Revision: df7b6b91422dbdbdb1de66fd865853e78ea3e5d2 URL: https://github.com/llvm/llvm-project/commit/df7b6b91422dbdbdb1de66fd865853e78ea3e5d2 DIFF: https://github.com/llvm/llvm-project/commit/df7b6b91422dbdbdb1de66fd865853e78ea3e5d2.diff

[PATCH] D36850: [ThinLTO] Add norecurse function attribute propagation

modimo added a comment. Checking build timing in release mode Clang self-build looking at purely thinlink timing: | Mode | Time (s) | | base | 2.254| | base + propagation | 2.556| | noinline | 8.870| | noinline + propagation | 10.

[PATCH] D107850: [asan] Implemented intrinsic for the custom calling convention similar used by HWASan for X86.

kstoimenov updated this revision to Diff 368510. kstoimenov added a comment. Updated with the fix for Bazel build. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107850/new/ https://reviews.llvm.org/D107850 Files: llvm/include/llvm/IR/Intrinsics.

[PATCH] D107850: [asan] Implemented intrinsic for the custom calling convention similar used by HWASan for X86.

vitalybuka accepted this revision. vitalybuka added a comment. And if it's straightforward fix for the revert you can "reuse" approvals and land without additional review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107850/new/ https://reviews.l

[PATCH] D107685: [WebAssembly] Tidy up EH/SjLj options

This revision was automatically updated to reflect the committed changes. Closed by commit rG77b921b870aa: [WebAssembly] Tidy up EH/SjLj options (authored by aheejin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107685/new/ https://reviews.llvm.or

[PATCH] D108582: [WebAssembly] Add Wasm SjLj option support for clang

aheejin added a comment. As we discussed offline, I'll remove `+multivalue` part for now; it doesn't have reliable support in the Wasm LLVM backend and Binaryen yet. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108582/new/ https://reviews.llvm.or

[clang] 6609892 - [clang] allow -fstack-clash-protection on FreeBSD

Author: Ed Maste Date: 2021-08-24T21:02:36-04:00 New Revision: 6609892a2dcdd1a4f6adefe191b55524861f020c URL: https://github.com/llvm/llvm-project/commit/6609892a2dcdd1a4f6adefe191b55524861f020c DIFF: https://github.com/llvm/llvm-project/commit/6609892a2dcdd1a4f6adefe191b55524861f020c.diff LOG:

[PATCH] D108643: Introduce _BitInt, deprecate _ExtInt

jyknight added inline comments. Comment at: clang/include/clang/Basic/TargetInfo.h:581 /// limitation is put into place for ABI reasons. - virtual bool hasExtIntType() const { + /// FIXME: _BitInt is a required type in C23, so there's not much utility in + /// asking whethe

[PATCH] D108571: [clang] allow -fstack-clash-protection on FreeBSD

This revision was automatically updated to reflect the committed changes. Closed by commit rG6609892a2dcd: [clang] allow -fstack-clash-protection on FreeBSD (authored by emaste). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D108582: [WebAssembly] Add Wasm SjLj option support for clang

aheejin updated this revision to Diff 368519. aheejin added a comment. This revision is now accepted and ready to land. Remove multivalue setting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108582/new/ https://reviews.llvm.org/D108582 Files: c

[clang] a947b40 - [WebAssembly] Add Wasm SjLj option support for clang

Author: Heejin Ahn Date: 2021-08-24T18:12:52-07:00 New Revision: a947b40cafa8a1d7e241699c1400d80c77e9894c URL: https://github.com/llvm/llvm-project/commit/a947b40cafa8a1d7e241699c1400d80c77e9894c DIFF: https://github.com/llvm/llvm-project/commit/a947b40cafa8a1d7e241699c1400d80c77e9894c.diff LO

[PATCH] D108582: [WebAssembly] Add Wasm SjLj option support for clang

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa947b40cafa8: [WebAssembly] Add Wasm SjLj option support for clang (authored by aheejin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D107850: [asan] Implemented intrinsic for the custom calling convention similar used by HWASan for X86.

kstoimenov added a comment. Thanks! I will submit tomorrow morning. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107850/new/ https://reviews.llvm.org/D107850 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D70172: [CUDA][HIP][OpenMP] Emit deferred diagnostics by a post-parsing AST travese

sugak added subscribers: weiwang, sugak. sugak added a comment. Herald added a subscriber: sstefan1. Hi @yaxunl! I'm working on upgrading a large codebase from LLVM-9 to LLVM-12. I noticed on average 10% compilation speed regression that seems to be caused this change. We use Clang modules and h

[PATCH] D108680: PR48030: Fix COMDAT-related linking problem with C++ thread_local static data members.

rsmith created this revision. rsmith added a reviewer: rjmccall. rsmith requested review of this revision. Herald added subscribers: cfe-commits, aheejin. Herald added a project: clang. Previously when emitting a C++ guarded initializer, we tried to work out what the enclosing function would be us

[PATCH] D67429: Improve code generation for thread_local variables:

rsmith added a comment. https://reviews.llvm.org/D108680 Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67429/new/ https://reviews.llvm.org/D67429 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[PATCH] D108680: PR48030: Fix COMDAT-related linking problem with C++ thread_local static data members.

rsmith added a comment. Note that there's a potential ABI impact here: because we accidentally put the `__cxx_global_init` function into a COMDAT with the variable, that meant that the `_ZTH` symbol (which is an alias to `__cxx_global_init`) also pointed into that same COMDAT. I'm not sure how

[PATCH] D108643: Introduce _BitInt, deprecate _ExtInt

rjmccall added a comment. I agree with James; I know you've reached out to the Itanium ABI group about mangling, but ABI involvement needs to mean also reaching out and getting psABI agreement about representation. I would suggest proposing a generic ABI, getting consensus on that generic ABI

[PATCH] D108680: PR48030: Fix COMDAT-related linking problem with C++ thread_local static data members.

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108680/new/ https://reviews.llvm.org/D108680 ___

[clang] cd4d6d7 - PR48030: Fix COMDAT-related linking problem with C++ thread_local static data members.

Author: Richard Smith Date: 2021-08-24T19:53:44-07:00 New Revision: cd4d6d718b2e51ed830a28d01d765da2a220afd3 URL: https://github.com/llvm/llvm-project/commit/cd4d6d718b2e51ed830a28d01d765da2a220afd3 DIFF: https://github.com/llvm/llvm-project/commit/cd4d6d718b2e51ed830a28d01d765da2a220afd3.diff

[PATCH] D108680: PR48030: Fix COMDAT-related linking problem with C++ thread_local static data members.

This revision was automatically updated to reflect the committed changes. Closed by commit rGcd4d6d718b2e: PR48030: Fix COMDAT-related linking problem with C++ thread_local static data… (authored by rsmith). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D102449: [WIP][Clang][OpenMP] Add the support for compare clause in atomic directive

tianshilei1992 planned changes to this revision. tianshilei1992 marked an inline comment as done. tianshilei1992 added a comment. I'm going to move code gen into `OMPIRBuilder`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102449/new/ https://revi

[PATCH] D107021: [Sema][ObjC] Allow conversions between pointers to ObjC pointers and pointers to structs

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Alright, LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107021/new/ https://reviews.llvm.org/D107021 _

[PATCH] D107450: [clang-tidy] Fix wrong FIxIt in performance-move-const-arg

Quuxplusone added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/performance-move-const-arg.cpp:262-263 + int a = 10; + forwardToShowInt(std::move(a)); + // CHECK-MESSAGES: :[[@LINE-1]]:20: warning: std::move of the variable 'a' of the trivially-copy

[PATCH] D108618: [CGCall] Add NoInline attr if presented for the target

rjmccall added a comment. Why do you want to add `noinline` to a function declaration that lacks a definition? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108618/new/ https://reviews.llvm.org/D108618

[PATCH] D36850: [ThinLTO] Add norecurse function attribute propagation

tejohnson added a comment. In D36850#2958594 , @modimo wrote: > @tejohnson Indirect calls are not captured in FunctionSummaries in CallGraph > or in a flag form saying they exist. Also looks like >

[PATCH] D108615: [Coroutines] [libcxx] Move coroutine component out of experimental namespace

ChuanqiXu added a comment. In D108615#2962618 , @lxfind wrote: > I am not familiar with the process of when to move something out of > experimental, but I do wonder how this is normally done so that people who > uses coroutines can have a smooth migrati

[clang] 323a6bf - Add "REQUIRES: arm-registered-target" line to test added in D108603.

Author: Douglas Yung Date: 2021-08-24T22:22:16-07:00 New Revision: 323a6bfbb8cf8082e22dc482abeaf6664d84bbdf URL: https://github.com/llvm/llvm-project/commit/323a6bfbb8cf8082e22dc482abeaf6664d84bbdf DIFF: https://github.com/llvm/llvm-project/commit/323a6bfbb8cf8082e22dc482abeaf6664d84bbdf.diff

[PATCH] D108268: [Modules] Change result of reading AST block to llvm::Error instead

bnbarham added a subscriber: yaxunl. bnbarham added a comment. > ! In D108268#2961735 , @vsapsai > wrote: > This might be a stupid idea and a bridge too far but what if delayed > diagnostic was storing `PartialDiagnostic` and not three strings? This loo

<    1   2