dexonsmith added a comment. In D108544#2962890 <https://reviews.llvm.org/D108544#2962890>, @jansvoboda11 wrote:
> I created D108647 <https://reviews.llvm.org/D108647> to more > directly/correctly address the issues I'm seeing at the moment in explicit > builds. > > I think dealing with the possibility of empty `PresumedModuleMapFile` is > still valuable, but I'm not aware how to test this at the moment (create > module from non-preprocessed sources). I'm not sure it is possible, based it being filled in always in ASTReader.cpp. I think this changed in ab75597ddac52f24e9cbd794cded195262ef670e but the comment wasn't updated. I suggest adding an assert that the module map file is not empty. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108544/new/ https://reviews.llvm.org/D108544 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
