dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land.
This LGTM. > The documentation of Module::PresumedModuleMapFile says this field is > non-empty only when building from preprocessed source. This means there can > still be cases where the dependency scanner generates empty > -fmodule-map-file= arguments. That's being addressed in separate patch: > D108544 <https://reviews.llvm.org/D108544>. I think the documentation might be out of date since ab75597ddac52f24e9cbd794cded195262ef670e. I made a comment in D108544 <https://reviews.llvm.org/D108544>. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108647/new/ https://reviews.llvm.org/D108647 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
