[PATCH] D99487: [CodeGen] Port basic block sections from ELF to COFF

TaoPan added a comment. Thanks MaskRay for your review comments! Comment at: llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp:1752 + else { +UniqueID = NextUniqueID++; +COMDATSymName = MBB.getParent()->getName(); MaskRay wrote: > I think `UniqueID = N

[PATCH] D105759: [WIP] Implement P2361 Unevaluated string literals

cor3ntin updated this revision to Diff 367409. cor3ntin marked 10 inline comments as done. cor3ntin added a comment. Address most of Aaron's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105759/new/ https://reviews.llvm.org/D105759 Files:

[PATCH] D105759: [WIP] Implement P2361 Unevaluated string literals

cor3ntin added a comment. I addressed most of the comments. I still need to look at the 3 loops thing (I guess if the string is very long it could leave the cache? I am not actually sure it's an issue but maybe I can improve that), and then remain design questions Repository: rG LLVM Github

[clang] cc3affd - [clang] [MSVC] Implement __mulh and __umulh builtins for aarch64

Author: Martin Storsjö Date: 2021-08-19T11:29:55+03:00 New Revision: cc3affd8b02091bf475f9dd083802e1b6a232be1 URL: https://github.com/llvm/llvm-project/commit/cc3affd8b02091bf475f9dd083802e1b6a232be1 DIFF: https://github.com/llvm/llvm-project/commit/cc3affd8b02091bf475f9dd083802e1b6a232be1.diff

[PATCH] D106721: [AArch64] Implemnt MSVC __mulh and __umulh builtins and corresponding IR level intrinsics

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcc3affd8b020: [clang] [MSVC] Implement __mulh and __umulh builtins for aarch64 (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D105267: [X86] AVX512FP16 instructions enabling 4/6

pengfei added a comment. Thanks Yuanke and Craig. Comment at: llvm/lib/Target/X86/X86InstrAVX512.td:9279 /// avx512_fp14_s rcp14ss, rcp14sd, rsqrt14ss, rsqrt14sd multiclass avx512_fp14_s opc, string OpcodeStr, SDNode OpNode, + X86FoldableSchedWrite sch

[PATCH] D107539: [OpenCL] opencl-c.h: add __opencl_c_images and __opencl_c_read_write_images

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107539/new/ https://reviews.llvm.org/D107539 _

[PATCH] D108323: [asan] Added -inline-small-callbacks LLVM flag, which would force inline code for 8 and 16 byte data types when otherwise a callback would have been used.

vitalybuka added inline comments. Comment at: clang/test/CodeGen/asan-use-callbacks.cpp:15 -int deref(int *p) { +long deref(long *p) { return *p; kcc wrote: > As we introduce a difference in behavior for small and large accesses, > I would extend this test

[PATCH] D107850: [asan] Implemented custom calling convention similar to the one used by HWASan for X86.

vitalybuka added a comment. In D107850#2952641 , @kstoimenov wrote: > I know it seems redundant to pass the constants with every function call, but > otherwise the code generation code will have to take dependency on > AddressSanitizerCommon.h, which I

[PATCH] D108359: [clang][NFC] Fix needless double-parenthisation

wingo created this revision. wingo requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Strip a layer of parentheses in TreeTransform::RebuildQualifiedType. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D108359 Files: clan

[PATCH] D108360: [clang][NFC] Remove dead code

wingo created this revision. wingo requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Remove code that has no effect in SemaType.cpp:processTypeAttrs. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D108360 Files: clang/li

Re: [PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

I applied the patch on top of the clang13 RC and It seems not to be generating any replacements. I haven't had the time to dig and understand why. Diagnostics seem to be correct. On Sun, Aug 15, 2021 at 12:16 PM Jonas Toth via Phabricator < revi...@reviews.llvm.org> wrote: > JonasToth added a com

[clang] 36d5138 - [NewPM] Make some sanitizer passes parameterized in the PassRegistry

Author: Bjorn Pettersson Date: 2021-08-19T12:43:37+02:00 New Revision: 36d51386195e3d606e0d40495f1135ab180bd6ae URL: https://github.com/llvm/llvm-project/commit/36d51386195e3d606e0d40495f1135ab180bd6ae DIFF: https://github.com/llvm/llvm-project/commit/36d51386195e3d606e0d40495f1135ab180bd6ae.di

[PATCH] D105007: [NewPM] Make some sanitizer passes parameterized in the PassRegistry

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG36d51386195e: [NewPM] Make some sanitizer passes parameterized in the PassRegistry (authored by bjope). Changed prior to commit: https://reviews.l

[clang] 7bda1a0 - [OpenCL] Fix as_type(vec3) invalid store creation

Author: Sven van Haastregt Date: 2021-08-19T11:57:09+01:00 New Revision: 7bda1a0711c67fde5f9bac5e1c9bd68163659d0e URL: https://github.com/llvm/llvm-project/commit/7bda1a0711c67fde5f9bac5e1c9bd68163659d0e DIFF: https://github.com/llvm/llvm-project/commit/7bda1a0711c67fde5f9bac5e1c9bd68163659d0e.

[PATCH] D107963: [OpenCL] Fix as_type(vec3) invalid store creation

This revision was automatically updated to reflect the committed changes. Closed by commit rG7bda1a0711c6: [OpenCL] Fix as_type(vec3) invalid store creation (authored by svenvh). Changed prior to commit: https://reviews.llvm.org/D107963?vs=365993&id=367448#toc Repository: rG LLVM Github Mono

[PATCH] D108339: [openmp][nfc] Replace OMPGridValues array with struct

JonChesterfield added a comment. Given this patch, I can then template the amdgpu one on wavesize to get something that is a compile time constant in the devicertl and easily used from clang/host plugin. Expecting to have a few refactors following on from this to make the gfx9/gfx10 abstraction

[PATCH] D108339: [openmp][nfc] Replace OMPGridValues array with struct

JonChesterfield updated this revision to Diff 367451. JonChesterfield added a comment. - revert to unsigned, file doesn't currently require stdint Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108339/new/ https://reviews.llvm.org/D108339 Files:

[PATCH] D108320: Add semantic token modifier for non-const reference parameter

sammccall added a comment. Agree this is nice, well done! A few more notes for consideration... Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:314 // (these tend to be vague, like Type or Unknown) +// - Resolved tokens (i.e. without the "dependent-name" modifi

[PATCH] D105177: [clangd] Implemented indexing of standard library

sammccall added a comment. > I removed Refs, Relations and Graph as per your comment. However I have to > admit, I don't know what they are and how they are used. > What's a good place to look at so that I learn what they do? Sorry about missing this. The best place is the `SymbolIndex` interfac

[PATCH] D108111: [CodeComplete] Only complete attributes that match the current LangOpts

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa1ebae08f4b2: [CodeComplete] Only complete attributes that match the current LangOpts (authored by sammccall). Repository: rG LLVM Github Monorepo

[clang] a1ebae0 - [CodeComplete] Only complete attributes that match the current LangOpts

Author: Sam McCall Date: 2021-08-19T13:35:07+02:00 New Revision: a1ebae08f4b243419738c3b3f0455160a880f861 URL: https://github.com/llvm/llvm-project/commit/a1ebae08f4b243419738c3b3f0455160a880f861 DIFF: https://github.com/llvm/llvm-project/commit/a1ebae08f4b243419738c3b3f0455160a880f861.diff LO

[PATCH] D107553: [C++4OpenCL] Initialize temporaries in the private address space

olestrohm updated this revision to Diff 367455. olestrohm added a comment. I made the check into an assert as suggested. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107553/new/ https://reviews.llvm.org/D107553 Files: clang/include/clang/Sema/Initialization.h clang/lib/Sema/SemaEx

[PATCH] D108301: [MSP430][Clang] Update hard-coded MCU data

jozefl updated this revision to Diff 367458. jozefl added a comment. Fixed clang-tidy warnings. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108301/new/ https://reviews.llvm.org/D108301 Files: clang/include/clang/Basic/MSP430Target.def clang/

[PATCH] D108366: [clang][deps] Deduce resource directory from the compiler path

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith, arphaman, kousikk. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. After [[libclang][deps] Accept only driver invocations, don't modify t

[clang] cab7c52 - [CodeCompletion] Provide placeholders for known attribute arguments

Author: Sam McCall Date: 2021-08-19T14:03:41+02:00 New Revision: cab7c52acdf508f73186dfe49b8cb012bb9129b2 URL: https://github.com/llvm/llvm-project/commit/cab7c52acdf508f73186dfe49b8cb012bb9129b2 DIFF: https://github.com/llvm/llvm-project/commit/cab7c52acdf508f73186dfe49b8cb012bb9129b2.diff LO

[PATCH] D108109: [CodeCompletion] Provide placeholders for known attribute arguments

This revision was automatically updated to reflect the committed changes. Closed by commit rGcab7c52acdf5: [CodeCompletion] Provide placeholders for known attribute arguments (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D108109?vs=366572&id=367462#toc Repository:

[PATCH] D106870: [OpenMP] Multi architecture compilation support

JonChesterfield added a comment. I think this patch needs to split up into a large number of much smaller pieces. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106870/new/ https://reviews.llvm.org/D106870 __

[PATCH] D108359: [clang][NFC] Fix needless double-parenthisation

wingo added a reviewer: rsmith. wingo added a comment. Hi Richard, I am new to clang, having mostly worked on the WebAssembly target in llvm proper -- I have a stack of patches, of which a couple later ones touch Sema/. See https://lists.llvm.org/pipermail/cfe-dev/2021-July/068559.html for bro

[PATCH] D108366: [clang][deps] Deduce resource directory from the compiler path

jansvoboda11 added a comment. Tagging @kousikk, since this is related to D69122 that introduced `ResourceDirectoryCache` to `clang-scan-deps`. When the compilation command doesn't have a `-resource-dir` argument, `ResourceDirectoryCache` invokes the specified c

[PATCH] D108215: [clang][deps] NFC: Move `ResourceDirectoryCache`

jansvoboda11 abandoned this revision. jansvoboda11 added a comment. Fair points. Abandoning in favor of D108366 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108215/new/ https://reviews.llvm.org/D108215

[PATCH] D108367: [NFC] computeSPIRKernelABIInfo(): use SPIRABInfo

linjamaki created this revision. linjamaki requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Make computeSPIRKernelABIInfo() to use SPIRABIInfo instead of DefaultABIInfo. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D1083

[PATCH] D108360: [clang][NFC] Remove dead code

wingo added a reviewer: rjmccall. wingo added a comment. Hi John, I am new to clang, having mostly worked on the WebAssembly target in llvm proper. I have a stack of patches related to address space treatment in codegen -- most of them NFC refactors to later allow the WebAssembly target to all

[clang] 77579b9 - [openmp][nfc] Replace OMPGridValues array with struct

Author: Jon Chesterfield Date: 2021-08-19T13:25:42+01:00 New Revision: 77579b99e9ce1638ca696fa7c3872ae8668d997d URL: https://github.com/llvm/llvm-project/commit/77579b99e9ce1638ca696fa7c3872ae8668d997d DIFF: https://github.com/llvm/llvm-project/commit/77579b99e9ce1638ca696fa7c3872ae8668d997d.di

[PATCH] D108339: [openmp][nfc] Replace OMPGridValues array with struct

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG77579b99e9ce: [openmp][nfc] Replace OMPGridValues array with struct (authored by JonChesterfield). Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D106888: [RISC-V] Implement jump tables for CFI-icall

asb added a comment. Is it possible to write a test case for this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106888/new/ https://reviews.llvm.org/D106888 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D108029: [clang][Codegen] Introduce the disable_sanitizer_instrumentation attribute

glider added inline comments. Comment at: llvm/include/llvm/Bitcode/LLVMBitCodes.h:674 ATTR_KIND_ELEMENTTYPE = 77, + ATTR_DISABLE_SANITIZER_INSTRUMENTATION = 78, }; Missing "_KIND_" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D105168: [RISCV] Unify the arch string parsing logic to RISCVISAInfo.

asb added a comment. I'm getting a build error (building with clang 12.0.1): FAILED: lib/Support/CMakeFiles/LLVMSupport.dir/RISCVISAInfo.cpp.o /usr/bin/clang++ -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/asb/llvm-p

[PATCH] D80392: [mips][mc][clang] Use pc-relative relocations in .eh_frame

atanasyan updated this revision to Diff 367472. atanasyan retitled this revision from "[WIP][mips] Use pc-relative relocations in .eh_frame" to "[mips][mc][clang] Use pc-relative relocations in .eh_frame". atanasyan edited the summary of this revision. atanasyan edited reviewers, added: emaste, gr

[PATCH] D108370: [clang-tidy] Fix wrong FixIt about union in cppcoreguidelines-pro-type-member-init

Sockke created this revision. Sockke added reviewers: aaron.ballman, bkramer, alexfh, malcolm.parsons, MTC, steven.zhang. Herald added subscribers: shchenz, kbarton, xazax.hun, nemanjai. Sockke requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber:

[PATCH] D106870: [OpenMP] Multi architecture compilation support

JonChesterfield added reviewers: ronlieb, pdhaliwal. JonChesterfield added a comment. Spent some time reading through this. I think the idea is to create a host binary that contains code objects for multiple variants of amdgpu - e.g. one that runs on gfx906 and another on gfx908, or one that run

[PATCH] D107450: [clang-tidy] Fix wrong FIxIt in performance-move-const-arg

Sockke updated this revision to Diff 367474. Sockke marked 2 inline comments as done. Sockke added a comment. Herald added a subscriber: jfb. Thanks for your reply @Quuxplusone. I have updated! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107450/new/ https://reviews.llvm.org/D107450 F

[PATCH] D108366: [clang][deps] Deduce resource directory from the compiler path

jansvoboda11 updated this revision to Diff 367478. jansvoboda11 added a comment. Account for Windows backslashes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108366/new/ https://reviews.llvm.org/D108366 Files: clang/include/clang/Tooling/Toolin

[PATCH] D108029: [clang][Codegen] Introduce the disable_sanitizer_instrumentation attribute

glider updated this revision to Diff 367480. glider added a comment. Updated BitcodeReader.cpp and several tests per Marco's suggestion Renamed ATTR_DISABLE_SANITIZER_INSTRUMENTATION to ATTR_KIND_DISABLE_SANITIZER_INSTRUMENTATION Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D108029: [clang][Codegen] Introduce the disable_sanitizer_instrumentation attribute

melver added inline comments. Comment at: llvm/lib/AsmParser/LLLexer.cpp:646 KEYWORD(dereferenceable_or_null); + KEYWORD(disable_sanitizer_instrumentation); KEYWORD(elementtype); Do the tests pass? There should also be the code that actually turns the tok

[PATCH] D108029: [clang][Codegen] Introduce the disable_sanitizer_instrumentation attribute

melver added a comment. llvm/docs/LangRef.rst also needs a corresponding change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108029/new/ https://reviews.llvm.org/D108029 ___ cfe-commits mailing list cf

[PATCH] D108370: [clang-tidy] Fix wrong FixIt about union in cppcoreguidelines-pro-type-member-init

MTC added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.cpp:49 +void forEachFieldWithFilter(const RecordDecl &Record, const T &Fields, +bool &AnyMemberHasInitPerUnion, Func &&Fn) { + for (const Fie

[PATCH] D106888: [RISC-V] Implement jump tables for CFI-icall

luismarques added a comment. In D106888#2954425 , @asb wrote: > Is it possible to write a test case for this? Good question. I had checked that the AArch64 implementation had included a test, but I think that was only for new target-specific stuff, whic

[PATCH] D108265: .clang-tidy: Push variable related readability-identifier-naming options down to projects

mehdi_amini added a comment. > the original discussion that spawned the (not-yet-accepted, as it says in its > opening sentence) linked proposal around variable naming. +1 with David again: if the proposal gets accepted, then this patch makes sense to me. Repository: rG LLVM Github Monorepo

[PATCH] D108029: [clang][Codegen] Introduce the disable_sanitizer_instrumentation attribute

glider added a comment. In D108029#2954566 , @melver wrote: > llvm/docs/LangRef.rst also needs a corresponding change. Right, will do. I thought LangRef was missing the sanitizer bits as well, and was planning to add them together, but apparently I was

[PATCH] D108029: [clang][Codegen] Introduce the disable_sanitizer_instrumentation attribute

melver accepted this revision. melver added a comment. LGTM with the LangRef change. Thanks! Comment at: llvm/lib/AsmParser/LLLexer.cpp:646 KEYWORD(dereferenceable_or_null); + KEYWORD(disable_sanitizer_instrumentation); KEYWORD(elementtype); glider wrot

[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

tiagoma added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/ConstCorrectnessCheck.cpp:168 +*Variable, *Result.Context, DeclSpec::TQ_const, +QualifierTarget::Value, QualifierPolicy::Right)) { + Diag << *Fix; -

[PATCH] D108151: [NFC][clang] Use X86 Features declaration from X86TargetParser

craig.topper added inline comments. Comment at: clang/lib/Basic/Targets/X86.cpp:1061 static unsigned getFeaturePriority(llvm::X86::ProcessorFeatures Feat) { - enum class FeatPriority { -#define FEATURE(FEAT) FEAT, -#include "clang/Basic/X86Target.def" + // Check that priorites

[clang] caa282a - Fix unknown parameter Wdocumentation warning. NFC.

Author: Simon Pilgrim Date: 2021-08-19T15:40:09+01:00 New Revision: caa282a4490332034809bd0baf3e7a2ed1b080ae URL: https://github.com/llvm/llvm-project/commit/caa282a4490332034809bd0baf3e7a2ed1b080ae DIFF: https://github.com/llvm/llvm-project/commit/caa282a4490332034809bd0baf3e7a2ed1b080ae.diff

[clang] fd37ead - Fix unknown parameter Wdocumentation warning. NFC.

Author: Simon Pilgrim Date: 2021-08-19T15:40:10+01:00 New Revision: fd37ead38659dec3e63b1b560d43e81249f3e3ce URL: https://github.com/llvm/llvm-project/commit/fd37ead38659dec3e63b1b560d43e81249f3e3ce DIFF: https://github.com/llvm/llvm-project/commit/fd37ead38659dec3e63b1b560d43e81249f3e3ce.diff

[clang] ae69164 - Fix unknown parameter Wdocumentation warning. NFC.

Author: Simon Pilgrim Date: 2021-08-19T15:40:10+01:00 New Revision: ae691648b47091313a5c2f964800d53e60b635ea URL: https://github.com/llvm/llvm-project/commit/ae691648b47091313a5c2f964800d53e60b635ea DIFF: https://github.com/llvm/llvm-project/commit/ae691648b47091313a5c2f964800d53e60b635ea.diff

[PATCH] D108151: [NFC][clang] Use X86 Features declaration from X86TargetParser

erichkeane added inline comments. Comment at: clang/lib/Basic/Targets/X86.cpp:1071 +assert(llvm::is_contained(Priorities, Priority) && + "Priorites don't form consequtive range!"); + } If all you care about is whether they are a consecutive range,

[PATCH] D108151: [NFC][clang] Use X86 Features declaration from X86TargetParser

craig.topper added inline comments. Comment at: clang/lib/Basic/Targets/X86.cpp:1071 +assert(llvm::is_contained(Priorities, Priority) && + "Priorites don't form consequtive range!"); + } erichkeane wrote: > If all you care about is whether they are

[PATCH] D108377: [asan] Implemented custom calling convention similar used by HWASan for X86.

kstoimenov created this revision. kstoimenov added a reviewer: vitalybuka. Herald added a subscriber: hiraditya. kstoimenov requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. The address sanitizer part of the code. Reposito

[PATCH] D105268: [X86] AVX512FP16 instructions enabling 5/6

LuoYuanke added inline comments. Comment at: clang/include/clang/Basic/BuiltinsX86.def:2010 +TARGET_BUILTIN(__builtin_ia32_vfmaddph, "V8xV8xV8xV8x", "ncV:128:", "avx512fp16,avx512vl") +TARGET_BUILTIN(__builtin_ia32_vfmaddph256, "V16xV16xV16xV16x", "ncV:256:", "avx512fp16,avx512

[PATCH] D108377: [asan] Implemented custom calling convention similar used by HWASan for X86.

kstoimenov updated this revision to Diff 367500. kstoimenov added a comment. Pulled constants like shadow base, etc out of the intrinsic. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108377/new/ https://reviews.llvm.org/D108377 Files: clang/tes

[PATCH] D107850: [asan] Implemented custom calling convention similar to the one used by HWASan for X86.

kstoimenov updated this revision to Diff 367501. kstoimenov added a comment. Pulled constants like shadow base, etc out of the intrinsic. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107850/new/ https://reviews.llvm.org/D107850 Files: clang/tes

[PATCH] D107477: [Clang][AST][NFC] Resolve FIXME: Make CXXRecordDecl *Record const.

gAlfonso-bit added a comment. gentle ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107477/new/ https://reviews.llvm.org/D107477 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D107477: [Clang][AST][NFC] Resolve FIXME: Make CXXRecordDecl *Record const.

RKSimon added a comment. In D107477#2954764 , @gAlfonso-bit wrote: > gentle ping Sorry I forgot about this - I'll deal with this but you really need to request commit access CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107477/new/ https://r

[PATCH] D107477: [Clang][AST][NFC] Resolve FIXME: Make CXXRecordDecl *Record const.

gAlfonso-bit added a comment. How do I request it? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107477/new/ https://reviews.llvm.org/D107477 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listi

[PATCH] D106888: [RISC-V] Implement jump tables for CFI-icall

twd2 added a comment. In D106888#2954571 , @luismarques wrote: > In D106888#2954425 , @asb wrote: > >> Is it possible to write a test case for this? > > Good question. I had checked that the AArch64 implementatio

[PATCH] D108151: [NFC][clang] Use X86 Features declaration from X86TargetParser

erichkeane added inline comments. Comment at: clang/lib/Basic/Targets/X86.cpp:1071 +assert(llvm::is_contained(Priorities, Priority) && + "Priorites don't form consequtive range!"); + } craig.topper wrote: > erichkeane wrote: > > If all you care abo

[PATCH] D107850: [asan] Implemented custom calling convention similar to the one used by HWASan for X86.

kstoimenov updated this revision to Diff 367505. kstoimenov added a comment. Pulled constants like shadow base, etc out of the intrinsic. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107850/new/ https://reviews.llvm.org/D107850 Files: clang/tes

[PATCH] D108151: [NFC][clang] Use X86 Features declaration from X86TargetParser

erichkeane added inline comments. Comment at: clang/lib/Basic/Targets/X86.cpp:1071 +assert(llvm::is_contained(Priorities, Priority) && + "Priorites don't form consequtive range!"); + } erichkeane wrote: > craig.topper wrote: > > erichkeane wrote: >

[PATCH] D108379: [OpenCL] Fix version reporting of C++ for OpenCL 2021

Topotuna created this revision. Topotuna added a reviewer: Anastasia. Herald added subscribers: ldrumm, dexonsmith, yaxunl. Topotuna requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. C++ for OpenCL version 2021 and later are expected to consi

[PATCH] D107850: [asan] Implemented custom calling convention similar to the one used by HWASan for X86.

kstoimenov updated this revision to Diff 367507. kstoimenov added a comment. Fixed after rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107850/new/ https://reviews.llvm.org/D107850 Files: llvm/include/llvm/IR/Intrinsics.td llvm/lib/Targ

[PATCH] D105268: [X86] AVX512FP16 instructions enabling 5/6

craig.topper added inline comments. Comment at: clang/include/clang/Basic/BuiltinsX86.def:2014 + +TARGET_BUILTIN(__builtin_ia32_vfmaddsh3_mask, "V8xV8xV8xV8xUcIi", "ncV:128:", "avx512fp16") +TARGET_BUILTIN(__builtin_ia32_vfmaddsh3_maskz, "V8xV8xV8xV8xUcIi", "ncV:128:", "avx512f

[PATCH] D106888: [RISC-V] Implement jump tables for CFI-icall

luismarques added a comment. In D106888#2954788 , @twd2 wrote: > Hi, you can check here: > https://buildkite.com/llvm-project/premerge-checks/builds/49755#814fd222-2e5a-4400-824d-d1a1f1293c01 > The clang-tidy failed due to the invalid case style for vari

[PATCH] D107850: [asan] Implemented custom calling convention similar to the one used by HWASan for X86.

kstoimenov marked 7 inline comments as done. kstoimenov added a comment. Added getAddressSanitizerParams to pull the constants out. Let me know if this is what you had in mind. Also struggled a little bit with git and rebase, but I think I have figured it out now. Comment at:

[PATCH] D108379: [OpenCL] Fix version reporting of C++ for OpenCL 2021

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! I imagine you will be adding some tests that will check the correctness of diagnostic wording in the subsequent commits? Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D108380: [openmp][nfc] Refactor GridValues

JonChesterfield created this revision. JonChesterfield added reviewers: jdoerfert, dpalermo, gregrodgers, ronlieb, tianshilei1992, grokos, atmnpatel. Herald added subscribers: kerbowa, guansong, yaxunl, nhaehnle, jvesely, jholewinski. JonChesterfield requested review of this revision. Herald adde

[clang] b0bf0b2 - [Clang][AST][NFC] Resolve FIXME: Make CXXRecordDecl *Record const.

Author: Alfsonso Gregory Date: 2021-08-19T16:36:32+01:00 New Revision: b0bf0b2e79e848ae502d7efc00a0bac37a96aedb URL: https://github.com/llvm/llvm-project/commit/b0bf0b2e79e848ae502d7efc00a0bac37a96aedb DIFF: https://github.com/llvm/llvm-project/commit/b0bf0b2e79e848ae502d7efc00a0bac37a96aedb.di

[PATCH] D107477: [Clang][AST][NFC] Resolve FIXME: Make CXXRecordDecl *Record const.

This revision was automatically updated to reflect the committed changes. Closed by commit rGb0bf0b2e79e8: [Clang][AST][NFC] Resolve FIXME: Make CXXRecordDecl *Record const. (authored by gAlfonso-bit, committed by RKSimon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D108247: [CUDA] Improve CUDA version detection and diagnostics.

Hahnfeld added inline comments. Comment at: clang/lib/Driver/ToolChains/Cuda.cpp:209-211 + Version = FS.exists(LibDevicePath + "/libdevice.10.bc") +? Version = CudaVersion::NEW +: Version = CudaVersion::CUDA_70; The co

[PATCH] D108380: [openmp][nfc] Refactor GridValues

JonChesterfield updated this revision to Diff 367513. JonChesterfield added a comment. - reorder field Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108380/new/ https://reviews.llvm.org/D108380 Files: clang/include/clang/Basic/TargetInfo.h cla

[PATCH] D107477: [Clang][AST][NFC] Resolve FIXME: Make CXXRecordDecl *Record const.

RKSimon added a comment. In D107477#2954787 , @gAlfonso-bit wrote: > How do I request it? https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D108379: [OpenCL] Fix version reporting of C++ for OpenCL 2021

Topotuna added a comment. In D108379#2954826 , @Anastasia wrote: > LGTM! Thanks! > > I imagine you will be adding some tests that will check the correctness of > diagnostic wording in the subsequent commits? Yes, I will add tests for diagnostics reporti

[PATCH] D105177: [clangd] Implemented indexing of standard library

kuhnel updated this revision to Diff 367523. kuhnel marked 18 inline comments as done. kuhnel added a comment. addressed review comments, has use-after-free problem Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105177/new/ https://reviews.llvm.org/

[PATCH] D107878: [SampleFDO] Flow Sensitive Sample FDO (FSAFDO) profile loader

lenary added inline comments. Comment at: llvm/test/CodeGen/X86/fsafdo_test2.ll:3 +; RUN: llvm-profdata merge --sample -profile-isfs -o %t.afdo %S/Inputs/fsloader.afdo +; RUN: llc -enable-fs-discriminator -fs-profile-file=%t.afdo -show-fs-branchprob -disable-ra-fsprofile-loader

[PATCH] D107878: [SampleFDO] Flow Sensitive Sample FDO (FSAFDO) profile loader

wenlei added inline comments. Comment at: llvm/test/CodeGen/X86/fsafdo_test2.ll:3 +; RUN: llvm-profdata merge --sample -profile-isfs -o %t.afdo %S/Inputs/fsloader.afdo +; RUN: llc -enable-fs-discriminator -fs-profile-file=%t.afdo -show-fs-branchprob -disable-ra-fsprofile-loader

[PATCH] D107878: [SampleFDO] Flow Sensitive Sample FDO (FSAFDO) profile loader

hoy added inline comments. Comment at: llvm/test/CodeGen/X86/fsafdo_test2.ll:3 +; RUN: llvm-profdata merge --sample -profile-isfs -o %t.afdo %S/Inputs/fsloader.afdo +; RUN: llc -enable-fs-discriminator -fs-profile-file=%t.afdo -show-fs-branchprob -disable-ra-fsprofile-loader=fa

[PATCH] D105177: [clangd] Implemented indexing of standard library

kuhnel added inline comments. Comment at: clang-tools-extra/clangd/index/StdLib.cpp:72 + Inputs.TFS = &TFS; + // TODO: can we get a real compile command from somewhere? + Inputs.CompileCommand.Directory = virtualRoot().str(); nridge wrote: > sammccall wrote: >

[PATCH] D107878: [SampleFDO] Flow Sensitive Sample FDO (FSAFDO) profile loader

JDevlieghere added inline comments. Comment at: llvm/include/llvm/CodeGen/MIRSampleProfile.h:59 +MIRSampleLoader( +std::make_unique(FileName, RemappingFileName)) { +LowBit = getFSPassBitBegin(P); You're instantiating a forward-declared typ

[PATCH] D106870: [OpenMP] Multi architecture compilation support

yaxunl added a comment. Can you document the device binary embedding scheme for multiple GPU's in clang documentation? This will help tool developers to develop tools to extract device binaries from executables or shared libraries. Also this may help interoperability with other offloading langu

[PATCH] D106409: [PowerPC] Truncate results for out of range values for vec_cts,vec_ctf

ZarkoCA updated this revision to Diff 367525. ZarkoCA retitled this revision from "[PowerPC] Add diagnostic for out of range values for vec_cts,vec_ctf" to "[PowerPC] Truncate results for out of range values for vec_cts,vec_ctf". ZarkoCA edited the summary of this revision. ZarkoCA added a commen

[PATCH] D107290: [PoC][RISCV] Add support for the vscale_range attribute

frasercrmck added a comment. This may be as far as we can take this patch without exposing RVV vectors bit control to the user/driver and having to worry about the concerns that spring from that: linking objects compiled with different RVV vector bits options, LTO, etc. I believe that with the

[clang] ca6d581 - [clang] Do not warn unused -enable-trivial-auto-var-init-zero-knowing-it-will-be-removed-from-clang

Author: Yi Kong Date: 2021-08-20T00:37:01+08:00 New Revision: ca6d5813d17598cd180995fb3bdfca00f364475f URL: https://github.com/llvm/llvm-project/commit/ca6d5813d17598cd180995fb3bdfca00f364475f DIFF: https://github.com/llvm/llvm-project/commit/ca6d5813d17598cd180995fb3bdfca00f364475f.diff LOG:

[PATCH] D108278: [clang] Do not warn unused -enable-trivial-auto-var-init-zero-knowing-it-will-be-removed-from-clang

This revision was automatically updated to reflect the committed changes. Closed by commit rGca6d5813d175: [clang] Do not warn unused -enable-trivial-auto-var-init-zero-knowing-it-will… (authored by kongyi). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG L

[PATCH] D108003: [Clang] Extend -Wbool-operation to warn about bitwise and of bools with side effects

aeubanks added a comment. In D108003#2944178 , @aeubanks wrote: > I ran this over Chrome and ran into a use case that looks legitimate. It > seems like the pattern in LLVM where we want to run a bunch of > transformations and get if any of them changed

[PATCH] D107647: [PowerPC] MMA - Remove deprecated built-ins and add new built-ins

saghir updated this revision to Diff 367530. saghir added a comment. Change the implementation to add new builtins and keep the depracated builtins. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107647/new/ https://reviews.llvm.org/D107647 Files:

[PATCH] D108247: [CUDA] Improve CUDA version detection and diagnostics.

tra added inline comments. Comment at: clang/lib/Driver/ToolChains/Cuda.cpp:209-211 + Version = FS.exists(LibDevicePath + "/libdevice.10.bc") +? Version = CudaVersion::NEW +: Version = CudaVersion::CUDA_70; Hahnfeld wr

[PATCH] D107690: [Modules] Do not remove failed modules after the control block phase

yaron.keren added inline comments. Comment at: clang/lib/Serialization/ASTReader.cpp:4268 // Read the AST block. if (ASTReadResult Result = ReadASTBlock(F, ClientLoadCapabilities)) + return Failure; Result is unused now. Comment

[PATCH] D108247: [CUDA] Improve CUDA version detection and diagnostics.

tra updated this revision to Diff 367532. tra added a comment. Fixed an error spotted by reviewer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108247/new/ https://reviews.llvm.org/D108247 Files: clang/include/clang/Basic/Cuda.h clang/include

[PATCH] D108387: [WebAssembly] Restore builtins and intrinsics for pmin/pmax

tlively created this revision. tlively added reviewers: aheejin, dschuff. Herald added subscribers: wingo, ecnelises, sunfish, hiraditya, jgravelle-google, sbc100. tlively requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. P

[PATCH] D108003: [Clang] Extend -Wbool-operation to warn about bitwise and of bools with side effects

rpbeltran added a comment. This patch seems like a great contribution! Really glad to see this being added. I did have a question though on why this only appears to catch "&" vs "&&" instead of doing the same for "|" vs "||". It seems like both operators have roughly the same potential for conf

  1   2   3   >