cor3ntin added a comment. I addressed most of the comments. I still need to look at the 3 loops thing (I guess if the string is very long it could leave the cache? I am not actually sure it's an issue but maybe I can improve that), and then remain design questions
Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105759/new/ https://reviews.llvm.org/D105759 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits