craig.topper added inline comments.

================
Comment at: clang/lib/Basic/Targets/X86.cpp:1071
+    assert(llvm::is_contained(Priorities, Priority) &&
+           "Priorites don't form consequtive range!");
+  }
----------------
erichkeane wrote:
> If all you care about is whether they are a consecutive range, why not just 
> use `std::is_sorted`?
The Priorities array isn't sorted. It's just whatever order the 
X86_FEATURE_COMPAT lists them.

The values need to be unique and in a contiguous range.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108151/new/

https://reviews.llvm.org/D108151

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to