[PATCH] D108119: Wiring of standard library indexing into clangd.

sammccall added a comment. (First just the bug that I suspect is blocking you from testing this, design feedback to come) Comment at: clang-tools-extra/clangd/ClangdServer.cpp:184 +} +AddIndex(SLIndex->get()); + } this pointer will dangle after the `i

[PATCH] D107450: [clang-tidy] Fix wrong FIxIt in performance-move-const-arg

Sockke updated this revision to Diff 366815. Sockke added a comment. update! Fixed some diagnostic descriptions. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107450/new/ https://reviews.llvm.org/D107450 Files: clang-tools-extra/clang-tidy/performance/MoveConstArgCheck.cpp clang-to

[PATCH] D108173: [WIP][clang] Add a cmake flag for choosing to build clang-repl

phosek added a comment. Rather than hardcoding this only for `clang-repl`, I'd prefer to use a more generic approach. We already have `LLVM_DISTRIBUTION_COMPONENTS` so one possibility would be to set a lit feature for every component. For example, if `LLVM_DISTRIBUTION_COMPONENTS=foo;bar` we w

[PATCH] D105426: [clangd] IncludeCleaner as a library: Find all references to symbols in the file

kbobyrev updated this revision to Diff 366819. kbobyrev added a comment. Remove findReferencedFiles (to be introduced in the next patch) to preserve proposed granularity. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105426/new/ https://reviews.llv

[PATCH] D105426: [clangd] IncludeCleaner as a library: Find all references to symbols in the file

kbobyrev updated this revision to Diff 366830. kbobyrev added a comment. Fix tests name. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105426/new/ https://reviews.llvm.org/D105426 Files: clang-tools-extra/clangd/CMakeLists.txt clang-tools-extr

[PATCH] D106343: [OpenCL] Support cl_ext_float_atomics

haonanya updated this revision to Diff 366829. haonanya added a comment. Add the new builtins to clang/lib/Sema/OpenCLBuiltins.td. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106343/new/ https://reviews.llvm.org/D106343 Files: clang/lib/Headers/opencl-c-base.h clang/lib/Headers/o

[PATCH] D106343: [OpenCL] Support cl_ext_float_atomics

haonanya added a comment. Hi, Anastasia and svenvh. Sorry for late reply. I have updated patch per your comments. Many thanks for your comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106343/new/ https://reviews.llvm.org/D106343 ___ c

[PATCH] D107366: [analyzer] Adjust JS code of analyzer's HTML report for IE support.

vsavchenko accepted this revision. vsavchenko added a comment. This revision is now accepted and ready to land. Now it looks good! Thanks again! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107366/new/ https://reviews.llvm.org/D107366 ___ c

[PATCH] D105426: [clangd] IncludeCleaner as a library: Find all references to symbols in the file

kbobyrev updated this revision to Diff 366832. kbobyrev added a comment. [clangd] IncludeCleaner: Mark used headers. Follow-up on D105426 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105426/new/ https://reviews

[PATCH] D105426: [clangd] IncludeCleaner as a library: Find all references to symbols in the file

kbobyrev updated this revision to Diff 366833. kbobyrev added a comment. Push back to the origin. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105426/new/ https://reviews.llvm.org/D105426 Files: clang-tools-extra/clangd/CMakeLists.txt clang-t

[PATCH] D106876: Remove non-affecting module maps from PCM files.

ilyakuteev added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106876/new/ https://reviews.llvm.org/D106876 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D108194: [clangd] IncludeCleaner: Mark used headers

kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman, mgrang. kbobyrev requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Follow-p on D

[PATCH] D108194: [clangd] IncludeCleaner: Mark used headers

kbobyrev updated this revision to Diff 366835. kbobyrev added a comment. Nit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108194/new/ https://reviews.llvm.org/D108194 Files: clang-tools-extra/clangd/Headers.cpp clang-tools-extra/clangd/Heade

[PATCH] D108194: [clangd] IncludeCleaner: Mark used headers

kbobyrev planned changes to this revision. kbobyrev added a comment. Need to add some basic tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108194/new/ https://reviews.llvm.org/D108194 ___ cfe-commi

[PATCH] D106343: [OpenCL] Support cl_ext_float_atomics

svenvh added a comment. Thanks for the update! I have a few points to improve the patch. Comment at: clang/lib/Sema/OpenCLBuiltins.td:1107 +// The functionality added by cl_ext_float_atomics extension +let MinVersion = CL30 in { + foreach TypePair = Do we rea

[PATCH] D106721: [AArch64] Implemnt MSVC __mulh and __umulh builtins and corresponding IR level intrinsics

mstorsjo updated this revision to Diff 366839. mstorsjo added a comment. Reimplemented the builtins by expanding to the corresponding i128 multiplication in IR, just like the corresponding existing `__mulh` and `__umulh` builtins on x86. Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D105268: [X86] AVX512FP16 instructions enabling 5/6

RKSimon added inline comments. Comment at: clang/lib/Headers/avx512fp16intrin.h:2373 + (__v32hf)(__m512h)(A), (__v32hf)(__m512h)(B), (__v32hf)(__m512h)(C), \ + (__mmask32)-1, (int)(R)) + Add outer brackets to all the defines to prevent precedence i

[PATCH] D105269: [X86] AVX512FP16 instructions enabling 6/6

RKSimon added inline comments. Comment at: clang/lib/Headers/avx512fp16intrin.h:2900 + (__v4sf)(__m128h)(C), (__v4sf)(__m128h)(A), (__v4sf)(__m128h)(B), \ + (__mmask8)-1, (int)(R)) + Outer brackets Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D108029: [clang][Codegen] Introduce the disable_sanitizer_instrumentation attribute

glider updated this revision to Diff 366845. glider added a comment. Address Aaron's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108029/new/ https://reviews.llvm.org/D108029 Files: clang/include/clang/Basic/Attr.td clang/include/cla

[PATCH] D108029: [clang][Codegen] Introduce the disable_sanitizer_instrumentation attribute

glider added inline comments. Comment at: clang/include/clang/Basic/Attr.td:2945 + let Spellings = [Clang<"disable_sanitizer_instrumentation">]; + let Subjects = SubjectList<[Function]>; + let Documentation = [DisableSanitizerInstrumentationDocs]; aaron.ballma

[PATCH] D108138: [SimplifyCFG] Remove switch statements before vectorization

david-arm added a comment. In D108138#2947229 , @lebedev.ri wrote: > I'm not sure i'm sold on this, even though i'm aware that selects hurt > vectorization. > How does this Simplify the CFG? I think it would be best to teach LV selects, > or at worst do

[PATCH] D108034: [SPIR-V] Add SPIR-V builtin functions and types

Anastasia added a comment. Can you elaborate the overall design flow please? Particularly, it is not clear why we need to duplicate OpenCL types and builtins at source level for SPIR-V... Is there any way to avoid this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D108138: [SimplifyCFG] Remove switch statements before vectorization

lebedev.ri added a comment. The alternative to teaching looprotate/LV about switches is to make swiches non-canonical in the first half of the pipeline, before LV. That is, don't form them, and aggressively expand any and all existing switches. Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D108138: [SimplifyCFG] Remove switch statements before vectorization

dmgreen added a comment. > I'm under the impression that the vectoriser has a policy of never making > scalar transformations I'm not sure what you mean. I've not looked into the details, but it could presumably be done as some sort of VPlan transformation, possibly in the constructions of vpl

[PATCH] D108138: [SimplifyCFG] Remove switch statements before vectorization

david-arm added a comment. In D108138#2948975 , @dmgreen wrote: >> I'm under the impression that the vectoriser has a policy of never making >> scalar transformations > > I'm not sure what you mean. I've not looked into the details, but it could > presu

[PATCH] D106891: [Remarks] Emit optimization remarks for atomics generating CAS loop

This revision was automatically updated to reflect the committed changes. Closed by commit rGf22ba5187350: [Remarks] Emit optimization remarks for atomics generating CAS loop (authored by gandhi21299). Changed prior to commit: https://reviews.llvm.org/D106891?vs=366683&id=366735#toc Repository

[PATCH] D108150: [Remarks] [AMDGPU] Emit optimization remarks for atomics generating hardware instructions

gandhi21299 updated this revision to Diff 366751. gandhi21299 added a comment. - added more tests - addressed feedback from reviewer Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108150/new/ https://reviews.llvm.org/D108150 Files: clang/test/Cod

[PATCH] D108150: [Remarks] [AMDGPU] Emit optimization remarks for atomics generating hardware instructions

gandhi21299 updated this revision to Diff 366752. gandhi21299 added a comment. - corrected an argument in AtomicExpand pass Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108150/new/ https://reviews.llvm.org/D108150 Files: clang/test/CodeGenOpenC

[PATCH] D108150: [Remarks] [AMDGPU] Emit optimization remarks for atomics generating hardware instructions

rampitec added inline comments. Comment at: clang/test/CodeGenOpenCL/atomics-remarks-gfx90a.cl:9 +// RUN: %clang_cc1 -cl-std=CL2.0 -O0 -triple=amdgcn-amd-amdhsa -target-cpu gfx90a \ +// RUN: -Rpass=si-lower -munsafe-fp-atomics %s -S -o - 2>&1 | \ You are c

[PATCH] D108150: [Remarks] [AMDGPU] Emit optimization remarks for atomics generating hardware instructions

gandhi21299 marked 5 inline comments as done. gandhi21299 added inline comments. Comment at: clang/test/CodeGenOpenCL/atomics-remarks-gfx90a.cl:9 +// RUN: %clang_cc1 -cl-std=CL2.0 -O0 -triple=amdgcn-amd-amdhsa -target-cpu gfx90a \ +// RUN: -Rpass=si-lower -munsafe-fp-atomi

[PATCH] D108150: [Remarks] [AMDGPU] Emit optimization remarks for atomics generating hardware instructions

gandhi21299 updated this revision to Diff 366765. gandhi21299 marked 2 inline comments as done. gandhi21299 added a comment. - split the OpenCL test into two for brevity - fixed a mistake in SIISelLowering as pointed out by reviewer - added the missing -munsafe-fp-atomics flag Repository: rG L

[PATCH] D108138: [SimplifyCFG] Remove switch statements before vectorization

dmgreen added a comment. In D108138#2948995 , @david-arm wrote: > In D108138#2948975 , @dmgreen wrote: > >>> I'm under the impression that the vectoriser has a policy of never making >>> scalar transformations >>

[PATCH] D108199: [msan] Add support for disable_sanitizer_instrumentation attribute

glider created this revision. glider added reviewers: eugenis, melver. Herald added a subscriber: hiraditya. glider requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Unlike __attribute__((no_sanitize("memory"))), this one wi

[PATCH] D108119: Wiring of standard library indexing into clangd.

kuhnel updated this revision to Diff 366856. kuhnel marked an inline comment as done. kuhnel added a comment. fixed lifecycle of StdLibIndex variable Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108119/new/ https://reviews.llvm.org/D108119 Files:

[PATCH] D108119: Wiring of standard library indexing into clangd.

kuhnel added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:180 + if (Opts.IndexStandardLibrary) { +auto SLIndex = indexStandardLibrary(TFS); +if (!SLIndex || !SLIndex->get()) { I'm not sure if returning a Expected makes sense her

[PATCH] D108138: [SimplifyCFG] Remove switch statements before vectorization

xbolva00 added subscribers: nikic, xbolva00. xbolva00 added a comment. Also check @nikic’s https://reviews.llvm.org/D95296 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108138/new/ https://reviews.llvm.org/D108138 _

[PATCH] D108202: [tsan] Add support for disable_sanitizer_instrumentation attribute

glider created this revision. glider added a reviewer: melver. Herald added subscribers: jfb, hiraditya. glider requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Unlike __attribute__((no_sanitize("thread"))), this one will c

[PATCH] D104975: Implement P1949

cor3ntin updated this revision to Diff 366860. cor3ntin marked an inline comment as done. cor3ntin added a comment. Fix Aaron's comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104975/new/ https://reviews.llvm.org/D104975 Files: clang/inclu

[PATCH] D104975: Implement P1949

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a commenting nit that I managed to miss last time (sorry about that). Btw, would you like to apply for commit privileges now that you've gotten a few patches unde

[PATCH] D108038: [C++4OpenCL] C++ for OpenCL version 2021 introduced to command line

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks Let's add a reference to RFC in the description: https://lists.llvm.org/pipermail/cfe-dev/2021-August/068593.html Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D104975: Implement P1949

cor3ntin updated this revision to Diff 366865. cor3ntin added a comment. Fix comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104975/new/ https://reviews.llvm.org/D104975 Files: clang/include/clang/Basic/CharInfo.h clang/include/clang/Bas

[PATCH] D108113: [C++4OpenCL] Enable -cl-std flag clc++21 as a shorthand for clc++2021

Anastasia added a subscriber: svenvh. Anastasia added a comment. @svenvh I would like to discuss it further with Sven whether it is a good direction or not? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108113/new/ https://reviews.llvm.org/D108113

[PATCH] D107963: [OpenCL] Fix as_type(vec3) invalid store creation

Anastasia accepted this revision. Anastasia added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:4789 - -if (!CGF.CGM.getCodeGenOpts().PreserveVec3Type) { - Src = createCastsForTypeOfSameSize(Builder, CGF.

[PATCH] D108119: Wiring of standard library indexing into clangd.

sammccall added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:180 + if (Opts.IndexStandardLibrary) { +auto SLIndex = indexStandardLibrary(TFS); +if (!SLIndex) { A couple of issues with indexing here and placing it in the stack:

[PATCH] D108113: [C++4OpenCL] Enable -cl-std flag clc++21 as a shorthand for clc++2021

svenvh added a comment. In D108113#2949141 , @Anastasia wrote: > @svenvh I would like to discuss it further with Sven whether it is a good > direction or not? The underlying motivation for adding those aliases seems to be missing from the description.

[PATCH] D108038: [C++4OpenCL] C++ for OpenCL version 2021 introduced to command line

svenvh accepted this revision. svenvh added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108038/new/ https://reviews.llvm.org/D108038 ___ cfe-commits mailing list cfe-commits@lists.llvm

[PATCH] D105426: [clangd] IncludeCleaner as a library: Find all references to symbols in the file

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:65 + bool VisitExpr(Expr *E) { +TraverseType(E->getType()); +return true; I just r

[PATCH] D106030: [Clang] add support for error+warning fn attrs

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Clang parts LGTM, thank you for this! Comment at: clang/test/Sema/attr-error.c:31-32 + +__attribute__((error("foo"))) int bad5(void); // expected-error {{'err

[PATCH] D105268: [X86] AVX512FP16 instructions enabling 5/6

pengfei updated this revision to Diff 366873. pengfei added a comment. Rebased. Add extra parentheses for macro. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105268/new/ https://reviews.llvm.org/D105268 Files: clang/include/clang/Basic/Builtins

[PATCH] D105268: [X86] AVX512FP16 instructions enabling 5/6

pengfei added inline comments. Comment at: clang/lib/Headers/avx512fp16intrin.h:2373 + (__v32hf)(__m512h)(A), (__v32hf)(__m512h)(B), (__v32hf)(__m512h)(C), \ + (__mmask32)-1, (int)(R)) + RKSimon wrote: > Add outer brackets to all the defines to pre

[PATCH] D107963: [OpenCL] Fix as_type(vec3) invalid store creation

svenvh added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:4789 - -if (!CGF.CGM.getCodeGenOpts().PreserveVec3Type) { - Src = createCastsForTypeOfSameSize(Builder, CGF.CGM.getDataLayout(), Src, Anastasia wrote: > While I agree with this

[PATCH] D105177: [clangd] Implemented indexing of standard library

sammccall added inline comments. Comment at: clang-tools-extra/clangd/FS.h:77 +/// Get a virtual root node for the filesystem depending on the OS +inline const llvm::StringLiteral virtualRoot() { "node" doesn't mean anything here. Comment at:

[PATCH] D104285: [analyzer][AST] Retrieve value by direct index from list initialization of constant array declaration.

ASDenysPetrov added a comment. @aaron.ballman Ok, I got your concerns. As I can see we shall only reason about objects within the bounds. Otherwise, we shall return `UndefinedVal`. E.g.: int arr[2][5]; int* ptr1= (int*)arr; // Valid indexing for `ptr` is in range [0,4]. int* ptr2 = &arr[0]

[PATCH] D108029: [clang][Codegen] Introduce the disable_sanitizer_instrumentation attribute

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Clang bits LGTM with a few minor documentation nits. Comment at: clang/include/clang/Basic/AttrDocs.td:2598-2599 + let Content = [{ +Use the ``disable_sanitize

[clang] ef198cd - [SVE] Remove usage of getMaxVScale for AArch64, in favour of IR Attribute

Author: Dylan Fleming Date: 2021-08-17T14:42:47+01:00 New Revision: ef198cd99e6bac3a2e87adb6c8a18fb461056fa6 URL: https://github.com/llvm/llvm-project/commit/ef198cd99e6bac3a2e87adb6c8a18fb461056fa6 DIFF: https://github.com/llvm/llvm-project/commit/ef198cd99e6bac3a2e87adb6c8a18fb461056fa6.diff

[PATCH] D106277: [SVE] Remove the interface for getMaxVScale in favour of the IR attributes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGef198cd99e6b: [SVE] Remove usage of getMaxVScale for AArch64, in favour of IR Attribute (authored by DylanFleming-arm). Changed prior to commit: h

[PATCH] D107430: [OMPIRBuilder] Add ordered directive to OMPIRBuilder

peixin added a comment. @Meinersbur Thanks for your review and suggestions. > While manually editing `ordered_codegen.cpp` gives nicer results, re-running > `update_cc_test_checks.py` would be less work. Your manual changes would be > also be dropped the next time somebody runs update_cc_test_

[PATCH] D108029: [clang][Codegen] Introduce the disable_sanitizer_instrumentation attribute

melver added inline comments. Comment at: llvm/include/llvm/IR/Attributes.td:90 +/// Do not instrument function with sanitizers. +def DisableSanitizerInstrumentation: EnumAttr<"disable_sanitizer_instrumentation", [FnAttr]>; + There's this long-tail of changes re

[PATCH] D108029: [clang][Codegen] Introduce the disable_sanitizer_instrumentation attribute

glider updated this revision to Diff 366887. glider added a comment. Fix the docs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108029/new/ https://reviews.llvm.org/D108029 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/Att

[PATCH] D108029: [clang][Codegen] Introduce the disable_sanitizer_instrumentation attribute

glider added inline comments. Comment at: llvm/include/llvm/IR/Attributes.td:90 +/// Do not instrument function with sanitizers. +def DisableSanitizerInstrumentation: EnumAttr<"disable_sanitizer_instrumentation", [FnAttr]>; + melver wrote: > There's this long-ta

[PATCH] D105267: [X86] AVX512FP16 instructions enabling 4/6

LuoYuanke added inline comments. Comment at: clang/include/clang/Basic/BuiltinsX86.def:1897 + +TARGET_BUILTIN(__builtin_ia32_rndscaleph_128_mask, "V8xV8xIiV8xUc", "ncV:128:", "avx512fp16,avx512vl") +TARGET_BUILTIN(__builtin_ia32_rndscaleph_256_mask, "V16xV16xIiV16xUs", "ncV:256

[PATCH] D108132: Add implicit map for a list item appears in a reduction clause.

jyu2 updated this revision to Diff 366894. jyu2 added a comment. Herald added a project: OpenMP. Herald added a subscriber: openmp-commits. Fix format and add new runtime test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108132/new/ https://revie

[PATCH] D104285: [analyzer][AST] Retrieve value by direct index from list initialization of constant array declaration.

aaron.ballman added a comment. In D104285#2949273 , @ASDenysPetrov wrote: > @aaron.ballman > Ok, I got your concerns. Thanks for sticking with me! > As I can see we shall only reason about objects within the bounds. Otherwise, > we shall return `Undef

[PATCH] D108132: Add implicit map for a list item appears in a reduction clause.

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:5825 + for (Expr *E : RC->varlists()) +if (!dyn_cast(E)) + ImplicitExprs.emplace_back(E); `isa`. Also, what if this is a `MemberExpr`? Co

[PATCH] D107450: [clang-tidy] Fix wrong FIxIt in performance-move-const-arg

Quuxplusone added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/performance-move-const-arg.cpp:263 + forwardToShowInt(std::move(a)); + // CHECK-MESSAGES: :[[@LINE-1]]:20: warning: std::move of the variable 'a' of the trivially-copyable type 'int' has

[PATCH] D107963: [OpenCL] Fix as_type(vec3) invalid store creation

jaykang10 added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:4789 - -if (!CGF.CGM.getCodeGenOpts().PreserveVec3Type) { - Src = createCastsForTypeOfSameSize(Builder, CGF.CGM.getDataLayout(), Src, svenvh wrote: > Anastasia wrote: > > Whi

[PATCH] D105167: [analyzer] Fix HTML report deduplication.

ASDenysPetrov accepted this revision. ASDenysPetrov added a comment. Nice work! Unfortunately I'm not able to run tests on my Windows env, but I've run you tests files manually. It works for me. P.S. BTW, is there any workarounds to make current tests supported on Windows? I know there is //REQ

[PATCH] D108211: Emit sizeof/alignof values as notes when a static_assert fails

arichardson created this revision. arichardson added reviewers: courbet, Quuxplusone, aaron.ballman. arichardson requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Trying to debug a static_assert(sizeof(foo) == ...) failure can be rather awkwa

[PATCH] D108212: Emit offsetof values as notes when a static_assert fails

arichardson created this revision. arichardson added reviewers: courbet, Quuxplusone, aaron.ballman. arichardson requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Trying to debug a static_assert(offset(foo, field) == ...) failure can be rathe

[PATCH] D105972: Fix __attribute__((annotate("")) with non-zero globals AS

arichardson updated this revision to Diff 366911. arichardson added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105972/new/ https://reviews.llvm.org/D105972 Files: clang/lib/CodeGen/CodeGenModule.cpp clang/lib/CodeGen/CodeG

[PATCH] D107477: [Clang][AST][NFC] Resolve FIXME: Make CXXRecordDecl *Record const.

RKSimon accepted this revision. RKSimon added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107477/new/ https://reviews.llvm.org/D107477 ___ cfe-commits mailing list cfe-commits

[PATCH] D104285: [analyzer][AST] Retrieve value by direct index from list initialization of constant array declaration.

ASDenysPetrov added a comment. @aaron.ballman Let me speak some thoughts. Consider next: int arr[2][5]; int *ptr1 = &arr[0][0]; int *ptr2 = &arr[1][0]; The Standard tells that `ptr1[5]` is UB and `ptr2[0]` is a valid object. In practice `ptr1` and `ptr2` usually are equal. But the Standar

[PATCH] D106615: [Clang][LLVM] generate btf_tag annotations for DIComposite types

yonghong-song added a comment. @dblaikie ping. Could you help take a look at the patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106615/new/ https://reviews.llvm.org/D106615 ___ cfe-commits mailing

[clang] 9dabacd - [analyzer] Adjust JS code of analyzer's HTML report for IE support.

Author: Denys Petrov Date: 2021-08-17T19:32:34+03:00 New Revision: 9dabacd09fdd52b5995546794290651c477d3885 URL: https://github.com/llvm/llvm-project/commit/9dabacd09fdd52b5995546794290651c477d3885 DIFF: https://github.com/llvm/llvm-project/commit/9dabacd09fdd52b5995546794290651c477d3885.diff

[PATCH] D107366: [analyzer] Adjust JS code of analyzer's HTML report for IE support.

This revision was automatically updated to reflect the committed changes. Closed by commit rG9dabacd09fdd: [analyzer] Adjust JS code of analyzer's HTML report for IE support. (authored by ASDenysPetrov). Changed prior to commit: https://reviews.llvm.org/D107366?vs=364418&id=366923#toc Reposito

[PATCH] D108215: [clang][deps] NFC: Move `ResourceDirectoryCache`

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith, arphaman. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The `ResourceDirectoryCache` is useful not only in the `clang-scan-deps` CLI to

[PATCH] D107963: [OpenCL] Fix as_type(vec3) invalid store creation

svenvh added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:4789 - -if (!CGF.CGM.getCodeGenOpts().PreserveVec3Type) { - Src = createCastsForTypeOfSameSize(Builder, CGF.CGM.getDataLayout(), Src, jaykang10 wrote: > svenvh wrote: > > Anasta

[PATCH] D107775: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType

gAlfonso-bit updated this revision to Diff 366931. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107775/new/ https://reviews.llvm.org/D107775 Files: clang/lib/AST/DeclPrinter.cpp clang/lib/AST/Type.cpp clang/lib/AST/TypePrinter.cpp Index: clang/lib/AST/TypePrinter.cpp ===

[PATCH] D108083: [PATCH 1/8] [sanitizer] Add hexagon support to sanitizer-common

vitalybuka accepted this revision. vitalybuka added a comment. This revision is now accepted and ready to land. Please correct me if I am wrong, but LLVM does not use [PATCH *] tags for series. Please remove them from title and git patches. You can link dependent patches into Phabricator "stack"

[PATCH] D108083: [PATCH 1/8] [sanitizer] Add hexagon support to sanitizer-common

vitalybuka requested changes to this revision. vitalybuka added a comment. This revision now requires changes to proceed. Sorry, approved accidentally. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108083/new/ https://reviews.llvm.org/D108083

[PATCH] D104285: [analyzer][AST] Retrieve value by direct index from list initialization of constant array declaration.

aaron.ballman added a comment. In D104285#2949638 , @ASDenysPetrov wrote: > @aaron.ballman > Let me speak some thoughts. Consider next: > > int arr[2][5]; > int *ptr1 = &arr[0][0]; > int *ptr2 = &arr[1][0]; > > The Standard tells that `ptr1[5]` is

[PATCH] D107887: scan-build-py: Force the opening in utf-8

isthismyaccount accepted this revision. isthismyaccount added a comment. This revision is now accepted and ready to land. Seems reasonable to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107887/new/ https://reviews.llvm.org/D107887 __

[PATCH] D107078: [analyzer] Catch leaking stack addresses via stack variables

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. It looks good to me, my concerns are addressed. But please wait for @NoQ 's approval. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107078/new/ https://reviews.llvm.org/D107078 __

[PATCH] D107887: scan-build-py: Force the opening in utf-8

phosek accepted this revision. phosek added a comment. LGTM Comment at: clang/tools/scan-build-py/lib/libscanbuild/report.py:420 -with open(filename) as handler: +with open(filename, encoding="utf-8") as handler: for line in handler.readlines(): -

[PATCH] D108083: [PATCH 1/8] [sanitizer] Add hexagon support to sanitizer-common

vitalybuka added a comment. In D108083#2948056 , @bcain wrote: > In D108083#2947914 , @vitalybuka > wrote: > >> Do we have public bot for hexagon? > > I think we have one intended to for checking hexagon-unknown-

[PATCH] D108199: [msan] Add support for disable_sanitizer_instrumentation attribute

eugenis accepted this revision. eugenis added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108199/new/ https://reviews.llvm.org/D108199 _

[PATCH] D107887: scan-build-py: Force the opening in utf-8

sylvestre.ledru updated this revision to Diff 366937. sylvestre.ledru added a comment. Replace " => ' Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107887/new/ https://reviews.llvm.org/D107887 Files: clang/tools/scan-build-py/lib/libscanbuild/re

[PATCH] D108218: Use installed llvm-lit.py instead of lit.py PR-51072

yaron.keren created this revision. yaron.keren requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D108218 Files: clang/test/utils/update_cc_test_checks/lit.local.cfg Index: c

[clang] 70b06fe - scan-build-py: Force the opening in utf-8

Author: Sylvestre Ledru Date: 2021-08-17T19:19:39+02:00 New Revision: 70b06fe8a1862f5b9a0ef4e5e9098c1e457cf275 URL: https://github.com/llvm/llvm-project/commit/70b06fe8a1862f5b9a0ef4e5e9098c1e457cf275 DIFF: https://github.com/llvm/llvm-project/commit/70b06fe8a1862f5b9a0ef4e5e9098c1e457cf275.dif

[PATCH] D108218: Use installed llvm-lit.py instead of lit.py PR-51072

yaron.keren abandoned this revision. yaron.keren added a comment. opened by mistake Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108218/new/ https://reviews.llvm.org/D108218 ___ cfe-commits mailing list

[PATCH] D107887: scan-build-py: Force the opening in utf-8

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG70b06fe8a186: scan-build-py: Force the opening in utf-8 (authored by sylvestre.ledru). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D108085: Use installed llvm-lit.py instead of lit.py PR-51072

yaron.keren updated this revision to Diff 366941. yaron.keren added a comment. Switched to Linux repo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108085/new/ https://reviews.llvm.org/D108085 Files: clang/test/utils/update_cc_test_checks/lit.lo

[PATCH] D108132: Add implicit map for a list item appears in a reduction clause.

jyu2 updated this revision to Diff 366945. jyu2 edited the summary of this revision. jyu2 added a comment. Address Alex's comments. Thanks Alex. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108132/new/ https://reviews.llvm.org/D108132 Files: c

[PATCH] D108150: [Remarks] [AMDGPU] Emit optimization remarks for atomics generating hardware instructions

gandhi21299 added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108150/new/ https://reviews.llvm.org/D108150 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D108083: [PATCH 1/8] [sanitizer] Add hexagon support to sanitizer-common

bcain added a comment. In D108083#2949815 , @vitalybuka wrote: >> We can help create a bot for hexagon-unknown-linux-musl. What's the process? > > Thank you. https://llvm.org/docs/HowToAddABuilder.html Oh I think I misunderstood: > Volunteers can provi

[PATCH] D107850: [asan] Implemented custom calling convention similar to the one used by HWASan for X86.

vitalybuka added a comment. This can be split into 3 patches in the following order: 1. x86 2. Instrumentation 3. clang Each of them needs tests, Intrtumentation changes are not tested. Comment at: llvm/include/llvm/Transforms/Instrumentation/AddressSanitizer.h:150 +namespa

[PATCH] D108083: [PATCH 1/8] [sanitizer] Add hexagon support to sanitizer-common

bcain added inline comments. Comment at: compiler-rt/lib/sanitizer_common/sanitizer_stacktrace.cpp:25 return pc + 8; -#elif defined(__powerpc__) || defined(__arm__) || defined(__aarch64__) +#elif defined(__powerpc__) || defined(__arm__) || defined(__aarch64__) \ + || defined(

[PATCH] D108215: [clang][deps] NFC: Move `ResourceDirectoryCache`

dexonsmith requested changes to this revision. dexonsmith added a comment. This revision now requires changes to proceed. I don't think this should be reused. If I'm reading the code correctly, this is just a super heavyweight (but cached) call to `Driver::GetResourcesPath()`. It should probably

[PATCH] D108223: gn build: Build libclang.so on ELF platforms.

pcc created this revision. pcc added a reviewer: thakis. pcc requested review of this revision. Herald added a project: LLVM. This requires changing the ELF build to enable -fPIC, consistent with other platforms. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D108223 Files: l

[PATCH] D108132: Add implicit map for a list item appears in a reduction clause.

jyu2 marked 4 inline comments as not done. jyu2 added a comment. Comment at: clang/lib/Sema/SemaOpenMP.cpp:5825 + for (Expr *E : RC->varlists()) +if (!dyn_cast(E)) + ImplicitExprs.emplace_back(E); ABataev wrote: > `isa`. Also,

  1   2   >