vitalybuka added a comment.
This can be split into 3 patches in the following order:
1. x86
2. Instrumentation
3. clang
Each of them needs tests, Intrtumentation changes are not tested.
================
Comment at: llvm/include/llvm/Transforms/Instrumentation/AddressSanitizer.h:150
+namespace AsanAccessInfo {
+
----------------
It's not how enums described here
https://llvm.org/docs/CodingStandards.html#id43
Also it's common to use enum class nowerdays.
However this one does not need to be enum and just "constexpr size_t"
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107850/new/
https://reviews.llvm.org/D107850
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
