sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
================
Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:65
+ bool VisitExpr(Expr *E) {
+ TraverseType(E->getType());
+ return true;
----------------
I just realized this uses "T" if any expression has type "T*" even if never
dereferenced, this is probably a gross overestimate. Nevertheless I guess fine
for now.
================
Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:101
+
+// Given a set of referenced FileIDs, determines all the potentially-referenced
+// files and macros by traversing expansion/spelling locations of macro IDs.
----------------
this struct is not used in this patch
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105426/new/
https://reviews.llvm.org/D105426
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
