[PATCH] D106005: [Docs] Define matrix initialisation in MatrixTypes documentation

SaurabhJha added inline comments. Comment at: clang/docs/MatrixTypes.rst:279 +The number of constituent arrays must equal the number rows in the matrix type M and the number of elements +in each constituent array must equal the number of columns in the matrix type. + ---

[PATCH] D105083: [clangd] Ensure Ref::Container refers to an indexed symbol

nridge updated this revision to Diff 360714. nridge marked 3 inline comments as done. nridge added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105083/new/ https://reviews.llvm.org/D105083 Files: clang-tools-e

[clang-tools-extra] f443793 - [clangd] Ensure Ref::Container refers to an indexed symbol

Author: Nathan Ridge Date: 2021-07-22T03:33:40-04:00 New Revision: f443793d26c39a78cfedea5a8cc2ad23e1253d84 URL: https://github.com/llvm/llvm-project/commit/f443793d26c39a78cfedea5a8cc2ad23e1253d84 DIFF: https://github.com/llvm/llvm-project/commit/f443793d26c39a78cfedea5a8cc2ad23e1253d84.diff

[PATCH] D105083: [clangd] Ensure Ref::Container refers to an indexed symbol

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf443793d26c3: [clangd] Ensure Ref::Container refers to an indexed symbol (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D106005: [Docs] Define matrix initialisation in MatrixTypes documentation

SaurabhJha updated this revision to Diff 360716. SaurabhJha added a comment. Address second round of comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106005/new/ https://reviews.llvm.org/D106005 Files: clang/docs/MatrixTypes.rst Index: c

[PATCH] D106527: [clangd] Canonicalize compile flags before applying edits

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: usaxena95, arphaman. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Pushes input for the compile ac

[PATCH] D106344: [PowerPC] Implement XL compatible behavior of __compare_and_swap

lkail updated this revision to Diff 360721. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106344/new/ https://reviews.llvm.org/D106344 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/test/CodeGen/builtins-ppc-xlcompat-cas.c llvm/test/CodeGen/Powe

[PATCH] D105690: [RISCV] Rename assembler mnemonic of unordered floating-point reductions for v1.0-rc change

jacquesguan added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105690/new/ https://reviews.llvm.org/D105690 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D106347: [PoC][RISCV] Encode arch information in a new module flag meatadata 'riscv-isa-bits'.

khchen updated this revision to Diff 360723. khchen added a comment. store target-features string as module flag. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106347/new/ https://reviews.llvm.org/D106347 Files: clang/lib/CodeGen/CodeGenModule.c

[PATCH] D105354: [clang][AST] Add support for DecompositionDecl to ASTImporter.

martong accepted this revision. martong added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/AST/ASTImporter.cpp:2305-2309 + BindingDecl *ToD; + if (GetImportedOrCreateDecl(ToD, D, Importer.getToContext(), DC, Loc, +

[PATCH] D106005: [Docs] Define matrix initialisation in MatrixTypes documentation

fhahn added a comment. Thank you very much for working on this! Are you planning on implementing the new specification as well? It would probably be good to land the update to the spec in close succession to the implementation, to avoid confusing users. Comment at: clang/docs

[PATCH] D106528: [clangd] Improve performance of dex by 45-60%

kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: usaxena95, arphaman. kbobyrev requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Take full advantage of AND's it

[PATCH] D105491: [clang] Use i64 for the !srcloc metadata on asm IR nodes.

simon_tatham added a comment. @lattner, thanks for the help. In this case, the real question is whether there's any use case for `!srcloc` that involves writing it out into a bitcode or IR file and then having a separate instance of clang load it back in again. I think that no such case can pos

[clang-tools-extra] 473eff1 - [clang-tidy] Fix crash and handle AttributedType in 'bugprone-easily-swappable-parameters'

Author: Whisperity Date: 2021-07-22T10:20:17+02:00 New Revision: 473eff1c3057185758bf35f0c052a873b1bdb6a9 URL: https://github.com/llvm/llvm-project/commit/473eff1c3057185758bf35f0c052a873b1bdb6a9 DIFF: https://github.com/llvm/llvm-project/commit/473eff1c3057185758bf35f0c052a873b1bdb6a9.diff LO

[PATCH] D106361: [clang-tidy] Fix crash and handle AttributedTypes in 'bugprone-easily-swappable-parameters'

This revision was automatically updated to reflect the committed changes. Closed by commit rG473eff1c3057: [clang-tidy] Fix crash and handle AttributedType in 'bugprone-easily-swappable… (authored by whisperity). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D106416: [analyzer] Fix build dependency issues for SATest

vsavchenko accepted this revision. vsavchenko added a comment. This revision is now accepted and ready to land. Awesome! Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106416/new/ https://reviews.llvm.org/D106416 __

[PATCH] D106530: [PowerPC] Change altivec indexed load/store builtins argument type

qiucf created this revision. qiucf added reviewers: jsji, nemanjai, shchenz, anhtuyen, PowerPC. Herald added subscribers: arphaman, kbarton. qiucf requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch changes the index argument of `lvx

[PATCH] D105703: [hwasan] Use stack safety analysis.

fmayer updated this revision to Diff 360735. fmayer added a comment. formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105703/new/ https://reviews.llvm.org/D105703 Files: clang/lib/CodeGen/BackendUtil.cpp clang/test/CodeGen/hwasan-stac

[PATCH] D105690: [RISCV] Rename assembler mnemonic of unordered floating-point reductions for v1.0-rc change

frasercrmck added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoV.td:10 /// This file describes the RISC-V instructions from the standard 'V' Vector /// extension, version 0.10. /// This version is still experimental as the 'V' extension hasn't been

[clang] bd41136 - [clang] Use i64 for the !srcloc metadata on asm IR nodes.

Author: Simon Tatham Date: 2021-07-22T10:24:52+01:00 New Revision: bd41136746a0b47882914cee5a8d1ac6714288d1 URL: https://github.com/llvm/llvm-project/commit/bd41136746a0b47882914cee5a8d1ac6714288d1 DIFF: https://github.com/llvm/llvm-project/commit/bd41136746a0b47882914cee5a8d1ac6714288d1.diff

[PATCH] D105491: [clang] Use i64 for the !srcloc metadata on asm IR nodes.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. simon_tatham marked an inline comment as done. Closed by commit rGbd41136746a0: [clang] Use i64 for the !srcloc metadata on asm IR nodes. (authored by simon_tatham). C

[PATCH] D105491: [clang] Use i64 for the !srcloc metadata on asm IR nodes.

simon_tatham added a comment. (But I've pushed this patch anyway, because I'm reasonably confident of the answer; if it turns out that there's some case along those lines that I should have taken care of, I'll fix or revert.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D104601: [Preprocessor] Implement -fminimize-whitespace.

Meinersbur updated this revision to Diff 360745. Meinersbur marked 2 inline comments as done. Meinersbur added a comment. - Error if -fminimize-whitespace is applied to asm files - Join lines with escaped newlines - Added some FIXMEs for grandfathered bugs Repository: rG LLVM Github Monorepo

[PATCH] D106504: [OpenCL] Change default standard version to CL1.2

svenvh added a comment. LGTM, just a small question. Comment at: clang/test/CodeGenOpenCL/spir_version.cl:2 +// RUN: %clang_cc1 %s -triple "spir-unknown-unknown" -emit-llvm -o - -cl-std=CL1.0 | FileCheck %s --check-prefix=CHECK-SPIR-CL10 // RUN: %clang_cc1 %s -triple "spir-un

[PATCH] D106535: [clangd] Use CommandMangler in TestTU

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: usaxena95, arphaman. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added projects: clang, clang-tools-extra. This makes testing setup

[PATCH] D106535: [clangd] Use CommandMangler in TestTU

sammccall added a comment. I guess this is technically untested, but will be covered after D106527 ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106535/new/ https://reviews.llvm.org/D106535

[clang] aa245dd - [clang][lex] NFC: Add explicit cast to silence -Wsign-compare

Author: Jan Svoboda Date: 2021-07-22T12:21:12+02:00 New Revision: aa245ddd4627c98083eb372b95e049073aeb36d2 URL: https://github.com/llvm/llvm-project/commit/aa245ddd4627c98083eb372b95e049073aeb36d2 DIFF: https://github.com/llvm/llvm-project/commit/aa245ddd4627c98083eb372b95e049073aeb36d2.diff L

[PATCH] D104601: [Preprocessor] Implement -fminimize-whitespace.

Meinersbur added a comment. I compiled the Linux kernel (default config, excludes most drivers. Takes ~18mins to compile) and indeed found two problems: 1. Linux contains `assembler-with-cpp` files. When compiling with clang, it processes it with `-E` before passing the result to `as`. There ar

[PATCH] D104601: [Preprocessor] Implement -fminimize-whitespace.

Meinersbur updated this revision to Diff 360753. Meinersbur added a comment. - Revert test changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104601/new/ https://reviews.llvm.org/D104601 Files: clang/docs/ClangCommandLineReference.rst clang

[PATCH] D106518: [RISCV] Disable EEW=64 for index values when XLEN=32.

frasercrmck added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:555 +defvar Xlen32EEWList = [["8", "(Log2EEW:3)"], +["16", "(Log2EEW:4)"], jrtc27 wrote: > Ignoring whether the change is actually correct, this sho

Re: [PATCH] D106535: [clangd] Use CommandMangler in TestTU

yes that's right. On Thu, Jul 22, 2021 at 12:20 PM Sam McCall via Phabricator < revi...@reviews.llvm.org> wrote: > sammccall added a comment. > > I guess this is technically untested, but will be covered after D106527 < > https://reviews.llvm.org/D106527>? > > > Repository: > rG LLVM Github Mon

[PATCH] D106371: [AIX] Generate large code model relocations when mcmodel=medium on AIX

xgupta added a comment. In D106371#2894736 , @anjankgk wrote: > Anjan Kumar Guttahalli Krishna > > Thank you! Seems you are contributing with an official mail, I think you can ask for commit access, if you want to continue contributing, bar is quite lo

[PATCH] D106527: [clangd] Canonicalize compile flags before applying edits

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/CompileCommands.cpp:210 + if (!ArgList.hasArgNoClaim(driver::options::OPT__DASH_DASH)) { +// In theory there might be more

[clang] 41adc09 - [clang][AST] Add support for DecompositionDecl to ASTImporter.

Author: Balázs Kéri Date: 2021-07-22T13:09:42+02:00 New Revision: 41adc09b221170065e227f43c7fd21ffce5e2a6e URL: https://github.com/llvm/llvm-project/commit/41adc09b221170065e227f43c7fd21ffce5e2a6e DIFF: https://github.com/llvm/llvm-project/commit/41adc09b221170065e227f43c7fd21ffce5e2a6e.diff L

[PATCH] D105354: [clang][AST] Add support for DecompositionDecl to ASTImporter.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG41adc09b2211: [clang][AST] Add support for DecompositionDecl to ASTImporter. (authored by balazske). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D106266: [C++4OpenCL] Add run line standard aliases clc++1.0 and CLC++1.0

teemperor added a comment. Quick note to prevent some confusion: I saw this patch and realized that the LLDB change was only necessary because some Clang code got copy pasted into LLDB. I removed that copy in https://reviews.llvm.org/D106537 so if you see merge conflicts while merging this, you

[clang] bde9415 - [hwasan] Use stack safety analysis.

Author: Florian Mayer Date: 2021-07-22T12:04:54+01:00 New Revision: bde9415fef25e9ff6e10595a2f4f5004dd62f10a URL: https://github.com/llvm/llvm-project/commit/bde9415fef25e9ff6e10595a2f4f5004dd62f10a DIFF: https://github.com/llvm/llvm-project/commit/bde9415fef25e9ff6e10595a2f4f5004dd62f10a.diff

[PATCH] D105703: [hwasan] Use stack safety analysis.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. fmayer marked 4 inline comments as done. Closed by commit rGbde9415fef25: [hwasan] Use stack safety analysis. (authored by fmayer). Changed prior to commit: https://

[PATCH] D106518: [RISCV] Disable EEW=64 for index values when XLEN=32.

jacquesguan added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:555 +defvar Xlen32EEWList = [["8", "(Log2EEW:3)"], +["16", "(Log2EEW:4)"], frasercrmck wrote: > jrtc27 wrote: > > Ignoring whether the change is act

[PATCH] D106504: [OpenCL] Change default standard version to CL1.2

Anastasia added inline comments. Comment at: clang/test/CodeGenOpenCL/spir_version.cl:2 +// RUN: %clang_cc1 %s -triple "spir-unknown-unknown" -emit-llvm -o - -cl-std=CL1.0 | FileCheck %s --check-prefix=CHECK-SPIR-CL10 // RUN: %clang_cc1 %s -triple "spir-unknown-unknown" -emit-l

[clang] 789a4a2 - Revert "[hwasan] Use stack safety analysis."

Author: Florian Mayer Date: 2021-07-22T12:16:16+01:00 New Revision: 789a4a2e5c30b3eee632446d5b99bba808587836 URL: https://github.com/llvm/llvm-project/commit/789a4a2e5c30b3eee632446d5b99bba808587836 DIFF: https://github.com/llvm/llvm-project/commit/789a4a2e5c30b3eee632446d5b99bba808587836.diff

[PATCH] D105703: [hwasan] Use stack safety analysis.

fmayer reopened this revision. fmayer added a comment. This revision is now accepted and ready to land. Sorry. broke a buildbot again: https://lab.llvm.org/buildbot/#/builders/139/builds/7613/steps/6/logs/FAIL__Clang__asan_c I am not sure why I cannot reproduce this locally. Pass 'HWAddressSa

[PATCH] D99436: [OPENMP]Fix PR49366: crash on VLAs in task untied regions.

ABataev added a comment. Better to fix this before the next release. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99436/new/ https://reviews.llvm.org/D99436 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D106266: [C++4OpenCL] Add run line standard aliases clc++1.0 and CLC++1.0

Topotuna added a comment. That is good to know. Thank you for sorting it out CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106266/new/ https://reviews.llvm.org/D106266 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

[PATCH] D99350: [OPENMP]Fix PR49649: The introduction of $ref globals is not always valid.

ABataev added a comment. Better to fix this before the next release. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99350/new/ https://reviews.llvm.org/D99350 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D105297: [OPENMP]Fix PR50347: Mapping of global scope deep object fails.

ABataev added a comment. Better to fix this before the next release. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105297/new/ https://reviews.llvm.org/D105297 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D105151: [OPENMP]Fix PR50733: unexpected final value of list-item in linear clause in loop construct.

ABataev added a comment. If the problem exists, better to fix it before the next release. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105151/new/ https://reviews.llvm.org/D105151 ___ cfe-commits mailin

[PATCH] D106504: [OpenCL] Change default standard version to CL1.2

svenvh accepted this revision. svenvh added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/CodeGenOpenCL/spir_version.cl:2 +// RUN: %clang_cc1 %s -triple "spir-unknown-unknown" -emit-llvm -o - -cl-std=CL1.0 | FileCheck %s --check-prefix=

[PATCH] D106005: [Docs] Define matrix initialisation in MatrixTypes documentation

SaurabhJha added a comment. In D106005#2895716 , @fhahn wrote: > Thank you very much for working on this! Are you planning on implementing the > new specification as well? It would probably be good to land the update to > the spec in close succession to

[PATCH] D104931: [AArch64] Wire up ILP32 ABI support in Clang

Amanieu added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104931/new/ https://reviews.llvm.org/D104931 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D106527: [clangd] Canonicalize compile flags before applying edits

sammccall added inline comments. Comment at: clang-tools-extra/clangd/CompileCommands.cpp:210 + if (!ArgList.hasArgNoClaim(driver::options::OPT__DASH_DASH)) { +// In theory there might be more than one input, but clangd can't deal with +// them anyway. s

[PATCH] D104601: [Preprocessor] Implement -fminimize-whitespace.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D104601#2895941 , @Meinersbur wrote: > I compiled the Linux kernel (default config, excludes most drivers. Takes > ~18mins to compil

[PATCH] D106434: [OpenCL] Add cl_khr_integer_dot_product

stuart accepted this revision. stuart added a comment. LGTM, too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106434/new/ https://reviews.llvm.org/D106434 ___ cfe-commits mailing list cfe-commits@lists

[clang] b9b696b - [clang][fpenv][patch] Change clang option -ffp-model=precise to select ffp-contract=on

Author: Melanie Blower Date: 2021-07-22T07:59:18-04:00 New Revision: b9b696bba6702a31ac0995a494cd31c730ade5ec URL: https://github.com/llvm/llvm-project/commit/b9b696bba6702a31ac0995a494cd31c730ade5ec DIFF: https://github.com/llvm/llvm-project/commit/b9b696bba6702a31ac0995a494cd31c730ade5ec.diff

[PATCH] D74436: Change clang option -ffp-model=precise to select ffp-contract=on

This revision was automatically updated to reflect the committed changes. Closed by commit rGb9b696bba670: [clang][fpenv][patch] Change clang option -ffp-model=precise to select ffp… (authored by mibintc). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D105555: [PoC][RISCV][Clang] Compute the default target-abi if it's empty.

asb added a comment. This looks like a good improvement to me - anything that still makes it a "[PoC]" proof of concept? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D10/new/ https://reviews.llvm.org/D10 __

[PATCH] D106504: [OpenCL] Change default standard version to CL1.2

azabaznov added inline comments. Comment at: clang/test/Parser/opencl-atomics-cl20.cl:7 -#if defined(__OPENCL_CPP_VERSION__) || __OPENCL_C_VERSION__ >= CL_VERSION_1_2 +#if defined(__OPENCL_CPP_VERSION__) || __OPENCL_C_VERSION__ >= CL_VERSION_2_0 #define LANG_VER_OK ---

[PATCH] D103938: Diagnose -Wunused-value in constant evaluation context

aaron.ballman added inline comments. Comment at: clang/test/Sema/i-c-e.c:77-78 + // expected-warning {{expression result unused}} +int comma3[(1, 2)]; // expected-warning {{variable length array folded to constant array as an extension}} \ +

[PATCH] D106349: [clang-format] respect AfterEnum for enums

m1cha updated this revision to Diff 360776. m1cha edited the summary of this revision. m1cha added a comment. - rebased to `main` - fixed the test `IndentAccessModifiers` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106349/new/ https://reviews.llvm.org/D106349 Files: clang/lib/Forma

[PATCH] D105555: [PoC][RISCV][Clang] Compute the default target-abi if it's empty.

arichardson added inline comments. Comment at: llvm/include/llvm/Support/TargetParser.h:177 StringRef resolveTuneCPUAlias(StringRef TuneCPU, bool IsRV64); +StringRef computeABIByArch(bool HasD, bool HasE, bool IsRV64); Maybe this should be `computeDefaultABIFr

[PATCH] D106216: Disallow narrowing conversions to bool in explicit specififers.

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:5638 ImplicitConversionSequence ICS = - CCE == Sema::CCEK_ExplicitBool - ? TryContextuallyConvertToBool(S, From) - : TryCopyInitialization(S, From, T, -

[PATCH] D106431: [clang-tidy] Fix cppcoreguidelines-init-variables with enum judgement

Sockke added a comment. At present, Our views on preventing UB are basically the same, so a warning still needs to be reported (BTW, the original version will not report warnings for enum class types). The final question is what is the recommended value for initialization and whether to provide

[PATCH] D106084: [DebugInfo] Switch to using constructor homing (-debug-info-kind=constructor) by default when debug info is enabled

probinson added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:1636 +if (Opts.getDebugInfo() == codegenoptions::DebugInfoConstructor) + Opts.setDebugInfo(codegenoptions::LimitedDebugInfo); No... you want to check both options in

[clang] 6bb042e - Implement _ExtInt conversion rules

Author: Aaron Ballman Date: 2021-07-22T09:10:36-04:00 New Revision: 6bb042e70024354acc65457e153b40d50cada4f5 URL: https://github.com/llvm/llvm-project/commit/6bb042e70024354acc65457e153b40d50cada4f5 DIFF: https://github.com/llvm/llvm-project/commit/6bb042e70024354acc65457e153b40d50cada4f5.diff

[PATCH] D106431: [clang-tidy] Fix cppcoreguidelines-init-variables with enum judgement

whisperity added a comment. The problem with enums is that translating //zero// (0, 0.0, nullptr, etc...) to the enum case is not always apparent. A warning **should** always be given. And //if// you can find a zero member in the enum, we can report an automated suggestion for that. To give an

[PATCH] D105997: Implement _ExtInt conversion rules

aaron.ballman closed this revision. aaron.ballman added a comment. Thanks for the reviews; I've committed in 6bb042e70024354acc65457e153b40d50cada4f5 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105997/new/ https:

[PATCH] D106542: [OPENMP]Fix PR49787: Codegen for calling __tgt_target_teams_nowait_mapper has too few arguments.

ABataev created this revision. ABataev added reviewers: jdoerfert, mikerice, jyu2. Herald added subscribers: guansong, yaxunl. ABataev requested review of this revision. Herald added subscribers: llvm-commits, sstefan1. Herald added projects: clang, LLVM. Added missed arguments in __tgt_target_tea

[PATCH] D105821: [analyzer] [WIP] Model destructor for std::unique_ptr

RedDocMD added a comment. > But before we go there we should decide whether we want to actually go for > inlining (or otherwise default-evaluating) these destructors. If we do, we > should probably not spend too much time on improving invalidation in the > checker, because default evaluation wo

[PATCH] D103385: [clang-tidy] bugprone-forwarding-reference-overload: support non-type template parameters

jwtowner added a comment. Friendly bump in case this was missed. Without this fix, bugprone-forwarding-reference-overload is not currently usable in a lot of codebases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103385/new/ https://reviews.llv

[clang] 4296d63 - Revert "[clang][fpenv][patch] Change clang option -ffp-model=precise to select ffp-contract=on"

Author: Melanie Blower Date: 2021-07-22T09:40:54-04:00 New Revision: 4296d633b08dcfc5bfb2df0800995df4b30ac196 URL: https://github.com/llvm/llvm-project/commit/4296d633b08dcfc5bfb2df0800995df4b30ac196 DIFF: https://github.com/llvm/llvm-project/commit/4296d633b08dcfc5bfb2df0800995df4b30ac196.diff

[PATCH] D74436: Change clang option -ffp-model=precise to select ffp-contract=on

mibintc reopened this revision. mibintc added a comment. This revision is now accepted and ready to land. I had to revert again, it's still failing on Intel buildbots. Cannot reproduce on Intel-internal Broadwell server. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D103385: [clang-tidy] bugprone-forwarding-reference-overload: support non-type template parameters

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Thank you for the ping, this fell off my radar. LGTM aside from some small nits. Comment at: clang-tools-extra/docs/clang-tidy/checks/bugprone-forwarding-refer

[PATCH] D105690: [RISCV] Rename assembler mnemonic of unordered floating-point reductions for v1.0-rc change

kito-cheng added inline comments. Comment at: llvm/test/MC/RISCV/rvv/aliases.s:86 +# NO-ALIAS: vfwredusum.vs v8, v4, v20, v0.t # encoding: [0x57,0x14,0x4a,0xc4] +vfwredusum.vs v8, v4, v20, v0.t I guess you want to verify `vfredsum.vs` and `vfwredsum.vs` here?

[PATCH] D106431: [clang-tidy] Fix cppcoreguidelines-init-variables with enum judgement

aaron.ballman added a comment. In D106431#2896206 , @whisperity wrote: > The problem with enums is that translating //zero// (0, 0.0, nullptr, etc...) > to the enum case is not always apparent. A warning **should** always be > given. And //if// you can

[PATCH] D106509: [OpenMP][OpenACC] Implement `hold` map type modifier extension in Clang (1/2)

ABataev added a comment. That's strange that we need to ignore `delete` modifier, I would say that most probably there is a bug in the user's code. > Questions: > Clang currently doesn't support OpenMP 5.1 features unless > -fopenmp-version=51. Does it make sense to have an option to enable

[PATCH] D106442: [clang-tidy] Improve "common type" diagnostic output in 'bugprone-easily-swappable-parameters'

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106442/new/ https://reviews.llvm.org/D106442

[PATCH] D106528: [clangd] Improve performance of dex by 45-60%

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Nice find! Comment at: clang-tools-extra/clangd/index/dex/Iterator.cpp:91 /// sync. void sync() { ReachedEnd |= Children.front()->reachedEnd(); -

[PATCH] D106431: [clang-tidy] Fix cppcoreguidelines-init-variables with enum judgement

whisperity added a comment. In D106431#2896334 , @aaron.ballman wrote: > In D106431#2896206 , @whisperity > wrote: > >> The problem with enums is that translating //zero// (0, 0.0, nullptr, >> etc...) to the en

[PATCH] D106484: [PowerPC] Add PowerPC "__stbcx" builtin and intrinsic for XL compatibility

NeHuang updated this revision to Diff 360803. NeHuang added a comment. - Addressed review comments from Lei - Rebased the patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106484/new/ https://reviews.llvm.org/D106484 Files: clang/include/clang

[PATCH] D106484: [PowerPC] Add PowerPC "__stbcx" builtin and intrinsic for XL compatibility

NeHuang marked an inline comment as done. NeHuang added inline comments. Comment at: clang/test/CodeGen/builtins-ppc-xlcompat-pwr8.c:31 + return __builtin_ppc_stbcx(c_addr, c); +} lei wrote: > Why not just add this tc to > `clang/test/CodeGen/builtins-ppc-xlcom

[PATCH] D106509: [OpenMP][OpenACC] Implement `hold` map type modifier extension in Clang (1/2)

jdoerfert added a comment. I would propose we prefix these new clauses and such with `ompx_`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106509/new/ https://reviews.llvm.org/D106509 ___ cfe-commits ma

[PATCH] D106509: [OpenMP][OpenACC] Implement `hold` map type modifier extension in Clang (1/2)

ABataev added a comment. In D106509#2896398 , @jdoerfert wrote: > I would propose we prefix these new clauses and such with `ompx_`. +1 here Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106509/new/ https

[PATCH] D106542: [OPENMP]Fix PR49787: Codegen for calling __tgt_target_teams_nowait_mapper has too few arguments.

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG, thx Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106542/new/ https://reviews.llvm.org/D106542 __

[PATCH] D106484: [PowerPC] Add PowerPC "__stbcx" builtin and intrinsic for XL compatibility

nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land. LGTM aside from a small nit. Comment at: clang/lib/Basic/Targets/PPC.cpp:124 Builder.defineMacro("__stfiw", "__builtin_ppc_stfiw"); + Builder.defineMacro("__stbcx", "

[PATCH] D106484: [PowerPC] Add PowerPC "__stbcx" builtin and intrinsic for XL compatibility

Conanap added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:3437 case PPC::BI__builtin_ppc_icbt: + case PPC::BI__builtin_ppc_stbcx: return SemaFeatureCheck(*this, TheCall, "isa-v207-instructions", would prefer if this joined the list of `s

[PATCH] D105690: [RISCV] Rename assembler mnemonic of unordered floating-point reductions for v1.0-rc change

HsiangKai added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoV.td:10 /// This file describes the RISC-V instructions from the standard 'V' Vector /// extension, version 0.10. /// This version is still experimental as the 'V' extension hasn't been --

[clang] 9ce931b - [HIP] Fix no matching constructor for init of shared_ptr and malloc

Author: Aaron En Ye Shi Date: 2021-07-22T14:32:41Z New Revision: 9ce931bd71855ced2146f77120df07e4bf381cec URL: https://github.com/llvm/llvm-project/commit/9ce931bd71855ced2146f77120df07e4bf381cec DIFF: https://github.com/llvm/llvm-project/commit/9ce931bd71855ced2146f77120df07e4bf381cec.diff LO

[PATCH] D106463: [HIP] Fix no matching constructor for init of shared_ptr and malloc

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9ce931bd7185: [HIP] Fix no matching constructor for init of shared_ptr and malloc (authored by ashi1). Herald added a project: clang. Herald added a

[PATCH] D106431: [clang-tidy] Fix cppcoreguidelines-init-variables with enum judgement

aaron.ballman added a comment. In D106431#2896367 , @whisperity wrote: > In D106431#2896334 , @aaron.ballman > wrote: > >> In D106431#2896206 , @whisperity >> wrote: >>

[PATCH] D106550: [PowerPC] Allow MMA builtins to accpet restrict qualified pointers

saghir created this revision. Herald added subscribers: steven.zhang, shchenz, kbarton, nemanjai. saghir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch allows MMA builtins on PowerPC to accept restrict qualified pointers. Repo

[PATCH] D106344: [PowerPC] Implement XL compatible behavior of __compare_and_swap

jsji accepted this revision as: jsji. jsji added a comment. This revision is now accepted and ready to land. > that looks like a historical issue which exists for 13yrs Hmm... OK.. Let us leave it as it is for now. Thanks for the new tests. Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] b455f7f - [OPENMP]Fix PR49787: Codegen for calling __tgt_target_teams_nowait_mapper has too few arguments.

Author: Alexey Bataev Date: 2021-07-22T07:53:37-07:00 New Revision: b455f7f22564a096c043b02fa159ab16669c121c URL: https://github.com/llvm/llvm-project/commit/b455f7f22564a096c043b02fa159ab16669c121c DIFF: https://github.com/llvm/llvm-project/commit/b455f7f22564a096c043b02fa159ab16669c121c.diff

[PATCH] D106542: [OPENMP]Fix PR49787: Codegen for calling __tgt_target_teams_nowait_mapper has too few arguments.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb455f7f22564: [OPENMP]Fix PR49787: Codegen for calling __tgt_target_teams_nowait_mapper has… (authored by ABataev). Repository: rG LLVM Github Mon

[PATCH] D106431: [clang-tidy] Fix cppcoreguidelines-init-variables with enum judgement

whisperity added a comment. In D106431#2896441 , @aaron.ballman wrote: > However, I don't recall how clang-tidy interacts with fix-its on notes off > the top of my head, so I'm making an assumption that clang-tidy's automatic > fixit applying mode hand

[PATCH] D106375: Thread safety analysis: Mock getter for private mutexes can be undefined

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! It took me a minute to convince myself it wasn't really an ODR use (the argument goes through the usual expression evaluation parsing and sema bits), but because the argume

[PATCH] D106431: [clang-tidy] Fix cppcoreguidelines-init-variables with enum judgement

aaron.ballman added a comment. In D106431#2896472 , @whisperity wrote: > In D106431#2896441 , @aaron.ballman > wrote: > >> However, I don't recall how clang-tidy interacts with fix-its on notes off >> the top o

[PATCH] D106542: [OPENMP]Fix PR49787: Codegen for calling __tgt_target_teams_nowait_mapper has too few arguments.

JonChesterfield added a comment. Nice, thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106542/new/ https://reviews.llvm.org/D106542 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[PATCH] D95588: [RISCV] Implement the MC layer support of P extension

Jim added a comment. ping? Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95588/new/ https://reviews.llvm.org/D95588 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[clang] f828f0a - Revert "[OPENMP]Fix PR49787: Codegen for calling __tgt_target_teams_nowait_mapper has too few arguments."

Author: Alexey Bataev Date: 2021-07-22T08:06:29-07:00 New Revision: f828f0a90fb14d10dbb5ac2d55c62d9dafdf8721 URL: https://github.com/llvm/llvm-project/commit/f828f0a90fb14d10dbb5ac2d55c62d9dafdf8721 DIFF: https://github.com/llvm/llvm-project/commit/f828f0a90fb14d10dbb5ac2d55c62d9dafdf8721.diff

[PATCH] D106277: [SVE] Remove the interface for getMaxVScale in favour of the IR attributes

craig.topper added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:504 VScale, VScale)); + } else if (getContext().getTargetInfo().hasFeature("sve")) { +CurFn->addFnAttr( Is the

  1   2   3   >