sammccall added inline comments.
================
Comment at: clang-tools-extra/clangd/CompileCommands.cpp:210
+ if (!ArgList.hasArgNoClaim(driver::options::OPT__DASH_DASH)) {
+ // In theory there might be more than one input, but clangd can't deal with
+ // them anyway.
----------------
sammccall wrote:
> More than one input is a really annoying error to diagnose, would we want to
> detect and log it here? Downside is this code runs *really* often.
Another option would be to delete all the OPT_INPUTs and append the actual
filename (CompileCommand::Filename)
This seems like it would define this class of errors out of existence, maybe?
Layering doesn't make it easy to do that right here, though :-\
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D106527/new/
https://reviews.llvm.org/D106527
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
