aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
Thank you for the ping, this fell off my radar. LGTM aside from some small nits.
================
Comment at:
clang-tools-extra/docs/clang-tidy/checks/bugprone-forwarding-reference-overload.rst:34
+ template<typename... A,
+ enable_if_t<is_constructible_v<tuple<string,int>,A&&...>,int> = 0>
+ explicit Person(A&&... a) {}
----------------
================
Comment at:
clang-tools-extra/docs/clang-tidy/checks/bugprone-forwarding-reference-overload.rst:56
+constructor is guarded.
\ No newline at end of file
----------------
Can you add the newline back?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D103385/new/
https://reviews.llvm.org/D103385
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
