[PATCH] D106136: [Analyzer][solver] Fix equivalence class invariant violation in removeDeadBindings

martong abandoned this revision. martong added a comment. In D106136#2883707 , @vsavchenko wrote: > In D106136#2883100 , @martong wrote: > >> Thanks for taking your time to take a look. And I accept your statemen

[PATCH] D106347: [PoC][RISCV] Encode arch information in a new module flag meatadata 'riscv-isa-bits'.

khchen created this revision. khchen added reviewers: jrtc27, MaskRay, kito-cheng. Herald added subscribers: vkmr, frasercrmck, dexonsmith, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng,

[PATCH] D103873: [Clang][RISCV] Implement vsoxseg and vsuxseg.

HsiangKai updated this revision to Diff 360042. HsiangKai added a comment. Remove RV32 test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103873/new/ https://reviews.llvm.org/D103873 Files: clang/include/clang/Basic/riscv_vector.td clan

[PATCH] D104904: [OpenMP][AMDGCN] Initial math headers support

JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. D105221 so LGTM too Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104904/new/ https://revie

[PATCH] D106296: [analyzer] Fix for faulty namespace test in SmartPtrModelling

vsavchenko added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:254-257 + const auto *Decl = Call.getDecl(); + if (!Decl) +return false; + if (!Decl->getDeclContext()->isStdNamespace()) I think you can have a separate f

[PATCH] D106136: [Analyzer][solver] Fix equivalence class invariant violation in removeDeadBindings

vsavchenko added a comment. In D106136#2889610 , @martong wrote: > In D106136#2883707 , @vsavchenko > wrote: > >> In D106136#2883100 , @martong >> wrote: >> >>> Thanks f

[PATCH] D106285: [Analyzer][solver] Fix inconsistent equivalence class data

vsavchenko added a comment. Ah, I see now! I think we could've put together a somewhat easier test knowing what's wrong, but it's not important at all. Thanks for addressing this issue! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106285/new/ ht

[PATCH] D106296: [analyzer] Fix for faulty namespace test in SmartPtrModelling

vsavchenko added a comment. Also, I tested this fix on a set of open-source projects and I don't see any problems. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106296/new/ https://reviews.llvm.org/D106296

[PATCH] D106349: [clang-format] respect AfterEnum for enums

m1cha created this revision. m1cha added a reviewer: MyDeveloperDay. m1cha requested review of this revision. Herald added a project: clang. See the commit message for more details. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D106349 Files: clang/lib/Format/UnwrappedLinePa

[PATCH] D106349: [clang-format] respect AfterEnum for enums

m1cha added a comment. I just noticed that phabricator strips the commit message so here it is: There is some similar looking code in `TokenAnnotator.cpp` but given that I've never worked on clang-format before I don't know what the purpose of that code is and how it's related to `UnwrappedLinePa

[PATCH] D106296: [analyzer] Fix for faulty namespace test in SmartPtrModelling

RedDocMD updated this revision to Diff 360051. RedDocMD added a comment. Refactored out check Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106296/new/ https://reviews.llvm.org/D106296 Files: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cp

[PATCH] D105491: [clang] Use i64 for the !srcloc metadata on asm IR nodes.

simon_tatham added a comment. I looked into this yesterday, and realised that I don't actually know what the use case //is// for emitting `!srcloc` metadata in an IR file. It's more or less ignored by llc, as far as I can see: if there's a late-breaking error in the inline asm string, you just

[PATCH] D106296: [analyzer] Fix for faulty namespace test in SmartPtrModelling

vsavchenko added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:252-255 + const auto *Decl = Call.getDecl(); + if (!Decl) +return false; + return Decl->getDeclContext()->isStdNamespace(); Can we use a one-liner that I s

[PATCH] D105703: [hwasan] Use stack safety analysis.

fmayer updated this revision to Diff 360054. fmayer marked an inline comment as done. fmayer added a comment. format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105703/new/ https://reviews.llvm.org/D105703 Files: clang/lib/CodeGen/BackendUtil.

[PATCH] D104797: [WebAssembly] Implementation of global.get/set for reftypes in LLVM IR

pmatos updated this revision to Diff 360055. pmatos added a comment. Rebase on top of main and add non-integral address spaces to emscripten OS Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104797/new/ https://reviews.llvm.org/D104797 Files: cla

[clang] e9c63ed - [hwasan] Use stack safety analysis.

Author: Florian Mayer Date: 2021-07-20T10:06:35+01:00 New Revision: e9c63ed10b3bdf6eb3fa76d1a3eb403d6fc6a118 URL: https://github.com/llvm/llvm-project/commit/e9c63ed10b3bdf6eb3fa76d1a3eb403d6fc6a118 DIFF: https://github.com/llvm/llvm-project/commit/e9c63ed10b3bdf6eb3fa76d1a3eb403d6fc6a118.diff

[PATCH] D105703: [hwasan] Use stack safety analysis.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe9c63ed10b3b: [hwasan] Use stack safety analysis. (authored by fmayer). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D106266: [C++4OpenCL] Add run line standard aliases clc++1.0 and CLC++1.0

Topotuna updated this revision to Diff 360059. Topotuna added a comment. `clc++` made no longer deprecated CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106266/new/ https://reviews.llvm.org/D106266 Files: clang/docs/UsersManual.rst clang/include/clang/Basic/LangStandards.def clan

[PATCH] D106266: [C++4OpenCL] Add run line standard aliases clc++1.0 and CLC++1.0

Topotuna added inline comments. Comment at: clang/include/clang/Basic/LangStandards.def:187 Digraphs | HexFloat | OpenCL) +LANGSTANDARD_ALIAS_DEPR(openclcpp10, "clc++") Anastasia wrote: > I am not sure we should move it into the deprecated categor

[clang] 63fd109 - [clang][deps] Normalize ignored filenames in minimizing file system

Author: Jan Svoboda Date: 2021-07-20T11:31:31+02:00 New Revision: 63fd109d3aa6db48e38e1c78f6084ad257f2c37d URL: https://github.com/llvm/llvm-project/commit/63fd109d3aa6db48e38e1c78f6084ad257f2c37d DIFF: https://github.com/llvm/llvm-project/commit/63fd109d3aa6db48e38e1c78f6084ad257f2c37d.diff L

[PATCH] D106064: [clang][deps] Normalize ignored filenames in minimizing file system

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG63fd109d3aa6: [clang][deps] Normalize ignored filenames in minimizing file system (authored by jansvoboda11). Changed prior to commit: https://rev

[clang] 5f08219 - Revert "[hwasan] Use stack safety analysis."

Author: Florian Mayer Date: 2021-07-20T10:36:46+01:00 New Revision: 5f08219322456b867605e4a19003f58ee418758f URL: https://github.com/llvm/llvm-project/commit/5f08219322456b867605e4a19003f58ee418758f DIFF: https://github.com/llvm/llvm-project/commit/5f08219322456b867605e4a19003f58ee418758f.diff

[PATCH] D105819: [analyzer] MallocChecker: Add a visitor to leave a note on functions that could have, but did not change ownership on leaked memory

Szelethus added a comment. An ever so gentle ping :^) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105819/new/ https://reviews.llvm.org/D105819 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/li

[PATCH] D105703: [hwasan] Use stack safety analysis.

fmayer reopened this revision. fmayer added a comment. This revision is now accepted and ready to land. Made some buildbot unhappy again. Sorry :( Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105703/new/ https://reviews.llvm.org/D105703 _

[PATCH] D106333: [AArch64][SVE] Handle svbool_t VLST <-> VLAT/GNUT conversion

junparser added a comment. In D106333#2889168 , @junparser wrote: > @efriedma with this patch, all of conversion between VLST and VLAT should > have same vector size(getElementType() * getElementCount()). The regression > in D105097

[PATCH] D106296: [analyzer] Fix for faulty namespace test in SmartPtrModelling

RedDocMD updated this revision to Diff 360061. RedDocMD added a comment. More refactor Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106296/new/ https://reviews.llvm.org/D106296 Files: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp cla

[PATCH] D106296: [analyzer] Fix for faulty namespace test in SmartPtrModelling

RedDocMD added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:252-255 + const auto *Decl = Call.getDecl(); + if (!Decl) +return false; + return Decl->getDeclContext()->isStdNamespace(); vsavchenko wrote: > Can we use a

[PATCH] D106296: [analyzer] Fix for faulty namespace test in SmartPtrModelling

vsavchenko added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:252 +static bool isStdFunctionCall(const CallEvent &Call) { + return Call.getDecl() && Call.getDecl() ->getDeclContext()->isStdNamespace(); +} nit: there's an ex

[PATCH] D106262: [clang][analyzer] Use generic note tag in alpha.unix.Stream .

Szelethus added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:380-391 +if (BT == &BT_UseAfterClose) + Message = "Stream closed here"; +else if (BT == &BT_UseAfterOpenFailed) + Message = "Assuming opening the stream fails here";

[PATCH] D106296: [analyzer] Fix for faulty namespace test in SmartPtrModelling

RedDocMD added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:252 +static bool isStdFunctionCall(const CallEvent &Call) { + return Call.getDecl() && Call.getDecl() ->getDeclContext()->isStdNamespace(); +} vsavchenko wrote: >

[PATCH] D106296: [analyzer] Fix for faulty namespace test in SmartPtrModelling

RedDocMD updated this revision to Diff 360064. RedDocMD added a comment. Removed unnecessary white space Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106296/new/ https://reviews.llvm.org/D106296 Files: clang/lib/StaticAnalyzer/Checkers/SmartPtr

[PATCH] D106005: [Docs] Define matrix initialisation in MatrixTypes documentation

fhahn added inline comments. Comment at: clang/docs/MatrixTypes.rst:271 +- +An empty value of a matrix type M can be initialised using this syntax: + is there a reason we need to allow 'empty' initialisation? What does it mean? Repository:

[PATCH] D106333: [AArch64][SVE] Handle svbool_t VLST <-> VLAT/GNUT conversion

paulwalker-arm added a comment. In D106333#2889168 , @junparser wrote: > @efriedma with this patch, all of conversion between VLST and VLAT should > have same vector size(getElementType() * getElementCount()). The regression > in D105097

[PATCH] D106111: opencl-c.h: add initial CL 3.0 conditionals for atomic operations.

azabaznov added a comment. You also need to guard //memory_order_seq_cst// enum entry. Note that //memory_order_acq_rel// is always defined as it can be used in //atomic_work_item_fence()// built-in function, AFAIR in all other cases if //memory_order_acq_rel// is used without //__opencl_c_atom

[PATCH] D106296: [analyzer] Fix for faulty namespace test in SmartPtrModelling

vsavchenko accepted this revision. vsavchenko added a comment. Great, LGTM! But let's wait for @xazax.hun anyways Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106296/new/ https://reviews.llvm.org/D106296 __

[clang] bc1a297 - [clang][deps] Separate filesystem caches for minimized and original files

Author: Jan Svoboda Date: 2021-07-20T12:08:46+02:00 New Revision: bc1a2979fc70d954ae97122205c71c8404a1b17e URL: https://github.com/llvm/llvm-project/commit/bc1a2979fc70d954ae97122205c71c8404a1b17e DIFF: https://github.com/llvm/llvm-project/commit/bc1a2979fc70d954ae97122205c71c8404a1b17e.diff L

[PATCH] D106146: [clang][deps] Separate filesystem caches for minimized and original files

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbc1a2979fc70: [clang][deps] Separate filesystem caches for minimized and original files (authored by jansvoboda11). Changed prior to commit: https

[PATCH] D106333: [AArch64][SVE] Handle svbool_t VLST <-> VLAT/GNUT conversion

junparser added a comment. In D106333#2889859 , @paulwalker-arm wrote: > In D106333#2889168 , @junparser > wrote: > >> @efriedma with this patch, all of conversion between VLST and VLAT should >> have same vec

[clang] e564fd9 - [clang][deps] Avoid minimizing PCH input files

Author: Jan Svoboda Date: 2021-07-20T12:20:10+02:00 New Revision: e564fd93ab85d1810e0d83e961ccc8b99025ff34 URL: https://github.com/llvm/llvm-project/commit/e564fd93ab85d1810e0d83e961ccc8b99025ff34 DIFF: https://github.com/llvm/llvm-project/commit/e564fd93ab85d1810e0d83e961ccc8b99025ff34.diff L

[PATCH] D104536: [clang][deps] Avoid minimizing PCH input files

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe564fd93ab85: [clang][deps] Avoid minimizing PCH input files (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D106339: Add support to generate Sphinx DOCX documentation

t-tye created this revision. t-tye added a reviewer: scott.linder. Herald added subscribers: libcxx-commits, mgorny. Herald added a reviewer: bollu. Herald added a reviewer: MaskRay. Herald added a reviewer: sscalpone. Herald added a project: libunwind. Herald added a reviewer: libunwind. t-tye req

[PATCH] D105703: [hwasan] Use stack safety analysis.

fmayer updated this revision to Diff 360076. fmayer added a comment. fix required analysis logic Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105703/new/ https://reviews.llvm.org/D105703 Files: clang/lib/CodeGen/BackendUtil.cpp clang/test/Cod

[PATCH] D104536: [clang][deps] Avoid minimizing PCH input files

thakis added a comment. Looks like this breaks tests on Windows: http://45.33.8.238/win/42264/step_7.txt Please take a look, and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104536/new/ https://reviews.l

[clang] c94a345 - [clang][deps] Fix test by checking ignored files correctly

Author: Jan Svoboda Date: 2021-07-20T13:20:56+02:00 New Revision: c94a345a5c693b6c12a41e8f50e3fe96d1311991 URL: https://github.com/llvm/llvm-project/commit/c94a345a5c693b6c12a41e8f50e3fe96d1311991 DIFF: https://github.com/llvm/llvm-project/commit/c94a345a5c693b6c12a41e8f50e3fe96d1311991.diff L

[PATCH] D104536: [clang][deps] Avoid minimizing PCH input files

jansvoboda11 added a comment. In D104536#288 , @thakis wrote: > Looks like this breaks tests on Windows: > http://45.33.8.238/win/42264/step_7.txt > > Please take a look, and revert for now if it takes a while to fix. Thanks, that was a bad rebase.

[PATCH] D105926: [PowerPC] Extra test case for LDARX

lkail added inline comments. Comment at: clang/test/CodeGen/builtins-ppc-xlcompat-check-ldarx-opt.ll:1 +; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py +; RUN: llc -verify-machineinstrs -mtriple=powerpc64le-unknown-linux-gnu \ This l

[PATCH] D105926: [PowerPC] Extra test case for LDARX

lkail requested changes to this revision. lkail added a comment. This revision now requires changes to proceed. Looks we should put it in `llvm/test/CodeGen/PowerPC`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105926/new/ https://reviews.llvm.or

[clang-tools-extra] 4190017 - [clangd] Add tests covering existing header-guard behavior. NFC

Author: Sam McCall Date: 2021-07-20T14:12:23+02:00 New Revision: 419001724542d4b0d3423a71f0d42857af6a6227 URL: https://github.com/llvm/llvm-project/commit/419001724542d4b0d3423a71f0d42857af6a6227 DIFF: https://github.com/llvm/llvm-project/commit/419001724542d4b0d3423a71f0d42857af6a6227.diff LO

[PATCH] D106201: [clangd] Add tests covering existing header-guard behavior. NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rG419001724542: [clangd] Add tests covering existing header-guard behavior. NFC (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106201/n

[clang-tools-extra] 69c04ef - [clangd] Propagate header-guarded flag from preamble to main AST

Author: Sam McCall Date: 2021-07-20T14:21:39+02:00 New Revision: 69c04ef95a3529614b694d7e2fd57ee817076e86 URL: https://github.com/llvm/llvm-project/commit/69c04ef95a3529614b694d7e2fd57ee817076e86 DIFF: https://github.com/llvm/llvm-project/commit/69c04ef95a3529614b694d7e2fd57ee817076e86.diff LO

[PATCH] D106203: [clangd] Propagate header-guarded flag from preamble to main AST

This revision was automatically updated to reflect the committed changes. Closed by commit rG69c04ef95a35: [clangd] Propagate header-guarded flag from preamble to main AST (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D106203?vs=359499&id=360093#toc Repository: r

[clang-tools-extra] eb03fa1 - [clang-tidy] Don't suggest "inline" fix for main function in

Author: Haojian Wu Date: 2021-07-20T14:24:38+02:00 New Revision: eb03fa1d2c05bad5a5f75a89d47b4b31d84bb90b URL: https://github.com/llvm/llvm-project/commit/eb03fa1d2c05bad5a5f75a89d47b4b31d84bb90b DIFF: https://github.com/llvm/llvm-project/commit/eb03fa1d2c05bad5a5f75a89d47b4b31d84bb90b.diff LO

[clang] fd22785 - [Lex] Consider a PCH header-guarded even with #endif truncated

Author: Sam McCall Date: 2021-07-20T14:25:36+02:00 New Revision: fd2278505482bd9db21423b0620be6afe04feb60 URL: https://github.com/llvm/llvm-project/commit/fd2278505482bd9db21423b0620be6afe04feb60 DIFF: https://github.com/llvm/llvm-project/commit/fd2278505482bd9db21423b0620be6afe04feb60.diff LO

[PATCH] D106204: [Lex] Consider a PCH header-guarded even with #endif truncated

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfd2278505482: [Lex] Consider a PCH header-guarded even with #endif truncated (authored by sammccall). Changed prior to commit: https://reviews.llv

[PATCH] D102343: [clang][patch][FPEnv} Initialization of C++ globals not strictfp aware

aaron.ballman added inline comments. Comment at: clang/include/clang/AST/Decl.h:1993 const DeclarationNameInfo &NameInfo, QualType T, - TypeSourceInfo *TInfo, StorageClass S, bool isInlineSpecified, - ConstexprSpecKind ConstexprKind, +

[PATCH] D106347: [PoC][RISCV] Encode arch information in a new module flag meatadata 'riscv-isa-bits'.

jrtc27 added a comment. Why can't we just save target-features itself as a module flag instead of inventing yet another equivalent encoding? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106347/new/ https://reviews.llvm.org/D106347 __

[PATCH] D105881: [flang][driver] Switch to `BoolFOption` for boolean options

awarzynski added a comment. Apologies, it has taken me a bit longer to get back to this. @jansvoboda11 , now I'm realising the key disadvantage of using `OptInFFlag/OptOutFFlag` - it's impossible to express the `opt-in`/`opt-out` semantics in TableGen. In fact, only the contents of `clang -cc1

[PATCH] D105491: [clang] Use i64 for the !srcloc metadata on asm IR nodes.

simon_tatham updated this revision to Diff 360098. simon_tatham edited the summary of this revision. simon_tatham added a comment. Added an i64 `!srcloc` to the only existing test of them I could find. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D105492: [clang] Introduce SourceLocation::[U]IntTy typedefs.

simon_tatham updated this revision to Diff 360099. simon_tatham retitled this revision from "[clang] Introduce SourceLocation::[U]IntType typedefs." to "[clang] Introduce SourceLocation::[U]IntTy typedefs.". simon_tatham added a comment. Renamed types to [U]IntTy. This will affect some of the de

[PATCH] D105881: [flang][driver] Switch to `BoolFOption` for boolean options

awarzynski updated this revision to Diff 360100. awarzynski added a comment. Switch from `BoolFOption` to `OptInFFlag`/`OptOutFFlag` I've refactored `OptInFFlag`/`OptOutFFlag` a tiny bit and created specialisations for `clang -cc1` (`OptInCC1FFlag`/`OptOutCC1FFlag`). I have added some comments

[PATCH] D105498: [clang] Remove assumption about SourceLocation alignment.

simon_tatham updated this revision to Diff 360101. simon_tatham edited the summary of this revision. simon_tatham added a comment. Split up the allocations as suggested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105498/new/ https://reviews.llvm

[PATCH] D105498: [clang] Remove assumption about SourceLocation alignment.

simon_tatham updated this revision to Diff 360104. simon_tatham added a comment. ... and removed an unused function from the previous version. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105498/new/ https://reviews.llvm.org/D105498 Files: clan

[PATCH] D106262: [clang][analyzer] Use generic note tag in alpha.unix.Stream .

balazske added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:380-391 +if (BT == &BT_UseAfterClose) + Message = "Stream closed here"; +else if (BT == &BT_UseAfterOpenFailed) + Message = "Assuming opening the stream fails here";

[PATCH] D105498: [clang] Remove assumption about SourceLocation alignment.

simon_tatham added inline comments. Comment at: clang/lib/AST/DeclObjC.cpp:31 #include "llvm/Support/ErrorHandling.h" +#include "llvm/Support/MathExtras.h" #include "llvm/Support/raw_ostream.h" Oops, before anyone else points it out, this `#include` is also now

[PATCH] D105498: [clang] Remove assumption about SourceLocation alignment.

tmatheson accepted this revision. tmatheson added a subscriber: efriedma. tmatheson added a comment. This revision is now accepted and ready to land. LGTM, but it would be good to have someone else comment on the increased number of allocations (maybe @rsmith or @efriedma?) Co

[PATCH] D105194: [PowerPC] Add PowerPC cmpb builtin and emit target indepedent code for XL compatibility

NeHuang updated this revision to Diff 360109. NeHuang added a comment. clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105194/new/ https://reviews.llvm.org/D105194 Files: clang/include/clang/Basic/BuiltinsPPC.def clang/lib/Basic/Tar

[PATCH] D103986: [PowerPC] Floating Point Builtins for XL Compat.

lei added a comment. please rebase to ToT Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103986/new/ https://reviews.llvm.org/D103986 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[clang] 02cd937 - [PowerPC][Builtins] Added a number of builtins for compatibility with XL.

Author: Stefan Pintilie Date: 2021-07-20T08:57:55-05:00 New Revision: 02cd937945f8f044aa52b7967531be2b77b27431 URL: https://github.com/llvm/llvm-project/commit/02cd937945f8f044aa52b7967531be2b77b27431 DIFF: https://github.com/llvm/llvm-project/commit/02cd937945f8f044aa52b7967531be2b77b27431.dif

[PATCH] D104386: [PowerPC][Builtins] Added a number of builtins for compatibility with XL.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG02cd937945f8: [PowerPC][Builtins] Added a number of builtins for compatibility with XL. (authored by stefanp). Changed prior to commit: https://re

[PATCH] D105498: [clang] Remove assumption about SourceLocation alignment.

simon_tatham added inline comments. Comment at: clang/include/clang/AST/DeclObjC.h:208 const ParmVarDecl *const *getParams() const { -return reinterpret_cast(ParamsAndSelLocs); +return const_cast(Params); } tmatheson wrote: > I don't think you need

[PATCH] D106296: [analyzer] Fix for faulty namespace test in SmartPtrModelling

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106296/new/ https://reviews.llvm.org/D106296

[PATCH] D105926: [PowerPC] Extra test case for LDARX

Conanap updated this revision to Diff 360114. Conanap added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Moved to llvm/test/CodeGen/PowerPC Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105926/new/ https://revie

[PATCH] D106296: [analyzer] Fix for faulty namespace test in SmartPtrModelling

xazax.hun added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:291 // we can try this function - if (Call.getNumArgs() == 2 && - Call.getDecl()->getDeclContext()->isStdNamespace()) -if (smartptr::isStdSmartPtr(Call.getArgExpr(0))

[PATCH] D106361: [clang-tidy] Fix crash and handle AttributedTypes in 'bugprone-easily-swappable-parameters'

whisperity created this revision. whisperity added reviewers: aaron.ballman, vabridgers. whisperity added a project: clang-tools-extra. Herald added subscribers: martong, gamesh411, Szelethus, rnkovacs, xazax.hun. whisperity requested review of this revision. Herald added a subscriber: cfe-commits.

[clang] 9cb00b9 - Reland Produce warning for performing pointer arithmetic on a null pointer.

Author: Jamie Schmeiser Date: 2021-07-20T10:12:20-04:00 New Revision: 9cb00b9ecbe74d19389a5818d61ddee328afe031 URL: https://github.com/llvm/llvm-project/commit/9cb00b9ecbe74d19389a5818d61ddee328afe031 DIFF: https://github.com/llvm/llvm-project/commit/9cb00b9ecbe74d19389a5818d61ddee328afe031.dif

[PATCH] D98798: Produce warning for performing pointer arithmetic on a null pointer.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG9cb00b9ecbe7: Reland Produce warning for performing pointer arithmetic on a null pointer. (authored by jamieschmeiser). C

[PATCH] D92928: [analyzer] Highlight arrows for currently selected event

ASDenysPetrov added a comment. I've made some debugging with IE. Let's keep the diagnostics IE friendly. We might not know how many users work with IE in real. Comment at: clang/lib/StaticAnalyzer/Core/HTMLDiagnostics.cpp:1275-1283 var scrollTo = function(el) { querySele

[PATCH] D105498: [clang] Remove assumption about SourceLocation alignment.

simon_tatham updated this revision to Diff 360123. simon_tatham added a comment. Addressed two nits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105498/new/ https://reviews.llvm.org/D105498 Files: clang/include/clang/AST/DeclObjC.h clang/lib

[PATCH] D92928: [analyzer] Highlight arrows for currently selected event

ASDenysPetrov added a comment. P.S. Sorry. My prev comments get dimmed, since I've playing with history commints, but they still are relevant. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92928/new/ https://reviews.llvm.org/D92928 __

[PATCH] D105498: [clang] Remove assumption about SourceLocation alignment.

simon_tatham added inline comments. Comment at: clang/include/clang/AST/DeclObjC.h:208 const ParmVarDecl *const *getParams() const { -return reinterpret_cast(ParamsAndSelLocs); +return const_cast(Params); } simon_tatham wrote: > tmatheson wrote: > >

[PATCH] D106339: Add support to generate Sphinx DOCX documentation

ldionne requested changes to this revision. ldionne added a comment. This revision now requires changes to proceed. What's the benefit of having docx documentation? We generate HTML documentation, which ends up in the website, and that seems strictly superior to generating docx. What do you need

[PATCH] D106262: [clang][analyzer] Use generic note tag in alpha.unix.Stream .

balazske updated this revision to Diff 360124. balazske added a comment. Support multiple bug types in the note tag function. Add the note tag to every place and update tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106262/new/ https://review

[PATCH] D103986: [PowerPC] Floating Point Builtins for XL Compat.

quinnp updated this revision to Diff 360128. quinnp added a comment. Rebasing patch. Moving macro definitions from a header file to a src file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103986/new/ https://reviews.llvm.org/D103986 Files: cla

[PATCH] D105926: [PowerPC] Extra test case for LDARX

lkail accepted this revision. lkail added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105926/new/ https://reviews.llvm.org/D105926

[clang] fd855c2 - [PowerPC] Restore FastMathFlags of Builder for Vector FDiv Builtins

Author: Quinn Pham Date: 2021-07-20T09:41:00-05:00 New Revision: fd855c24c72ce01573d726317acaaefc9809d9dc URL: https://github.com/llvm/llvm-project/commit/fd855c24c72ce01573d726317acaaefc9809d9dc DIFF: https://github.com/llvm/llvm-project/commit/fd855c24c72ce01573d726317acaaefc9809d9dc.diff LO

[PATCH] D105984: [PowerPC] Restore FastMathFlags of Builder for Vector FDiv Builtins

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfd855c24c72c: [PowerPC] Restore FastMathFlags of Builder for Vector FDiv Builtins (authored by quinnp, committed by kamaub). Changed prior to commit

[PATCH] D104743: [UpdateCCTestChecks] Implement --global-hex-value-regex

jdenny updated this revision to Diff 360131. jdenny added a comment. Applied @jdoerfert's suggestion: generalize to all integer values. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104743/new/ https://reviews.llvm.org/D104743 Files: clang/test/utils/update_cc_test_checks/Inputs/glob

[PATCH] D106260: [OpenCL] Add support of __opencl_c_3d_image_writes feature macro

Anastasia added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:10092 "use of type 'double' requires %select{cl_khr_fp64|cl_khr_fp64 and __opencl_c_fp64}0 support">; +def err_opencl_3d_image_writes_requires_extensions : Error< +"use of type

[PATCH] D92928: [analyzer] Highlight arrows for currently selected event

vsavchenko added a comment. Maybe I'm missing something, but do we really need to care about IE? The last version was released in 2013, and even Microsoft itself stops supporting IE. Why should we care? Is there anyone who uses old deprecated browser that is not maintained? `classList` thin

[PATCH] D105881: [flang][driver] Switch to `BoolFOption` for boolean options

PeteSteinfeld accepted this revision. PeteSteinfeld added a comment. This revision is now accepted and ready to land. All builds, tests, and looks good. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105881/new/ https://reviews.llvm.org/D105881 ___

[PATCH] D104743: [UpdateCCTestChecks] Implement --global-hex-value-regex

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG, sure why not. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104743/new/ https://reviews.llvm.org/D104743 ___ cfe-commits mailing

[PATCH] D92928: [analyzer] Highlight arrows for currently selected event

vsavchenko added a comment. I want to say that I really appreciate the effort you put into finding all the workarounds for IE, but it makes adding new features here incredibly painful because IE doesn't seem to support anything. And the majority of developers (on Linux and on MacOS) have liter

[clang] ea864c9 - [clang][patch][NFC] Refactor calculation of FunctionDecl to avoid duplicate code

Author: Melanie Blower Date: 2021-07-20T11:01:22-04:00 New Revision: ea864c9933021030e33411da79b5155a78b33325 URL: https://github.com/llvm/llvm-project/commit/ea864c9933021030e33411da79b5155a78b33325 DIFF: https://github.com/llvm/llvm-project/commit/ea864c9933021030e33411da79b5155a78b33325.diff

[PATCH] D106361: [clang-tidy] Fix crash and handle AttributedTypes in 'bugprone-easily-swappable-parameters'

aaron.ballman added a comment. The rename from `CommonType` to `CoreType` could probably be done as a separate NFC to make the review a bit easier, if we decide that's a good terminology switch. I'm not certain switching from `common` to `core` makes things more clear though; what's the distinc

[PATCH] D106084: [DebugInfo] Switch to using constructor homing (-debug-info-kind=constructor) by default when debug info is enabled

probinson added a comment. > (hence the renaming of "limited" a long time ago to "standalone-debug" to > create a policy/philosophy around what goes in each category). Sorry, what? I thought -fstandalone-debug meant FullDebugInfo, and AFAICT that's still how the driver handles it? Repository

[PATCH] D92928: [analyzer] Highlight arrows for currently selected event

ASDenysPetrov added a comment. In D92928#2890448 , @vsavchenko wrote: > IE doesn't seem to support anything. And the majority of developers (on > Linux and on MacOS) have literally no way to test it. What we gain from > supporting IE for non-existing u

[PATCH] D93769: [clang] Add support for option -ffp-eval-method and extend #pragma float_control similarly

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D93769#2887857 , @mibintc wrote: > I've rebased and applied clang-format. I'd like to push this, looking for > your +1, thank you! I'

[PATCH] D106084: [DebugInfo] Switch to using constructor homing (-debug-info-kind=constructor) by default when debug info is enabled

probinson added a comment. > Wouldn't the current "limited" behavior have problems for this shared > libraries situation too? Sounds like in that case -fstandalone-debug should > be used. @jmorse am I remembering correctly, that we require dllimport-style annotations, so "limited" actually inc

[clang] 2f5b2ea - [UpdateCCTestChecks] Implement --global-value-regex

Author: Joel E. Denny Date: 2021-07-20T11:23:20-04:00 New Revision: 2f5b2ea6cd854edfa2722ae0b5acf604a333e785 URL: https://github.com/llvm/llvm-project/commit/2f5b2ea6cd854edfa2722ae0b5acf604a333e785 DIFF: https://github.com/llvm/llvm-project/commit/2f5b2ea6cd854edfa2722ae0b5acf604a333e785.diff

[clang] 5b0a948 - [UpdateCCTestChecks] Implement --global-hex-value-regex

Author: Joel E. Denny Date: 2021-07-20T11:23:20-04:00 New Revision: 5b0a948a81e695f044e88659be18a28256b1e309 URL: https://github.com/llvm/llvm-project/commit/5b0a948a81e695f044e88659be18a28256b1e309 DIFF: https://github.com/llvm/llvm-project/commit/5b0a948a81e695f044e88659be18a28256b1e309.diff

  1   2   3   >