Topotuna added inline comments.
================ Comment at: clang/include/clang/Basic/LangStandards.def:187 Digraphs | HexFloat | OpenCL) +LANGSTANDARD_ALIAS_DEPR(openclcpp10, "clc++") ---------------- Anastasia wrote: > I am not sure we should move it into the deprecated category yet... for now > let's just use `LANGSTANDARD_ALIAS`. You are right. I tried to closely follow how `cl1.0` version is regarded on line 169, but it is a slightly different case because `cl` has more than one version already. ================ Comment at: clang/test/Driver/unknown-std.cl:14 // CHECK-NEXT: note: use 'cl3.0' for 'OpenCL 3.0' standard -// CHECK-NEXT: note: use 'clc++' for 'C++ for OpenCL' standard +// CHECK-NEXT: note: use 'clc++1.0' for 'C++ for OpenCL 1.0' standard ---------------- Anastasia wrote: > does it not print `clc++` anymore? The error messages here are derived from language definitions in file `Basic/LangStandards.def`, so both files need to be modified accordingly. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106266/new/ https://reviews.llvm.org/D106266 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits