tmatheson accepted this revision. tmatheson added a subscriber: efriedma. tmatheson added a comment. This revision is now accepted and ready to land.
LGTM, but it would be good to have someone else comment on the increased number of allocations (maybe @rsmith or @efriedma?) ================ Comment at: clang/include/clang/AST/DeclObjC.h:208 const ParmVarDecl *const *getParams() const { - return reinterpret_cast<const ParmVarDecl *const *>(ParamsAndSelLocs); + return const_cast<const ParmVarDecl *const *>(Params); } ---------------- I don't think you need the `const_cast` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105498/new/ https://reviews.llvm.org/D105498 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits