[PATCH] D103040: Print default template argument if manually specified in typedef declaration.

dblaikie added inline comments. Comment at: clang/test/SemaTemplate/class-template-id.cpp:12-14 +return ptr2; // expected-error{{cannot initialize return object of type 'A *' (aka 'A *') with an lvalue of type 'const A *'}} else { +return ptr3; // expected-error{{can

[PATCH] D105017: [analyzer] LValueToRValueBitCasts should evaluate to an r-value

steakhal added a comment. In D105017#2848465 , @NoQ wrote: > So it worked out of the box? Great! Yes, it did. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105017/new/ https://reviews.llvm.org/D105017 _

[PATCH] D103797: [clang] Use resolved path for headers in decluse diagnostics

sammccall added a comment. We discussed this a bit offline, and IIUC the plan is not to push this through at least for now. Notes: - path to a file is more accurate/informative than spelling, since it really is the file rather than the name that is restricted - however in practice the spelling

[PATCH] D104616: [analyzer] Model comparision methods of std::unique_ptr

RedDocMD updated this revision to Diff 355458. RedDocMD added a comment. Refactored out common block Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104616/new/ https://reviews.llvm.org/D104616 Files: clang/lib/StaticAnalyzer/Checkers/SmartPtr.h

[PATCH] D105168: [RISCV] Unify the arch string parsing logic to to RISCVArchStringParser.

kito-cheng updated this revision to Diff 355459. kito-cheng added a comment. Minor clean up. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105168/new/ https://reviews.llvm.org/D105168 Files: clang/lib/Basic/Targets/RISCV.cpp clang/lib/Basic/Ta

[PATCH] D105097: [clang][AArch64][SVE] Handle PRValue under VLAT <-> VLST cast

junparser updated this revision to Diff 355460. junparser added a comment. address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105097/new/ https://reviews.llvm.org/D105097 Files: clang/lib/CodeGen/CGExprScalar.cpp clang/test/CodeGen

[PATCH] D105127: Implement P1401R5

cor3ntin updated this revision to Diff 355462. cor3ntin added a comment. Fix and add tests for the case where the condition is not convertible to bool Simplify code. Add reference to c++23 wording Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105127

[PATCH] D104616: [analyzer] Model comparision methods of std::unique_ptr

RedDocMD added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:443-446 + auto RetVal = C.getSValBuilder().evalBinOp( + State, BOK, FirstPtrVal, SecondPtrVal, Call.getResultType()); + State = State->BindExpr(Call.getOriginExpr(), C.getLoc

[PATCH] D105177: [clangd] Implemented indexing of standard library

kuhnel created this revision. Herald added subscribers: usaxena95, kadircet, arphaman, mgorny. kuhnel requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. This is only the indexing part, it is NOT wired up to t

[PATCH] D105177: [clangd] Implemented indexing of standard library

kuhnel updated this revision to Diff 355466. kuhnel added a comment. forgot header comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105177/new/ https://reviews.llvm.org/D105177 Files: clang-tools-extra/clangd/CMakeLists.txt clang-tools-ex

[PATCH] D105145: [clang][Fuchsia] Remove relative-vtables multilibs

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105145/new/ https://reviews.llvm.org/D105145 ___

[PATCH] D105120: [clang] Fix UB when string.front() is used for the empty string

This revision was automatically updated to reflect the committed changes. Closed by commit rGfceaf8621179: [clang] Fix UB when string.front() is used for the empty string (authored by DmitryPolukhin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105

[clang] fceaf86 - [clang] Fix UB when string.front() is used for the empty string

Author: Dmitry Polukhin Date: 2021-06-30T01:07:47-07:00 New Revision: fceaf8621179aa758c44f3eaee02d789abfd455b URL: https://github.com/llvm/llvm-project/commit/fceaf8621179aa758c44f3eaee02d789abfd455b DIFF: https://github.com/llvm/llvm-project/commit/fceaf8621179aa758c44f3eaee02d789abfd455b.dif

[PATCH] D105097: [clang][AArch64][SVE] Handle PRValue under VLAT <-> VLST cast

efriedma added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:2103 + if (const CallExpr *CE = dyn_cast(E)) +Ty = CE->getCallReturnType(CGF.getContext()); + I don't think we need to call getCallReturnType() here. A call that returns

[PATCH] D104052: [clang] Fix CallExpr dependence bit may not respecting all its arguments.

hokein updated this revision to Diff 355469. hokein added a comment. refine the solution: introduce a separate method, and call it when needed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104052/new/ https://reviews.llvm.org/D104052 Files: cla

[PATCH] D104052: [clang] Fix CallExpr dependence bit may not respecting all its arguments.

hokein added a comment. sorry for the delay, I lost the track. > I think I can also live with adding explicit recomputeDependence() calls in > the right places, and slapping a warning on setArg() that it might be needed. I'm inclined with this option. As you mentioned, there are two major pla

[PATCH] D105014: added some example code for llvm::Expected

kuhnel updated this revision to Diff 355470. kuhnel added a comment. addressed Sam's review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105014/new/ https://reviews.llvm.org/D105014 Files: llvm/include/llvm/Support/Error.h Index: llvm

[PATCH] D105014: added some example code for llvm::Expected

kuhnel updated this revision to Diff 355471. kuhnel marked 2 inline comments as done. kuhnel added a comment. fixed variable name Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105014/new/ https://reviews.llvm.org/D105014 Files: llvm/include/llvm

[PATCH] D105014: added some example code for llvm::Expected

kuhnel marked 4 inline comments as done. kuhnel added inline comments. Comment at: llvm/include/llvm/Support/Error.h:462 +/// +/// Unit-testing a function returning an 'Expceted': +/// @code{.cpp} sammccall wrote: > This seems too intrusive/unusual to put inli

[PATCH] D105014: added some example code for llvm::Expected

kuhnel updated this revision to Diff 355472. kuhnel marked an inline comment as done. kuhnel added a comment. argh, again fixed autoformatter :( Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105014/new/ https://reviews.llvm.org/D105014 Files: ll

[PATCH] D105017: [analyzer] LValueToRValueBitCasts should evaluate to an r-value

vsavchenko accepted this revision. vsavchenko added a comment. Oh, wow, that's awesome! Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105017/new/ https://reviews.llvm.org/D105017 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D105014: added some example code for llvm::Expected

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks! Comment at: llvm/include/llvm/Support/Error.h:464 +///errs() << "Problem with division " +/// << toString(E) << "\n"; +/// } -

[PATCH] D105127: Implement P1401R5

cor3ntin updated this revision to Diff 355477. cor3ntin added a comment. Fix formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105127/new/ https://reviews.llvm.org/D105127 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/li

[PATCH] D104904: [OpenMP][AMDGCN] Initial math headers support

JonChesterfield added inline comments. Comment at: clang/test/Headers/Inputs/include/cstdlib:29 float fabs(float __x) { return __builtin_fabs(__x); } +#endif jdoerfert wrote: > That seems to be fundamentally broken then, but let's see, maybe it will > somehow

[PATCH] D105177: [clangd] Implemented indexing of standard library

kuhnel updated this revision to Diff 355478. kuhnel added a comment. using EXPECT_THAT_EXPECTED Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105177/new/ https://reviews.llvm.org/D105177 Files: clang-tools-extra/clangd/CMakeLists.txt clang-too

[PATCH] D104904: [OpenMP][AMDGCN] Initial math headers support

JonChesterfield added inline comments. Comment at: clang/lib/Headers/__clang_hip_cmath.h:43 +__DEVICE__ __CONSTEXPR__ long abs(long __n) { return ::labs(__n); } +__DEVICE__ __CONSTEXPR__ float fma(float __x, float __y, float __z) { return ::fmaf(__x, __y, __z); ---

[PATCH] D105014: added some example code for llvm::Expected

kuhnel updated this revision to Diff 355481. kuhnel added a comment. also added example code for EXPECT_THAT_EXPECTED. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105014/new/ https://reviews.llvm.org/D105014 Files: llvm/include/llvm/Support/Er

[PATCH] D105097: [clang][AArch64][SVE] Handle PRValue under VLAT <-> VLST cast

junparser added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:2103 + if (const CallExpr *CE = dyn_cast(E)) +Ty = CE->getCallReturnType(CGF.getContext()); + efriedma wrote: > I don't think we need to call getCallReturnType() here. A

[PATCH] D105097: [clang][AArch64][SVE] Handle PRValue under VLAT <-> VLST cast

junparser updated this revision to Diff 355484. junparser added a comment. address comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105097/new/ https://reviews.llvm.org/D105097 Files: clang/lib/CodeGen/CGExprScalar.cpp clang/test/CodeGen/

[PATCH] D105014: added some example code for llvm::Expected

kuhnel updated this revision to Diff 355485. kuhnel marked 2 inline comments as done. kuhnel added a comment. fixed compilation issues Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105014/new/ https://reviews.llvm.org/D105014 Files: llvm/include

[PATCH] D105014: added some example code for llvm::Expected

kuhnel added inline comments. Comment at: llvm/include/llvm/Support/Error.h:464 +///errs() << "Problem with division " +/// << toString(E) << "\n"; +/// } sammccall wrote: > this won't compile, you need std::move(E) sorry, I was too lazy

[clang] c818cb9 - [analyzer][satest][NFC] Relax dependencies requirements

Author: Valeriy Savchenko Date: 2021-06-30T12:50:21+03:00 New Revision: c818cb96ad4aa65bceadc72199677c852e8c22bd URL: https://github.com/llvm/llvm-project/commit/c818cb96ad4aa65bceadc72199677c852e8c22bd DIFF: https://github.com/llvm/llvm-project/commit/c818cb96ad4aa65bceadc72199677c852e8c22bd.d

[PATCH] D104550: [analyzer] Implement getType for SVal

DavidSpickett added a comment. @vsavchenko One of the added tests is failing on our 32 bit Armv7 Thumb bot: https://lab.llvm.org/buildbot/#/builders/170/builds/61 /home/tcwg-buildslave/worker/clang-thumbv7-full-2stage/llvm/clang/unittests/StaticAnalyzer/SValTest.cpp:169: Failure Expected e

[PATCH] D105014: added some example code for llvm::Expected

sammccall added inline comments. Comment at: llvm/include/llvm/Testing/Support/Error.h:168 +/// Helper marcro for checking the result of an 'Expected' +/// marcro -> macro Comment at: llvm/include/llvm/Testing/Support/Error.h:179 +/// /

[PATCH] D105127: Implement P1401R5

mizvekov added a comment. Thanks! Just some nits and some minor points on the tests. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:1491 +def err_constexpr_if_condition_expression_is_not_constant : Error< + "constexpr if condition is not a constant expression con

[PATCH] D104550: [analyzer] Implement getType for SVal

vsavchenko added a comment. In D104550#2849561 , @DavidSpickett wrote: > @vsavchenko One of the added tests is failing on our 32 bit Armv7 Thumb bot: > https://lab.llvm.org/buildbot/#/builders/170/builds/61 > > > /home/tcwg-buildslave/worker/clang-th

[PATCH] D104550: [analyzer] Implement getType for SVal

DavidSpickett added a comment. Cool. If you see a few more emails with the same thing ignore them, the armv7 bots are rather slow to catch up. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104550/new/ https://reviews.llvm.org/D104550

[PATCH] D104904: [OpenMP][AMDGCN] Initial math headers support

JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. I recommend we ship this and fix up the rough edges as we run into them. Paired with ocml it passes OVO libm tests which seems to be a fairly high bar for 'does it work'. The

[PATCH] D104604: [clang] NFC: add line break at the end of if expressions

xgupta added a comment. It seems you need someone to commit this patch? If so you need to share your name and email address. So that someone with commit access can commit it for you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104604/new/ https

[PATCH] D104904: [OpenMP][AMDGCN] Initial math headers support

pdhaliwal added inline comments. Comment at: clang/lib/Headers/__clang_hip_cmath.h:96 +__DEVICE__ __CONSTEXPR__ bool isnan(float __x) { return ::__isnanf(__x); } +__DEVICE__ __CONSTEXPR__ bool isnan(double __x) { return ::__isnan(__x); } jdoerfert wrote: > ^ Th

[PATCH] D104604: [clang] NFC: add line break at the end of if expressions

zhouyizhou added a comment. In D104604#2849676 , @xgupta wrote: > It seems you need someone to commit this patch? If so you need to share your > name and email address. So that someone with commit access can commit it for > you. Thank you very much, I

[PATCH] D105127: Implement P1401R5

cor3ntin updated this revision to Diff 355505. cor3ntin marked an inline comment as done. cor3ntin added a comment. Improve and fix test, Move the fixme in a more sensible place Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105127/new/ https://revi

[PATCH] D105127: Implement P1401R5

cor3ntin added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:1491 +def err_constexpr_if_condition_expression_is_not_constant : Error< + "constexpr if condition is not a constant expression convertible to bool">; def err_static_assert_failed : Err

[PATCH] D105049: [NFC] Remove extra semicolons in clang/lib/APINotes/APINotesFormat.h

xgupta added a comment. > These result in warnings while building and don't need to be there. What are the warnings you get, I run `make clangAPINotes` didn't get any. I am on a7ed55f64c5fdce9af3257458779402fb9de1f8b ( [A

[clang] 2fd7550 - [clang] NFC: add line break at the end of if expressions

Author: Zhouyi Zhou Date: 2021-06-30T19:48:24+08:00 New Revision: 2fd75507d1855300d0a59451337d0a55b081887c URL: https://github.com/llvm/llvm-project/commit/2fd75507d1855300d0a59451337d0a55b081887c DIFF: https://github.com/llvm/llvm-project/commit/2fd75507d1855300d0a59451337d0a55b081887c.diff L

[PATCH] D104604: [clang] NFC: add line break at the end of if expressions

This revision was automatically updated to reflect the committed changes. Closed by commit rG2fd75507d185: [clang] NFC: add line break at the end of if expressions (authored by zhouyizhou, committed by pengfei). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D105014: added some example code for llvm::Expected

kuhnel updated this revision to Diff 355507. kuhnel marked 4 inline comments as done. kuhnel added a comment. updated code examples based on Sam's review Oh my, this is really simple if you know how it's supposed to work. However my intuition is completely off in trying to understand the error h

[PATCH] D105014: added some example code for llvm::Expected

kuhnel updated this revision to Diff 355508. kuhnel added a comment. fixed typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105014/new/ https://reviews.llvm.org/D105014 Files: llvm/include/llvm/Testing/Support/Error.h Index: llvm/include/llv

[PATCH] D105014: added some example code for llvm::Expected

kuhnel updated this revision to Diff 355510. kuhnel added a comment. now fixing arc's way of git commits :( Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105014/new/ https://reviews.llvm.org/D105014 Files: llvm/include/llvm/Support/Error.h llv

[PATCH] D105185: Add _AIX73 macro

Jake-Egan created this revision. Herald added subscribers: kbarton, nemanjai. Jake-Egan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D105185 Files: clang/lib/Basic/Target

[clang] f7ce532 - [clang-offload-bundler] Add unbundling of archives containing bundled object files into device specific archives

Author: Saiyedul Islam Date: 2021-06-30T17:55:50+05:30 New Revision: f7ce532d622dc26eddd25f87faec0ff35dc0c2e9 URL: https://github.com/llvm/llvm-project/commit/f7ce532d622dc26eddd25f87faec0ff35dc0c2e9 DIFF: https://github.com/llvm/llvm-project/commit/f7ce532d622dc26eddd25f87faec0ff35dc0c2e9.diff

[PATCH] D93525: [clang-offload-bundler] Add unbundling of archives containing bundled object files into device specific archives

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf7ce532d622d: [clang-offload-bundler] Add unbundling of archives c

[PATCH] D93525: [clang-offload-bundler] Add unbundling of archives containing bundled object files into device specific archives

saiislam added a comment. @yaxunl this patch on its own is failing in our internal CI. I have an internal patch (542569) to integrate it cleanly there. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93525/new/ https://reviews.llvm.org/D93525

[PATCH] D93525: [clang-offload-bundler] Add unbundling of archives containing bundled object files into device specific archives

grokos added inline comments. Comment at: clang/docs/ClangOffloadBundler.rst:128 + + --- + A bit of wordplay, but it's weird that a *triple* now has 4 elements... Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:147 +T

[PATCH] D104797: [WebAssembly] Implementation of global.get/set for reftypes in LLVM IR

pmatos added inline comments. Comment at: llvm/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp:1138 + +Ops[0] = TableSet; // The new chain is the TableSet itself + } sbc100 wrote: > I was expecting to see a TABLE_SET back to a null after the call here to

[PATCH] D105167: [analyzer] Fix HTML report deduplication.

steakhal added a comment. AFAIK from CodeChecker's side we are fine with this change. I think we are not using the `stable-report-filename` analyzer config either. Aside from these, the less //Perl// the better, I guess. Comment at: clang/lib/StaticAnalyzer/Core/HTMLDiagnostic

[PATCH] D104797: [WebAssembly] Implementation of global.get/set for reftypes in LLVM IR

pmatos added inline comments. Comment at: llvm/lib/Target/WebAssembly/WebAssemblyTargetMachine.cpp:130 TT.isArch64Bit() -? "e-m:e-p:64:64-i64:64-n32:64-S128-ni:1" -: "e-m:e-p:32:32-i64:64-n32:64-S128

[PATCH] D105142: RFC: Implementing new mechanism for hard register operands to inline asm as a constraint.

theraven added a comment. The code looks fine but it would be good to see some docs along with it. We're currently missing docs on inline assembly entirely and the GCC ones are somewhat... opaque when it comes to describing how constraints work. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D105185: [AIX] Add _AIX73 version macro

xgupta accepted this revision. xgupta added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/Basic/Targets/OSTargets.h:704 +if (OsVersion >= std::make_pair(7, 3)) + Builder.defineMacro("_AIX73"); Seems this line

[PATCH] D105185: [AIX] Add _AIX73 version macro

Jake-Egan added inline comments. Comment at: clang/lib/Basic/Targets/OSTargets.h:704 +if (OsVersion >= std::make_pair(7, 3)) + Builder.defineMacro("_AIX73"); xgupta wrote: > Seems this line need formatting? I originally had it matching the format of th

[PATCH] D104925: [Analyzer] Improve report of file read at end-of-file condition.

martong added a comment. +1 for note tags. Comment at: clang/test/Analysis/stream-note.c:134 + +void check_eof_notes_3() { + FILE *F; Perhaps we could have some more explanatory test case names. I mean how _3 is different than _2? What is the case each of the

[PATCH] D105185: [AIX] Add _AIX73 version macro

xgupta added inline comments. Comment at: clang/lib/Basic/Targets/OSTargets.h:704 +if (OsVersion >= std::make_pair(7, 3)) + Builder.defineMacro("_AIX73"); Jake-Egan wrote: > xgupta wrote: > > Seems this line need formatting? > I originally had it match

[PATCH] D105167: [analyzer] Fix HTML report deduplication.

vsavchenko accepted this revision. vsavchenko added a comment. This revision is now accepted and ready to land. This is incredible! Thanks for addressing it! I've encountered this many times. Comment at: clang/lib/StaticAnalyzer/Core/HTMLDiagnostics.cpp:277 + + std::strings

[PATCH] D105191: [Clang][OpenMP] Add support for Static Device Libraries

saiislam created this revision. saiislam added reviewers: jdoerfert, ABataev, JonChesterfield, grokos. Herald added subscribers: kerbowa, guansong, yaxunl, nhaehnle, jvesely. saiislam requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang.

[clang] e773216 - [clang][patch] Add builtin __arithmetic_fence and option fprotect-parens

Author: Melanie Blower Date: 2021-06-30T09:58:06-04:00 New Revision: e773216f46368cd927a3c67bfa2516913acb75e7 URL: https://github.com/llvm/llvm-project/commit/e773216f46368cd927a3c67bfa2516913acb75e7 DIFF: https://github.com/llvm/llvm-project/commit/e773216f46368cd927a3c67bfa2516913acb75e7.diff

[PATCH] D100118: [clang] Add support for new builtin __arithmetic_fence to control floating point optimization, and new clang option fprotect-parens

This revision was automatically updated to reflect the committed changes. Closed by commit rGe773216f4636: [clang][patch] Add builtin __arithmetic_fence and option fprotect-parens (authored by mibintc). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D105185: [AIX] Add _AIX73 version macro

Jake-Egan added inline comments. Comment at: clang/lib/Basic/Targets/OSTargets.h:704 +if (OsVersion >= std::make_pair(7, 3)) + Builder.defineMacro("_AIX73"); xgupta wrote: > Jake-Egan wrote: > > xgupta wrote: > > > Seems this line need formatting? > >

[PATCH] D93525: [clang-offload-bundler] Add unbundling of archives containing bundled object files into device specific archives

yaxunl added a comment. In D93525#2849815 , @saiislam wrote: > @yaxunl > this patch on its own is failing in our internal CI. I have an internal patch > (542569) to integrate it cleanly there. Fine. Thanks. Repository: rG LLVM Github Monorepo CHANG

[PATCH] D105187: [OPENMP]Fix PR50640: OpenMP target clause implicitly scaling loop bounds to uint64_t.

jhuber6 accepted this revision. jhuber6 added a comment. This revision is now accepted and ready to land. LGTM, work on my end. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105187/new/ https://reviews.llvm.org/D105187

[PATCH] D104854: Introduce intrinsic llvm.isnan

sepavloff updated this revision to Diff 355539. sepavloff added a comment. Herald added subscribers: kbarton, nemanjai. Addressed reviewer's notes - Math flags are set when ISNAN node is transformed, - They are set in calls to getNode, - WidenVecOp_ISNAN is made similar to WidenVecOp_SETCC, - Bui

[PATCH] D93525: [clang-offload-bundler] Add unbundling of archives containing bundled object files into device specific archives

saiislam added inline comments. Comment at: clang/docs/ClangOffloadBundler.rst:128 + + --- + grokos wrote: > A bit of wordplay, but it's weird that a *triple* now has 4 elements... I think llvm::Triple it is named Triple because of historical reasons. Otherwise

[PATCH] D105194: [PowerPC] Add PowerPC cmpb builtin and emit target indepedent code for XL compatibility

NeHuang created this revision. NeHuang added reviewers: nemanjai, stefanp, lei, PowerPC. NeHuang added a project: LLVM. Herald added subscribers: shchenz, kbarton. NeHuang requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch is in a s

[PATCH] D104854: Introduce intrinsic llvm.isnan

sepavloff added a comment. In D104854#2841505 , @efriedma wrote: > I'd like to see some test coverage for all the floating-point types (half, > bfloat16, ppc_fp128). Tests for half are added to aarch64-fpclass.ll, new file was created to test ppc_fp128

[PATCH] D93525: [clang-offload-bundler] Add unbundling of archives containing bundled object files into device specific archives

grokos added inline comments. Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:147 +Target.split(Components, '-', 5); +Components.resize(6); +this->OffloadKind = Components[0]; saiislam wrote: > grokos wrote: > > Leftover? `Compon

[PATCH] D105191: [Clang][OpenMP] Add support for Static Device Libraries

jdoerfert added a comment. Not a thorough review but comments to address. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:1662 + std::string archname = ArchName.str(); + std::string gpuname = GPUArch.str(); + Coding convention. Comme

[PATCH] D105185: [AIX] Add _AIX73 version macro

xgupta added inline comments. Comment at: clang/lib/Basic/Targets/OSTargets.h:704 +if (OsVersion >= std::make_pair(7, 3)) + Builder.defineMacro("_AIX73"); Jake-Egan wrote: > xgupta wrote: > > Jake-Egan wrote: > > > xgupta wrote: > > > > Seems this line

[PATCH] D104918: [clang-repl] Implement partial translation units and error recovery.

sgraenitz added a comment. A few minor notes Comment at: clang/include/clang/Interpreter/Interpreter.h:63 +if (auto Err = ErrOrPTU.takeError()) return Err; +if (ErrOrPTU->TheModule) `ErrorOr` has different semantics and is still in use, so the na

[PATCH] D104052: [clang] Fix CallExpr dependence bit may not respecting all its arguments.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/AST/Expr.h:2991 + /// ! the dependence bits might be stale after calling this setter, it is + /// *caller*'s responsibility to rec

[PATCH] D105142: RFC: Implementing new mechanism for hard register operands to inline asm as a constraint.

anirudhp added a comment. In D105142#2849835 , @theraven wrote: > The code looks fine but it would be good to see some docs along with it. > We're currently missing docs on inline assembly entirely and the GCC ones are > somewhat... opaque when it come

[PATCH] D105099: [clang-format] Add an option to put one constructor initializer per line

curdeius added a comment. In D105099#2848583 , @owenpan wrote: > If we were to start this all over without the need of backward compatibility > and the existence of the related unit tests, an enum might be a better > option. Then I still think the user

[clang-tools-extra] bb41f85 - [clangd] Correct SelectionTree behavior around anonymous field access.

Author: Sam McCall Date: 2021-06-30T17:34:48+02:00 New Revision: bb41f8569138f9f87baf7f4b4e26b3cdcdfd42c6 URL: https://github.com/llvm/llvm-project/commit/bb41f8569138f9f87baf7f4b4e26b3cdcdfd42c6 DIFF: https://github.com/llvm/llvm-project/commit/bb41f8569138f9f87baf7f4b4e26b3cdcdfd42c6.diff LO

[PATCH] D104376: [clangd] Correct SelectionTree behavior around anonymous field access.

This revision was automatically updated to reflect the committed changes. Closed by commit rGbb41f8569138: [clangd] Correct SelectionTree behavior around anonymous field access. (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D104898: [clang-repl] Allow passing in code as positional arguments.

sgraenitz accepted this revision. sgraenitz added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/test/Interpreter/execute.cpp:1 // RUN: cat %s | clang-repl | FileCheck %s +// RUN: clang-repl "int i = 10;" 'extern "C" int printf(const char*,.

[PATCH] D100553: [clangd] Log feature configuration (linux+asan+grpc) of the clangd build

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. sammccall marked 3 inline comments as done. Closed by commit rG0c96a92d8666: [clangd] Log feature configuration (linux+asan+grpc) of the clangd build (authored by sammc

[clang-tools-extra] b447445 - [clangd] Show padding following a field on field hover.

Author: Sam McCall Date: 2021-06-30T17:50:59+02:00 New Revision: b447445eaa6f8ff826a7eab276c10bc6f133aeb0 URL: https://github.com/llvm/llvm-project/commit/b447445eaa6f8ff826a7eab276c10bc6f133aeb0 DIFF: https://github.com/llvm/llvm-project/commit/b447445eaa6f8ff826a7eab276c10bc6f133aeb0.diff LO

[PATCH] D98377: [clangd] Show padding following a field on field hover.

This revision was automatically updated to reflect the committed changes. Closed by commit rGb447445eaa6f: [clangd] Show padding following a field on field hover. (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D98377?vs=329805&id=355571#toc Repository: rG LLVM Git

[PATCH] D95807: [Coroutines] Add the newly generated SCCs back to the CGSCC work queue after CoroSplit actually happened

aeubanks accepted this revision. aeubanks added a comment. The CoroSplit/PassBuilder changes lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95807/new/ https://reviews.llvm.org/D95807 ___ cfe-commits

[clang-tools-extra] 0c96a92 - [clangd] Log feature configuration (linux+asan+grpc) of the clangd build

Author: Sam McCall Date: 2021-06-30T17:49:29+02:00 New Revision: 0c96a92d8666b8eb69eb1275aed572f857182d9a URL: https://github.com/llvm/llvm-project/commit/0c96a92d8666b8eb69eb1275aed572f857182d9a DIFF: https://github.com/llvm/llvm-project/commit/0c96a92d8666b8eb69eb1275aed572f857182d9a.diff LO

[PATCH] D104742: [UpdateCCTestChecks] Implement --global-value-regex

jdenny updated this revision to Diff 355579. jdenny added a comment. Fix the new test for the race discussed at D104714#2841465 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104742/new/ https://reviews.llvm.org/D104742 Files: clang/test/ut

[PATCH] D104743: [UpdateCCTestChecks] Implement --global-hex-value-regex

jdenny updated this revision to Diff 355582. jdenny added a comment. Fix the new test for the race discussed at D104714#2841465 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104743/new/ https://reviews.llvm.org/D104743 Files: clang/test/ut

[PATCH] D104852: [AArch64][SVEIntrinsicOpts] Convect cntb/h/w/d to vscale intrinsic or constant.

david-arm accepted this revision. david-arm added a comment. This revision is now accepted and ready to land. LGTM! Thanks a lot for making the changes. :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104852/new/ https://reviews.llvm.org/D104852

[PATCH] D104925: [Analyzer] Improve report of file read at end-of-file condition.

balazske updated this revision to Diff 355594. balazske added a comment. Using NoteTag. Removed the EOF sequence number. Renamed test functions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104925/new/ https://reviews.llvm.org/D104925 Files: cl

[PATCH] D104925: [Analyzer] Improve report of file read at end-of-file condition.

balazske marked an inline comment as done. balazske added a comment. Updated to use `NoteTag`. Note "End-of-file status is discovered here" is removed. Comment at: clang/test/Analysis/stream-note.c:141 + int RRet = fread(Buf, 1, 1, F); // expected-note {{Assuming that stream

[clang-tools-extra] 5709842 - [clangd] Fix highlighting for implicit ObjC property refs

Author: David Goldman Date: 2021-06-30T12:31:50-04:00 New Revision: 570984204f24c326699dedcc05793b77b013f068 URL: https://github.com/llvm/llvm-project/commit/570984204f24c326699dedcc05793b77b013f068 DIFF: https://github.com/llvm/llvm-project/commit/570984204f24c326699dedcc05793b77b013f068.diff

[PATCH] D104904: [OpenMP][AMDGCN] Initial math headers support

JonChesterfield added a comment. @ronlieb reports that this change means __CUDA__ is defined for openmp amdgcn compilation. I'm going to try to verify that Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104904/new/ https://reviews.llvm.org/D104904

[PATCH] D104117: [clangd] Fix highlighting for implicit ObjC property refs

This revision was automatically updated to reflect the committed changes. Closed by commit rG570984204f24: [clangd] Fix highlighting for implicit ObjC property refs (authored by dgoldman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104117/new/ ht

[PATCH] D104797: [WebAssembly] Implementation of global.get/set for reftypes in LLVM IR

tlively added inline comments. Comment at: llvm/lib/Target/WebAssembly/WebAssemblyTargetMachine.cpp:130 TT.isArch64Bit() -? "e-m:e-p:64:64-i64:64-n32:64-S128-ni:1" -: "e-m:e-p:32:32-i64:64-n32:64-S12

[PATCH] D95807: [Coroutines] Add the newly generated SCCs back to the CGSCC work queue after CoroSplit actually happened

lxfind added inline comments. Comment at: llvm/lib/Transforms/Coroutines/CoroSplit.cpp:2112-2114 StringRef Value = Attr.getValueAsString(); LLVM_DEBUG(dbgs() << "CoroSplit: Processing coroutine '" << F.getName() << "' state: " << Value << "\n"); -

[PATCH] D95807: [Coroutines] Add the newly generated SCCs back to the CGSCC work queue after CoroSplit actually happened

lxfind updated this revision to Diff 355607. lxfind added a comment. fix warning Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95807/new/ https://reviews.llvm.org/D95807 Files: clang/test/CodeGenCoroutines/coro-newpm-pipeline.cpp llvm/lib/Pass

[clang-tools-extra] b56e5f8 - [clangd] Unbreak mac build after 0c96a92d8666b8

Author: Nico Weber Date: 2021-06-30T12:53:38-04:00 New Revision: b56e5f8a10c1ec4fd3750bdd269fbad778820326 URL: https://github.com/llvm/llvm-project/commit/b56e5f8a10c1ec4fd3750bdd269fbad778820326 DIFF: https://github.com/llvm/llvm-project/commit/b56e5f8a10c1ec4fd3750bdd269fbad778820326.diff LO

  1   2   3   >