vsavchenko accepted this revision.
vsavchenko added a comment.
This revision is now accepted and ready to land.
This is incredible! Thanks for addressing it! I've encountered this many
times.
================
Comment at: clang/lib/StaticAnalyzer/Core/HTMLDiagnostics.cpp:277
+
+ std::stringstream filename;
+ filename << "report-";
----------------
steakhal wrote:
> I don't frequently see `stringstream`s in the codebase.
> Why don't you use the llvm alternative?
> ```
> std::string s;
> llvm::raw_string_ostream os(s);
> ```
nit: whatever stream you choose, can you please start it with a capital letter?
💅
================
Comment at: clang/lib/StaticAnalyzer/Core/HTMLDiagnostics.cpp:286-287
+ // but the stable report filename is still more verbose.
+ // We should rename the option ("verbose" filename?) but it will break
+ // people's workflows.
+ if (DiagOpts.ShouldWriteStableReportFilename) {
----------------
Can we make a mirror for this option and mark the other one as deprecated?
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105167/new/
https://reviews.llvm.org/D105167
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
