[PATCH] D105001: [Clang][RISCV] Support half-precision floating point for RVV intrinsics.

HsiangKai added inline comments. Comment at: clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vfadd.c:13 +// ASM-NOT: warning #include craig.topper wrote: > Do you plan to bring back the ASM check for all tests? No, I will remove it. This is the first patch

[PATCH] D103668: [PowerPC] Implement trap and conversion builtins for XL compatibility

Conanap updated this revision to Diff 355129. Conanap added a comment. Separated new test cases, rebased for newest changes, different semachecking Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103668/new/ https://reviews.llvm.org/D103668 Files:

[PATCH] D103668: [PowerPC] Implement trap and conversion builtins for XL compatibility

Conanap updated this revision to Diff 355130. Conanap marked 3 inline comments as done. Conanap added a comment. Removed unneccessary brackets Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103668/new/ https://reviews.llvm.org/D103668 Files: clan

[PATCH] D103668: [PowerPC] Implement trap and conversion builtins for XL compatibility

Conanap added a comment. Addressed comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103668/new/ https://reviews.llvm.org/D103668 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[clang] d8faf03 - [X86] Add -mgeneral-regs-only support.

Author: Tianqing Wang Date: 2021-06-29T16:02:51+08:00 New Revision: d8faf03807ac059f669ddea8742dd540e58e45be URL: https://github.com/llvm/llvm-project/commit/d8faf03807ac059f669ddea8742dd540e58e45be DIFF: https://github.com/llvm/llvm-project/commit/d8faf03807ac059f669ddea8742dd540e58e45be.diff

[PATCH] D103943: [X86] Add -mgeneral-regs-only support.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd8faf03807ac: [X86] Add -mgeneral-regs-only support. (authored by tianqing). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D105087: [clang-format] PR49960 clang-format doesn't handle ASI after "return" on JavaScript

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: curdeius, HazardyKnusperkeks, mprobst. MyDeveloperDay added projects: clang, clang-format. MyDeveloperDay requested review of this revision. https://bugs.llvm.org/show_bug.cgi?id=49960 clang-format can mutate legal javascript c

[PATCH] D95807: [Coroutines] Add the newly generated SCCs back to the CGSCC work queue after CoroSplit actually happened

ChuanqiXu added a comment. > note that we don't really need to run Inliner again on the ramp function > after split This isn't accurate. The inline may run again for ramp function after split and it's required by coro elide. It seems like that we don't need the attribute `CORO_PRESPLIT_ATTR` a

[clang] 4d8871a - PR50767: clear non-distinct debuginfo for function with nodebug definition after undecorated declaration

Author: Bruno De Fraine Date: 2021-06-29T10:26:45+02:00 New Revision: 4d8871a898b30f11c905b27954c18d826c0953c9 URL: https://github.com/llvm/llvm-project/commit/4d8871a898b30f11c905b27954c18d826c0953c9 DIFF: https://github.com/llvm/llvm-project/commit/4d8871a898b30f11c905b27954c18d826c0953c9.dif

[PATCH] D104777: PR50767: clear non-distinct debuginfo for function with nodebug definition after undecorated declaration

This revision was automatically updated to reflect the committed changes. Closed by commit rG4d8871a898b3: PR50767: clear non-distinct debuginfo for function with nodebug definition… (authored by brunodf, committed by jeroen.dobbelaere). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D99517: Implemented [[clang::musttail]] attribute for guaranteed tail calls.

theraven added a comment. The error message here is very confusing: /home/theraven/snmalloc2/src/mem/../ds/../aal/../ds/defines.h:122:27: error: cannot perform a tail call to function 'error' because its signature is incompatible with the calling function [[clang::musttail]] return sn

[PATCH] D93373: [Flang][Openmp] Upgrade TASKGROUP construct to 5.0.

AMDChirag added a comment. @jdoerfert Could you please take a look at this patch as well? (especially for the clang part) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93373/new/ https://reviews.llvm.org/D93373 ___

[PATCH] D69560: [clang-tidy] Add 'bugprone-easily-swappable-parameters' check

whisperity marked 2 inline comments as done. whisperity added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/EasilySwappableParametersCheck.cpp:113-120 +#define FB(Name, K) MIX_##Name = (1ull << (K##ull - 1ull)) + + FB(None, 1), //< Mix between the two

[clang] 78d309c - [OpenCL] Fix qualifiers check on binding references to temporaries

Author: Ole Strohm Date: 2021-06-29T10:03:57+01:00 New Revision: 78d309ce197c30593450e792b0c2dc7a575f0050 URL: https://github.com/llvm/llvm-project/commit/78d309ce197c30593450e792b0c2dc7a575f0050 DIFF: https://github.com/llvm/llvm-project/commit/78d309ce197c30593450e792b0c2dc7a575f0050.diff LO

[PATCH] D103962: [C++4OpenCL] Fix qualifiers check on binding references to temporaries

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG78d309ce197c: [OpenCL] Fix qualifiers check on binding references to temporaries (authored by olestrohm). Repository: rG LLVM Github Monorepo CHA

[PATCH] D104550: [analyzer] Implement getType for SVal

Szelethus accepted this revision. Szelethus added a comment. Really appreciate the unit tests! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104550/new/ https://reviews.llvm.org/D104550 ___ cfe-commits m

[PATCH] D105091: [RISCV] Pass -u to linker correctly.

kito-cheng created this revision. Herald added subscribers: vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, niosHD, sabuasal, simoncook, johnrusso,

[PATCH] D104550: [analyzer] Implement getType for SVal

vsavchenko updated this revision to Diff 355152. vsavchenko added a comment. Add one more note to `getType` docstring Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104550/new/ https://reviews.llvm.org/D104550 Files: clang/include/clang/StaticAna

[PATCH] D104647: [analyzer] Support SVal::getType for pointer-to-member values

vsavchenko updated this revision to Diff 355154. vsavchenko added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104647/new/ https://reviews.llvm.org/D104647 Files: clang/include/clang/StaticAnalyzer/Core/PathSensitive/BasicValu

[clang] 159024c - [analyzer] Implement getType for SVal

Author: Valeriy Savchenko Date: 2021-06-29T12:11:19+03:00 New Revision: 159024ce231502d4d68825c35c3548a14577f0fd URL: https://github.com/llvm/llvm-project/commit/159024ce231502d4d68825c35c3548a14577f0fd DIFF: https://github.com/llvm/llvm-project/commit/159024ce231502d4d68825c35c3548a14577f0fd.d

[PATCH] D105092: [PoC][RISCV] Add the tail policy argument to builtins/intrinsics.

HsiangKai created this revision. HsiangKai added reviewers: craig.topper, frasercrmck, rogfer01, kito-cheng. Herald added subscribers: StephenFan, vkmr, dexonsmith, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, edward

[PATCH] D104550: [analyzer] Implement getType for SVal

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG159024ce2315: [analyzer] Implement getType for SVal (authored by vsavchenko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D104915: [OpenCL] Add support of __opencl_c_read_write_images feature macro

Anastasia added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:10106 def err_opencl_invalid_read_write : Error< - "access qualifier %0 can not be used for %1 %select{|prior to OpenCL version 2.0}2">; + "access qualifier %0 can not be used for %1

[clang] b284229 - [analyzer] Fix SValTest for LocAsInt test

Author: Valeriy Savchenko Date: 2021-06-29T13:01:41+03:00 New Revision: b2842298cebf420ecb3750bf309021a7f37870c1 URL: https://github.com/llvm/llvm-project/commit/b2842298cebf420ecb3750bf309021a7f37870c1 DIFF: https://github.com/llvm/llvm-project/commit/b2842298cebf420ecb3750bf309021a7f37870c1.d

[PATCH] D105097: [clang][AArch64][SVE] Handle PRValue under VLAT <-> VLST cast

junparser created this revision. junparser added reviewers: joechrisellis, c-rhodes, efriedma, aeubanks, bsmith. Herald added subscribers: psnobl, kristof.beyls, tschuett. junparser requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This chang

[PATCH] D104858: [OpenCL][ARM] Fix ICE when compiling a kernel

Anastasia updated this revision to Diff 355166. Anastasia retitled this revision from "[OpenCL][ARM] Fix ICE when compiling a source with the kernel" to "[OpenCL][ARM] Fix ICE when compiling a kernel". Anastasia edited the summary of this revision. Anastasia added reviewers: pekka, svenvh. Anastas

[PATCH] D105099: [clang-format] Add an option to put one constructor initializer per line

owenpan created this revision. owenpan added reviewers: djasper, klimek, krasimir, MyDeveloperDay, curdeius, HazardyKnusperkeks. owenpan added a project: clang-format. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. See PR50549

[PATCH] D105101: [analyzer] Make CheckerManager::hasPathSensitiveCheckers() complete again

steakhal created this revision. steakhal added reviewers: NoQ, vsavchenko, Szelethus, martong. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun, whisperity. steakhal requested review of this revision. H

[PATCH] D105052: [clang][darwin] add support for Mac Catalyst availability

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:860 + .Case("maccatalyst", "macCatalyst") + .Case("maccatalyst_app_extension", "macCatalyst App Extension") .Case("swift", "Swift") Should thi

[PATCH] D105052: [clang][darwin] add support for Mac Catalyst availability

aaron.ballman added a comment. Btw, the CI failures look to be unrelated to the patch. (It's pretty unfortunate how often this is the case lately...) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105052/new/ https://reviews.llvm.org/D105052

[PATCH] D105112: [clang] Add -fdump-record-layouts-canonical option

daltenty created this revision. daltenty added reviewers: stevewan, dexonsmith. Herald added a subscriber: dang. daltenty requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This option implies -fdump-record-layouts but dumps record layout info

[PATCH] D20689: [clang-tidy] Add 'readability-suspicious-call-argument' check

aaron.ballman added a comment. I think this looks good to me. @alexfh, you had raised questions about this meeting the quality bar. I think those concerns are valid in the abstract (swapped argument checking requires heuristics), but I'd argue that most existing code bases that actually have sw

[PATCH] D105101: [analyzer] Make CheckerManager::hasPathSensitiveCheckers() complete again

vsavchenko accepted this revision. vsavchenko added a comment. This revision is now accepted and ready to land. Great! Thanks for the detailed explanation in your Summary. I agree that there should be a runtime check, but it doesn't seem viable as long as `Checker.h` is organized the way it is o

[PATCH] D103615: [Clang] Add option to handle behaviour of vector bool/vector pixel.

stefanp reopened this revision. stefanp added a comment. This revision is now accepted and ready to land. I'm sorry I missed the asserts requirement. I will recommit this patch after I add `REQUIRES: asserts`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D105092: [PoC][RISCV] Add the tail policy argument to builtins/intrinsics.

khchen added inline comments. Comment at: clang/utils/TableGen/RISCVVEmitter.cpp:1148 +if (HasPolicy) { + ProtoMaskSeq.push_back("z"); +} maybe the policy argument should be a constant value ("Kz")? Repository: rG LLVM Github Monorepo CHANGES SI

[clang] 3dae019 - [analyzer] Make CheckerManager::hasPathSensitiveCheckers() complete again

Author: Balazs Benics Date: 2021-06-29T16:35:07+02:00 New Revision: 3dae01911b6902f00e80eb7ebdc2f55bb28f173e URL: https://github.com/llvm/llvm-project/commit/3dae01911b6902f00e80eb7ebdc2f55bb28f173e DIFF: https://github.com/llvm/llvm-project/commit/3dae01911b6902f00e80eb7ebdc2f55bb28f173e.diff

[PATCH] D105101: [analyzer] Make CheckerManager::hasPathSensitiveCheckers() complete again

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3dae01911b69: [analyzer] Make CheckerManager::hasPathSensitiveCheckers() complete again (authored by steakhal). Changed prior to commit: https://

[PATCH] D103615: [Clang] Add option to handle behaviour of vector bool/vector pixel.

bmahjour added a comment. In D103615#2847047 , @stefanp wrote: > I'm sorry I missed the asserts requirement. > I will recommit this patch after I add `REQUIRES: asserts`. Instead of disabling the tests for non-assert builds, can we just remove the `entr

[PATCH] D103615: [Clang] Add option to handle behaviour of vector bool/vector pixel.

bmahjour added a comment. In D103615#2846245 , @dblaikie wrote: > As mentioned in the reverting commit - these tests fail in non-asserts > builds, because they assume named IR instructions (like the named entry BB > label), which aren't provided on a no

[PATCH] D105120: [clang] Fix UB when string.front() is used for the empty string

DmitryPolukhin created this revision. DmitryPolukhin added reviewers: kadircet, lh123, sammccall, hokein, ilya-biryukov. DmitryPolukhin added projects: clang, clang-tools-extra. Herald added a subscriber: usaxena95. DmitryPolukhin requested review of this revision. Compilation database might have

[PATCH] D105120: [clang] Fix UB when string.front() is used for the empty string

DmitryPolukhin updated this revision to Diff 355233. DmitryPolukhin added a comment. Replace tab with spaces Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105120/new/ https://reviews.llvm.org/D105120 Files: clang/lib/Tooling/ExpandResponseFilesC

[PATCH] D104952: [hexagon] Add {hvx,}hexagon_{protos,circ_brev...}

bcain updated this revision to Diff 355234. bcain added a comment. Removed some unavailable instructions. Added include order fix in hexagon_circ_brev Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104952/new/ https://reviews.llvm.org/D104952 File

[clang] c33ebad - Print default template argument if manually specified in typedef declaration.

Author: Pratyush Das Date: 2021-06-29T14:57:26Z New Revision: c33ebad73516ffcf7b00821a430aa6a0199941f0 URL: https://github.com/llvm/llvm-project/commit/c33ebad73516ffcf7b00821a430aa6a0199941f0 DIFF: https://github.com/llvm/llvm-project/commit/c33ebad73516ffcf7b00821a430aa6a0199941f0.diff LOG:

[PATCH] D103040: Print default template argument if manually specified in typedef declaration.

This revision was automatically updated to reflect the committed changes. Closed by commit rGc33ebad73516: Print default template argument if manually specified in typedef declaration. (authored by reikdas, committed by v.g.vassilev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D105017: [analyzer] LValueToRValueBitCasts should evaluate to an r-value

steakhal updated this revision to Diff 355245. steakhal marked an inline comment as done. steakhal added a comment. Evaluate `LValueToRValueBitCast`s the same way as we evaluate `LValueToRValue` casts. Extended the tests accordingly. Thanks for the hint @NoQ! It looks much better now. CHANGES

[PATCH] D105017: [analyzer] LValueToRValueBitCasts should evaluate to an r-value

steakhal added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/ExprEngineC.cpp:543 case CK_VectorSplat: { state = handleLVectorSplat(state, LCtx, CastE, Bldr, Pred); continue; NoQ wrote: > You didn't start it but that's, ugh, n

[PATCH] D105017: [analyzer] LValueToRValueBitCasts should evaluate to an r-value

steakhal marked an inline comment as done. steakhal added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/ExprEngineC.cpp:543 case CK_VectorSplat: { state = handleLVectorSplat(state, LCtx, CastE, Bldr, Pred); continue; steakhal

[PATCH] D105099: [clang-format] Add an option to put one constructor initializer per line

MyDeveloperDay added a comment. Seem similar to D90232: [clang-format] Formatting constructor initializer lists by putting them always on different lines (update to D14484) which seems to have got stalled I sort of feel I prefer the design where we have an enum

[PATCH] D105099: [clang-format] Add an option to put one constructor initializer per line

MyDeveloperDay added a comment. We already have `AllowAllConstructorInitializersOnNextLine` and `ConstructorInitializerAllOnOneLineOrOnePerLine` Sort of feels like we need to combine them with this, I should also say I'd quite like this functionality, its just how do we deliver it via the opt

[PATCH] D104617: [clangd] Type hints for structured bindings

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Cool! Comment at: clang-tools-extra/clangd/InlayHints.cpp:40 +// types would be "tuple_element::type". +TypeHintPolicy.PrintCanonicalTypes = true; }

[PATCH] D104056: [clangd][nfc] Show more information in logs when compiler instance prepare fails

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks, LGTM Sorry about the delay - we got sidetracked into some ideas about whether these errors should actually be surfaced to the user as diagnostics instead. But that shouldn't blo

[PATCH] D104052: [clang] Fix CallExpr dependence bit may not respecting all its arguments.

sammccall added a comment. Ping - curious about your thoughts here! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104052/new/ https://reviews.llvm.org/D104052 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D105127: Implement P1401R5

cor3ntin created this revision. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Support Narrowing conversions to bool in if constexpr condition under C++23 language mode. Only if constexpr is implemented as the behavior of static_

[PATCH] D104601: [Preprocessor] Implement -fnormalize-whitespace.

aaron.ballman added a comment. I'm still mulling over the feature, but I have some nits with the patch while I was exploring it. I share the concerns raised by @dblaikie and would add that it's very common for implementers to ask developers to run their code through `-E` mode to submit preproce

[PATCH] D95807: [Coroutines] Add the newly generated SCCs back to the CGSCC work queue after CoroSplit actually happened

lxfind added a comment. In D95807#2846358 , @ChuanqiXu wrote: >> note that we don't really need to run Inliner again on the ramp function >> after split > > This isn't accurate. The inline may run again for ramp function after split > and it's required b

[PATCH] D105120: [clang] Fix UB when string.front() is used for the empty string

DmitryPolukhin updated this revision to Diff 355261. DmitryPolukhin added a comment. Fix clang-tidy style warning Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105120/new/ https://reviews.llvm.org/D105120 Files: clang/lib/Tooling/ExpandResponseF

[PATCH] D104925: [Analyzer] Improve report of file read at end-of-file condition.

balazske added a comment. Is it better to save the actual `ExplodedNode` in the note tag? Then the error node of the `BugReport` can be used to search the bug path and check if the saved node is encountered. In this way a `NoteTag` could be used and the "sequence numbers" would be unnecessary.

[PATCH] D104285: [analyzer] Retrieve value by direct index from list initialization of constant array declaration.

ASDenysPetrov added a comment. @chrish_ericsson_atx Thanks for the new test case. I'll handle it ASAP. > To be clear, neither this new reproducer nor the one I originally posted fail > if commit b30521c28a4d > is > reverted.

[PATCH] D105092: [PoC][RISCV] Add the tail policy argument to builtins/intrinsics.

craig.topper added inline comments. Comment at: clang/utils/TableGen/RISCVVEmitter.cpp:1148 +if (HasPolicy) { + ProtoMaskSeq.push_back("z"); +} khchen wrote: > maybe the policy argument should be a constant value ("Kz")? Agreed. Co

[PATCH] D103615: [Clang] Add option to handle behaviour of vector bool/vector pixel.

dblaikie added a comment. In D103615#2847118 , @bmahjour wrote: > In D103615#2847047 , @stefanp wrote: > >> I'm sorry I missed the asserts requirement. >> I will recommit this patch after I add `REQUIRES: asserts`

[PATCH] D103615: [Clang] Add option to handle behaviour of vector bool/vector pixel.

bmahjour added a comment. > (generally: disabling the test in non-asserts builds isn't the right path, > modifying the test so it doesn't depend on asserts IR naming is the right > path) Agreed. > Yes, probably removing the entry: check would be sufficient - give it a test > locally and see h

[clang] 952944c - [ObjC][ARC] Don't add operand bundle clang.arc.attachedcall to a call if

Author: Akira Hatanaka Date: 2021-06-29T10:23:01-07:00 New Revision: 952944c12c0aa917e97805e929b5cd4e40866f91 URL: https://github.com/llvm/llvm-project/commit/952944c12c0aa917e97805e929b5cd4e40866f91 DIFF: https://github.com/llvm/llvm-project/commit/952944c12c0aa917e97805e929b5cd4e40866f91.diff

[PATCH] D105135: [Internalize] Preserve variables externally initialized.

hliao created this revision. hliao added reviewers: yaxunl, bogner. Herald added subscribers: ormris, hiraditya. hliao requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. - ``externally_initialized`` variables would be initial

[PATCH] D97824: [ObjC][ARC] Don't add operand bundle `clang.arc.attachedcall` to a call if the call already has the operand bundle

This revision was automatically updated to reflect the committed changes. Closed by commit rG952944c12c0a: [ObjC][ARC] Don't add operand bundle clang.arc.attachedcall to a call if (authored by ahatanak). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D104616: [analyzer] Model comparision methods of std::unique_ptr

RedDocMD added a comment. Sorry for not updating. Was down with fever. This patch does *not* work now. `operationKindFromOverloadedOperator` is broken because the maps don't get populated. I am not entirely sure why this is happening. Will try to fix tomorrow. @NoQ, @vsavchenko, @xazax.hun, @tee

[clang] aaba371 - [clang][PATCH][nfc] Refactor TargetInfo::adjust to pass DiagnosticsEngine to allow diagnostics on target-unsupported options

Author: Melanie Blower Date: 2021-06-29T13:26:23-04:00 New Revision: aaba37187fda7f5a7fdc4c1e6129cbaaa1bbf709 URL: https://github.com/llvm/llvm-project/commit/aaba37187fda7f5a7fdc4c1e6129cbaaa1bbf709 DIFF: https://github.com/llvm/llvm-project/commit/aaba37187fda7f5a7fdc4c1e6129cbaaa1bbf709.diff

[PATCH] D104729: [clang][PATCH][nfc] Refactor TargetInfo::adjust to pass DiagnosticsEngine to allow diagnostics on target-unsupported options

This revision was automatically updated to reflect the committed changes. Closed by commit rGaaba37187fda: [clang][PATCH][nfc] Refactor TargetInfo::adjust to pass DiagnosticsEngine to… (authored by mibintc). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D105135: [Internalize] Preserve variables externally initialized.

hliao added inline comments. Comment at: clang/test/CodeGenCUDA/host-used-device-var.cu:20 -// DEV-NEG-NOT: @v1 -__device__ int v1; BTW, as clang codegen tests, those checks should not rely on middle-end optimizations to work correctly. Comm

[PATCH] D103615: [Clang] Add option to handle behaviour of vector bool/vector pixel.

dblaikie added a comment. In D103615#2847704 , @bmahjour wrote: >> (generally: disabling the test in non-asserts builds isn't the right path, >> modifying the test so it doesn't depend on asserts IR naming is the right >> path) > > Agreed. > >> Yes, pro

[PATCH] D104946: [AMDGPU] Add builtin functions image_bvh_intersect_ray

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/include/clang/Basic/BuiltinsAMDGPU.def:221-224 +TARGET_BUILTIN(__builtin_amdgcn_image_bvh_intersect_ray, "V4UiUifV4fV4fV4fV4Ui", "nc", "gfx10-insts") +TARGET_BUILTIN(__builtin_amdgcn_image_b

[PATCH] D105087: [clang-format] PR49960 clang-format doesn't handle ASI after "return" on JavaScript

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. It's a strange language :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105087/new/ https://reviews.llvm.org/D105087 _

[PATCH] D105099: [clang-format] Add an option to put one constructor initializer per line

HazardyKnusperkeks added a comment. In D105099#2847328 , @MyDeveloperDay wrote: > Seem similar to D90232: [clang-format] Formatting constructor initializer > lists by putting them always on different lines (update to D14484) >

[PATCH] D105087: [clang-format] PR49960 clang-format doesn't handle ASI after "return" on JavaScript

mprobst added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:1015 +if (!eof()) { + if (Next->is(tok::identifier)) { +// Peek the next token. can you add comments explaining what syntax is being detected here?

[PATCH] D104946: [AMDGPU] Add builtin functions image_bvh_intersect_ray

yaxunl updated this revision to Diff 355309. yaxunl added a comment. Add check for ISA. Add comments about argument types. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104946/new/ https://reviews.llvm.org/D104946 Files: clang/include/clang/Basic/BuiltinsAMDGPU.def clang/lib/CodeGe

[PATCH] D103615: [Clang] Add option to handle behaviour of vector bool/vector pixel.

stefanp added a comment. In D103615#2847650 , @dblaikie wrote: > In D103615#2847118 , @bmahjour > wrote: > >> In D103615#2847047 , @stefanp >> wrote: >> >>> I'm sorry I

[PATCH] D103615: [Clang] Add option to handle behaviour of vector bool/vector pixel.

dblaikie added a comment. In D103615#2847965 , @stefanp wrote: > In D103615#2847650 , @dblaikie > wrote: > >> In D103615#2847118 , @bmahjour >> wrote: >> >>> In D103615#

[PATCH] D103615: [Clang] Add option to handle behaviour of vector bool/vector pixel.

stefanp updated this revision to Diff 355315. stefanp added a comment. Updated test cases to avoid failures on non assert builds. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103615/new/ https://reviews.llvm.org/D103615 Files: clang/include/cla

[PATCH] D103615: [Clang] Add option to handle behaviour of vector bool/vector pixel.

stefanp updated this revision to Diff 355320. stefanp added a comment. Removed the lines that specified that checks were auto generated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103615/new/ https://reviews.llvm.org/D103615 Files: clang/incl

[PATCH] D105097: [clang][AArch64][SVE] Handle PRValue under VLAT <-> VLST cast

efriedma added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:2120 + } else +Addr = EmitLValue(E).getAddress(CGF); Addr = Builder.CreateElementBitCast(Addr, CGF.ConvertTypeForMem(DestTy)); I don't think it's legal to use EmitL

[PATCH] D104085: [compiler-rt][hwasan] Setup hwasan thread handling on Fuchsia

leonardchan updated this revision to Diff 355323. leonardchan added a comment. Ok. Ready for reviews. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104085/new/ https://reviews.llvm.org/D104085 Files: compiler-rt/lib/hwasan/CMakeLists.txt compi

[clang] 90dfd05 - [Clang] Add option to handle behaviour of vector bool/vector pixel.

Author: Stefan Pintilie Date: 2021-06-29T14:07:12-05:00 New Revision: 90dfd059198ed94334f9b1ccfd29b566feb75e8b URL: https://github.com/llvm/llvm-project/commit/90dfd059198ed94334f9b1ccfd29b566feb75e8b DIFF: https://github.com/llvm/llvm-project/commit/90dfd059198ed94334f9b1ccfd29b566feb75e8b.dif

[PATCH] D103615: [Clang] Add option to handle behaviour of vector bool/vector pixel.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG90dfd059198e: [Clang] Add option to handle behaviour of vector bool/vector pixel. (authored by stefanp). Repository: rG LLVM Github Monorepo CHAN

[PATCH] D104085: [compiler-rt][hwasan] Setup hwasan thread handling on Fuchsia

leonardchan added a comment. Let me know if this should be split up also. I think this might be small and and simple enough for one patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104085/new/ https://reviews.llvm.org/D104085

[PATCH] D105142: RFC: Implementing new mechanism for hard register operands to inline asm as a constraint.

anirudhp created this revision. Herald added subscribers: pengfei, jfb, tpr. anirudhp requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. - Relevant RFCs posted here https://lists.llvm.org/pipermail/llvm-dev/2021-June/151370.html https://gcc.g

[PATCH] D105142: RFC: Implementing new mechanism for hard register operands to inline asm as a constraint.

anirudhp updated this revision to Diff 355332. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105142/new/ https://reviews.llvm.org/D105142 Files: clang/include/clang/Basic/TargetInfo.h clang/lib/Basic/TargetInfo.cpp clang/lib/CodeGen/CGStmt.cpp

[PATCH] D105145: [clang][Fuchsia] Remove relative-vtables multilibs

leonardchan created this revision. leonardchan added reviewers: phosek, mcgrathr. leonardchan added a project: clang. Herald added a subscriber: mgorny. leonardchan requested review of this revision. As of D102374 , relative vtables is enabled on Fuchsia by defau

[PATCH] D104388: [clang-format] PR50727 C# Invoke Lamda Expression indentation incorrect

curdeius added a comment. I can't help with C# part either, unfortunately. I'll chime in if I see something strange, but current patch looks okay to me. I let other reviewers (@exv) accept it when they feel it's ok. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:1793

[PATCH] D104388: [clang-format] PR50727 C# Invoke Lamda Expression indentation incorrect

jbcoe accepted this revision. jbcoe added a subscriber: krasimir. jbcoe added a comment. Some outstanding nits to address but this looks good to me. With @krasimir I implemented a good fraction of the C# support and am confident that these changes are an improvement. CHANGES SINCE LAST ACTION

[PATCH] D105099: [clang-format] Add an option to put one constructor initializer per line

curdeius added a comment. Formatting part and tests look good to me, but I'd rather see this patch merge all related boolean options into one enum. Just thinking out loud, but is it doable to merge AllowAllConstructorInitializersOnNextLine, ConstructorInitializerAllOnOneLineOrOnePerLine and thi

[PATCH] D104601: [Preprocessor] Implement -fnormalize-whitespace.

Meinersbur updated this revision to Diff 355350. Meinersbur marked 6 inline comments as done. Meinersbur added a comment. - Address review by @aaron.ballman Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104601/new/ https://reviews.llvm.org/D104601

[PATCH] D104601: [Preprocessor] Implement -fnormalize-whitespace.

Meinersbur added a comment. In D104601#2847400 , @aaron.ballman wrote: > ... would add that it's very common for implementers to ask developers to run > their code through `-E` mode to submit preprocessed output in order to > reproduce a customer issue

[PATCH] D104616: [analyzer] Model comparision methods of std::unique_ptr

NoQ added a comment. I suspect that you might want to include `OperationKinds.def` instead of `OperationKinds.h`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104616/new/ https://reviews.llvm.org/D104616 _

[PATCH] D104925: [Analyzer] Improve report of file read at end-of-file condition.

NoQ added a comment. In D104925#2846283 , @balazske wrote: > I could not find a way to pass the needed information from the BugReport to > the `NoteTag`. The "sequence number" (in `EofSeqMap`) is only known when the > bug is detected, this should be pas

[PATCH] D105148: [CMake] Don't use -Bsymbolic-functions for MinGW targets

mstorsjo created this revision. mstorsjo added reviewers: MaskRay, phosek. Herald added subscribers: fedor.sergeev, mgorny. mstorsjo requested review of this revision. Herald added projects: clang, LLVM. Herald added a subscriber: cfe-commits. This is an ELF specific option which isn't supported f

[PATCH] D104918: [clang-repl] Implement partial translation units and error recovery.

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. I'm (happily) surprised this required so few changes! Comment at: clang/include/clang/Basic/LangOptions.h:690-691 + + /// The translation unit is a partial translation unit,

[PATCH] D105151: [OPENMP]Fix PR50733: unexpected final value of list-item in linear clause in loop construct.

ABataev created this revision. ABataev added reviewers: mikerice, jdoerfert. Herald added subscribers: guansong, yaxunl. ABataev requested review of this revision. Herald added a project: clang. Currently the last value of linear is calculated as var = init + num_iters * step. Replaced it with va

[PATCH] D105017: [analyzer] LValueToRValueBitCasts should evaluate to an r-value

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. So it worked out of the box? Great! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105017/new/ https://reviews.llvm.org/D105017 ___ cfe-commits m

[PATCH] D105148: [CMake] Don't use -Bsymbolic-functions for MinGW targets

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. > but I don't know if the solaris linker supports -Bsymbolic-functions or not. According to a Solaris "man pages section 1: User Commands", -Bsymbolic-functions is supported. Repository:

[PATCH] D105099: [clang-format] Add an option to put one constructor initializer per line

owenpan added a comment. In D105099#2847332 , @MyDeveloperDay wrote: > We already have > > `AllowAllConstructorInitializersOnNextLine` and > `ConstructorInitializerAllOnOneLineOrOnePerLine` > > Sort of feels like we need to combine them with this, > > I

[clang] 8d21d54 - [CodeGen] Stop creating fake FunctionDecls when generating IR for

Author: Akira Hatanaka Date: 2021-06-29T14:22:33-07:00 New Revision: 8d21d5472501460933e78aead04cf59579025ba4 URL: https://github.com/llvm/llvm-project/commit/8d21d5472501460933e78aead04cf59579025ba4 DIFF: https://github.com/llvm/llvm-project/commit/8d21d5472501460933e78aead04cf59579025ba4.diff

  1   2   >