aaron.ballman added inline comments.
================
Comment at: clang/include/clang/Basic/Attr.td:860
+ .Case("maccatalyst", "macCatalyst")
+ .Case("maccatalyst_app_extension", "macCatalyst App Extension")
.Case("swift", "Swift")
----------------
Should this be `(App Extension)` instead (consistent with the other cases)?
================
Comment at: clang/lib/Sema/SemaDeclAttr.cpp:2564
+ IdentifierInfo *NewII = nullptr;
+ auto MinIOSMacVersion = [](const VersionTuple &V) -> VersionTuple {
+ if (V.empty())
----------------
Do you need the trailing return type here?
================
Comment at: clang/lib/Sema/SemaDeclAttr.cpp:2572-2573
+ };
+ llvm::function_ref<VersionTuple(const VersionTuple &V)> VersionRemapper =
+ MinIOSMacVersion;
+ if (II->getName() == "ios")
----------------
Why do you need a `function_ref` here -- can we not just call
`MinIOSMacVersion()` instead?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105052/new/
https://reviews.llvm.org/D105052
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
