steakhal marked an inline comment as done.
steakhal added inline comments.

================
Comment at: clang/lib/StaticAnalyzer/Core/ExprEngineC.cpp:543
       case CK_VectorSplat: {
         state = handleLVectorSplat(state, LCtx, CastE, Bldr, Pred);
         continue;
----------------
steakhal wrote:
> NoQ wrote:
> > You didn't start it but that's, ugh, not a great name for the function to 
> > handle the new cast.
> > 
> > I wouldn't mind eliminating the function entirely and inlining the 
> > implementation as it actually makes the code easier to read, for once.
> I'm going to do that in an NFC follow-up patch.
D105125


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105017/new/

https://reviews.llvm.org/D105017

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to