[PATCH] D103784: [X86] Support __tile_stream_loadd intrinsic for new AMX interface

yubing updated this revision to Diff 350797. yubing added a comment. Address yuanke's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103784/new/ https://reviews.llvm.org/D103784 Files: clang/include/clang/Basic/BuiltinsX86_64.def clang

[PATCH] D101868: [clang-format] Adds a formatter for aligning arrays of structs

curdeius added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:216-221 +struct test demo[] = +{ +{56,23, "hello"}, +{-1, 93463, "world"}, +{ 7, 5,"!!"} +}; Don't forget to re-generate .rst. Rep

[PATCH] D101868: [clang-format] Adds a formatter for aligning arrays of structs

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/WhitespaceManager.h:233 + /// Align Array Initializers over all \c Changes + void alignArrayInitializers(); Can ensure the comment starts with a capital and finishes with punctuation (I perso

[PATCH] D103784: [X86] Support __tile_stream_loadd intrinsic for new AMX interface

yubing updated this revision to Diff 350803. yubing added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103784/new/ https://reviews.llvm.org/D103784 Files: clang/include/clang/Basic/BuiltinsX86_64.def clang/lib/Headers/amxint

[PATCH] D103426: Clang: Extend format string checking to wprintf/wscanf

MarcusJohnson91 added a comment. In D103426#2806391 , @aaron.ballman wrote: > Do you have a reference to the WG14 paper proposing these conversion > specifiers? I've previously written up the proposal, which you actually helped with (thank you for tha

[PATCH] D103784: [X86] Support __tile_stream_loadd intrinsic for new AMX interface

LuoYuanke accepted this revision. LuoYuanke added a comment. This revision is now accepted and ready to land. LGTM. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103784/new/ https://reviews.llvm.org/D103784 _

[PATCH] D53014: Add CMAKE_BUILD_TYPE to the list of BOOTSTRAP_DEFAULT_PASSTHROUGH variables

serge-sans-paille accepted this revision. serge-sans-paille added a comment. This revision is now accepted and ready to land. LGTM, sorry for the late review. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53014/new/ https://reviews.llvm.org/D53014 __

[PATCH] D103949: Only consider built-in compound assignment operators for -Wunused-but-set-*

sberg created this revision. sberg added a reviewer: mbenfield. sberg added a project: clang. sberg requested review of this revision. At least LibreOffice has, for mainly historic reasons that would be hard to change now, a class `Any` with an overloaded `operator >>=` that semantically does no

[PATCH] D103878: [clang][RISCV][test] Add more tests of the -mabi and -march options

benshi001 updated this revision to Diff 350828. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103878/new/ https://reviews.llvm.org/D103878 Files: clang/test/Driver/riscv-abi.c clang/test/Driver/riscv-arch.c Index: clang/test/Driver/riscv-arch.c ==

[PATCH] D103949: Only consider built-in compound assignment operators for -Wunused-but-set-*

xbolva00 added a comment. gcc also ignores it? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103949/new/ https://reviews.llvm.org/D103949 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/

[clang] d806d11 - Interp.h - AddSubMulHelper - avoid APSInt::toString std::string wrapper. NFCI

Author: Simon Pilgrim Date: 2021-06-09T11:09:31+01:00 New Revision: d806d11b14e1db7d5c5986d563e74ca972f0e5e6 URL: https://github.com/llvm/llvm-project/commit/d806d11b14e1db7d5c5986d563e74ca972f0e5e6 DIFF: https://github.com/llvm/llvm-project/commit/d806d11b14e1db7d5c5986d563e74ca972f0e5e6.diff

[clang] f3fd36e - JSONNodeDumper.cpp - VisitIntegerLiteral - avoid APSInt::toString std::string wrapper. NFCI

Author: Simon Pilgrim Date: 2021-06-09T11:09:32+01:00 New Revision: f3fd36e590f4ca36e466801bee40497714df895c URL: https://github.com/llvm/llvm-project/commit/f3fd36e590f4ca36e466801bee40497714df895c DIFF: https://github.com/llvm/llvm-project/commit/f3fd36e590f4ca36e466801bee40497714df895c.diff

[PATCH] D103949: Only consider built-in compound assignment operators for -Wunused-but-set-*

sberg added a comment. In D103949#2807490 , @xbolva00 wrote: > gcc also ignores it? For reasons that I never looked into, GCC never warned for any of these cases. The Clang implementation appears to be way more aggressive (in a positive sense) to begi

[PATCH] D103720: [clang] NFC: Rename rvalue to prvalue

This revision was automatically updated to reflect the committed changes. Closed by commit rGaef5d8fdc7d0: [clang] NFC: Rename rvalue to prvalue (authored by mizvekov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103720/new/ https://reviews.llvm.o

[clang] c25572b - [clang] NFC: rename SK_CastDerivedToBaseRValue to SK_CastDerivedToBasePRValue

Author: Matheus Izvekov Date: 2021-06-09T12:38:59+02:00 New Revision: c25572bf2993438f24b57d859d072e8b2aa975d2 URL: https://github.com/llvm/llvm-project/commit/c25572bf2993438f24b57d859d072e8b2aa975d2 DIFF: https://github.com/llvm/llvm-project/commit/c25572bf2993438f24b57d859d072e8b2aa975d2.dif

[PATCH] D103933: [clang] NFC: rename SK_CastDerivedToBaseRValue to SK_CastDerivedToBasePRValue

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc25572bf2993: [clang] NFC: rename SK_CastDerivedToBaseRValue to SK_CastDerivedToBasePRValue (authored by mizvekov). Repository: rG LLVM Github Mon

[PATCH] D103663: [AMDGPU] Add gfx1013 target

foad added inline comments. Comment at: llvm/lib/Target/AMDGPU/AMDGPU.td:471 + "true", + "Encoding format GFX10_A" +>; bcahoon wrote: > foad wrote: > > I realise you're just following the precedent set by GFX10_B, but is this > > terminology actually used in a

[PATCH] D97869: [OpenCL] Add OpenCL builtin test generator

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97869/new/ https://reviews.llvm.org/D97869 ___ cfe-commits mailing list

[PATCH] D103953: Sanitizers.h - remove MathExtras.h include dependency

RKSimon created this revision. RKSimon added reviewers: pgousseau, filcab, bkramer. Herald added a subscriber: dexonsmith. RKSimon requested review of this revision. Herald added a project: clang. We include the MathExtras.h header purely for the countPopulation() method - by moving this into San

[PATCH] D103953: Sanitizers.h - remove MathExtras.h include dependency

RKSimon added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:3129 static CheckRecoverableKind getRecoverableKind(SanitizerMask Kind) { - assert(Kind.countPopulation() == 1); + assert(Kind.isPowerOf2()); if (Kind == SanitizerKind::Function || Kind == SanitizerKind

[PATCH] D97869: [OpenCL] Add OpenCL builtin test generator

azabaznov added a comment. @svenvh, are you going to add header-like output emitting? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97869/new/ https://reviews.llvm.org/D97869 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

[PATCH] D103953: Sanitizers.h - remove MathExtras.h include dependency

pgousseau accepted this revision. pgousseau added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103953/new/ https://reviews.llvm.org/D103953

[clang] c92f505 - Correct the behavior of va_arg checking in C++

Author: Aaron Ballman Date: 2021-06-09T07:18:32-04:00 New Revision: c92f505346b80fd053ef191bbc66810c9d564b0c URL: https://github.com/llvm/llvm-project/commit/c92f505346b80fd053ef191bbc66810c9d564b0c DIFF: https://github.com/llvm/llvm-project/commit/c92f505346b80fd053ef191bbc66810c9d564b0c.diff

[PATCH] D103611: Correct the behavior of va_arg checking in C++

aaron.ballman closed this revision. aaron.ballman added a comment. Thank you for the reviews, @efriedma! I have committed in c92f505346b80fd053ef191bbc66810c9d564b0c CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1036

[PATCH] D103949: Only consider built-in compound assignment operators for -Wunused-but-set-*

xbolva00 added a comment. Ok thanks for info. We should follow gcc in this case. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103949/new/ https://reviews.llvm.org/D103949 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[PATCH] D97869: [OpenCL] Add OpenCL builtin test generator

svenvh added a comment. In D97869#2807627 , @azabaznov wrote: > @svenvh, are you going to add header-like output emitting? Yes, I can add that if there is interest. I already have it on a local branch, so if there is interest (and it seems there is? :-)

[PATCH] D97869: [OpenCL] Add OpenCL builtin test generator

azabaznov added a comment. In D97869#2807654 , @svenvh wrote: > In D97869#2807627 , @azabaznov wrote: > >> @svenvh, are you going to add header-like output emitting? > > Yes, I can add that if there is interest. I

[PATCH] D102689: [C++] Ignore top-level qualifiers in casts

Anastasia added inline comments. Comment at: clang/test/SemaCXX/warn-reinterpret-base-class.cpp:301 - // expected-warning@+2 {{'reinterpret_cast' to class 'L' (aka 'const F *volatile') from its base at non-zero offset 'E *' behaves differently from 'static_cast'}} + // expe

[PATCH] D102850: [C++4OpenCL] Fix overloading resolution of addrspace constructors

Anastasia added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:9870 + if (S.getLangOpts().OpenCL) { +if (const auto *CD1 = dyn_cast_or_null(Cand1.Function)) { Anastasia wrote: > olestrohm wrote: > > Anastasia wrote: > > > olestrohm wrote: >

[PATCH] D102689: [C++] Ignore top-level qualifiers in casts

olestrohm added inline comments. Comment at: clang/test/SemaCXX/warn-reinterpret-base-class.cpp:301 - // expected-warning@+2 {{'reinterpret_cast' to class 'L' (aka 'const F *volatile') from its base at non-zero offset 'E *' behaves differently from 'static_cast'}} + // expe

[PATCH] D103911: [OpenCL] Add support of __opencl_c_images feature macro

svenvh added inline comments. Comment at: clang/test/SemaOpenCL/unsupported-image.cl:1 +// RUN: %clang_cc1 -verify -cl-std=CL3.0 -cl-ext=-__opencl_c_images %s +// RUN: %clang_cc1 -verify -cl-std=CL3.0 -cl-ext=+__opencl_c_images %s Should we add `-triple spir`, as

[PATCH] D103401: [OpenCL] Add support of __opencl_c_generic_address_space feature macro

Anastasia added inline comments. Comment at: clang/lib/Basic/TargetInfo.cpp:405 + const auto &OpenCLFeaturesMap = getSupportedOpenCLOpts(); + Opts.OpenCLGenericAddressSpace = hasFeatureEnabled( + OpenCLFeaturesMap, "__opencl_c_generic_address_space"); -

[PATCH] D103911: [OpenCL] Add support of __opencl_c_images feature macro

Anastasia added inline comments. Comment at: clang/test/SemaOpenCL/unsupported-image.cl:1 +// RUN: %clang_cc1 -verify -cl-std=CL3.0 -cl-ext=-__opencl_c_images %s +// RUN: %clang_cc1 -verify -cl-std=CL3.0 -cl-ext=+__opencl_c_images %s svenvh wrote: > Should we add

[PATCH] D103911: [OpenCL] Add support of __opencl_c_images feature macro

azabaznov added inline comments. Comment at: clang/test/SemaOpenCL/unsupported-image.cl:1 +// RUN: %clang_cc1 -verify -cl-std=CL3.0 -cl-ext=-__opencl_c_images %s +// RUN: %clang_cc1 -verify -cl-std=CL3.0 -cl-ext=+__opencl_c_images %s Anastasia wrote: > svenvh wro

[clang] 64dbd64 - [clang-cl] Parse /await:strict, new in MSVC 16.10

Author: Hans Wennborg Date: 2021-06-09T14:27:05+02:00 New Revision: 64dbd649cf661cbca5e8670d220aec40d6892572 URL: https://github.com/llvm/llvm-project/commit/64dbd649cf661cbca5e8670d220aec40d6892572 DIFF: https://github.com/llvm/llvm-project/commit/64dbd649cf661cbca5e8670d220aec40d6892572.diff

[PATCH] D103623: [Clang] Test case for -Wunused-but-set-variable, warn for volatile.

sberg accepted this revision. sberg added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103623/new/ https://reviews.llvm.org/D103623 ___ c

[PATCH] D103958: [WIP] Support MustControl conditional control attribute

melver created this revision. Herald added subscribers: dexonsmith, jfb, hiraditya. Herald added a reviewer: aaron.ballman. melver requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, jdoerfert. Herald added projects: clang, LLVM. [ WIP, only high-level comments

[clang] c1cd743 - [clang] p1099 using-enum feature macro & web page

Author: Nathan Sidwell Date: 2021-06-09T05:40:53-07:00 New Revision: c1cd743519af3978b944df88f57c6e523caa10dc URL: https://github.com/llvm/llvm-project/commit/c1cd743519af3978b944df88f57c6e523caa10dc DIFF: https://github.com/llvm/llvm-project/commit/c1cd743519af3978b944df88f57c6e523caa10dc.diff

[PATCH] D102242: [clang] p1099 5/5: feature macro & web page

This revision was automatically updated to reflect the committed changes. Closed by commit rGc1cd743519af: [clang] p1099 using-enum feature macro & web page (authored by urnathan). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D103958: [WIP] Support MustControl conditional control attribute

lebedev.ri added a comment. This is missing langref changes, and a RFC to llvm-dev. I'm rather skeptical of this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103958/new/ https://reviews.llvm.org/D103958 __

[PATCH] D99436: [OPENMP]Fix PR49366: crash on VLAs in task untied regions.

ABataev updated this revision to Diff 350870. ABataev added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99436/new/ https://reviews.llvm.org/D99436 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/include/clang/Se

[PATCH] D88174: [Sema] Address-space sensitive check for unbounded arrays (v2)

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! Thank you for the fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88174/new/ https://reviews.llvm.org/D88174 ___ cfe-commits

[PATCH] D103426: Clang: Extend format string checking to wprintf/wscanf

aaron.ballman added a comment. In D103426#2807245 , @MarcusJohnson91 wrote: > In D103426#2806391 , @aaron.ballman > wrote: > >> Do you have a reference to the WG14 paper proposing these conversion >> specifiers

[PATCH] D103961: [analyzer] Extract InlinedFunctionCallHandler

vsavchenko created this revision. vsavchenko added reviewers: NoQ, xazax.hun, martong, steakhal, Szelethus, manas, RedDocMD. Herald added subscribers: ASDenysPetrov, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. vsavchenko requested review of this revision.

[PATCH] D103962: [C++4OpenCL] Fix qualifiers check on binding references to temporaries

olestrohm created this revision. olestrohm added reviewers: Anastasia, svenvh. olestrohm added a project: clang. Herald added subscribers: ldrumm, yaxunl. olestrohm requested review of this revision. Herald added a subscriber: cfe-commits. Fixing the qualifiers check from PR49733. It would be gre

[PATCH] D97869: [OpenCL] Add OpenCL builtin test generator

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8866793b4e0a: [OpenCL] Add OpenCL builtin test generator (authored by svenvh). Herald added a subscriber: ldrumm. Herald added a project: clang. Cha

[clang] 8866793 - [OpenCL] Add OpenCL builtin test generator

Author: Sven van Haastregt Date: 2021-06-09T14:03:58+01:00 New Revision: 8866793b4e0abd31e4f57abf9ba832d691a3a3e1 URL: https://github.com/llvm/llvm-project/commit/8866793b4e0abd31e4f57abf9ba832d691a3a3e1 DIFF: https://github.com/llvm/llvm-project/commit/8866793b4e0abd31e4f57abf9ba832d691a3a3e1.

[clang] 206a66d - Sanitizers.h - remove MathExtras.h include dependency

Author: Simon Pilgrim Date: 2021-06-09T14:38:20+01:00 New Revision: 206a66de5902b2b6dc0c62c4a25526d7e7f24186 URL: https://github.com/llvm/llvm-project/commit/206a66de5902b2b6dc0c62c4a25526d7e7f24186 DIFF: https://github.com/llvm/llvm-project/commit/206a66de5902b2b6dc0c62c4a25526d7e7f24186.diff

[PATCH] D103953: Sanitizers.h - remove MathExtras.h include dependency

This revision was automatically updated to reflect the committed changes. Closed by commit rG206a66de5902: Sanitizers.h - remove MathExtras.h include dependency (authored by RKSimon). Changed prior to commit: https://reviews.llvm.org/D103953?vs=350845&id=350882#toc Repository: rG LLVM Github

[PATCH] D93525: [clang-offload-bundler] Add unbundling of archives containing bundled object files into device specific archives

saiislam updated this revision to Diff 350883. saiislam added a comment. 1. Removed TargetID support, to be reviewed in a followup patch. 2. Added OffloadTargetInfo class to encapsulate handling of bundle entry ID components: OffloadKind, Triple, GPUArch. Repository: rG LLVM Github Monorepo

[PATCH] D93525: [clang-offload-bundler] Add unbundling of archives containing bundled object files into device specific archives

saiislam updated this revision to Diff 350884. saiislam added a comment. Removed unused header. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93525/new/ https://reviews.llvm.org/D93525 Files: clang/docs/ClangOffloadBundler.rst clang/test/Drive

[PATCH] D103958: [WIP] Support MustControl conditional control attribute

melver added a comment. In D103958#2807811 , @lebedev.ri wrote: > This is missing langref changes, and a RFC to llvm-dev. We're not there yet, but will send something. Having real code helped me understand what out the myriad of options that were discu

[PATCH] D93525: [clang-offload-bundler] Add unbundling of archives containing bundled object files into device specific archives

jdoerfert added a comment. Thanks for splitting this. I quickly went over it only. Comment at: clang/docs/ClangOffloadBundler.rst:137 + + myarch--myOS- not needed here. Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:

[PATCH] D103934: clang/darwin: use response files with ld64

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. Nice :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103934/new/ https://reviews.llvm.org/D103934

[PATCH] D103958: [WIP] Support MustControl conditional control attribute

jdoerfert added a comment. WIP here is fine, would help to include a test that shows/explains what problem is actually solved though. I don't understand form this patch alone. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103958/new/ https://revie

[PATCH] D103888: [ADT] Remove APInt/APSInt toString() std::string variants

RKSimon updated this revision to Diff 350893. RKSimon added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103888/new/ https://reviews.llvm.org/D103888 Files: clang-tools-extra/clang-tidy/abseil/DurationRewriter.cpp clang-too

[PATCH] D99675: [llvm][clang] Create new intrinsic llvm.arith.fence to control FP optimization at expression level

pengfei added inline comments. Comment at: llvm/docs/LangRef.rst:21195 +'``llvm.arithmetic_fence``' Intrinsic +^^ + pengfei wrote: > Should be equal to the text? Yeah, a good catch. But I initially meant `^^^` should be equal to the ti

[PATCH] D93525: [clang-offload-bundler] Add unbundling of archives containing bundled object files into device specific archives

saiislam updated this revision to Diff 350897. saiislam added a comment. Removed Triple format example from documentation and simplified conditional calling of bundling/unbundling functions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93525/new/

[PATCH] D101139: Create install targets for scan-build-py.

wanders added a comment. I think this looks good. I can't vouch for the cmake changes. However there seems like diff is based on something that already has moved parts into libexec. It doesn't apply cleanly here - and buildkite seems to complain too. Make sure you have the complete diff. CHAN

[PATCH] D103314: [Analyzer][solver] Simplify existing constraints when a new constraint is added

martong updated this revision to Diff 350898. martong added a comment. - Simplify the symbol before eq tracking as well Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103314/new/ https://reviews.llvm.org/D103314 Files: clang/include/clang/Static

[PATCH] D103314: [Analyzer][solver] Simplify existing constraints when a new constraint is added

martong added a comment. In D103314#2798968 , @martong wrote: > In D103314#2790868 , @vsavchenko > wrote: > >> Awesome! >> I know, I said that we are ready to land, but I think I was too excited >> about this ch

[PATCH] D101237: [lldb] Fix [[no_unique_address]] and libstdc++ 11's std::unique_ptr

jankratochvil updated this revision to Diff 350900. jankratochvil edited the summary of this revision. jankratochvil added a comment. This patch now requires: D101236 , D103910 and D103966 .

[PATCH] D103967: [Analyzer][solver] Add dump methods for (dis)equality classes.

martong created this revision. martong added reviewers: vsavchenko, NoQ, steakhal. Herald added subscribers: manas, ASDenysPetrov, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun, whisperity. Herald added a reviewer: Szelethus.

[PATCH] D103967: [Analyzer][solver] Add dump methods for (dis)equality classes.

martong updated this revision to Diff 350905. martong added a comment. - Change comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103967/new/ https://reviews.llvm.org/D103967 Files: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp

[PATCH] D102782: Add support for Warning Flag "-Wstack-usage="

rsanthir.quic added a comment. @bruno all tests are passing, could you take another look when you have a chance? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102782/new/ https://reviews.llvm.org/D102782 __

[PATCH] D103792: [clang][AST] Set correct DeclContext in ASTImporter lookup table for template params.

balazske updated this revision to Diff 350906. balazske added a comment. Add test for deduction guides. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103792/new/ https://reviews.llvm.org/D103792 Files: clang/lib/AST/ASTImporter.cpp clang/unitt

[PATCH] D90835: [clang-tidy] Ignore diagnostics due to macro expansion from not-interested headers

lebedev.ri added a comment. This needs to explain why the existing functionality isn't sufficient - if the header is really not from this project, then it should be included via `-isystem`, and that will naturally suppress all diagnostics from it. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D103792: [clang][AST] Set correct DeclContext in ASTImporter lookup table for template params.

balazske marked an inline comment as done. balazske added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:6005 + // Template parameters for a CXXDeductionGuideDecl are re-used by the + // non-deduction-guide-decl template. That template is imported too, and ---

[PATCH] D103792: [clang][AST] Set correct DeclContext in ASTImporter lookup table for template params.

balazske marked an inline comment as done. balazske added inline comments. Comment at: clang/unittests/AST/ASTImporterTest.cpp:4468 + `-ParmVarDecl 0x13f3728 col:36 'A' + */ + auto *FromD1 = FirstDeclMatcher().match( This should not have been reformatted.

[PATCH] D103911: [OpenCL] Add support of __opencl_c_images feature macro

Anastasia added inline comments. Comment at: clang/test/SemaOpenCL/unsupported-image.cl:1 +// RUN: %clang_cc1 -verify -cl-std=CL3.0 -cl-ext=-__opencl_c_images %s +// RUN: %clang_cc1 -verify -cl-std=CL3.0 -cl-ext=+__opencl_c_images %s azabaznov wrote: > Anastasia

[PATCH] D90835: [clang-tidy] Ignore diagnostics due to macro expansion from not-interested headers

DmitryPolukhin added a comment. In D90835#2808153 , @lebedev.ri wrote: > This needs to explain why the existing functionality isn't sufficient - if > the header is really not from this project, > then it should be included via `-isystem`, and that will na

[PATCH] D102782: Add support for Warning Flag "-Wstack-usage="

Quuxplusone added inline comments. Comment at: clang/docs/ReleaseNotes.rst:79-80 +- ``-Wstack-usage=`` warn if stack usage of user functions might + exceed . + Does this mean: - Warn if the size of any single function's stack frame (including temporaries and

[PATCH] D101868: [clang-format] Adds a formatter for aligning arrays of structs

feg208 updated this revision to Diff 350910. feg208 marked 4 inline comments as done. feg208 added a comment. Gets some of the formatting issues. Still chasing a test issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101868/new/ https://reviews.

[PATCH] D101868: [clang-format] Adds a formatter for aligning arrays of structs

feg208 added a comment. Got some changes. The failing test is an open issue Comment at: clang/docs/ClangFormatStyleOptions.rst:216-221 +struct test demo[] = +{ +{56,23, "hello"}, +{-1, 93463, "world"}, +{ 7, 5,"!!"} +}; --

[PATCH] D103314: [Analyzer][solver] Simplify existing constraints when a new constraint is added

vsavchenko added a comment. OK, we definitely need to know about performance. Plus, I'm still curious about the crash. I didn't get how simplification helped/caused that crash. I have one thought here. If the lack of simplification indeed caused the crash, we are in trouble with this patch. I

[PATCH] D99675: [llvm][clang] Create new intrinsic llvm.arithmetic.fence to control FP optimization at expression level

mibintc updated this revision to Diff 350912. mibintc retitled this revision from "[llvm][clang] Create new intrinsic llvm.arith.fence to control FP optimization at expression level" to "[llvm][clang] Create new intrinsic llvm.arithmetic.fence to control FP optimization at expression level". mib

[PATCH] D103495: [static initializers] Emit global_ctors and global_dtors in reverse order when init_array is not used.

rnk added a subscriber: probinson. rnk added a comment. In D103495#2806097 , @jyknight wrote: > Won't this change cause weird effects with LTO, when you're merging multiple > TUs' global_ctors arrays before emitting? Won't this end up reversing the > or

[clang] 1c7f339 - clang/darwin: use response files with ld64

Author: Keith Smiley Date: 2021-06-09T09:04:37-07:00 New Revision: 1c7f3395b8ec52462220898495883ec570390367 URL: https://github.com/llvm/llvm-project/commit/1c7f3395b8ec52462220898495883ec570390367 DIFF: https://github.com/llvm/llvm-project/commit/1c7f3395b8ec52462220898495883ec570390367.diff

[PATCH] D103934: clang/darwin: use response files with ld64

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1c7f3395b8ec: clang/darwin: use response files with ld64 (authored by keith). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D103949: Only consider built-in compound assignment operators for -Wunused-but-set-*

mbenfield added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:7794-7798 +if (BO->getLHS()->getType()->isDependentType() || +BO->getRHS()->getType()->isDependentType()) +{ + if (BO->getOpcode() != BO_Assign) +return; Woul

[PATCH] D101868: [clang-format] Adds a formatter for aligning arrays of structs

feg208 updated this revision to Diff 350920. feg208 added a comment. Fixes the busted test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101868/new/ https://reviews.llvm.org/D101868 Files: clang/docs/ClangFormatStyleOptions.rst clang/docs/Rele

[PATCH] D101868: [clang-format] Adds a formatter for aligning arrays of structs

feg208 updated this revision to Diff 350924. feg208 added a comment. Ick. Missed a semi colon in the test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101868/new/ https://reviews.llvm.org/D101868 Files: clang/docs/ClangFormatStyleOptions.rst

[PATCH] D103314: [Analyzer][solver] Simplify existing constraints when a new constraint is added

martong marked 2 inline comments as done. martong added a comment. > I have one thought here. If the lack of simplification indeed caused the > crash, we are in trouble with this patch. IMO simplification in just one > place should make it better, but shouldn't produce infeasible states for us.

[PATCH] D103967: [Analyzer][solver] Add dump methods for (dis)equality classes.

vsavchenko added a comment. This is definitely useful! Thanks! I was just wondering if we should add it into the state printer instead. @NoQ what's your take on this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103967/new/ https://reviews.llvm

[PATCH] D101139: Create install targets for scan-build-py.

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101139/new/ https://reviews.llvm.org/D101139 ___ cfe-commits mailing list cfe-commits@l

[clang] 8908903 - Corrects some minor issues with the CXX status page.

Author: Aaron Ballman Date: 2021-06-09T13:38:41-04:00 New Revision: 8908903eacb0e0a79c004e49959f860b5c0e4d53 URL: https://github.com/llvm/llvm-project/commit/8908903eacb0e0a79c004e49959f860b5c0e4d53 DIFF: https://github.com/llvm/llvm-project/commit/8908903eacb0e0a79c004e49959f860b5c0e4d53.diff

[PATCH] D103894: NarrowingConversionsCheck should support inhibiting conversions of mixed integer and floating point types with WarnOnEquivalentBitWidth=0.

Stephen updated this revision to Diff 350950. Stephen added a comment. Fix the expected error messages. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103894/new/ https://reviews.llvm.org/D103894 Files: clang-tools-extra/test/clang-tidy/checkers

[PATCH] D103845: [compiler-rt][hwasan] Add newline between record_addr lines on frame record dumps

pcc added a comment. Thanks for tracking this down. It seems best to change the Printf call to add the newline, since otherwise it looks like you'd be adding a spurious newline to the other callers of `RenderFrame` on Fuchsia. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 64b2fb7 - [CSSPGO] Emit mangled dwarf names for line tables debug option under -fpseudo-probe-for-profiling

Author: Hongtao Yu Date: 2021-06-09T10:46:03-07:00 New Revision: 64b2fb7967a749b83f59656f0cd2f4d00501efaa URL: https://github.com/llvm/llvm-project/commit/64b2fb7967a749b83f59656f0cd2f4d00501efaa DIFF: https://github.com/llvm/llvm-project/commit/64b2fb7967a749b83f59656f0cd2f4d00501efaa.diff LO

[PATCH] D103909: [CSSPGO] Emit mangled dwarf names for line tables debug option under -fpseudo-probe-for-profiling

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG64b2fb7967a7: [CSSPGO] Emit mangled dwarf names for line tables debug option under -fpseudo… (authored by hoy). Repository: rG LLVM Github Monorep

[PATCH] D99696: [clang] NRVO: Improvements and handling of more cases.

Quuxplusone accepted this revision. Quuxplusone added a comment. This revision is now accepted and ready to land. @mizvekov, my understanding is: - D99696 was temporarily blocked on D103720 , but now D103720

[PATCH] D103982: [clang] Make CXXDefaultArgExpr inherit dependence from the inner Expr

adamcz created this revision. adamcz added a reviewer: hokein. adamcz requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Before this change, CXXDefaultArgExpr would always have ExprDependence::None. This can lead to issues when, for example, t

[PATCH] D101868: [clang-format] Adds a formatter for aligning arrays of structs

curdeius added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:216-221 +struct test demo[] = +{ +{56,23, "hello"}, +{-1, 93463, "world"}, +{ 7, 5,"!!"} +}; feg208 wrote: > curdeius wrote: > > Don

[PATCH] D103314: [Analyzer][solver] Simplify existing constraints when a new constraint is added

martong marked 2 inline comments as done. martong added inline comments. Comment at: clang/test/Analysis/find-binop-constraints.cpp:155-158 +// Here, e1 is still bound to (reg_$0) - (reg_$1) but we +// should be able to simplify it to (reg_$0) - 2 and thus realize +//

[PATCH] D103825: [clang] Do not crash when ArgTy is null in CheckArgAlignment

adamcz added a comment. Thanks Haojian! I sent out https://reviews.llvm.org/D103982 for the CXXDefaultArgExpr. I'll update this change after I submit that one. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103825/new/ https://reviews.llvm.org/D103

[PATCH] D103314: [Analyzer][solver] Simplify existing constraints when a new constraint is added

martong added a comment. > OK, we definitely need to know about performance. Couldn't agree more. I am in the middle of a performance measurement that I do with csa-testbench (on memchached,tmux,curl,twin,redis,vim,openssl,sqlite,ffmpeg,postgresql,tinyxml2,libwebm,xerces,bitcoin,protobuf). Hop

[PATCH] D103314: [Analyzer][solver] Simplify existing constraints when a new constraint is added

martong updated this revision to Diff 350966. martong marked an inline comment as done. martong added a comment. - Remove isEqualTo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103314/new/ https://reviews.llvm.org/D103314 Files: clang/include/

[PATCH] D103314: [Analyzer][solver] Simplify existing constraints when a new constraint is added

martong marked an inline comment as done. martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:1789 + if (DisequalToOther.contains(*this)) +return nullptr; if (!DisequalToOther.isEmpty()) { vsavchenko wrote:

[PATCH] D101139: Create install targets for scan-build-py.

isthismyaccount added a comment. Thanks for the reviews. I'll take over this and try to get the merge conflicts resolved. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101139/new/ https://reviews.llvm.org/D101139 ___ cfe-commits mailing list

[PATCH] D103958: [WIP] Support MustControl conditional control attribute

nickdesaulniers added a comment. The first talk from https://www.youtube.com/watch?v=FFjV9f_Ub9o (https://github.com/ClangBuiltLinux/plumbers-2020-slides/blob/master/LPC_2020_--_Dependency_ordering.pdf) might be helpful to link to at some point from the commit message, for a little additional c

  1   2   >