Anastasia added inline comments.
================ Comment at: clang/test/SemaOpenCL/unsupported-image.cl:1 +// RUN: %clang_cc1 -verify -cl-std=CL3.0 -cl-ext=-__opencl_c_images %s +// RUN: %clang_cc1 -verify -cl-std=CL3.0 -cl-ext=+__opencl_c_images %s ---------------- svenvh wrote: > Should we add `-triple spir`, as some of the image types (e.g. msaa) are part > of an extension that may not be available for every default triple? yes, the test might fail in some bots otherwise... Btw it would be good to test that 3d images work correctly for OpenCL 3. Would it work if we add `RUN` line with `CL3.0` into `test/SemaOpenCL/access-qualifier.cl` or are we missing some more work to enable the test? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103911/new/ https://reviews.llvm.org/D103911 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
