[PATCH] D102577: TreeTransform.h: make the switch case more beautiful

zhouyizhou added a comment. I do some "grep" in clang/lib directory: llvm-project/clang/lib#find . -name "*.*"|xargs grep -n -B 2 "break;"|grep -A 2 "}" my patch also seems to match the coding style of other parts of clang. Thanks again CHANGES SINCE LAST ACTION https://reviews.llvm.org/D10

[PATCH] D102479: [clang][driver] Treat unkonwn -flto= values as -flto

tbaeder updated this revision to Diff 345763. tbaeder added a comment. On second thought, rather only handle `=auto` and `=jobserver` and don't warn. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102479/new/ https://reviews.llvm.org/D102479 Files: clang/include/clang/Driver/Options.t

[clang] b9d5b0c - [clang][deps] NFC: Stop assuming the TU's context hash

Author: Jan Svoboda Date: 2021-05-17T09:16:00+02:00 New Revision: b9d5b0c20180e41f24722e622b8c3a3bb510fc1d URL: https://github.com/llvm/llvm-project/commit/b9d5b0c20180e41f24722e622b8c3a3bb510fc1d DIFF: https://github.com/llvm/llvm-project/commit/b9d5b0c20180e41f24722e622b8c3a3bb510fc1d.diff L

[PATCH] D102473: [clang][deps] NFC: Stop assuming the TU's context hash

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb9d5b0c20180: [clang][deps] NFC: Stop assuming the TU's context hash (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D102592: [sanitizer] Caught global buffer underflow for first variable

condy updated this revision to Diff 345767. condy added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fix some tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102592/new/ https://reviews.llvm.org/D102592 Fil

[PATCH] D102482: [clang][deps] NFC: Report modules' context hash

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd3fb4b9065e9: [clang][deps] NFC: Report modules' context hash (authored by jansvoboda11). Changed prior to commit: https://reviews.llvm.org/D10248

[clang] d3fb4b9 - [clang][deps] NFC: Report modules' context hash

Author: Jan Svoboda Date: 2021-05-17T09:24:23+02:00 New Revision: d3fb4b9065e93e2617db44f3ab9c31f341d9cd1f URL: https://github.com/llvm/llvm-project/commit/d3fb4b9065e93e2617db44f3ab9c31f341d9cd1f DIFF: https://github.com/llvm/llvm-project/commit/d3fb4b9065e93e2617db44f3ab9c31f341d9cd1f.diff L

[clang] d9cb70b - [clang] NFC: Remove CompilerInstance::getInvocationPtr

Author: Jan Svoboda Date: 2021-05-17T09:33:35+02:00 New Revision: d9cb70ba29dbd74aac294caad0686f1ed52295f9 URL: https://github.com/llvm/llvm-project/commit/d9cb70ba29dbd74aac294caad0686f1ed52295f9 DIFF: https://github.com/llvm/llvm-project/commit/d9cb70ba29dbd74aac294caad0686f1ed52295f9.diff L

[PATCH] D102482: [clang][deps] NFC: Report modules' context hash

jansvoboda11 added a comment. Thanks for the review! Comment at: clang/include/clang/Frontend/CompilerInstance.h:230-232 - std::shared_ptr getInvocationPtr() { + CompilerInvocation &getInvocation() { assert(Invocation && "Compiler instance has no invocation!"); -retu

[PATCH] D102519: [clangd] Set FileSystem for tweaks in Check tool.

kadircet added a comment. thanks, lgtm! Comment at: clang-tools-extra/clangd/tool/Check.cpp:215 nullptr); - for (const auto &T : - prepareTweaks(Selection, Opts.TweakFilter, Opts.FeatureModules)) { + auto Tweaks = +

[PATCH] D102592: [sanitizer] Caught global buffer underflow for first variable

condy updated this revision to Diff 345777. condy added a comment. Fix some tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102592/new/ https://reviews.llvm.org/D102592 Files: clang/test/CodeGen/asan-globals-alias.cpp clang/test/CodeGen/as

[PATCH] D102592: [sanitizer] Caught global buffer underflow for first variable

condy updated this revision to Diff 345784. condy added a comment. Fix all tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102592/new/ https://reviews.llvm.org/D102592 Files: clang/test/CodeGen/asan-globals-alias.cpp clang/test/CodeGen/asa

[PATCH] D102592: [sanitizer] Caught global buffer underflow for first variable

condy updated this revision to Diff 345786. condy added a comment. Fix typos Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102592/new/ https://reviews.llvm.org/D102592 Files: clang/test/CodeGen/asan-globals-alias.cpp clang/test/CodeGen/asan-gl

[PATCH] D102577: TreeTransform.h: make the switch case more beautiful

pengfei added a comment. I think you can add a NFC in the title. Comment at: clang/lib/Sema/TreeTransform.h:3947-3949 NestedNameSpecifierLoc NNS, QualType ObjectType,

[clang] d3676d4 - [clang][modules] Build inferred modules

Author: Michael Spencer Date: 2021-05-17T10:40:51+02:00 New Revision: d3676d4b666ead794fc58bbc7e07aa406dcf487a URL: https://github.com/llvm/llvm-project/commit/d3676d4b666ead794fc58bbc7e07aa406dcf487a DIFF: https://github.com/llvm/llvm-project/commit/d3676d4b666ead794fc58bbc7e07aa406dcf487a.dif

[PATCH] D102491: [clang][modules] Build inferred modules

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd3676d4b666e: [clang][modules] Build inferred modules (authored by Bigcheese, committed by jansvoboda11). Repository: rG LLVM Github Monorepo CHA

[PATCH] D102280: [analyzer] Engine: fix crash with SEH __leave keyword

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. I think it's good to go. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102280/new/ https://reviews.llvm.org/D102280

[PATCH] D102577: NFC: TreeTransform.h: make the switch case more beautiful

zhouyizhou updated this revision to Diff 345792. zhouyizhou retitled this revision from "TreeTransform.h: make the switch case more beautiful " to "NFC: TreeTransform.h: make the switch case more beautiful ". zhouyizhou added a comment. use clang-format to fix the function TransformNestedNameSpe

[PATCH] D102519: [clangd] Set FileSystem for tweaks in Check tool.

usaxena95 updated this revision to Diff 345793. usaxena95 marked an inline comment as done. usaxena95 added a comment. added comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102519/new/ https://reviews.llvm.org/D102519 Files: clang-tools-e

[clang-tools-extra] 0e7c7d4 - [clangd] Set FileSystem for tweaks in Check tool.

Author: Utkarsh Saxena Date: 2021-05-17T11:10:07+02:00 New Revision: 0e7c7d461df167f141428286afb781636ac92a9e URL: https://github.com/llvm/llvm-project/commit/0e7c7d461df167f141428286afb781636ac92a9e DIFF: https://github.com/llvm/llvm-project/commit/0e7c7d461df167f141428286afb781636ac92a9e.diff

[PATCH] D102519: [clangd] Set FileSystem for tweaks in Check tool.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0e7c7d461df1: [clangd] Set FileSystem for tweaks in Check tool. (a

[PATCH] D102519: [clangd] Set FileSystem for tweaks in Check tool.

usaxena95 added a comment. Did you need any other change ? Didn't realised the revision was not "accepted". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102519/new/ https://reviews.llvm.org/D102519 ___

[PATCH] D102519: [clangd] Set FileSystem for tweaks in Check tool.

kadircet added a comment. oops, sorry. i thought i've accepted the revision already :D Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102519/new/ https://reviews.llvm.org/D102519 ___ cfe-commits mailing l

[clang] 1d9e8e1 - [clang][deps] Support inferred modules

Author: Michael Spencer Date: 2021-05-17T11:41:54+02:00 New Revision: 1d9e8e13dd7b3204fa51ada17d1608bdbd1bed66 URL: https://github.com/llvm/llvm-project/commit/1d9e8e13dd7b3204fa51ada17d1608bdbd1bed66 DIFF: https://github.com/llvm/llvm-project/commit/1d9e8e13dd7b3204fa51ada17d1608bdbd1bed66.dif

[PATCH] D102495: [clang][deps] Support inferred modules

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1d9e8e13dd7b: [clang][deps] Support inferred modules (authored by Bigcheese, committed by jansvoboda11). Changed prior to commit: https://reviews.

[PATCH] D102577: NFC: TreeTransform.h: make the function TransformNestedNameSpecifierLoc more beautiful

pengfei accepted this revision. pengfei added a comment. This revision is now accepted and ready to land. LGTM. Thanks for improving it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102577/new/ https://reviews.llvm.org/D102577 ___ cfe-commit

[PATCH] D102443: [PowerPC] Added multiple PowerPC builtins

qiucf added a comment. Is there any motivation to add these builtins? I don't see them implemented in GCC. Besides, in Clang I think a prefix `__builtin` is preferred for them. Comment at: clang/include/clang/Basic/BuiltinsPPC.def:28 +BUILTIN(__popcntb, "ULiULi", "") +BUILTI

[PATCH] D100396: [SYCL] Enable `opencl_global_[host,device]` attributes for SYCL

bader updated this revision to Diff 345806. bader marked an inline comment as done. bader added a comment. Added documentation to cover conversion rules and rebased on ToT. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100396/new/ https://reviews.l

[PATCH] D102280: [analyzer] Engine: fix crash with SEH __leave keyword

AbbasSabra added a comment. In D102280#2762760 , @steakhal wrote: > I think it's good to go. Thank you! Great! can you take care of merging it? I don't have accesss. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D102495: [clang][deps] Support inferred modules

RKSimon added inline comments. Comment at: clang/utils/module-deps-to-rsp.py:1 +#!/usr/bin/env python + @Bigcheese - https://lab.llvm.org/buildbot/#/builders/139/builds/4147 doesn't like this - should this be python3 ? Repository: rG LLVM Github Monorepo CH

[PATCH] D100919: [AArch64] Support customizing stack protector guard

dmgreen accepted this revision. dmgreen added a comment. Thanks. This sounds good to me, if David agrees. Comment at: llvm/lib/Target/AArch64/AArch64InstrInfo.cpp:1912 +if (!SrcReg) + report_fatal_error("Unknow SysReg for Stack Protector Guard Register"); + ---

[PATCH] D102397: [AArch64] Lower bitreverse in ISel

dmgreen accepted this revision. dmgreen added a comment. This revision is now accepted and ready to land. Thanks. LGTM Comment at: llvm/test/CodeGen/AArch64/neon_rbit.ll:9 + +define <8 x i8> @rbit_8x8(<8 x i8> %A) nounwind { +; CHECK-LABEL: rbit_8x8: v8i8 and v

[clang-tools-extra] ec2f737 - [clangd][QueryDriver] Dont check for existence of driver

Author: Kadir Cetinkaya Date: 2021-05-17T12:38:17+02:00 New Revision: ec2f7376e39fa5d820d059b6e83e69690fe6315f URL: https://github.com/llvm/llvm-project/commit/ec2f7376e39fa5d820d059b6e83e69690fe6315f DIFF: https://github.com/llvm/llvm-project/commit/ec2f7376e39fa5d820d059b6e83e69690fe6315f.dif

[PATCH] D102431: [clangd][QueryDriver] Dont check for existence of driver

This revision was automatically updated to reflect the committed changes. Closed by commit rGec2f7376e39f: [clangd][QueryDriver] Dont check for existence of driver (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102431/new/ htt

[PATCH] D100919: [AArch64] Support customizing stack protector guard

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. LGTM with one nit. Comment at: llvm/lib/Target/AArch64/AArch64InstrInfo.cpp:1919 +int Offset = Options.StackProtectorGuardOffset; +if (Offset >= 0 && Of

[PATCH] D100630: [Debug-Info][DBX] DW_TAG_rvalue_reference_type should not be generated when dwarf version is smaller than 4

shchenz added a comment. In D100630#2760972 , @dblaikie wrote: > This isn't the sort of thing I'd like to leave to a FIXME later - seems like > the sort of thing we shouldn't create now to fix later. > > @aprantl mind having a second look at this to cons

[clang] e827d74 - [clang][deps] Specify Python 3 in shebang

Author: Jan Svoboda Date: 2021-05-17T13:02:25+02:00 New Revision: e827d74a97dcf6623470baf3bda86b1c9544e3df URL: https://github.com/llvm/llvm-project/commit/e827d74a97dcf6623470baf3bda86b1c9544e3df DIFF: https://github.com/llvm/llvm-project/commit/e827d74a97dcf6623470baf3bda86b1c9544e3df.diff L

[PATCH] D102495: [clang][deps] Support inferred modules

thakis added a comment. Looks like this breaks tests on windows: http://45.33.8.238/win/38908/step_7.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102495/new/ https://reviews.llvm.org/D102495 ___ cfe

[clang] 3549466 - [OpenCL] Drop pragma handling for extension types/decls.

Author: Anastasia Stulova Date: 2021-05-17T12:09:43+01:00 New Revision: 3549466ac05eda57c9ce13abd7cb6dd365f6d8d6 URL: https://github.com/llvm/llvm-project/commit/3549466ac05eda57c9ce13abd7cb6dd365f6d8d6 DIFF: https://github.com/llvm/llvm-project/commit/3549466ac05eda57c9ce13abd7cb6dd365f6d8d6.d

[PATCH] D101043: [OpenCL] Drop extension pragma handling for extension types/declarations

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3549466ac05e: [OpenCL] Drop pragma handling for extension types/decls. (authored by Anastasia). Herald added a subscriber: ldrumm. Herald added a pro

[PATCH] D102495: [clang][deps] Support inferred modules

jansvoboda11 added inline comments. Comment at: clang/utils/module-deps-to-rsp.py:1 +#!/usr/bin/env python + RKSimon wrote: > @Bigcheese - https://lab.llvm.org/buildbot/#/builders/139/builds/4147 doesn't > like this - should this be python3 ? Thanks, that seems

[PATCH] D102495: [clang][deps] Support inferred modules

jansvoboda11 added a comment. In D102495#2763080 , @thakis wrote: > Looks like this breaks tests on windows: > http://45.33.8.238/win/38908/step_7.txt Thanks for the heads-up. This might be hitting behavior introduced here: https://reviews.llvm.org/D10

[PATCH] D102495: [clang][deps] Support inferred modules

thakis added a comment. Did you see my message about the windows breakage? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102495/new/ https://reviews.llvm.org/D102495 ___ cfe-commits mailing list cfe-comm

[clang] ccd485e - Revert "[clang][deps] Support inferred modules"

Author: Jan Svoboda Date: 2021-05-17T13:27:14+02:00 New Revision: ccd485e55424b78c07c2f9520faf00b805f78c9b URL: https://github.com/llvm/llvm-project/commit/ccd485e55424b78c07c2f9520faf00b805f78c9b DIFF: https://github.com/llvm/llvm-project/commit/ccd485e55424b78c07c2f9520faf00b805f78c9b.diff L

[PATCH] D102495: [clang][deps] Support inferred modules

jansvoboda11 added a comment. In D102495#2763115 , @thakis wrote: > Did you see my message about the windows breakage? Yes, reverted in ccd485e55424b78c07c2f9520faf00b805f78c9b . Rep

[clang] 66b112d - [OpenCL] Fix reinterpret_cast of vectors

Author: Ole Strohm Date: 2021-05-17T12:42:21+01:00 New Revision: 66b112d624a549489fa0af131cf7b632c6181424 URL: https://github.com/llvm/llvm-project/commit/66b112d624a549489fa0af131cf7b632c6181424 DIFF: https://github.com/llvm/llvm-project/commit/66b112d624a549489fa0af131cf7b632c6181424.diff LO

[PATCH] D101519: [C++4OpenCL] Fix reinterpret_cast of vectors

This revision was automatically updated to reflect the committed changes. Closed by commit rG66b112d624a5: [OpenCL] Fix reinterpret_cast of vectors (authored by olestrohm). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101519/new/ https://reviews.ll

[PATCH] D95425: Implementation of global.get/set for reftypes in LLVM IR

wingo added inline comments. Comment at: llvm/lib/Target/WebAssembly/WebAssemblyInstrTable.td:15 multiclass TABLE { + let mayLoad = 1 in defm TABLE_GET_#rt : I<(outs rt:$res), (ins table32_op:$table), pmatos wrote: > tlively wrote: > > wingo wrote: > > > I t

[PATCH] D102614: [index] Add support for type of pointers to class members

OikawaKirie created this revision. OikawaKirie added a reviewer: akyrtzi. OikawaKirie added a project: clang. Herald added a subscriber: arphaman. OikawaKirie requested review of this revision. Herald added a subscriber: cfe-commits. Required in D102159 that we s

[PATCH] D99439: Update @llvm.powi to handle different int sizes for the exponent

bjope added inline comments. Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeFloatTypes.cpp:581 RTLIB::POWI_F128, RTLIB::POWI_PPCF128); if (!TLI.getLibcallName(LC)) { efriedma wrote: > b

[clang] 05de4b4 - Put back the trailing commas on TYPED_TEST_SUITE

Author: Benjamin Kramer Date: 2021-05-17T14:14:13+02:00 New Revision: 05de4b413930418b60c0dd1e72681b476b50e7fb URL: https://github.com/llvm/llvm-project/commit/05de4b413930418b60c0dd1e72681b476b50e7fb DIFF: https://github.com/llvm/llvm-project/commit/05de4b413930418b60c0dd1e72681b476b50e7fb.dif

[PATCH] D102569: [clang-tidy] Fix altera-struct-pack-align crash for struct fields with incomplete type

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you for the fix! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102569/new/ https://reviews.llvm.org/D102569 ___

[PATCH] D102443: [PowerPC] Added multiple PowerPC builtins

nemanjai added subscribers: rjmccall, rsmith. nemanjai added a comment. In terms of the motivation for this, the description of the patch should include something along the lines of: "This is the first in a series of patches to provide builtins for compatibility with the XL compiler." Since th

[clang] 888ce70 - [DebugInfo] Fix DWARF expressions for __block vars that are not on the heap

Author: Raphael Isemann Date: 2021-05-17T14:32:07+02:00 New Revision: 888ce70af288168136cf1ca658c3cf6d6759bb3f URL: https://github.com/llvm/llvm-project/commit/888ce70af288168136cf1ca658c3cf6d6759bb3f DIFF: https://github.com/llvm/llvm-project/commit/888ce70af288168136cf1ca658c3cf6d6759bb3f.dif

[PATCH] D99946: [DebugInfo] Fix DWARF expressions for __block vars that are not on the heap

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG888ce70af288: [DebugInfo] Fix DWARF expressions for __block vars that are not on the heap (authored by teemperor). Herald added a subscriber: cfe-com

[PATCH] D102397: [AArch64] Lower bitreverse in ISel

This revision was automatically updated to reflect the committed changes. Closed by commit rG50511df32edf: [AArch64] Lower bitreverse in ISel (authored by Rin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102397/new/ https://reviews.llvm.org/D1023

[clang] 50511df - [AArch64] Lower bitreverse in ISel

Author: Irina Dobrescu Date: 2021-05-17T13:35:27+01:00 New Revision: 50511df32edf53238b75b0e9767120dc772dbf14 URL: https://github.com/llvm/llvm-project/commit/50511df32edf53238b75b0e9767120dc772dbf14 DIFF: https://github.com/llvm/llvm-project/commit/50511df32edf53238b75b0e9767120dc772dbf14.diff

[PATCH] D96524: [OpenCL] Add support of OpenCL C 3.0 __opencl_c_fp64

azabaznov updated this revision to Diff 345846. azabaznov edited the summary of this revision. azabaznov added a comment. Rebase after https://reviews.llvm.org/D100976; addressed review comments and updated docs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D102248: [C++4OpenCL] Fix initialization of __constant constructors without arguments

olestrohm updated this revision to Diff 345845. olestrohm added a comment. Relaxed the checks in the codegen test because of failures on platforms with slightly different IR being generated. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102248/new/ https://reviews.llvm.org/D102248 Fil

[PATCH] D102241: [clang] p1099 4/5: using enum EnumTag

urnathan updated this revision to Diff 345848. urnathan added a comment. Add serialization test and fix bug so found (thanks Bruno!) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102241/new/ https://reviews.llvm.org/D102241 Files: clang-tools-extra/clangd/FindTarget.cpp clang/inclu

[PATCH] D102531: PR45881: Properly use CXXThisOverride for templated lambda

aaron.ballman added a comment. Mostly just superficial comments from me at this point. Comment at: clang/lib/Sema/SemaTemplate.cpp:5094-5095 +bool ForLambdaCallOperator = false; +if (CXXRecordDecl *Rec = +dyn_cast(Template->getDeclContext())) + ForLambd

[clang] b89e09a - Silence "Undefined or garbage value returned to caller" static analysis warning. NFCI.

Author: Simon Pilgrim Date: 2021-05-17T14:08:27+01:00 New Revision: b89e09a19f9b60dfa9477b24a404a7ae5522f898 URL: https://github.com/llvm/llvm-project/commit/b89e09a19f9b60dfa9477b24a404a7ae5522f898 DIFF: https://github.com/llvm/llvm-project/commit/b89e09a19f9b60dfa9477b24a404a7ae5522f898.diff

[PATCH] D102488: [clang][deps] Prune unused header search paths

jansvoboda11 updated this revision to Diff 345861. jansvoboda11 added a comment. Use, serialize and deserialize `llvm::BitVector` instead of `std::set`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102488/new/ https://reviews.llvm.org/D102488 Fil

[PATCH] D102488: [clang][deps] Prune unused header search paths

jansvoboda11 planned changes to this revision. jansvoboda11 added a comment. In D102488#2760406 , @dexonsmith wrote: > I think it'd be useful to have direct tests for "detecting used search > paths". That might be a nice thing to separate out and test i

[clang-tools-extra] ab92a4c - [clang-tidy] Fix altera-struct-pack-align crash for struct fields with incomplete type

Author: Georgy Komarov Date: 2021-05-17T16:50:47+03:00 New Revision: ab92a4c26f54170bf72706ad29c0fb151a177590 URL: https://github.com/llvm/llvm-project/commit/ab92a4c26f54170bf72706ad29c0fb151a177590 DIFF: https://github.com/llvm/llvm-project/commit/ab92a4c26f54170bf72706ad29c0fb151a177590.diff

[PATCH] D102569: [clang-tidy] Fix altera-struct-pack-align crash for struct fields with incomplete type

This revision was automatically updated to reflect the committed changes. Closed by commit rGab92a4c26f54: [clang-tidy] Fix altera-struct-pack-align crash for struct fields with… (authored by jubnzv). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102

[PATCH] D101192: Add support for #elifdef and #elifndef

aaron.ballman added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101192/new/ https://reviews.llvm.org/D101192 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D101192: Add support for #elifdef and #elifndef

mibintc accepted this revision. mibintc added a comment. This revision is now accepted and ready to land. let 'er rip CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101192/new/ https://reviews.llvm.org/D101192 ___ cfe-commits mailing list cfe-

[clang] 6052a8a - [clang] In DependencyCollector on Windows, ignore case and separators when discarding duplicate dependency file paths.

Author: Sylvain Audi Date: 2021-05-17T10:32:52-04:00 New Revision: 6052a8a53559d667321637f7159353ab724a1141 URL: https://github.com/llvm/llvm-project/commit/6052a8a53559d667321637f7159353ab724a1141 DIFF: https://github.com/llvm/llvm-project/commit/6052a8a53559d667321637f7159353ab724a1141.diff

[PATCH] D102339: [clang] On Windows, ignore case and separators when discarding duplicate dependency file paths.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. saudi marked 2 inline comments as done. Closed by commit rG6052a8a53559: [clang] In DependencyCollector on Windows, ignore case and separators when… (authored by saudi)

[PATCH] D102633: [clang-scan-deps] Improvements to thread usage

saudi created this revision. saudi added reviewers: arphaman, dexonsmith, Bigcheese. saudi added projects: clang, LLVM. saudi requested review of this revision. Herald added a subscriber: cfe-commits. Switching back to `std::thread` to simplify the logic, as `ThreadPool` adds a layer of task mana

[PATCH] D27683: Prepare PrettyStackTrace for LLDB adoption

thakis added inline comments. Herald added subscribers: llvm-commits, kristina. Herald added a project: LLVM. Comment at: llvm/trunk/lib/Support/PrettyStackTrace.cpp:93 +extern "C" const char *__crashreporter_info__ +__attribute__((visibility("hidden"))) = 0; asm(".desc ___c

[PATCH] D87029: [AIX] Implement AIX special bitfield related alignment rules

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe0921655b1ff: [AIX] Implement AIX special bitfield related alignment rules (authored by Xiangling_L). Changed prior to commit: https://reviews.llv

[clang] e092165 - [AIX] Implement AIX special bitfield related alignment rules

Author: Xiangling Liao Date: 2021-05-17T11:30:29-04:00 New Revision: e0921655b1ff8d4ba7c14be59252fe05b705920e URL: https://github.com/llvm/llvm-project/commit/e0921655b1ff8d4ba7c14be59252fe05b705920e DIFF: https://github.com/llvm/llvm-project/commit/e0921655b1ff8d4ba7c14be59252fe05b705920e.diff

[PATCH] D102543: [Scudo] Make -fsanitize=scudo use standalone. Migrate tests.

cryptoad added a comment. I think one of the remaining things to address is the supported architectures: set(ALL_SCUDO_SUPPORTED_ARCH ${X86} ${X86_64} ${ARM32} ${ARM64} ${MIPS32} ${MIPS64} ${PPC64}) set(ALL_SCUDO_STANDALONE_SUPPORTED_ARCH ${X86} ${X86_64} ${ARM64}) I am unclear as to whethe

[PATCH] D102306: Add gfx1034

kzhuravl added a subscriber: t-tye. kzhuravl added a comment. In D102306#2760806 , @tra wrote: > In D102306#2760775 , @msearles > wrote: > >> In D102306#2758166 , >> @Jo

[PATCH] D102543: [Scudo] Make -fsanitize=scudo use standalone. Migrate tests.

hctim marked 2 inline comments as done. hctim added a comment. In D102543#2763749 , @cryptoad wrote: > I think one of the remaining things to address is the supported architectures: > > set(ALL_SCUDO_SUPPORTED_ARCH ${X86} ${X86_64} ${ARM32} ${ARM64} ${M

[PATCH] D102543: [Scudo] Make -fsanitize=scudo use standalone. Migrate tests.

hctim updated this revision to Diff 345906. hctim marked 2 inline comments as done. hctim added a comment. Address Kostya's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102543/new/ https://reviews.llvm.org/D102543 Files: clang/lib/Dri

[PATCH] D102556: [HIP] Fix spack detection

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. LGTM with a test nit. Comment at: clang/test/Driver/rocm-detect.hip:115 + +// SPACK-MISS-SILENT-NOT: SPACK package hip-4.0.0 not found at +// SPACK-MISS-SILENT-NOT: SPACK package r

[clang] 5f58322 - [HWASan] Build separate LAM runtime on x86_64.

Author: Matt Morehouse Date: 2021-05-17T09:19:06-07:00 New Revision: 5f58322368b070b63fe2b2559a54f646cb97e2c4 URL: https://github.com/llvm/llvm-project/commit/5f58322368b070b63fe2b2559a54f646cb97e2c4 DIFF: https://github.com/llvm/llvm-project/commit/5f58322368b070b63fe2b2559a54f646cb97e2c4.diff

[PATCH] D102286: [HWASan] Build separate LAM runtime on x86_64.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5f58322368b0: [HWASan] Build separate LAM runtime on x86_64. (authored by morehouse). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D102556: [HIP] Fix spack detection

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/test/Driver/rocm-detect.hip:115 + +// SPACK-MISS-SILENT-NOT: SPACK package hip-4.0.0 not found at +// SPACK-MISS-SILENT-NOT: SPACK package rocm-device-libs-4.0.0 not found at

[clang] 02c2468 - [Clang][NVPTX] Add NVPTX intrinsics and builtins for CUDA PTX cp.async instructions

Author: Stuart Adams Date: 2021-05-17T09:46:59-07:00 New Revision: 02c2468864bbb37f7b279aff84961815c1500b6c URL: https://github.com/llvm/llvm-project/commit/02c2468864bbb37f7b279aff84961815c1500b6c DIFF: https://github.com/llvm/llvm-project/commit/02c2468864bbb37f7b279aff84961815c1500b6c.diff

[clang] f226e28 - [Clang][NVPTX] Add NVPTX intrinsics and builtins for CUDA PTX redux.sync instructions

Author: Steffen Larsen Date: 2021-05-17T09:46:59-07:00 New Revision: f226e28a880f8e40b1bfd4c77b9768a667372d22 URL: https://github.com/llvm/llvm-project/commit/f226e28a880f8e40b1bfd4c77b9768a667372d22 DIFF: https://github.com/llvm/llvm-project/commit/f226e28a880f8e40b1bfd4c77b9768a667372d22.diff

[PATCH] D100394: [Clang][NVPTX] Add NVPTX intrinsics and builtins for CUDA PTX cp.async instructions

This revision was automatically updated to reflect the committed changes. Closed by commit rG02c2468864bb: [Clang][NVPTX] Add NVPTX intrinsics and builtins for CUDA PTX cp.async… (authored by nyalloc, committed by tra). Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D100124: [Clang][NVPTX] Add NVPTX intrinsics and builtins for CUDA PTX redux.sync instructions

This revision was automatically updated to reflect the committed changes. Closed by commit rGf226e28a880f: [Clang][NVPTX] Add NVPTX intrinsics and builtins for CUDA PTX redux.sync… (authored by steffenlarsen, committed by tra). Changed prior to commit: https://reviews.llvm.org/D100124?vs=339169

[PATCH] D100768: [Clang][OpenMP] Remove the mandatory flush for capture for OpenMP 5.1

tianshilei1992 updated this revision to Diff 345917. tianshilei1992 added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100768/new/ https://reviews.llvm.org/D100768 Files: clang/lib/CodeGen/CGStmtOpenMP.cpp clang/test/OpenMP/

[PATCH] D102638: [NFC] Pass GV value type instead of pointer type to GetOrCreateLLVMGlobal

aeubanks created this revision. aeubanks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. For opaque pointers, to avoid PointerType::getElementType(). Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D102638 Files: clang/

[PATCH] D102488: [clang][deps] Prune unused header search paths

jansvoboda11 updated this revision to Diff 345922. jansvoboda11 added a comment. Make PCM parsing lazier Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102488/new/ https://reviews.llvm.org/D102488 Files: clang/include/clang/Lex/HeaderSearch.h c

[PATCH] D101561: [Prototype] Introduce attribute for ignoring C++ ABI

aeubanks abandoned this revision. aeubanks added a comment. turns out this didn't have a good enough impact to pursue Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101561/new/ https://reviews.llvm.org/D101561 __

[clang] 18cb17c - [HIP] Fix spack detection

Author: Yaxun (Sam) Liu Date: 2021-05-17T13:24:05-04:00 New Revision: 18cb17ce4cd54b9971550840b6f0b872de0d4c8c URL: https://github.com/llvm/llvm-project/commit/18cb17ce4cd54b9971550840b6f0b872de0d4c8c DIFF: https://github.com/llvm/llvm-project/commit/18cb17ce4cd54b9971550840b6f0b872de0d4c8c.dif

[PATCH] D102556: [HIP] Fix spack detection

This revision was automatically updated to reflect the committed changes. yaxunl marked an inline comment as done. Closed by commit rG18cb17ce4cd5: [HIP] Fix spack detection (authored by yaxunl). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D102556?vs=345643&i

[PATCH] D102492: [clang][AST] Add support for BindingDecl to ASTImporter.

shafik added inline comments. Comment at: clang/unittests/AST/ASTImporterTest.cpp:873 + MatchVerifier Verifier; + testImport("int a[2] = {1, 2};" + "auto [declToImport, x] = a;", Can we add a larger variety of tests? Given how simple the `BindingDec

[PATCH] D102585: [M68k] Support inline asm operands w/ simple constraints

nickdesaulniers added a comment. LGTM but please review the linter warnings. Comment at: clang/lib/Basic/Targets/M68k.cpp:145 case 'd': // data register - case 'f': // floating point register info.setAllowsRegister(); did you mean to drop support for `

[PATCH] D102640: [ASTimporter] Remove decl from lookup only if it has decl context

steakhal created this revision. steakhal added reviewers: teemperor, shafik, balazske, a.sidorin, martong. Herald added subscribers: whisperity, rnkovacs. steakhal requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In the case of `TypedefDecl`

[PATCH] D91466: [WIP][clang][Fuchsia] Support HWASan for Fuchsia

leonardchan updated this revision to Diff 345931. leonardchan added a comment. Update to some feedback from first round of reviews. Minor refactoring of code that can be shared between the linux and fuchsia implementations. Still need to discuss refactoring the hwasan threads implementation. R

[PATCH] D102543: [Scudo] Make -fsanitize=scudo use standalone. Migrate tests.

cryptoad accepted this revision. cryptoad added a comment. This revision is now accepted and ready to land. I think this is good, with the additional arch Comment at: compiler-rt/cmake/config-ix.cmake:338 set(ALL_SCUDO_SUPPORTED_ARCH ${X86} ${X86_64} ${ARM32} ${ARM64} ${MIPS32

[PATCH] D102543: [Scudo] Make -fsanitize=scudo use standalone. Migrate tests.

hctim updated this revision to Diff 345939. hctim added a comment. Add arm32 to supported. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102543/new/ https://reviews.llvm.org/D102543 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp clang/test

[PATCH] D102547: [clang][AVR] Redefine [u]int16_t to be compatible with avr-gcc

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM, thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102547/new/ https://reviews.llvm.org/D102547 ___ cfe-commits mailing list

[PATCH] D102568: [Driver] Delete -mimplicit-it=

nickdesaulniers accepted this revision. nickdesaulniers added a comment. This revision is now accepted and ready to land. Seems fine to me; the only reference in all of Android that looks problematic might be building libaom for windows: https://android.googlesource.com/platform/external/libaom/

  1   2   >