nickdesaulniers accepted this revision. nickdesaulniers added a comment. This revision is now accepted and ready to land.
Seems fine to me; the only reference in all of Android that looks problematic might be building libaom for windows: https://android.googlesource.com/platform/external/libaom/+/refs/heads/master/libaom/build/cmake/aom_configure.cmake#158, which I don't think we do for Android. Should be an easy fix either way (replace `-mimplicit-it=always` with `-Wa,-wmimplicit-it=always`). The linux kernel already uses `-Wa,-mimplicit-it`. Also, GCC rejects the option: https://godbolt.org/z/8rxjY9dPj. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102568/new/ https://reviews.llvm.org/D102568 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
