tra accepted this revision. tra added a comment. This revision is now accepted and ready to land.
LGTM with a test nit. ================ Comment at: clang/test/Driver/rocm-detect.hip:115 + +// SPACK-MISS-SILENT-NOT: SPACK package hip-4.0.0 not found at +// SPACK-MISS-SILENT-NOT: SPACK package rocm-device-libs-4.0.0 not found at ---------------- Nit: I'd match the version with a regex. Otherwise this test would continue passing even if compiler were to report `hip-some.other.version not found` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102556/new/ https://reviews.llvm.org/D102556 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
