[PATCH] D102159: [index][analyzer][ctu] Eliminate white spaces in the CTU lookup name.

akyrtzi added a comment. Maybe we could also handle this kind of type instead of leaving it 'unhandled'? What `Type` is it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102159/new/ https://reviews.llvm.org/D102159 ___

[clang-tools-extra] 1746068 - Clangd Matchers.h: Fix -Wdeprecated-copy by making the defaulted copy ctor and deleted copy assignment operators explicit

Author: David Blaikie Date: 2021-05-10T14:31:11-07:00 New Revision: 174606877df46f3e8ce0c60a4c744687d3ee3271 URL: https://github.com/llvm/llvm-project/commit/174606877df46f3e8ce0c60a4c744687d3ee3271 DIFF: https://github.com/llvm/llvm-project/commit/174606877df46f3e8ce0c60a4c744687d3ee3271.diff

[PATCH] D100388: [BROKEN][clang] Try to fix thunk function types

lebedev.ri added a subscriber: efriedma. lebedev.ri added a comment. ping @rsmith / @efriedma - if there are any further thoughts on the problem, i would love to hear them Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100388/new/ https://reviews.l

[PATCH] D101735: [WebAssembly] Reenable end-to-end test in wasm-eh.cpp

dblaikie added a comment. FWIW - please avoid end-to-end tests where possible (writing separate source to LLVM IR (in clang) and LLVM IR to assembly (in LLVM) tests). (recent discussions on the wasm simd instructions touched on this issue too) Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D100919: [AArch64] Support customizing stack protector guard

nickdesaulniers added a comment. bumping for review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100919/new/ https://reviews.llvm.org/D100919 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[PATCH] D100388: [BROKEN][clang] Try to fix thunk function types

efriedma added a comment. Made a couple suggestions to make this easier to review. The test changes you've made so far seem reasonable. Is there some specific section of the code you want feedback on? Comment at: clang/include/clang/Basic/Thunk.h:1 +//===- Thunk.h - Decla

[PATCH] D101876: [clang] Support -fpic -fno-semantic-interposition for RISCV

luismarques accepted this revision. luismarques added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101876/new/ https://reviews.llvm.org/D101876

[PATCH] D102015: [clang CodeGen] Don't crash on large atomic function parameter.

ahatanak added a comment. C structs with ObjC pointer fields under ARC are non-trivial to destruct too. struct foo { int big[128]; id a; }; void test_atomic_array_param(_Atomic(struct foo) a) { } Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D102015: [clang CodeGen] Don't crash on large atomic function parameter.

ahatanak added a comment. Using `_Atomic` for C structs with non-trivially destructible fields currently doesn't work, so maybe that should just be disallowed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102015/new/ https://reviews.llvm.org/D102

[PATCH] D95745: Support unwinding from inline assembly

Amanieu accepted this revision. Amanieu added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95745/new/ https://reviews.llvm.org/D95745 ___

[PATCH] D102015: [clang CodeGen] Don't crash on large atomic function parameter.

efriedma added a comment. > Using _Atomic for C structs with non-trivially destructible fields currently > doesn't work, so maybe that should just be disallowed. I'd prefer to disallow _Atomic on all types that aren't trivially destructible, yes. Not impossible to support, of course, but I don

[PATCH] D101667: Modules: Remove ModuleLoader::OtherUncachedFailure, NFC

dexonsmith added a comment. Ping! Happy to weaken the commit message to "likely NFC" in case there's some way that we get back here after a fatal error. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101667/new/ https://reviews.llvm.org/D101667 __

[PATCH] D102185: Widen `name` stencil to support `TypeLoc` nodes.

steveire added a reviewer: ymandel. steveire added a comment. Adding Yitzhak as a reviewer. I notice that at least the name of a cxxBaseSpecifier is not supported and I don't know if that (or lack of typeloc support) is desired in the Transformer design. Repository: rG LLVM Github Monorepo

[PATCH] D101876: [clang] Support -fpic -fno-semantic-interposition for RISCV

MaskRay updated this revision to Diff 344234. MaskRay added a comment. rebase after aarch64 support Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101876/new/ https://reviews.llvm.org/D101876 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/t

[PATCH] D102090: [CMake][ELF] Add -fno-semantic-interposition and -Bsymbolic-functions

rnk added a comment. +1 to the idea, but I have no idea if this is the right cmake spot If we've decided to actually care about the shared library build, should we also consider using `-fvisibility-inlines-hidden`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D102070: [AIX][TLS] Diagnose use of unimplemented TLS models

NeHuang updated this revision to Diff 344258. NeHuang added a comment. Address review comment for the diagnostic message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102070/new/ https://reviews.llvm.org/D102070 Files: clang/include/clang/Basic

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

rsmith added inline comments. Comment at: clang/lib/Interpreter/IncrementalParser.cpp:226-235 + if (PP.getLangOpts().DelayedTemplateParsing) { +// Microsoft-specific: +// Late parsed templates can leave unswallowed "macro"-like tokens. +// They will seriously confuse

[PATCH] D102147: [Clang][Coroutines] Implement P2014R0 Option 1 behind -fcoroutines-aligned-alloc

ChuanqiXu added a comment. In D102147#2747939 , @ychen wrote: > In D102147#2747611 , @ChuanqiXu > wrote: > >> Since D97915 would fix the problem that >> the variables in the fra

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

rsmith accepted this revision. rsmith added a comment. Generally-speaking, we have a plan that I'm happy for us to work towards, and I'm happy for our progress towards that plan to be incremental. Even though this might not be fully in that direction right now, I think that's OK. CHANGES SINCE

[PATCH] D96215: [clang-tidy] Aliasing: Add support for lambda captures.

NoQ added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/Aliasing.cpp:45-48 +return llvm::any_of(LE->captures(), [Var](const LambdaCapture &C) { + return C.capturesVariable() && C.getCaptureKind() == LCK_ByRef && + C.getCapturedVar() == Var;

[PATCH] D102213: [ASTMatchers] Add forCallable(), a generalization of forFunction().

NoQ created this revision. NoQ added reviewers: alexfh, gribozavr2, aaron.ballman, stephenkelly, xazax.hun, vsavchenko. Herald added subscribers: martong, rnkovacs. NoQ requested review of this revision. It additionally covers Objective-C methods and blocks that don't inherit from `FunctionDecl`

[PATCH] D102214: [clang-tidy] bugprone-infinite-loop: forFunction() -> forCallable().

NoQ created this revision. NoQ added reviewers: alexfh, gribozavr2, aaron.ballman, stephenkelly, xazax.hun, vsavchenko. Herald added subscribers: martong, mgehre, rnkovacs. NoQ requested review of this revision. Herald added a project: clang-tools-extra. This patch takes advantage of the new ASTM

[PATCH] D101790: [clang-tidy] Aliasing: Add support for passing the variable into a function by reference.

NoQ updated this revision to Diff 344283. NoQ added a comment. Rebase on top of D102214 (that patch will probably land sooner than this patch and there are test conflicts). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101790/new/ https://reviews.llvm

[PATCH] D102159: [index][analyzer][ctu] Eliminate white spaces in the CTU lookup name.

OikawaKirie added a comment. In D102159#2749033 , @akyrtzi wrote: > Maybe we could also handle this kind of type instead of leaving it > 'unhandled'? What `Type` is it? The member function pointer type, see the test case. Although it would be perfect t

[PATCH] D101735: [WebAssembly] Reenable end-to-end test in wasm-eh.cpp

aheejin added a comment. @dblaikie I can remove this one. This is not an important test anyway. But where are we supposed to test the arguments clang driver invokes the backend LLVM compilation with? This was mainly to test if `-exception-model=wasm` reaches the backend compilation. Repositor

[PATCH] D101735: [WebAssembly] Reenable end-to-end test in wasm-eh.cpp

dblaikie added a comment. In D101735#2749716 , @aheejin wrote: > @dblaikie I can remove this one. This is not an important test anyway. But > where are we supposed to test the arguments clang driver invokes the backend > LLVM compilation with? This was

Re: [clang] e994e74 - [OpenCL] Add clang extension for non-portable kernel parameters.

On 5/5/21 6:58 AM, Anastasia Stulova via cfe-commits wrote: Author: Anastasia Stulova Date: 2021-05-05T14:58:23+01:00 New Revision: e994e74bca49831eb649e7c67955e9de7a1784b6 URL: https://github.com/llvm/llvm-project/commit/e994e74bca49831eb649e7c67955e9de7a1784b6 DIFF: https://github.com/llvm/

[PATCH] D101914: [clangd][index-sever] Limit results in repsonse

kbobyrev accepted this revision. kbobyrev added a comment. This revision is now accepted and ready to land. Good point, thanks! I wonder if this can somehow make the experience worse in _some_ specific cases but I can't think of anything on top of my mind, so this should be all good.

[PATCH] D101915: [clangd][remote-client] Set HasMore to true for failure

kbobyrev accepted this revision. kbobyrev added a comment. This revision is now accepted and ready to land. Good catch, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101915/new/ https://reviews.llvm.org/D101915

[PATCH] D102015: [clang CodeGen] Don't crash on large atomic function parameter.

rjmccall added a comment. In D102015#2748441 , @efriedma wrote: > In D102015#2743634 , @rjmccall > wrote: > >> Objective-C object types also have aggregate evaluation kind. Those can >> only be used as value ty

[PATCH] D102216: JSONLinkDatabase

Glebuska created this revision. Glebuska requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D102216 Files: clang/docs/JSONLinkDatabase.rst Index: clang/docs/JSONLinkDatabase.r

[PATCH] D101914: [clangd][index-sever] Limit results in repsonse

kadircet updated this revision to Diff 344289. kadircet marked an inline comment as done. kadircet added a comment. - Change logs to mention original limits. - Add the test i forgot first time. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101914/ne

[PATCH] D101914: [clangd][index-sever] Limit results in repsonse

kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/remote/server/Server.cpp:152 +if (HasMore) + log("[public] Limiting result size for Lookup request."); LookupReply LastMessage; kbobyrev wrote: > nit (here and elsewhere): ma

[clang-tools-extra] 888307e - [clangd][remote-client] Set HasMore to true for failure

Author: Kadir Cetinkaya Date: 2021-05-11T08:22:24+02:00 New Revision: 888307ee625b50b060317e2100fb16e0be2626b7 URL: https://github.com/llvm/llvm-project/commit/888307ee625b50b060317e2100fb16e0be2626b7 DIFF: https://github.com/llvm/llvm-project/commit/888307ee625b50b060317e2100fb16e0be2626b7.dif

[clang-tools-extra] daf3cb3 - [clangd][index-sever] Limit results in repsonse

Author: Kadir Cetinkaya Date: 2021-05-11T08:22:23+02:00 New Revision: daf3cb3b8a5868d9089a69025c556b564615b844 URL: https://github.com/llvm/llvm-project/commit/daf3cb3b8a5868d9089a69025c556b564615b844 DIFF: https://github.com/llvm/llvm-project/commit/daf3cb3b8a5868d9089a69025c556b564615b844.dif

[PATCH] D101914: [clangd][index-sever] Limit results in repsonse

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdaf3cb3b8a58: [clangd][index-sever] Limit results in repsonse (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D101915: [clangd][remote-client] Set HasMore to true for failure

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG888307ee625b: [clangd][remote-client] Set HasMore to true for failure (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D89177: [cmake] Add support for multiple distributions

smeenai updated this revision to Diff 344299. smeenai added a comment. Uppercase variable names Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89177/new/ https://reviews.llvm.org/D89177 Files: clang/cmake/caches/MultiDistributionExample.cmake c

<    1   2