kadircet added inline comments.
================
Comment at: clang-tools-extra/clangd/index/remote/server/Server.cpp:152
+ if (HasMore)
+ log("[public] Limiting result size for Lookup request.");
LookupReply LastMessage;
----------------
kbobyrev wrote:
> nit (here and elsewhere): maybe add something like `(requested X, sending Y)`
> to the message for clarity. I don't expect this to be common anyway so
> probably verbosity isn't an issue here.
doesn't really apply here, as lookup request doesn't have a limit. practically
it triggers when user makes a request with more than `LimitResults` request ids
in a single batch, but in theory could kick in earlier as an index can return
multiple results for the same symbol id (but they never do).
changing the rest though.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D101914/new/
https://reviews.llvm.org/D101914
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
