[PATCH] D100388: [BROKEN][clang] Try to fix thunk function types

lebedev.ri added a comment. ping @rsmith - any further thoughts here? In D100388#2709870 , @lebedev.ri wrote: > @rsmith i was able to make some forward progress here. > What do you think about this? > > (I haven't updated all tests because i don't want

[PATCH] D102018: [WebAssembly] Use functions instead of macros for const SIMD intrinsics

aheejin accepted this revision. aheejin added a comment. This revision is now accepted and ready to land. > To improve hygiene, consistency, and usability, it would be good to replace > all > the macro intrinsics in wasm_simd128.h with functions. The reason for using > macros in the first place w

[PATCH] D102051: [RISCV] Consider scalar types for required extensions.

HsiangKai created this revision. HsiangKai added reviewers: khchen, arcbbb. Herald added subscribers: vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217,

[PATCH] D101601: [SelectionDAG] Make fast and linearize visible by clang -pre-RA-sched

TaoPan updated this revision to Diff 343598. TaoPan added a comment. git rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101601/new/ https://reviews.llvm.org/D101601 Files: llvm/include/llvm/CodeGen/TargetLowering.h llvm/lib/CodeGen/Selec

[PATCH] D102051: [RISCV] Consider scalar types for required extensions.

khchen accepted this revision. khchen added a comment. This revision is now accepted and ready to land. Good catch! LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102051/new/ https://reviews.llvm.org/D102051 __

[PATCH] D101868: [clang-format] Adds a formatter for aligning arrays of structs

curdeius added inline comments. Comment at: clang/docs/ReleaseNotes.rst:247-248 +- Option ``AlignArrayOfStructure`` has been added to allow for ordering array-like + initializers into nice orderly columns while respecting column limits. +

[PATCH] D101763: [analyzer][ctu] Avoid parsing invocation list again and again during on-demand parsing of CTU

steakhal added a comment. I would rather match on the complete line (except the file descriptor ofc). By inspecting the output that is piped to the `count`, I have a suspicion: openat(AT_FDCWD, "invocations.yaml", O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory) It should have fou

[PATCH] D101873: [clang] Support clang -fpic -fno-semantic-interposition for AArch64

peter.smith added a comment. Thanks for the update. With the clarification that this isn't breaking aarch64 long range thunks now, and we are not considering Arm then I'm happy for this to happen if the user opts in with -fno-semantic-interposition. I think the longer term question, outside of

[PATCH] D92677: Provide default location of sysroot for Baremetal toolchain.

abidh added a comment. If gcc and clang based toolchains are installed in the same prefix then having sysroot at same location can cause one installation to overwrite parts of other. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92677/new/ https:/

[PATCH] D102049: [BareMetal] Ensure that sysroot always comes after library paths

abidh accepted this revision. abidh added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102049/new/ https://reviews.llvm.org/D102049 ___ c

[PATCH] D101763: [analyzer][ctu] Avoid parsing invocation list again and again during on-demand parsing of CTU

OikawaKirie updated this revision to Diff 343626. OikawaKirie added a comment. In D101763#2743984 , @steakhal wrote: > By inspecting the output that is piped to the `count`, I have a suspicion: > > openat(AT_FDCWD, "invocations.yaml", O_RDONLY|O_CLOEXEC

[PATCH] D102022: [AMDGPU] Expose __builtin_amdgcn_perm for v_perm_b32

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc714d037857f: [AMDGPU] Expose __builtin_amdgcn_perm for v_perm_b32 (authored by rampitec). Herald added a project: clang. Herald added a subscriber:

[PATCH] D101921: [MC] Make it possible for targets to define their own MCObjectFileInfo

MaskRay added a comment. Can you post the RISCV patch depending on this one? Comment at: llvm/include/llvm/Support/TargetRegistry.h:1029 +/// RegisterMCObjectFileInfo - Helper template for registering a target object +/// file info implementation. This invokes the static "Cr

[PATCH] D101921: [MC] Make it possible for targets to define their own MCObjectFileInfo

flip1995 added a comment. In D101921#2743735 , @MaskRay wrote: > Can you post the RISCV patch depending on this one? Yes, sure. See https://reviews.llvm.org/D102052. Comment at: llvm/include/llvm/Support/TargetRegistry.h:1029 +/// R

[PATCH] D101921: [MC] Make it possible for targets to define their own MCObjectFileInfo

flip1995 added inline comments. Comment at: llvm/lib/DWARFLinker/DWARFStreamer.cpp:57 - MOFI.reset(new MCObjectFileInfo); - MC.reset( - new MCContext(TheTriple, MAI.get(), MRI.get(), MOFI.get(), MSTI.get())); - MOFI->initMCObjectFileInfo(*MC, /*PIC=*/false); + MC.reset

[PATCH] D101921: [MC] Make it possible for targets to define their own MCObjectFileInfo

flip1995 added a comment. In D101921#2743735 , @MaskRay wrote: > Can you post the RISCV patch depending on this one? Yes, sure. See https://reviews.llvm.org/D102052. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D100630: [Debug-Info][DBX] DW_TAG_rvalue_reference_type should not be generated when dwarf version is smaller than 4

shchenz added a comment. gentle ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100630/new/ https://reviews.llvm.org/D100630 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

[PATCH] D101921: [MC] Make it possible for targets to define their own MCObjectFileInfo

flip1995 updated this revision to Diff 343605. flip1995 added a comment. Remove redundant item names in doc comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101921/new/ https://reviews.llvm.org/D101921 Files: clang/lib/Parse/ParseStmtAsm.c

[PATCH] D102062: [analyzer][ctu] Append ctu-dir to ctu-invocation-list for non-absolute paths

OikawaKirie created this revision. OikawaKirie added reviewers: gamesh411, steakhal, martong, balazske. OikawaKirie added a project: clang. Herald added subscribers: ASDenysPetrov, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. OikawaKir

[PATCH] D102064: Parse vector bool when stdbool.h and altivec.h are included

ZarkoCA created this revision. ZarkoCA added reviewers: PowerPC, clang, cebowleratibm, hubert.reinterpretcast, bmahjour. ZarkoCA added projects: clang, PowerPC. ZarkoCA requested review of this revision. Herald added a subscriber: cfe-commits. Currently when including stdbool.h and altivec.h decl

[clang] f372ff1 - [NFC] (test commit) Changed example invocation of C++ for OpenCL

Author: Ole Strohm Date: 2021-05-07T12:31:37+01:00 New Revision: f372ff17f74f99f5e1c021a9c919b33c4caf38d9 URL: https://github.com/llvm/llvm-project/commit/f372ff17f74f99f5e1c021a9c919b33c4caf38d9 DIFF: https://github.com/llvm/llvm-project/commit/f372ff17f74f99f5e1c021a9c919b33c4caf38d9.diff LO

[PATCH] D100482: [PowerPC] Provide MMA builtins for compatibility

nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land. LGTM. Thanks for fixing this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100482/new/ https://reviews.llvm.org/D100482 __

[PATCH] D101763: [analyzer][ctu] Avoid parsing invocation list again and again during on-demand parsing of CTU

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. I would love to see `PreviousParsingResult` combined with `InvocationList` using a `llvm::Error`. I'm pretty sure it can be done. Regardless, I think it's already better than it was. CHAN

[PATCH] D102064: Parse vector bool when stdbool.h and altivec.h are included

nemanjai added inline comments. Comment at: clang/test/Parser/altivec-bool.c:11 +// RUN:-target-feature +altivec -fsyntax-only %s + +__vector bool char bc; Do we not want the test case to provide a similar define to what `stdbool.h` does? Repositor

[PATCH] D102065: [AMDGPU][OpenMP] Emit textual IR for -emit-llvm -S

pdhaliwal created this revision. pdhaliwal added reviewers: jdoerfert, JonChesterfield, ronlieb, gregrodgers. Herald added subscribers: kerbowa, guansong, t-tye, tpr, dstuttard, yaxunl, nhaehnle, jvesely, kzhuravl. pdhaliwal requested review of this revision. Herald added subscribers: cfe-commits,

[PATCH] D102062: [analyzer][ctu] Append ctu-dir to ctu-invocation-list for non-absolute paths

steakhal added a comment. On second thought the current behavior is reasonable. We call clang from a command line, so I think it's fair to expect that relative paths are resolved using the CWD. AFAIK if one does not supply the `ctu-invocation-list`, then it would be substituted by `ctu-dir/invoc

[PATCH] D102065: [AMDGPU][OpenMP] Emit textual IR for -emit-llvm -S

JonChesterfield added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4397 JA.getType() == types::TY_LTO_BC) { - CmdArgs.push_back("-emit-llvm-bc"); + // Emit textual llvm IR for AMDGPU offloading for -emit-llvm -S + if (Triple.is

[PATCH] D101519: [C++4OpenCL] Fix reinterpret_cast of vectors

olestrohm updated this revision to Diff 343647. olestrohm retitled this revision from "[C++4OpenCL] Fix reinterpret_cast of vectors and types with address spaces" to "[C++4OpenCL] Fix reinterpret_cast of vectors". olestrohm set the repository for this revision to rG LLVM Github Monorepo. olestroh

[PATCH] D100782: [PowerPC] Improve f32 to i32 bitcast code gen

nemanjai requested changes to this revision. nemanjai added a comment. This revision now requires changes to proceed. Please add the missing BE handling. Comment at: llvm/lib/Target/PowerPC/PPCInstrVSX.td:2800 + (f32 (fpround f64:$A)), (f32 (fproun

[PATCH] D92815: [PowerPC] [Clang] Enable float128 feature on VSX targets

nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land. LGTM. Comment at: clang/lib/Basic/Targets/PPC.cpp:359 llvm::find(FeaturesVec, "+float128") != FeaturesVec.end()) { -// We have __float128 on PPC but not power

[PATCH] D102065: [AMDGPU][OpenMP] Emit textual IR for -emit-llvm -S

pdhaliwal added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4397 JA.getType() == types::TY_LTO_BC) { - CmdArgs.push_back("-emit-llvm-bc"); + // Emit textual llvm IR for AMDGPU offloading for -emit-llvm -S + if (Triple.isAMDGCN

[PATCH] D102067: [amdgpu-arch] Guard hsa.h with __has_include

pdhaliwal created this revision. pdhaliwal added reviewers: jdoerfert, JonChesterfield, ronlieb, davezarzycki. Herald added subscribers: kerbowa, t-tye, tpr, dstuttard, yaxunl, nhaehnle, jvesely, kzhuravl. pdhaliwal requested review of this revision. Herald added subscribers: cfe-commits, wdng. He

[PATCH] D99949: [AMDGPU][OpenMP] Add amdgpu-arch tool to list AMD GPUs installed

pdhaliwal added a comment. I have put up a patch D102067 which uses __has_include as a workaround for header not found issue. @davezarzycki can you check if this resolves the issue? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[clang] 76f1de1 - [OpenCL] Fix optional image types.

Author: Anastasia Stulova Date: 2021-05-07T13:29:28+01:00 New Revision: 76f1de10f43ec4d1eb6146c45ccd6f93df5aa3e1 URL: https://github.com/llvm/llvm-project/commit/76f1de10f43ec4d1eb6146c45ccd6f93df5aa3e1 DIFF: https://github.com/llvm/llvm-project/commit/76f1de10f43ec4d1eb6146c45ccd6f93df5aa3e1.d

[PATCH] D100983: [OpenCL] Fix optional image types

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG76f1de10f43e: [OpenCL] Fix optional image types. (authored by Anastasia). Herald added a subscriber: ldrumm. Herald added a project: clang. Changed

[PATCH] D102064: Parse vector bool when stdbool.h and altivec.h are included

ZarkoCA updated this revision to Diff 343656. ZarkoCA added a comment. - update test cases to contain `_Bool` as well Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102064/new/ https://reviews.llvm.org/D102064 Files: clang/include/clang/Parse/Par

[PATCH] D102065: [AMDGPU][OpenMP] Emit textual IR for -emit-llvm -S

JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. Ah, yes. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102065/new/ https://reviews.llvm.org/D102065 _

[PATCH] D102067: [amdgpu-arch] Guard hsa.h with __has_include

JonChesterfield added a comment. Logic doesn't look quite right to me. If the compiler supports has_include, but neither of those headers exist, we fall through to main() which won't compile. How about: #if defined(__has_include) #if __has_include("hsa.h") #define HSA_FOUND 1 // nam

[PATCH] D102069: [clang][PreProcessor] Cutoff parsing after hitting completion point

kadircet created this revision. kadircet added a reviewer: hokein. kadircet requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This fixes a crash caused by Lexers being invalidated at code completion points in https://github.com/llvm/llvm-proj

[PATCH] D100604: [PowerPC] Improve codegen for int-to-fp conversion of subword vector extract

nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100604/new/ https://reviews.llvm.org/D100604 ___ cfe-commits mailing list cfe-comm

[PATCH] D93769: [clang] Add support for option -ffp-eval-method and extend #pragma float_control similarly

mibintc updated this revision to Diff 343666. mibintc added a comment. Respond to @aaron.ballman 's review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93769/new/ https://reviews.llvm.org/D93769 Files: clang/docs/LanguageExtensions.rst clang/

[PATCH] D102070: [AIX][TLS] Diagnose use of unimplemented TLS models

NeHuang created this revision. Herald added a reviewer: aaron.ballman. NeHuang requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add front end diagnostics to report error for unimplemented TLS models set by - compiler option `-ftls-model` -

[PATCH] D102067: [amdgpu-arch] Guard hsa.h with __has_include

pdhaliwal updated this revision to Diff 343668. pdhaliwal added a comment. Added fallback in case __has_include is not defined or header is not found anywhere. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102067/new/ https://reviews.llvm.org/D102

[PATCH] D100976: [OpenCL] Simplify use of C11 atomic types

Anastasia added inline comments. Comment at: clang/test/Parser/opencl-atomics-cl20.cl:34 atomic_ptrdiff_t pd; -// OpenCL v2.0 s6.13.11.8, _Atomic type specifier and _Atomic type qualifier -// are not supported by OpenCL. - _Atomic int i; // expected-error {{use of undeclared

[PATCH] D100976: [OpenCL] Simplify use of C11 atomic types

Anastasia added inline comments. Comment at: clang/test/Parser/opencl-atomics-cl20.cl:34 atomic_ptrdiff_t pd; -// OpenCL v2.0 s6.13.11.8, _Atomic type specifier and _Atomic type qualifier -// are not supported by OpenCL. - _Atomic int i; // expected-error {{use of undeclared

[PATCH] D93769: [clang] Add support for option -ffp-eval-method and extend #pragma float_control similarly

mibintc marked 9 inline comments as done. mibintc added inline comments. Comment at: clang/include/clang/Lex/Preprocessor.h:181 IdentifierInfo *Ident__is_target_environment;// __is_target_environment + IdentifierInfo *Ident__FLT_EVAL_METHOD__;// __FLT_EVAL_METHOD_

[PATCH] D100976: [OpenCL] Simplify use of C11 atomic types

mantognini added inline comments. Comment at: clang/test/Parser/opencl-atomics-cl20.cl:34 atomic_ptrdiff_t pd; -// OpenCL v2.0 s6.13.11.8, _Atomic type specifier and _Atomic type qualifier -// are not supported by OpenCL. - _Atomic int i; // expected-error {{use of undeclared

[PATCH] D100482: [PowerPC] Provide MMA builtins for compatibility

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG25bbff632d01: [PowerPC] Provide MMA builtins for compatibility (authored by saghir). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[clang] 25bbff6 - [PowerPC] Provide MMA builtins for compatibility

Author: Ahsan Saghir Date: 2021-05-07T09:10:16-05:00 New Revision: 25bbff632d018d178272a61c0732203d53d3a2e3 URL: https://github.com/llvm/llvm-project/commit/25bbff632d018d178272a61c0732203d53d3a2e3 DIFF: https://github.com/llvm/llvm-project/commit/25bbff632d018d178272a61c0732203d53d3a2e3.diff

[PATCH] D101843: [OpenCL] Add clang extension for bitfields

Anastasia added inline comments. Comment at: clang/test/SemaOpenCL/unsupported.cl:11 +#ifndef BITFIELDS_EXT +// expected-error@-2 {{bit-fields are not supported in OpenCL}} +#endif svenvh wrote: > The extension has "bitfields" in the name but most diagnostics (in

[PATCH] D102067: [amdgpu-arch] Guard hsa.h with __has_include

JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. LGTM, thanks. I think this leaves us totally sure the clang build will succeed with a best effort chance of having a working amdgpu ident tool afterwards. Repository: rG L

[PATCH] D95425: Implementation of global.get/set for reftypes in LLVM IR

pmatos marked 7 inline comments as done. pmatos added inline comments. Comment at: llvm/lib/CodeGen/MachineOperand.cpp:1174 + } else +OS << ", opaque "; if (getAlign() != getBaseAlign()) tlively wrote: > Is there a test that demonstrates this printing? Al

[PATCH] D102067: [amdgpu-arch] Guard hsa.h with __has_include

JonChesterfield added a comment. A thought - we need to keep return 0 for success, but could return a different integer for each failure mode. That would be useful when guessing why it failed. Orthogonal to this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D101192: Add support for #elifdef and #elifndef

aaron.ballman updated this revision to Diff 343680. aaron.ballman added a comment. Updated based on review feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101192/new/ https://reviews.llvm.org/D101192 Files: clang/include/clang/Basic/DiagnosticLexKinds.td clang/include/clang

[PATCH] D102070: [AIX][TLS] Diagnose use of unimplemented TLS models

NeHuang updated this revision to Diff 343683. NeHuang added a comment. Update the test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102070/new/ https://reviews.llvm.org/D102070 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td c

[PATCH] D101192: Add support for #elifdef and #elifndef

aaron.ballman marked 2 inline comments as done. aaron.ballman added inline comments. Comment at: clang/lib/Lex/PPDirectives.cpp:3254-3265 + Token MacroNameTok; + ReadMacroName(MacroNameTok); + + // Error reading macro name? If so, diagnostic already issued. + if (MacroNameTo

[PATCH] D95425: Implementation of global.get/set for reftypes in LLVM IR

pmatos updated this revision to Diff 343685. pmatos added a comment. - Simplifies some of code in the middle-end. - Removes setComdat and adds setWeak Small improvements to address comments in review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D9

[PATCH] D93769: [clang] Add support for option -ffp-eval-method and extend #pragma float_control similarly

aaron.ballman added a reviewer: hubert.reinterpretcast. aaron.ballman added a subscriber: hubert.reinterpretcast. aaron.ballman added a comment. I think the changes look good to me, but I'm not a floating-point expert either. Adding @hubert.reinterpretcast for his floating-point expertise. ===

[PATCH] D102070: [AIX][TLS] Diagnose use of unimplemented TLS models

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:548 +def err_aix_unsupported_tls_model : Error<"The tls model %0 is not yet supported on AIX">; + This neatly avoids the problem of diagnostics not starting wit

[PATCH] D95425: Implementation of global.get/set for reftypes in LLVM IR

pmatos updated this revision to Diff 343695. pmatos added a comment. Making the linter happy... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95425/new/ https://reviews.llvm.org/D95425 Files: clang/lib/Basic/Targets/WebAssembly.cpp llvm/includ

[PATCH] D99683: [HIP] Support ThinLTO

yaxunl marked an inline comment as done. yaxunl added a comment. In D99683#2683308 , @tejohnson wrote: > To do what I suggested in the prior comment, you'd probably want to add a new > index-wide flag (since we don't read IR in the thin link). See for exa

[PATCH] D99683: [HIP] Support ThinLTO

yaxunl updated this revision to Diff 343696. yaxunl marked an inline comment as done. yaxunl added a comment. revised by Teresa's comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99683/new/ https://reviews.llvm.org/D99683 Files: clang/include/clang/Driver/Driver.h clang/inclu

[PATCH] D102064: Parse vector bool when stdbool.h and altivec.h are included

ZarkoCA added inline comments. Comment at: clang/test/Parser/altivec-bool.c:11 +// RUN:-target-feature +altivec -fsyntax-only %s + +__vector bool char bc; nemanjai wrote: > Do we not want the test case to provide a similar define to what `stdbool.h`

[PATCH] D101630: [HIP] Fix device-only compilation

yaxunl added a comment. In D101630#2733761 , @tra wrote: > In D101630#2730273 , @yaxunl wrote: > >> How about an option -fhip-bundle-device-output. If it is on, device output >> is bundled no matter how many GPU

[PATCH] D101873: [clang] Support clang -fpic -fno-semantic-interposition for AArch64

MaskRay added a comment. In D101873#2743987 , @peter.smith wrote: > Thanks for the update. > > With the clarification that this isn't breaking aarch64 long range thunks > now, and we are not considering Arm then I'm happy for this to happen if the > us

[PATCH] D101572: Make `hasTypeLoc` matcher support more node types.

SilensAngelusNex added a comment. I don't have commit access; you can go ahead and submit it. Thanks for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101572/new/ https://reviews.llvm.org/D101572 __

[PATCH] D102051: [RISCV] Consider scalar types for required extensions.

craig.topper added a comment. LGTM too Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102051/new/ https://reviews.llvm.org/D102051 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[PATCH] D101960: [openmp] Drop requirement on library path environment variables

protze.joachim added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:648 +void tools::addOpenMPRuntimeSpecificRPath(const ToolChain &TC, + const ArgList &Args, JonChesterfield wrote: > lebedev.ri

[PATCH] D99797: [analyzer] Implemented RangeSet::Factory::unite function to handle intersections and adjacency

ASDenysPetrov updated this revision to Diff 343714. ASDenysPetrov added a comment. Updated the patch due to comments. Added more tests. Simplified and improved solution. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99797/new/ https://reviews.llvm.org/D99797 Files: clang/include/cl

[PATCH] D99797: [analyzer] Implemented RangeSet::Factory::unite function to handle intersections and adjacency

ASDenysPetrov added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:136 + +RangeSet RangeSet::Factory::unite(RangeSet LHS, RangeSet RHS) { + if (LHS.isEmpty()) vsavchenko wrote: > I'd prefer `merge` There are common namings

[PATCH] D101259: [clang-tidy] Fix cppcoreguidelines-pro-type-vararg false positives with __builtin_ms_va_list

jubnzv added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines-pro-type-vararg-ms.cpp:7 + +// RUN: %check_clang_tidy %s cppcoreguidelines-pro-type-vararg %t + dyung wrote: > jubnzv wrote: > > probinson wrote: > > > probins

[PATCH] D101960: [openmp] Drop requirement on library path environment variables

JonChesterfield added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:648 +void tools::addOpenMPRuntimeSpecificRPath(const ToolChain &TC, + const ArgList &Args, protze.joachim wrote: > JonChesterf

[PATCH] D70638: [Diagnostic] add a warning which warns about misleading indentation

kastiglione added a comment. @Tyker in case you didn't see my previous message, I'm curious if you'd be willing to take a look at the bug. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70638/new/ https://reviews.llvm.org/D70638 __

[PATCH] D100980: [OpenCL] Allow use of double type without extension pragma

azabaznov added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:10006 "use of %select{type|declaration}0 %1 requires %2 support">; +def ext_opencl_double_without_pragma : Extension< + "Clang permits use of type 'double' regardless pragma if 'cl_k

[PATCH] D102018: [WebAssembly] Use functions instead of macros for const SIMD intrinsics

tlively added a comment. In D102018#2743818 , @aheejin wrote: > So what prevented us from using functions when we were using `_Static_assert` > and why is it now possible to use functions? From inside a function, the parameter never looks like a constan

[PATCH] D102086: [RISCV] Validate the SEW and LMUL operands to __builtin_rvv_vsetvli(max)

craig.topper created this revision. craig.topper added reviewers: evandro, HsiangKai, arcbbb, frasercrmck, rogfer01, khchen. Herald added subscribers: StephenFan, vkmr, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, edward-jon

[clang] 1e9c39a - [WebAssembly] Use functions instead of macros for const SIMD intrinsics

Author: Thomas Lively Date: 2021-05-07T11:50:19-07:00 New Revision: 1e9c39a3f982fe2f50cd19c74be8b64dfba4baad URL: https://github.com/llvm/llvm-project/commit/1e9c39a3f982fe2f50cd19c74be8b64dfba4baad DIFF: https://github.com/llvm/llvm-project/commit/1e9c39a3f982fe2f50cd19c74be8b64dfba4baad.diff

[PATCH] D102018: [WebAssembly] Use functions instead of macros for const SIMD intrinsics

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1e9c39a3f982: [WebAssembly] Use functions instead of macros for const SIMD intrinsics (authored by tlively). Repository: rG LLVM Github Monorepo

[PATCH] D101192: Add support for #elifdef and #elifndef

aaron.ballman updated this revision to Diff 343731. aaron.ballman marked an inline comment as done. aaron.ballman added a comment. Now, with ever-so-slightly better formatting (the rest of the formatting issues are either matching existing style or a fight between my clang-format and CI's clang-

[PATCH] D97680: [OpenMP] Simplify GPU memory globalization

tianshilei1992 added a comment. Is it better to split the patch? For example, the new alloc/free shared can be in a separate patch, and the globalization can be in another one. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97680/new/ https://revie

[PATCH] D102070: [AIX][TLS] Diagnose use of unimplemented TLS models

NeHuang updated this revision to Diff 343743. NeHuang added a comment. Addressed review comment for the diagnostic message and update the test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102070/new/ https://reviews.llvm.org/D102070 Files:

[PATCH] D102090: [CMake][ELF] Add -fno-semantic-interposition and -Bsymbolic-functions

MaskRay created this revision. Herald added subscribers: pengfei, mgorny. MaskRay requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. In an ELF shared object, a default visibility defined symbol is preemptible by default. Thi

[clang] c04c66d - [RISCV] Consider scalar types for required extensions.

Author: Hsiangkai Wang Date: 2021-05-08T04:06:45+08:00 New Revision: c04c66d705b4f6e95a6325ef6d6c647ebc622165 URL: https://github.com/llvm/llvm-project/commit/c04c66d705b4f6e95a6325ef6d6c647ebc622165 DIFF: https://github.com/llvm/llvm-project/commit/c04c66d705b4f6e95a6325ef6d6c647ebc622165.diff

[PATCH] D102051: [RISCV] Consider scalar types for required extensions.

This revision was automatically updated to reflect the committed changes. Closed by commit rGc04c66d705b4: [RISCV] Consider scalar types for required extensions. (authored by HsiangKai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102051/new/ http

[PATCH] D101868: [clang-format] Adds a formatter for aligning arrays of structs

feg208 marked 4 inline comments as done. feg208 added a comment. I think I have all the tests and requested review comments rolled up Comment at: clang/unittests/Format/FormatTest.cpp:16352 +template +auto createStylesImpl( curdeius wrote: > HazardyKnusperke

[PATCH] D101868: [clang-format] Adds a formatter for aligning arrays of structs

feg208 updated this revision to Diff 343747. feg208 added a comment. Added more tests and addressed review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101868/new/ https://reviews.llvm.org/D101868 Files: clang/docs/ClangFormatStyleOpti

[PATCH] D101868: [clang-format] Adds a formatter for aligning arrays of structs

feg208 updated this revision to Diff 343748. feg208 marked an inline comment as done. feg208 added a comment. Oops missed a request Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101868/new/ https://reviews.llvm.org/D101868 Files: clang/docs/Clan

[PATCH] D101868: [clang-format] Adds a formatter for aligning arrays of structs

feg208 added a comment. Missed a request in the release notes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101868/new/ https://reviews.llvm.org/D101868 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D99797: [analyzer] Implemented RangeSet::Factory::unite function to handle intersections and adjacency

ASDenysPetrov updated this revision to Diff 343750. ASDenysPetrov added a comment. Minor comment fix. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99797/new/ https://reviews.llvm.org/D99797 Files: clang/include/clang/StaticAnalyzer/Core/PathSensitive/RangedConstraintManager.h cla

[clang] 6b00b34 - [BareMetal] Ensure that sysroot always comes after library paths

Author: Petr Hosek Date: 2021-05-07T13:21:07-07:00 New Revision: 6b00b34b8a05896f79b18a1963811299b83d5b21 URL: https://github.com/llvm/llvm-project/commit/6b00b34b8a05896f79b18a1963811299b83d5b21 DIFF: https://github.com/llvm/llvm-project/commit/6b00b34b8a05896f79b18a1963811299b83d5b21.diff LO

[PATCH] D102049: [BareMetal] Ensure that sysroot always comes after library paths

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6b00b34b8a05: [BareMetal] Ensure that sysroot always comes after library paths (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES

[clang] c4adc49 - [SEH] Fix regression with SEH in noexpect functions

Author: Olivier Goffart Date: 2021-05-07T13:27:59-07:00 New Revision: c4adc49a1c988e6ea8a340b6245525ef5599812c URL: https://github.com/llvm/llvm-project/commit/c4adc49a1c988e6ea8a340b6245525ef5599812c DIFF: https://github.com/llvm/llvm-project/commit/c4adc49a1c988e6ea8a340b6245525ef5599812c.dif

[PATCH] D102027: [SEH] Fix regression with SEH in noexpect functions

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc4adc49a1c98: [SEH] Fix regression with SEH in noexpect functions

[PATCH] D102027: [SEH] Fix regression with SEH in noexpect functions

rnk added a comment. I went ahead and implemented my suggested changes and pushed this with attribution. Thanks for the fix! Comment at: clang/lib/CodeGen/CGException.cpp:1966 StartFunction(GlobalDecl(), RetTy, Fn, FnInfo, Args, OutlinedStmt->getBeginLoc(

[PATCH] D101766: [TableGen] [Clang] Clean up Options.td and add asserts

dblaikie added inline comments. Comment at: clang/include/clang/Driver/Options.td:1089 + LangOpts<"DoubleSquareBracketAttributes">, + Default, PosFlag, NegFlag, jansvoboda11 wrote: > Paul-C-Anagnostopoulos wrote: > > jansvoboda11 wrote: > > > Paul-C-Anagnost

[clang] f97ada2 - Revert "[BareMetal] Ensure that sysroot always comes after library paths"

Author: Petr Hosek Date: 2021-05-07T13:38:04-07:00 New Revision: f97ada27aaf64207a2ffad937ce3ccf009e81bd8 URL: https://github.com/llvm/llvm-project/commit/f97ada27aaf64207a2ffad937ce3ccf009e81bd8 DIFF: https://github.com/llvm/llvm-project/commit/f97ada27aaf64207a2ffad937ce3ccf009e81bd8.diff LO

[PATCH] D102090: [CMake][ELF] Add -fno-semantic-interposition and -Bsymbolic-functions

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102090/new/ https://reviews.llvm.org/D102090 ___

[PATCH] D102090: [CMake][ELF] Add -fno-semantic-interposition and -Bsymbolic-functions

tstellar added a comment. Does this change mean that LD_PRELOAD will no longer work? Are there any other downsides to adding these flags? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102090/new/ https://reviews.llvm.org/D102090

[PATCH] D90996: [clang-format] Add --staged/--cached option to git-clang-format

alex1701c added a comment. Any update on this topic? I really like this feature. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90996/new/ https://reviews.llvm.org/D90996 ___ cfe-commits mailing list cfe-

[PATCH] D102090: [CMake][ELF] Add -fno-semantic-interposition and -Bsymbolic-functions

MaskRay updated this revision to Diff 343755. MaskRay added a comment. Set global CMAKE_SHARED_LINKER_FLAGS instead. This additional makes -DBUILD_SHARED_LIBS=on builds (dev only; not recommended for packagers) faster. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

  1   2   >