yaxunl marked an inline comment as done.
yaxunl added a comment.
In D99683#2683308 <https://reviews.llvm.org/D99683#2683308>, @tejohnson wrote:
> To do what I suggested in the prior comment, you'd probably want to add a new
> index-wide flag (since we don't read IR in the thin link). See for example
> how EnableSplitLTOUnit is set and used. You could add a flag like
> ForceImportAll or something like that. Then you don't necessarily even need
> to bump up the importing threshold or add the new import-noinline flag. Just
> key off of that in the importer to try to force import everything. If
> something cannot be imported, fail with a clear error.
will do
================
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4421
+ // Only AMDGPU supports device-side LTO
+ if (IsUsingLTO && (!IsDeviceOffloadAction || Triple.isAMDGPU())) {
Args.AddLastArg(CmdArgs, options::OPT_flto, options::OPT_flto_EQ);
----------------
tejohnson wrote:
> Should there be an error (or is there one already) emitted somewhere if LTO
> is requested along with device offloading and this isn't AMDGPU?
yes. will do
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D99683/new/
https://reviews.llvm.org/D99683
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
