[PATCH] D101743: [clangd] Fix hover crash on broken code

kadircet created this revision. kadircet added a reviewer: hokein. Herald added subscribers: usaxena95, arphaman. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: rG LLVM Github Monor

[PATCH] D101616: [clangd] Fix data type of WorkDoneProgressReport::percentage

ckandeler added a comment. Would you mind pushing this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101616/new/ https://reviews.llvm.org/D101616 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D101236: [ASTImporter] Import definitions required for layout of [[no_unique_address]] from LLDB

martong added inline comments. Comment at: clang/unittests/AST/ASTImporterTest.cpp:6408 + // Import the definition of the created class. + llvm::Error Err = findFromTU(FromC)->Importer->ImportDefinition(ToC); + EXPECT_FALSE((bool)Err); I suppose that the probl

[PATCH] D101635: [analyzer] Fix assertion in SVals.h

NoQ added a comment. In D101635#2731210 , @steakhal wrote: > Does anyone have an idea how to prevent such a silly mistake from happening > again? Maybe use more optionals? I.e., `castRegion` may fail, so let's change it to return `Optional` where the p

[PATCH] D97183: [analyzer] Add NoteTag for smart-ptr get()

RedDocMD added a comment. @NoQ ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97183/new/ https://reviews.llvm.org/D97183 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D101516: Introduce clangd-server-monitor tool

kadircet added inline comments. Comment at: clang-tools-extra/clangd/test/remote-index/pipeline_helper.py:77 + index_server_monitor_process.wait() + for line in index_server_monitor_process.stderr: +args.server_log.write(line) logs for index-server and moni

[PATCH] D101554: [clangd] Add support for the `defaultLibrary` semantic token modifier

kadircet added a comment. LG from my side. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:470 + if (auto *OT = dyn_cast(T)) +return scopeModifier(OT->getInterface()); return llvm::None; is this guaranteed to be non-null ? Repository:

[PATCH] D101672: Modules: Simplify how DisableGeneratingGlobalModuleIndex is set, likely NFC

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101672/new/ https://reviews.llvm.org/D101672 __

[PATCH] D101670: Modules: Rename ModuleBuildFailed => DisableGeneratingGlobalModuleIndex, NFC

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101670/new/ https://reviews.llvm.org/D101670 __

[PATCH] D101696: [Matrix] Implement C-style explicit type conversions in CXX for matrix types

fhahn added a comment. Thanks for the update! Technically the fix in `clang/lib/CodeGen/CGExprScalar.cpp` is unrelated to C++ support. It would be great if you could put up a separate patch, so we can land this independently. The whole patch basically LGTM. It would be great if you could add a

[PATCH] D100727: [clang-format] Add options to AllowShortIfStatementsOnASingleLine to apply to "else if" and "else".

curdeius updated this revision to Diff 342338. curdeius added a comment. - Fix format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100727/new/ https://reviews.llvm.org/D100727 Files: clang/include/clang/Format/Format.h clang/lib/Format/Forma

[PATCH] D101526: [analyzer][StdLibraryFunctionsChecker] Add NoteTags for applied arg constraints

martong marked 4 inline comments as done. martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:836-837 + NewState, NewNode, + C.getNoteTag([Msg](PathSensitiveBugReport &BR, + llv

[PATCH] D101526: [analyzer][StdLibraryFunctionsChecker] Add NoteTags for applied arg constraints

martong marked 2 inline comments as done. martong added inline comments. Comment at: clang/test/Analysis/std-c-library-functions-arg-constraints-note-tags.cpp:16 +int test_note(int x, int y) { +__single_val_1(x); // expected-note{{Applied constraint: The 1st arg should be

[PATCH] D70401: [WIP][RISCV] Implement ilp32e ABI

khchen added a comment. Herald added a subscriber: vkmr. Hi, I would like to add ilp32e ABI support in llvm Is there anyone working on this? It seem the one thing missed is ilp32e ABI should disallow D ISA extension. Is there anything else? Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D101640: [clang][patch] Add support for option -fextend-arguments-64: widen integer arguments to int64 in unprototyped function calls

jansvoboda11 added a comment. Usually, Clang has two flags to control a feature: one to turn it on and the other to turn it off. The last one on the command-line wins. Accepting both `-fextend-arguments=64` and `-fextend-arguments=32` would be more consistent with the rest of the command-line o

[PATCH] D101526: [analyzer][StdLibraryFunctionsChecker] Add NoteTags for applied arg constraints

martong updated this revision to Diff 342342. martong marked an inline comment as done. martong added a comment. - Add the description to the note tag only if the SVal is interesting - Use 'Assuming the nth arg is in ...' form for the descriptions Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D99646: [clang-tidy] misc-avoid-std-io-outside-main: a new check

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/AvoidStdIoOutsideMainCheck.cpp:22 + Finder->addMatcher( + declRefExpr(to(varDecl(hasAnyName("cin", "wcin", "cout", "wcout", "cerr", +"wcerr"), -

[clang-tools-extra] 53df522 - [clang-tidy][NFC] Short circuit getting enum options suggestions.

Author: Nathan James Date: 2021-05-03T11:20:27+01:00 New Revision: 53df522a0c536d32a60c0ed571097a78ce2541a7 URL: https://github.com/llvm/llvm-project/commit/53df522a0c536d32a60c0ed571097a78ce2541a7 DIFF: https://github.com/llvm/llvm-project/commit/53df522a0c536d32a60c0ed571097a78ce2541a7.diff

[PATCH] D100934: [clang][modules] Build inferred modules

jansvoboda11 added a comment. @dexonsmith ping Comment at: clang/lib/Serialization/ASTReader.cpp:5621 + // FIXME: NameAsWritten + ModMap.setUmbrellaHeader(CurrentModule, *Umbrella, Blob, ""); else if (CurrentModule->getUmbrellaHeader().Entry != *Umbre

[PATCH] D101462: Make it possible for targets to define their own MCObjectFileInfo

flip1995 updated this revision to Diff 342345. flip1995 added a comment. [MC] Untangle MCContext and MCObjectFileInfo This untangles the MCContext and the MCObjectFileInfo. There is a circular dependency between MCContext and MCObjectFileInfo. Currently this dependency also exists during construc

[PATCH] D101750: [clangd] Find implementors only when index is present.

usaxena95 created this revision. usaxena95 added a reviewer: sammccall. Herald added subscribers: kadircet, arphaman. usaxena95 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: rG LLVM Github

[PATCH] D101721: [clang-tidy][NFC] Update tests and Default options to use boolean value

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! One thing I'd like to be sure of though -- do we still have at least one test that's showing you can use false/0 and true/1/nonzero interchangeably? If not, we should proba

[clang] fe4c9b3 - [clang] Remove libstdc++ friend template hack

Author: Nathan Sidwell Date: 2021-05-03T04:19:30-07:00 New Revision: fe4c9b3cb0c3c0cac6b63de3b47a86e31559bb6d URL: https://github.com/llvm/llvm-project/commit/fe4c9b3cb0c3c0cac6b63de3b47a86e31559bb6d DIFF: https://github.com/llvm/llvm-project/commit/fe4c9b3cb0c3c0cac6b63de3b47a86e31559bb6d.diff

[PATCH] D101392: Remove libstdc++ friend template hack

This revision was automatically updated to reflect the committed changes. Closed by commit rGfe4c9b3cb0c3: [clang] Remove libstdc++ friend template hack (authored by urnathan). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D92024: [clang] Implement P0692R1 from C++20 (access checking on specializations and instantiations)

krisb added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:3080 +// For instance this marked as unavailable: +//class __attribute((unavailable)) UnavailableClass;` +auto RemoveAccessCheckingDiagnostics = [&TemplateInfo, this]() { aorlo

[PATCH] D101526: [analyzer][StdLibraryFunctionsChecker] Add NoteTags for applied arg constraints

steakhal added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:688-703 std::string StdLibraryFunctionsChecker::BufferSizeConstraint::describe( -ProgramStateRef State, const Summary &Summary) const { +DescritptionKind DK, Pro

[PATCH] D101721: [clang-tidy][NFC] Update tests and Default options to use boolean value

njames93 added a comment. In D101721#2733125 , @aaron.ballman wrote: > LGTM! One thing I'd like to be sure of though -- do we still have at least > one test that's showing you can use false/0 and true/1/nonzero > interchangeably? If not, we should prob

[PATCH] D101566: Let -Wweak-template-vtables warn on implicit instantiations

aaronpuchert added a comment. In D101566#2730746 , @dblaikie wrote: > Out of curiosity - have you tried it & measured any significant > improvement/value in build times/sizes/etc? No, I fear that would take too much time. (Not so much the benchmarking,

[PATCH] D101721: [clang-tidy][NFC] Update tests and Default options to use boolean value

aaron.ballman added a comment. In D101721#2733169 , @njames93 wrote: > In D101721#2733125 , @aaron.ballman > wrote: > >> LGTM! One thing I'd like to be sure of though -- do we still have at least >> one test tha

[PATCH] D101439: [clang-cl] Add parsing support for a bunch of new flags

hans marked 2 inline comments as done. hans added inline comments. Comment at: clang/include/clang/Driver/Options.td:6117 def _SLASH_favor : CLJoined<"favor">; +def _SLASH_fsanitize_address_use_after_return : CLJoined<"fsanitize-address-use-after-return">; +def _SLASH_fno_sanit

[clang] 876bf51 - [clang-cl] Add parsing support for a bunch of new flags

Author: Hans Wennborg Date: 2021-05-03T13:51:27+02:00 New Revision: 876bf516e7d4bba615da6cf791372fb36fc8f947 URL: https://github.com/llvm/llvm-project/commit/876bf516e7d4bba615da6cf791372fb36fc8f947 DIFF: https://github.com/llvm/llvm-project/commit/876bf516e7d4bba615da6cf791372fb36fc8f947.diff

[PATCH] D101439: [clang-cl] Add parsing support for a bunch of new flags

This revision was automatically updated to reflect the committed changes. hans marked 2 inline comments as done. Closed by commit rG876bf516e7d4: [clang-cl] Add parsing support for a bunch of new flags (authored by hans). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[clang] 530e074 - Thread safety analysis: Replace flags in FactEntry by SourceKind (NFC)

Author: Aaron Puchert Date: 2021-05-03T14:03:17+02:00 New Revision: 530e074faafe995a560e80815f5af8306670ea7b URL: https://github.com/llvm/llvm-project/commit/530e074faafe995a560e80815f5af8306670ea7b DIFF: https://github.com/llvm/llvm-project/commit/530e074faafe995a560e80815f5af8306670ea7b.diff

[clang] daca6ed - Thread safety analysis: Fix false negative on break

Author: Aaron Puchert Date: 2021-05-03T14:03:17+02:00 New Revision: daca6edb31efae048a420595fae9750aaa91c733 URL: https://github.com/llvm/llvm-project/commit/daca6edb31efae048a420595fae9750aaa91c733 DIFF: https://github.com/llvm/llvm-project/commit/daca6edb31efae048a420595fae9750aaa91c733.diff

[PATCH] D100801: Thread safety analysis: Replace flags in FactEntry by SourceKind [NFC]

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. aaronpuchert marked an inline comment as done. Closed by commit rG530e074faafe: Thread safety analysis: Replace flags in FactEntry by SourceKind (NFC) (authored by aaro

[PATCH] D101754: [Matrix] Remove bitcast when casting between matrices of the same size

SaurabhJha created this revision. Herald added a subscriber: tschuett. SaurabhJha requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In matrix type casts, we were doing bitcast when the matrices had the same size. This was incorrect and this

[PATCH] D101202: Thread safety analysis: Fix false negative on break

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdaca6edb31ef: Thread safety analysis: Fix false negative on break (authored by aaronpuchert). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D101755: Thread safety analysis: Eliminate parameter from intersectAndWarn (NFC)

aaronpuchert created this revision. aaronpuchert added reviewers: aaron.ballman, delesley. aaronpuchert requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We were modifying precisely when intersecting the lock sets of multiple predecessors wit

[PATCH] D101696: [Matrix] Implement C-style explicit type conversions in CXX for matrix types

SaurabhJha added a comment. In D101696#2732983 , @fhahn wrote: > Thanks for the update! Technically the fix in > `clang/lib/CodeGen/CGExprScalar.cpp` is unrelated to C++ support. It would be > great if you could put up a separate patch, so we can land t

[PATCH] D101702: [clang-format] Add more support for C# 8 nullables

MyDeveloperDay added a comment. Thank you for the patch Comment at: clang/lib/Format/TokenAnnotator.cpp:3197 +Right.is(TT_CSharpNullCoalescingAssignment)) + return true; + should this honour SpaceBeforeAssignmentOperators ? Repository: rG LLVM

[PATCH] D101628: [Format] Don't sort includes if DisableFormat is true

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. I've seen this asked for multiple time, I think this is fine. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101628/new/ https://

[PATCH] D101753: clang: Fix variable spelling

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGab7316f1c64c: [clang] Spell correct variable (authored by urnathan). Herald added a project: clang. Herald added a subscriber: cfe-commits. Reposito

[clang] ab7316f - [clang] Spell correct variable

Author: Nathan Sidwell Date: 2021-05-03T05:33:47-07:00 New Revision: ab7316f1c64c3530a6eca2e449c2dd734e83498e URL: https://github.com/llvm/llvm-project/commit/ab7316f1c64c3530a6eca2e449c2dd734e83498e DIFF: https://github.com/llvm/llvm-project/commit/ab7316f1c64c3530a6eca2e449c2dd734e83498e.diff

[PATCH] D101721: [clang-tidy][NFC] Update tests and Default options to use boolean value

njames93 added a comment. In D101721#2733173 , @aaron.ballman wrote: > In D101721#2733169 , @njames93 > wrote: > >> However in a few years once we can be confident most users are using >> clang-tidy-11 or newer

[PATCH] D100727: [clang-format] Add options to AllowShortIfStatementsOnASingleLine to apply to "else if" and "else".

MyDeveloperDay added a comment. Still looks good to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100727/new/ https://reviews.llvm.org/D100727 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D93095: Introduce -Wreserved-identifier

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Aside from the formatting nit and the question about the diagnostic, I think this LGTM! Comment at: clang/include/clang/Basic/DiagnosticGroups.td:637 def Keyw

[PATCH] D101754: [Matrix] Remove bitcast when casting between matrices of the same size

fhahn accepted this revision. fhahn added a comment. This revision is now accepted and ready to land. LGTM, thanks! I can commit this change on your behalf in a bit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101754/new/ https://reviews.llvm.org

[PATCH] D101721: [clang-tidy][NFC] Update tests and Default options to use boolean value

aaron.ballman added a comment. In D101721#2733260 , @njames93 wrote: > In D101721#2733173 , @aaron.ballman > wrote: > >> In D101721#2733169 , @njames93 >> wrote: >> >>>

[PATCH] D70094: [clang-tidy] new altera ID dependent backward branch check

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/altera/IdDependentBackwardBranchCheck.h:32 +: VariableDeclaration(Declaration), Location(Location), + Message(Message) {} +IdDependencyRecord(const FieldDecl *Declaration, SourceLo

[PATCH] D101479: [Driver] Support libc++ in MSVC

thakis added a comment. How does this interact with `/MT` / `/MD`? Does this link the static or the dynamic libc++? If the former, does that do the right thing for DLLs? If the latter, are users expected to manually copy libc++.dll? (Sorry, not super up to speed on the static/shared lib status

[PATCH] D101739: [OpenMP] Fix non-determinism in clang task codegen

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101739/new/ https://reviews.llvm.org/D101739 ___

[PATCH] D101754: [Matrix] Remove bitcast when casting between matrices of the same size

SaurabhJha added a comment. In D101754#2733273 , @fhahn wrote: > LGTM, thanks! > > I can commit this change on your behalf in a bit Cheers Florian! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101754/new/

[PATCH] D101479: [Driver] Support libc++ in MSVC

mstorsjo added subscribers: smeenai, mstorsjo. mstorsjo added a comment. In D101479#2733303 , @thakis wrote: > How does this interact with `/MT` / `/MD`? Does this link the static or the > dynamic libc++? If the former, does that do the right thing for D

[PATCH] D101139: Create install targets for scan-build-py.

wanders added inline comments. Comment at: clang/tools/scan-build-py/CMakeLists.txt:8 + "bin/intercept-cc" + "bin/scan-build") + This overwrites the "bin/scan-build" that was installed from the scan-build (no -py) subdirectory. So with this "scan-build

[PATCH] D101758: [clang][modules] Add -cc1 option to backup PCM files

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith. Herald added a subscriber: dang. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. During a highly parallel build with `-fimplicit-modules`,

[PATCH] D101503: [OpenMPIRBuilder] Add createOffloadMaptypes and createOffloadMapnames functions

Meinersbur accepted this revision. Meinersbur added a comment. This revision is now accepted and ready to land. LGTM, thank you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101503/new/ https://reviews.llvm.org/D101503 ___

[clang] 696becb - [Matrix] Remove bitcast when casting between matrices of the same size

Author: Saurabh Jha Date: 2021-05-03T15:31:43+01:00 New Revision: 696becbd139e4bbbe304ce2231de0fb50f307b68 URL: https://github.com/llvm/llvm-project/commit/696becbd139e4bbbe304ce2231de0fb50f307b68 DIFF: https://github.com/llvm/llvm-project/commit/696becbd139e4bbbe304ce2231de0fb50f307b68.diff L

[PATCH] D101754: [Matrix] Remove bitcast when casting between matrices of the same size

This revision was automatically updated to reflect the committed changes. Closed by commit rG696becbd139e: [Matrix] Remove bitcast when casting between matrices of the same size (authored by SaurabhJha, committed by fhahn). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D101479: [Driver] Support libc++ in MSVC

thakis added a comment. In D101479#2733354 , @mstorsjo wrote: > Not sure if we want the desicion between static and shared libc++ be coupled > with `/MT` and `/MD`, as one can quite plausibly want to use e.g. a static > libc++ with `/MD`. Right, I mean

[PATCH] D101554: [clangd] Add support for the `defaultLibrary` semantic token modifier

dgoldman updated this revision to Diff 342391. dgoldman added a comment. Remove unnecessary scope modifier Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101554/new/ https://reviews.llvm.org/D101554 Files: clang-tools-extra/clangd/SemanticHighlig

[PATCH] D101554: [clangd] Add support for the `defaultLibrary` semantic token modifier

dgoldman marked 2 inline comments as done. dgoldman added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:470 + if (auto *OT = dyn_cast(T)) +return scopeModifier(OT->getInterface()); return llvm::None; kadircet wrote: > is t

[PATCH] D101462: [MC] Untangle MCContext and MCObjectFileInfo

flip1995 updated this revision to Diff 342352. flip1995 marked 3 inline comments as done. flip1995 edited the summary of this revision. flip1995 added a comment. Herald added subscribers: dcaballe, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, stephenneuend

[PATCH] D101462: [MC] Untangle MCContext and MCObjectFileInfo

flip1995 updated this revision to Diff 342354. flip1995 added a comment. Fix arc mistake... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101462/new/ https://reviews.llvm.org/D101462 Files: clang/lib/Parse/ParseStmtAsm.cpp clang/tools/driver/c

[clang-tools-extra] c3d5f30 - [clangd] Find implementors only when index is present.

Author: Utkarsh Saxena Date: 2021-05-03T17:16:33+02:00 New Revision: c3d5f306e910788fcc4db8da9c9e819a0869264b URL: https://github.com/llvm/llvm-project/commit/c3d5f306e910788fcc4db8da9c9e819a0869264b DIFF: https://github.com/llvm/llvm-project/commit/c3d5f306e910788fcc4db8da9c9e819a0869264b.diff

[PATCH] D101750: [clangd] Find implementors only when index is present.

This revision was automatically updated to reflect the committed changes. Closed by commit rGc3d5f306e910: [clangd] Find implementors only when index is present. (authored by usaxena95). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101750/new/ http

[PATCH] D100621: [OpenMP] Ensure the DefaultMapperId has a location

JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. Not ideal to have unreproducible failures but the fix looks safe regardless Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D10062

[PATCH] D99543: [clang-tidy] Allow opt-in or out of some commonly occuring patterns in NarrowingConversionsCheck.

Stephen updated this revision to Diff 342409. Stephen marked 2 inline comments as done. Stephen added a comment. Within clang-tidy's NarrowingConversionsCheck. - Allow opt-out of some common occurring patterns, such as: - Implicit casts between types of equivalent bit widths. - Implicit casts

[PATCH] D99543: [clang-tidy] Allow opt-in or out of some commonly occuring patterns in NarrowingConversionsCheck.

Stephen requested review of this revision. Stephen added a comment. Thanks, ymandel! Anything else, aaron.ballman or hokein? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99543/new/ https://reviews.llvm.org/D99543

[PATCH] D101696: [Matrix] Implement C-style explicit type conversions in CXX for matrix types

SaurabhJha updated this revision to Diff 342413. SaurabhJha added a comment. Rebase with main and add new tests for uitofp, unsigned int to int, and int to unsigned int Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101696/new/ https://reviews.llvm

[PATCH] D101763: [analyzer][ctu] Avoid parsing invocation list again and again during on-demand parsing of CTU

OikawaKirie created this revision. OikawaKirie added reviewers: gamesh411, balazske, martong, xazax.hun. OikawaKirie added a project: clang. Herald added subscribers: steakhal, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. OikawaKir

[clang] 8d93d7f - [clang-format] Add options to AllowShortIfStatementsOnASingleLine to apply to "else if" and "else".

Author: Marek Kurdej Date: 2021-05-03T18:11:25+02:00 New Revision: 8d93d7ffedebc5f18dee22ba954d38a1d2d0affa URL: https://github.com/llvm/llvm-project/commit/8d93d7ffedebc5f18dee22ba954d38a1d2d0affa DIFF: https://github.com/llvm/llvm-project/commit/8d93d7ffedebc5f18dee22ba954d38a1d2d0affa.diff

[PATCH] D100727: [clang-format] Add options to AllowShortIfStatementsOnASingleLine to apply to "else if" and "else".

This revision was automatically updated to reflect the committed changes. Closed by commit rG8d93d7ffedeb: [clang-format] Add options to AllowShortIfStatementsOnASingleLine to apply to… (authored by curdeius). Changed prior to commit: https://reviews.llvm.org/D100727?vs=342338&id=342417#toc Re

[PATCH] D101030: [OpenMP] Overhaul `declare target` handling

jdoerfert updated this revision to Diff 342419. jdoerfert added a comment. Fix tests by not always emitting a definition for omp allocate Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101030/new/ https://reviews.llvm.org/D101030 Files: clang/inc

[clang] d492532 - [docs] Fix syntax typo.

Author: Marek Kurdej Date: 2021-05-03T18:28:54+02:00 New Revision: d492532b8c3a90502a452174c7f1d2677d054fda URL: https://github.com/llvm/llvm-project/commit/d492532b8c3a90502a452174c7f1d2677d054fda DIFF: https://github.com/llvm/llvm-project/commit/d492532b8c3a90502a452174c7f1d2677d054fda.diff

[PATCH] D101479: [Driver] Support libc++ in MSVC

mstorsjo added a comment. In D101479#2733434 , @thakis wrote: > In D101479#2733354 , @mstorsjo > wrote: > >> Not sure if we want the desicion between static and shared libc++ be coupled >> with `/MT` and `/MD`,

[clang] b2be167 - [docs] Fix title overline.

Author: Marek Kurdej Date: 2021-05-03T18:32:36+02:00 New Revision: b2be167a49523b1caab78bfca0635b8439c157ee URL: https://github.com/llvm/llvm-project/commit/b2be167a49523b1caab78bfca0635b8439c157ee DIFF: https://github.com/llvm/llvm-project/commit/b2be167a49523b1caab78bfca0635b8439c157ee.diff

[clang] 9d669e8 - [docs] Bump the trunk major version to 13 and update copyright year.

Author: Marek Kurdej Date: 2021-05-03T18:44:47+02:00 New Revision: 9d669e859b8069bf154c6d9ec37cc6bc2304f4e9 URL: https://github.com/llvm/llvm-project/commit/9d669e859b8069bf154c6d9ec37cc6bc2304f4e9 DIFF: https://github.com/llvm/llvm-project/commit/9d669e859b8069bf154c6d9ec37cc6bc2304f4e9.diff

[PATCH] D101030: [OpenMP] Overhaul `declare target` handling

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGDecl.cpp:2618 +void CodeGenModule::EmitOMPAllocateDecl(const OMPAllocateDecl *D) { + for (Expr *E : const_cast(D)->varlists()) { +auto *DE = cast(E); Why need to remove constantness here? =

[PATCH] D101462: [MC] Untangle MCContext and MCObjectFileInfo

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Looks great! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101462/new/ https://reviews.llvm.org/D101462 _

[PATCH] D97915: [Coroutines] Handle overaligned frame allocation

ychen added a comment. In D97915#2728377 , @ChuanqiXu wrote: > This code snippets confused me before: > > coro.alloc.align: ; preds = > %coro.check.align > %mask = sub i64 %11, 1 > %intptr = ptrtoint i8* %call to

[PATCH] D100620: [OpenMP] Make sure classes work on the device as they do on the host

jdoerfert updated this revision to Diff 342433. jdoerfert marked an inline comment as done. jdoerfert added a comment. Herald added a subscriber: mgorny. Avoid including by not wrapping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100620/new/ ht

[clang] 31751ce - [clang-format] Fix build on gcc < 7 introduced in rG8d93d7ff.

Author: Marek Kurdej Date: 2021-05-03T18:52:41+02:00 New Revision: 31751ce1b9239d7aacac84864bf06c36ce888408 URL: https://github.com/llvm/llvm-project/commit/31751ce1b9239d7aacac84864bf06c36ce888408 DIFF: https://github.com/llvm/llvm-project/commit/31751ce1b9239d7aacac84864bf06c36ce888408.diff

[PATCH] D100620: [OpenMP] Make sure classes work on the device as they do on the host

JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. cstdlib may not exist, probably in the same situations as new not existing, but that can probably be left until the problem arises. I think this looks reasonable, and it'll u

[PATCH] D101030: [OpenMP] Overhaul `declare target` handling

jdoerfert added inline comments. Comment at: clang/lib/CodeGen/CGDecl.cpp:2618 +void CodeGenModule::EmitOMPAllocateDecl(const OMPAllocateDecl *D) { + for (Expr *E : const_cast(D)->varlists()) { +auto *DE = cast(E); ABataev wrote: > Why need to remove constan

[PATCH] D100620: [OpenMP] Make sure classes work on the device as they do on the host

JonChesterfield added a comment. We might want a test that includes along with this header, to check they don't conflict with one another Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100620/new/ https://reviews.llvm.org/D100620

[PATCH] D100620: [OpenMP] Make sure classes work on the device as they do on the host

jdoerfert added a comment. In D100620#2733707 , @JonChesterfield wrote: > We might want a test that includes along with this header, to check > they don't conflict with one another For that I need to replicate the potentially conflicting `` stuff in t

[PATCH] D101766: [TableGen] [Clang] Clean up Options.td and add asserts

Paul-C-Anagnostopoulos created this revision. Paul-C-Anagnostopoulos added reviewers: jansvoboda11, dblaikie, craig.topper. Herald added a subscriber: dang. Paul-C-Anagnostopoulos requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This revisio

[PATCH] D101462: [MC] Untangle MCContext and MCObjectFileInfo

flip1995 added a comment. Not sure how the process from here on out is. I think it is important to note, that I don't have push rights and someone else will have to land this for me (I guess?). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101462/

[PATCH] D101462: [MC] Untangle MCContext and MCObjectFileInfo

flip1995 added a comment. > I'll keep this open for a few days as it touches too many things. Sounds good 👍 I used `arc diff`. The commits I made with `git` have my name and email attached. But it seems like `arc` doesn't use them? I'll figure it out tomorrow, can't be that hard, I hope. Rep

[PATCH] D101462: [MC] Untangle MCContext and MCObjectFileInfo

MaskRay added a comment. In D101462#2733691 , @flip1995 wrote: > Not sure how the process from here on out is. I think it is important to > note, that I don't have push rights and someone else will have to land this > for me (I guess?). I'll keep this

[PATCH] D101630: [HIP] Fix device-only compilation

tra added a subscriber: jdoerfert. tra added a comment. In D101630#2730273 , @yaxunl wrote: > How about an option -fhip-bundle-device-output. If it is on, device output is > bundled no matter how many GPU arch there are. By default it is on. +1 to the o

[PATCH] D101735: [WebAssembly] Reenable end-to-end test in wasm-eh.cpp

tlively accepted this revision. tlively added a comment. This revision is now accepted and ready to land. This is hopefully less controversial because the test already exists and this is just re-enabling it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[clang] a27ca15 - [OpenMP] Fix non-determinism in clang task codegen

Author: Giorgis Georgakoudis Date: 2021-05-03T10:34:38-07:00 New Revision: a27ca15dd08342b199e2feb5ae896475fd90a518 URL: https://github.com/llvm/llvm-project/commit/a27ca15dd08342b199e2feb5ae896475fd90a518 DIFF: https://github.com/llvm/llvm-project/commit/a27ca15dd08342b199e2feb5ae896475fd90a51

[PATCH] D101739: [OpenMP] Fix non-determinism in clang task codegen

This revision was automatically updated to reflect the committed changes. Closed by commit rGa27ca15dd083: [OpenMP] Fix non-determinism in clang task codegen (authored by ggeorgakoudis). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101739/new/ http

[PATCH] D100620: [OpenMP] Make sure classes work on the device as they do on the host

JonChesterfield added a comment. In D100620#2733708 , @jdoerfert wrote: > For that I need to replicate the potentially conflicting `` stuff in the > test header mockups. I'll try it later on one system though. Yep, may not be able to check in something

[PATCH] D100934: [clang][modules] Build inferred modules

dexonsmith added a comment. Given that there are four different things being done in this commit, it sounds naively like it should be four separate commits. If the logic is too intertwined to land each of the four pieces separately (certainly possible), can you quickly explain why, to motivate

[PATCH] D101763: [analyzer][ctu] Avoid parsing invocation list again and again during on-demand parsing of CTU

steakhal added a comment. Awesome! Seems good to me. Though I've got limited experience on CTU stuff. It would be nice to have tests, but it seems pretty hard to come up with one for this. Given that this is just a 'performance' issue, I'm fine with it. Somehow try to check if this resolved your

[PATCH] D99543: [clang-tidy] Allow opt-in or out of some commonly occuring patterns in NarrowingConversionsCheck.

njames93 added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines-narrowing-conversions-ignoreconversionfromtypes-option.cpp:12 + +typedef long long size_t; + This is breaking tests on windows, It seems like its pre-defined

[clang] 64a390c - Modules: Remove an extra early return, NFC

Author: Duncan P. N. Exon Smith Date: 2021-05-03T10:50:09-07:00 New Revision: 64a390c1bc75eb55eeed3061df15dc581fd563e6 URL: https://github.com/llvm/llvm-project/commit/64a390c1bc75eb55eeed3061df15dc581fd563e6 DIFF: https://github.com/llvm/llvm-project/commit/64a390c1bc75eb55eeed3061df15dc581fd5

[PATCH] D101645: [clang] RecursiveASTVisitor visits ObjCPropertyRefExpr's class receiver

benlangmuir added a subscriber: akyrtzi. benlangmuir added inline comments. Comment at: clang/test/Index/Core/index-source.m:410 // CHECK-NEXT: RelCont | classReceivers | c:@F@classReceivers +// CHECK: [[@LINE-3]]:3 | class/ObjC | ClassReceivers | c:objc(cs)ClassReceivers | _OB

  1   2   3   >