mstorsjo added subscribers: smeenai, mstorsjo. mstorsjo added a comment. In D101479#2733303 <https://reviews.llvm.org/D101479#2733303>, @thakis wrote:
> How does this interact with `/MT` / `/MD`? Does this link the static or the > dynamic libc++? If the former, does that do the right thing for DLLs? If the > latter, are users expected to manually copy libc++.dll? (Sorry, not super up > to speed on the static/shared lib status of libc++ on windows.) Right now, libc++ headers mark everything dllimport by default, unless `_LIBCPP_DISABLE_VISIBILITY_ANNOTATIONS` is defined. If you build a static-only libc++, libc++'s `__config_site` predefines `_LIBCPP_DISABLE_VISIBILITY_ANNOTATIONS`. Not sure if we want the desicion between static and shared libc++ be coupled with `/MT` and `/MD`, as one can quite plausibly want to use e.g. a static libc++ with `/MD`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101479/new/ https://reviews.llvm.org/D101479 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
