ABataev added inline comments.
================ Comment at: clang/lib/CodeGen/CGDecl.cpp:2618 +void CodeGenModule::EmitOMPAllocateDecl(const OMPAllocateDecl *D) { + for (Expr *E : const_cast<OMPAllocateDecl *>(D)->varlists()) { + auto *DE = cast<DeclRefExpr>(E); ---------------- Why need to remove constantness here? ================ Comment at: clang/lib/CodeGen/CGDecl.cpp:2622 + + // Skipp all but globals. + if (!VD->hasGlobalStorage()) ---------------- `Skip` ================ Comment at: clang/lib/CodeGen/CGDecl.cpp:2623-2624 + // Skipp all but globals. + if (!VD->hasGlobalStorage()) + continue; + ---------------- What about static locals, will it work? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101030/new/ https://reviews.llvm.org/D101030 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits