[PATCH] D99790: [CGCall] Annotate `this` argument with alignment

rjmccall added a comment. I agree. The arrangement logic is assuming that the exact pointer type doesn't matter because it's all just a pointer in the end, but of course that breaks down when we start inferring attributes. Pointer authentication also really wants to know the original declarati

[PATCH] D100615: [RISCV][Driver] Make the ordering of CmdArgs consistent between RISCV::Linker and baremetal::Linker

arcbbb updated this revision to Diff 338004. arcbbb added a comment. Addressed @MaskRay 's comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100615/new/ https://reviews.llvm.org/D100615 Files: clang/lib/Driver/ToolChains/RISCVToolchain.cpp

[PATCH] D99503: [clang-format] Inconsistent behavior regarding line break before access modifier

curdeius added a comment. @max_s I think you need to rebase on current main and fix two tests as //probably// D98237 (or another patch) changed the behaviour of this patch. [ FAILED ] 2 tests, listed below: [ FAILED ] FormatTest.FormatsAccessModifiers

[PATCH] D99790: [CGCall] Annotate `this` argument with alignment

lebedev.ri added a comment. I have tried to fix this in D100388 , but i don't quite understand all the moving parts, so it's still not in a working state (even though it fixed those two tests), so i'm not sure how productive it is to develop it via a review feedb

[PATCH] D100596: [WebAssembly] Remove saturating fp-to-int target intrinsics

aheejin accepted this revision. aheejin added inline comments. This revision is now accepted and ready to land. Comment at: llvm/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp:124-127 + if (Subtarget->hasNontrappingFPToInt()) +for (auto Op : {ISD::FP_TO_SINT_SAT, ISD::FP

[PATCH] D99503: [clang-format] Inconsistent behavior regarding line break before access modifier

Max_S updated this revision to Diff 338011. Max_S added a comment. Sorry for the inconvenience. These were the errors, that inspired this patch. In all cases the new version is now the correct one. The default setting of EmptyLineBeforeAccessModifier is to insert empty lines for logical blocks,

[PATCH] D99158: [RISCV][WIP] Implement intrinsics for P extension

Jim updated this revision to Diff 338017. Jim added a comment. 1. Updating D99158 : [RISCV][WIP] Implement intrinsics for P extension # 2. Enter a brief description of the changes included in this update. 3. The first line is used as subject, next lines as comment

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

rjmccall added a comment. Sorry for the delay. That seems like a reasonable summary of our discussion. Let me try to lay out the right architecture for this as I see it. Conceptually, we can split the translation unit into a sequence of partial translation units (PTUs). Every declaration wil

[PATCH] D99158: [RISCV][WIP] Implement intrinsics for P extension

Jim added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:762 + for (unsigned Opc = 0; Opc < ISD::BUILTIN_OP_END; ++Opc) +setOperationAction(Opc, VT, Expand); + craig.topper wrote: > You probably need handling for insert_vect

[PATCH] D100626: [analyzer][NFC] Remove duplicated work from retain count leak report

vsavchenko created this revision. vsavchenko added a reviewer: NoQ. Herald added subscribers: steakhal, ASDenysPetrov, martong, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, kristof.beyls, xazax.hun. vsavchenko requested review of this revision.

[clang] fd4e08a - [clang-format] Inconsistent behavior regarding line break before access modifier

Author: Max Sagebaum Date: 2021-04-16T10:39:13+02:00 New Revision: fd4e08aa8f7edfe877d022859ce162a1b4fa684c URL: https://github.com/llvm/llvm-project/commit/fd4e08aa8f7edfe877d022859ce162a1b4fa684c DIFF: https://github.com/llvm/llvm-project/commit/fd4e08aa8f7edfe877d022859ce162a1b4fa684c.diff

[PATCH] D99503: [clang-format] Inconsistent behavior regarding line break before access modifier

This revision was automatically updated to reflect the committed changes. Closed by commit rGfd4e08aa8f7e: [clang-format] Inconsistent behavior regarding line break before access modifier (authored by Max_S, committed by curdeius). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D100611: [RISCV] Add new attribute __clang_riscv_builtin_alias for intrinsics.

frasercrmck added a comment. Is this idea that this will later be "automatically" applied to builtins in `riscv_vector.h`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100611/new/ https://reviews.llvm.org/D100611

[PATCH] D100516: [AST] Add TypeLoc support to node introspection

steveire updated this revision to Diff 338030. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100516/new/ https://reviews.llvm.org/D100516 Files: clang/include/clang/Tooling/NodeIntrospection.h clang/lib/Tooling

[clang] efc013e - Revert "[AMDGPU][OpenMP] Add amdgpu-arch tool to list AMD GPUs installed"

Author: Pushpinder Singh Date: 2021-04-16T09:16:58Z New Revision: efc013ec4d950a68e6f80dd98cda35e1a96a6fc8 URL: https://github.com/llvm/llvm-project/commit/efc013ec4d950a68e6f80dd98cda35e1a96a6fc8 DIFF: https://github.com/llvm/llvm-project/commit/efc013ec4d950a68e6f80dd98cda35e1a96a6fc8.diff L

[PATCH] D99949: [AMDGPU][OpenMP] Add amdgpu-arch tool to list AMD GPUs installed

pdhaliwal added a comment. I've reverted this from main for now as there seems to be issue with executing test script on some CI machines. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99949/new/ https://reviews.llvm.org/D99949 __

[PATCH] D100471: [C++4OpenCL] Add extra diagnostics for kernel argument types

olestrohm updated this revision to Diff 338032. olestrohm set the repository for this revision to rG LLVM Github Monorepo. olestrohm added a comment. Restricted the checks to C++ for OpenCL and added another test for OpenCL vector types. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D100460: [WIP][clang] Move deep copy into CompilerInvocation::clone

jansvoboda11 updated this revision to Diff 338034. jansvoboda11 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100460/new/ https://reviews.llvm.org/D100460 Files: clang-tools-extra/clangd/TUScheduler.cpp clang-tools-extr

[PATCH] D100460: [WIP][clang] Move deep copy into CompilerInvocation::clone

jansvoboda11 updated this revision to Diff 338036. jansvoboda11 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100460/new/ https://reviews.llvm.org/D100460 Files: clang-tools-extra/clangd/TUScheduler.cpp clang-tools-extr

[PATCH] D100499: [AArch64] Neon Polynomial vadd Intrinsic Fix

DavidSpickett added a comment. Both clang and GCC have their issues when it comes to matching the ACLE, so I wouldn't take the header guard as fact. It could be that we never implemented the A32 path for these functions/when they were added the document was in flux/no on ever tried this on A32.

[PATCH] D100616: [clang][NFC] Fix a potential assert failure

benshi001 updated this revision to Diff 338045. benshi001 retitled this revision from "[clang] Fix a potential assert failure" to "[clang][NFC] Fix a potential assert failure". benshi001 added a reviewer: craig.topper. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100616/new/ https://rev

[PATCH] D100616: [clang][NFC] Fix a potential assert failure

benshi001 marked an inline comment as done. benshi001 added inline comments. Comment at: clang/include/clang/Basic/TargetBuiltins.h:334 static constexpr uint64_t LargestBuiltinID = std::max( {NEON::FirstTSBuiltin, ARM::LastTSBuiltin, SVE::FirstTSBuiltin, AArch64

[PATCH] D99079: [ARM][AArch64] Require appropriate features for crypto algorithms

dcandler updated this revision to Diff 338046. dcandler added a comment. I've updated the patch to fix the test failures, and slightly reworked the driver code to avoid the above iterator invalidation. I've also added a comment there to clarify what it is doing: individually determining whether

[PATCH] D99936: [clang][parser] Unify rejecting (non) decl stmt with gnu attributes

tbaeder added a comment. Hey Aaron, it's been a while. Do you have a suggestion on how to proceed if @rsmith has no opinion on it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99936/new/ https://reviews.llvm.org/D99936 __

[PATCH] D100516: [AST] Add TypeLoc support to node introspection

steveire updated this revision to Diff 338049. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100516/new/ https://reviews.llvm.org/D100516 Files: clang/include/clang/Tooling/NodeIntrospection.h clang/lib/Tooling

[PATCH] D100638: [AST][Introspection] Avoid creating temporary strings when comparing LocationCalls.

njames93 created this revision. njames93 added a reviewer: steveire. njames93 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Adds a bit of boiler plate, but removing the need to build temporary strings to compare the calls definitely wort

[PATCH] D99949: [AMDGPU][OpenMP] Add amdgpu-arch tool to list AMD GPUs installed

JonChesterfield added a comment. The failing log pointed at `"-mllvm" "--amdhsa-code-object-version=4"`, which is a hard error if the amdgpu triple is missing from the llvm. I see the test features amdgpu-registered-target. Perhaps that does not behave as one might wish? I'd suggest rebuilding

[PATCH] D100499: [AArch64] Neon Polynomial vadd Intrinsic Fix

DavidSpickett added a comment. Ok, it's behind the aarch64 guard because there's a giant #ifdef around it that I didn't see. If you move it in `arm_neon.td` down to outside that #ifdef you get the definitions. Next problem is that the `poly128_t` type isn't implemented for AArch32. Not sure why

[PATCH] D99741: [RISCV][Clang] Add some RVV Floating-Point intrinsic functions. (vfclass, vfmerge, vfrec7, vfrsqrt7, vfsqrt)

thakis added a comment. Was there any more progress on this? If not, let's revert for now to not permanently slow down tests by over 20%. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99741/new/ https://reviews.llvm.org/D99741 ___

[PATCH] D100638: [AST][Introspection] Avoid creating temporary strings when comparing LocationCalls.

steveire added inline comments. Comment at: clang/lib/Tooling/NodeIntrospection.cpp:84 + + auto LI = Left.rbegin(), LE = Left.rend(), RI = Right.rbegin(); + for (; LI != LE; ++LI, ++RI) { Would it make sense to compare the sizes `(leftsize < rightsize) return t

[PATCH] D96367: Partially Revert "scan-view: Remove Reporter.py and associated AppleScript files"

Arfrever added a comment. This commit is missing in `release/12.x` branch, so `scan-view` in recently released Clang 12.0.0 is broken. Please backport this commit to `release/12.x` branch so that it is included at least in upcoming Clang 12.0.1. Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D100590: DeclContext: Fix iterator category

v.g.vassilev accepted this revision. v.g.vassilev added a comment. This revision is now accepted and ready to land. Nice catch! Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100590/new/ https://reviews.llvm.org/D100590

[PATCH] D99741: [RISCV][Clang] Add some RVV Floating-Point intrinsic functions. (vfclass, vfmerge, vfrec7, vfrsqrt7, vfsqrt)

khchen added a comment. In D99741#2694344 , @thakis wrote: > Was there any more progress on this? If not, let's revert for now to not > permanently slow down tests by over 20%. https://reviews.llvm.org/D100611 https://reviews.llvm.org/D100617 Do you mea

[PATCH] D100620: [OpenMP] Make sure classes work on the device as they do on the host

JonChesterfield added inline comments. Comment at: clang/lib/Headers/openmp_wrappers/__clang_openmp_device_functions.h:20 +// need to `include `. +#include +#endif I think there are legitimate use cases for writing code that doesn't include new. Can we add the

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

Anastasia added inline comments. Comment at: clang/lib/AST/ItaniumMangle.cpp:2379 unsigned TargetAS = Context.getASTContext().getTargetAddressSpace(AS); - if (TargetAS != 0) + if (TargetAS != 0 || Context.getASTContext().getLangOpts().SYCLIsDevice) ASStr

[PATCH] D100638: [AST][Introspection] Avoid creating temporary strings when comparing LocationCalls.

njames93 added inline comments. Comment at: clang/lib/Tooling/NodeIntrospection.cpp:84 + + auto LI = Left.rbegin(), LE = Left.rend(), RI = Right.rbegin(); + for (; LI != LE; ++LI, ++RI) { steveire wrote: > Would it make sense to compare the sizes `(leftsize < r

[PATCH] D100534: [clang][deps] Generate the full command-line for modules

jansvoboda11 updated this revision to Diff 338069. jansvoboda11 added a comment. Share `ModuleDeps::Invocation` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100534/new/ https://reviews.llvm.org/D100534 Files: clang/include/clang/Frontend/Compil

[PATCH] D100534: [clang][deps] Generate the full command-line for modules

jansvoboda11 added inline comments. Comment at: clang/include/clang/Tooling/DependencyScanning/ModuleDepCollector.h:78-80 + /// The compiler invocation associated with the translation unit that imports + /// this module. + CompilerInvocation Invocation; dexon

[PATCH] D100534: [clang][deps] Generate the full command-line for modules

jansvoboda11 added inline comments. Comment at: clang/lib/Tooling/DependencyScanning/ModuleDepCollector.cpp:62 std::function LookupModuleDeps) const { - // TODO: Build full command line. That also means capturing the original - // command line into NonPathCommandLine

[PATCH] D100638: [AST][Introspection] Avoid creating temporary strings when comparing LocationCalls.

steveire added inline comments. Comment at: clang/lib/Tooling/NodeIntrospection.cpp:84 + + auto LI = Left.rbegin(), LE = Left.rend(), RI = Right.rbegin(); + for (; LI != LE; ++LI, ++RI) { njames93 wrote: > steveire wrote: > > Would it make sense to compare the

[PATCH] D99741: [RISCV][Clang] Add some RVV Floating-Point intrinsic functions. (vfclass, vfmerge, vfrec7, vfrsqrt7, vfsqrt)

thakis added a comment. In D99741#2694369 , @khchen wrote: > In D99741#2694344 , @thakis wrote: > >> Was there any more progress on this? If not, let's revert for now to not >> permanently slow down tests by over 2

[PATCH] D99741: [RISCV][Clang] Add some RVV Floating-Point intrinsic functions. (vfclass, vfmerge, vfrec7, vfrsqrt7, vfsqrt)

khchen added a comment. In D99741#2694435 , @thakis wrote: > In D99741#2694369 , @khchen wrote: > >> In D99741#2694344 , @thakis wrote: >> >>> Was there any more progress on

[PATCH] D100471: [C++4OpenCL] Add extra diagnostics for kernel argument types

svenvh accepted this revision. svenvh added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100471/new/ https://reviews.llvm.org/D100471 __

[PATCH] D100488: [SystemZ][z/OS] Add IsText Argument to GetFile and GetFileOrSTDIN

abhina.sreeskantharajan added a comment. In D100488#2692772 , @rnk wrote: > In D100488#2689494 , @amccarth > wrote: > >> Personally, I'm not a fan of boolean function parameters because of the >> inline comments

[clang] 10c7b9f - [OPENMP]Fix PR49115: Incorrect results for scan directive.

Author: Alexey Bataev Date: 2021-04-16T06:25:35-07:00 New Revision: 10c7b9f64fa6c0257fe8a7f89123afb5e463ebda URL: https://github.com/llvm/llvm-project/commit/10c7b9f64fa6c0257fe8a7f89123afb5e463ebda DIFF: https://github.com/llvm/llvm-project/commit/10c7b9f64fa6c0257fe8a7f89123afb5e463ebda.diff

[PATCH] D100187: [OPENMP]Fix PR49115: Incorrect results for scan directive.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG10c7b9f64fa6: [OPENMP]Fix PR49115: Incorrect results for scan directive. (authored by ABataev). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D100644: [clang][cli] NFC: Use Diags to report parsing success/failure

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. `Success` is set to `false` whenever `Diags.Report(diag::err_)` is called. Remove the dup

[PATCH] D100611: [RISCV] Add new attribute __clang_riscv_builtin_alias for intrinsics.

HsiangKai added a comment. In D100611#2694004 , @frasercrmck wrote: > Is this idea that this will later be "automatically" applied to builtins in > `riscv_vector.h`? I will prepare another patch to update the header generator. Repository: rG LLVM G

[PATCH] D99861: [Clang] Record tokens in attribute arguments for user-defined C++/C2x attributes

urnathan added a comment. See also https://bugs.llvm.org/show_bug.cgi?id=46446. when I first fell into this issue, I did think it was trying to save the token stream as this patch is doing. Neat I thought :) although I'm a clang weenie, saving the tokens is putting this into deferred-parse t

[PATCH] D45639: [Driver] Support default libc++ library location on Darwin

ldionne accepted this revision. ldionne added a comment. This revision is now accepted and ready to land. In D45639#2693706 , @phosek wrote: > It's depends on the order: whichever comes first wins. The default order of > paths that the driver uses is (1)

[PATCH] D99741: [RISCV][Clang] Add some RVV Floating-Point intrinsic functions. (vfclass, vfmerge, vfrec7, vfrsqrt7, vfsqrt)

thakis added a comment. > Please wait a few days. > Those commits add almost total 300k line from all tests. > I think maybe reverting is not a good idea if we have a good progress on this > slow down issue. Yes, if we can fix the regression in a few days, then all is good. Repository: rG L

[PATCH] D99675: RFC [llvm][clang] Create new intrinsic llvm.arith.fence to control FP optimization at expression level

mibintc updated this revision to Diff 338099. mibintc added a comment. I accidentally dropped the test case in previous commit. Just adding it back in -- under the llvm/test directory (previously it was in the wrong location). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D99689: [OPENMP]Add option -fopenmp-cuda-const-firstprivate to control address space of the corresponding global.

ABataev updated this revision to Diff 338100. ABataev added a comment. Rebase + update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99689/new/ https://reviews.llvm.org/D99689 Files: clang/include/clang/Basic/LangOptions.def clang/include/clan

[clang] e71994a - [SystemZ][z/OS] Add IsText Argument to GetFile and GetFileOrSTDIN

Author: Jonathan Crowther Date: 2021-04-16T10:08:36-04:00 New Revision: e71994a239d5f807c1c75515bfa512495224469f URL: https://github.com/llvm/llvm-project/commit/e71994a239d5f807c1c75515bfa512495224469f DIFF: https://github.com/llvm/llvm-project/commit/e71994a239d5f807c1c75515bfa512495224469f.d

[PATCH] D100488: [SystemZ][z/OS] Add IsText Argument to GetFile and GetFileOrSTDIN

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe71994a239d5: [SystemZ][z/OS] Add IsText Argument to GetFile and GetFileOrSTDIN (authored by Jonathan.Crowther, committed by abhina.sreeskantharajan

[PATCH] D100298: [Clang][Coroutine][DebugInfo] Follow-up: reduce a tests ordering requirements

probinson accepted this revision. probinson added a comment. This revision is now accepted and ready to land. One optional nit and LGTM, assuming the DILocalVariable ordering is consistent with what we see downstream. Comment at: clang/test/CodeGenCoroutines/coro-dwarf.cpp:1 -

[PATCH] D95976: [OpenMP] Simplify offloading parallel call codegen

ggeorgakoudis updated this revision to Diff 338102. ggeorgakoudis added a comment. Fix for getThreadsLimit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95976/new/ https://reviews.llvm.org/D95976 Files: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp

[PATCH] D100630: [Debug-Info][DBX] DW_TAG_rvalue_reference_type should not be generated when dwarf version is smaller than 4

shchenz created this revision. shchenz added reviewers: dblaikie, aprantl, probinson, jsji, Esme, echristo, PowerPC. shchenz added a project: debug-info. shchenz requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. As discussed in D99250

[PATCH] D100630: [Debug-Info][DBX] DW_TAG_rvalue_reference_type should not be generated when dwarf version is smaller than 4

probinson added a comment. If DBX is going to be really pedantic about not recognizing tags or attributes that don't align with the DWARF version, maybe we're better off with really supporting `-gstrict-dwarf` and just have DBX tuning imply that. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D100611: [RISCV] Add new attribute __clang_riscv_builtin_alias for intrinsics.

HsiangKai updated this revision to Diff 338105. HsiangKai added a comment. Add a negative test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100611/new/ https://reviews.llvm.org/D100611 Files: clang/include/clang/Basic/Attr.td clang/incl

[PATCH] D99432: [OPENMP]Fix PR48851: the locals are not globalized in SPMD mode.

ABataev updated this revision to Diff 338107. ABataev added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99432/new/ https://reviews.llvm.org/D99432 Files: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp clang/test/OpenMP/nvptx_dist

[PATCH] D100448: [RISCV][Clang] Add RVV AMO builtins

khchen added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:749 + foreach type = type_list in +foreach eew_list = [["8", "(Log2EEW:3)"], ["16", "(Log2EEW:4)"], +["32", "(Log2EEW:5)"], ["64", "(Log2EEW:6)"]] in { ---

[PATCH] D100644: [clang][cli] NFC: Use Diags to report parsing success/failure

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100644/new/ https://reviews.llvm.org/D100644 __

[PATCH] D100391: [RISCV][Clang] Add RVV miscellaneous intrinsic functions.

khchen added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:1304 +// Reinterpret between different SEW under the same LMUL +foreach dst_sew = ["(FixedLog2SEW:3)", "(FixedLog2SEW:4)", "(FixedLog2SEW:5)", + "(FixedLog2SEW:6)"]

[PATCH] D99530: [OPENMP]Fix PR49098: respect firstprivate of declare target variable.

ABataev updated this revision to Diff 338111. ABataev added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99530/new/ https://reviews.llvm.org/D99530 Files: clang/lib/Sema/SemaOpenMP.cpp clang/test/OpenMP/target_firstprivate_c

[PATCH] D100534: [clang][deps] Generate the full command-line for modules

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM, just a couple of other comments inline. Comment at: clang/include/clang/Frontend/CompilerInstance.h:230 + + std::shared_ptr getInvocationPtr() { assert(In

[PATCH] D99436: [OPENMP]Fix PR49366: crash on VLAs in task untied regions.

ABataev updated this revision to Diff 338114. ABataev added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99436/new/ https://reviews.llvm.org/D99436 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/include/clang/

[PATCH] D99350: [OPENMP]Fix PR49649: The introduction of $ref globals is not always valid.

ABataev updated this revision to Diff 338116. ABataev added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99350/new/ https://reviews.llvm.org/D99350 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/test/OpenMP/declare_targe

[clang] 8628ed0 - [Driver] Allow both lib64 and lib in rocm-detect test.

Author: Troy Johnson Date: 2021-04-16T09:55:57-05:00 New Revision: 8628ed0310e2fc97e1536a8032327d746973069a URL: https://github.com/llvm/llvm-project/commit/8628ed0310e2fc97e1536a8032327d746973069a DIFF: https://github.com/llvm/llvm-project/commit/8628ed0310e2fc97e1536a8032327d746973069a.diff

[PATCH] D100502: Allow lib64 in driver test

This revision was automatically updated to reflect the committed changes. Closed by commit rG8628ed0310e2: [Driver] Allow both lib64 and lib in rocm-detect test. (authored by troyj). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100502/new/ https://

[PATCH] D100652: [HIP] Support hipRTC in header

yaxunl created this revision. yaxunl added a reviewer: tra. yaxunl requested review of this revision. hipRTC compiles HIP device code at run time. Since the system may not have development tools installed, when a HIP program is compiled through hipRTC, there is no standard C or C++ header availabl

[PATCH] D99762: [OPENMP]Fix PR49777: Clang should not try to specialize orphaned directives in device codegen.

ABataev updated this revision to Diff 338122. ABataev added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99762/new/ https://reviews.llvm.org/D99762 Files: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp clang/lib/CodeGen/CGOpenMPRu

[PATCH] D100653: [clang][cli] NFC: Move conditional LangOptions parsing/generation

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. NFC, this simplifies the main parsing/generating functions by moving logic around conditi

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

mbenfield added inline comments. Comment at: clang/lib/Sema/SemaStmt.cpp:437 + CompoundStmt *CS = CompoundStmt::Create(Context, Elts, L, R); + DiagnoseUnusedButSetVariables(CS); + return CS; mbenfield wrote: > mbenfield wrote: > > george.burgess.iv wrote: > >

[PATCH] D99079: [ARM][AArch64] Require appropriate features for crypto algorithms

dcandler updated this revision to Diff 338126. dcandler marked 2 inline comments as done. dcandler added a comment. Removed one duplicated line. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99079/new/ https://reviews.llvm.org/D99079 Files: clang/include/clang/Basic/arm_neon.td cla

[PATCH] D100654: [SystemZ][z/OS] Set more text files as text

abhina.sreeskantharajan created this revision. Herald added subscribers: dexonsmith, arphaman. abhina.sreeskantharajan requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This patch corrects more instances of text files being

[PATCH] D100533: [clang][deps] Remove the -full-command-line flag

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100533/new/ https://reviews.llvm.org/D100533 _

[PATCH] D100653: [clang][cli] NFC: Move conditional LangOptions parsing/generation

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100653/new/ https://reviews.llvm.org/D100653 _

[PATCH] D100455: [clang] Rename CompilerInvocationBase to RefBase, split out ValueBase

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100455/new/ https://reviews.llvm.org/D100455 _

[PATCH] D100473: [clang] Implement CompilerInvocation copy assignment

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. I think this is fine given that we already have a copy constructor with deep copy semantics. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D99861: [Clang] Record tokens in attribute arguments for user-defined C++/C2x attributes

aaron.ballman added a comment. In D99861#2694605 , @urnathan wrote: > See also https://bugs.llvm.org/show_bug.cgi?id=46446. when I first fell into > this issue, I did think it was trying to save the token stream as this patch > is doing. Neat I thought

[PATCH] D100391: [RISCV][Clang] Add RVV miscellaneous intrinsic functions.

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100391/new/ https://reviews.llvm.org/D100391 ___

[PATCH] D99936: [clang][parser] Unify rejecting (non) decl stmt with gnu attributes

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D99936#2694178 , @tbaeder wrote: > Hey Aaron, it's been a while. Do you have a suggestion on how to proceed if > @rsmith has no opinio

[PATCH] D100617: [RISCV][Clang] Drop the assembly tests for RVV intrinsics.

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100617/new/ https://reviews.llvm.org/D100617 ___

[PATCH] D99158: [RISCV][WIP] Implement intrinsics for P extension

craig.topper added inline comments. Comment at: llvm/test/CodeGen/RISCV/rvp/intrinsics-rv32p.ll:25 + %1 = bitcast i32 %b.coerce to <4 x i8> + %2 = tail call <4 x i8> @llvm.riscv.add8.v4i8(<4 x i8> %0, <4 x i8> %1) + %3 = bitcast <4 x i8> %2 to i32 I'm still no

[PATCH] D99158: [RISCV][WIP] Implement intrinsics for P extension

craig.topper added a comment. Also can you please explain the vector codegen plan at a high level? Do you intend to support auto vectorization or just using vector_size in C? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99158/new/ https://reviews

[PATCH] D99158: [RISCV][WIP] Implement intrinsics for P extension

craig.topper added inline comments. Comment at: clang/include/clang/Basic/Builtins.def:41 // E -> ext_vector, followed by the number of elements and the base type. +// e -> Register sized Vector, followd by the base type and +// its width is the same as the register size

[PATCH] D70094: [clang-tidy] new altera ID dependent backward branch check

ffrankies updated this revision to Diff 338160. ffrankies marked 3 inline comments as done. ffrankies added a comment. Removed `*- C++ -*` from IdDependentBackwardBranchCheck.cpp file-level comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70094/new/ https://reviews.llvm.org/D70094

[PATCH] D100609: [Offload][OpenMP][CUDA] Allow fembed-bitcode for device offload

tra added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4442-4446 + std::string CPU = getCPUName(Args, Triple, /*FromAs*/ false); + if (!CPU.empty()) { +CmdArgs.push_back("-target-cpu"); +CmdArgs.push_back(Args.MakeArgString(CPU)); +

[PATCH] D100619: [ASTReader] Only mark module out of date if not already compiled

akyrtzi added inline comments. Comment at: clang/test/Modules/Inputs/error/error.h:1 +#pragma mark mark + Is this pragma relevant for the test? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100619/new/ https://rev

[PATCH] D100630: [Debug-Info][DBX] DW_TAG_rvalue_reference_type should not be generated when dwarf version is smaller than 4

jsji added a comment. In D100630#2694681 , @probinson wrote: > If DBX is going to be really pedantic about not recognizing tags or > attributes that don't align with the DWARF version, maybe we're better off > with really supporting `-gstrict-dwarf` and

[PATCH] D100514: [OpenMP] Added codegen for masked directive

cchen added a comment. In D100514#2693600 , @jdoerfert wrote: > Any reason we should not unconditionally use the OMPIRBuilder impl? (btw, > many thanks for providing one!) > We have an OMPIRBuilder always around in clang's codegen, so there is little >

[PATCH] D100514: [OpenMP] Added codegen for masked directive

cchen added a comment. In D100514#2693601 , @jdoerfert wrote: > Also, don't forget to mark it as done in > https://clang.llvm.org/docs/OpenMPSupport.html :) I'll mark it as done after combined constructs are also done. Thanks! Repository: rG LLVM Gi

[PATCH] D100514: [OpenMP] Added codegen for masked directive

jdoerfert added a comment. In D100514#2695271 , @cchen wrote: > In D100514#2693600 , @jdoerfert > wrote: > >> Any reason we should not unconditionally use the OMPIRBuilder impl? (btw, >> many thanks for providin

[PATCH] D100609: [Offload][OpenMP][CUDA] Allow fembed-bitcode for device offload

jdoerfert added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4442-4446 + std::string CPU = getCPUName(Args, Triple, /*FromAs*/ false); + if (!CPU.empty()) { +CmdArgs.push_back("-target-cpu"); +CmdArgs.push_back(Args.MakeArgString(CP

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

aeubanks added a comment. Running this over Chromium, I'm getting $ cat /tmp/a.cc struct A { int i; A(int i): i(i) {} }; $ ./build/rel/bin/clang++ -fsyntax-only /tmp/a.cc -Wunused-but-set-parameter /tmp/a.cc:3:9: warning: parameter 'i' set but not used [-Wunused-but-set-para

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

aeubanks added a comment. -Wunused-but-set-variable is firing on `x` at [1] [1] https://source.chromium.org/chromium/chromium/src/+/master:third_party/abseil-cpp/absl/synchronization/mutex.h;drc=07cb7b184515ad207d30f00d0b00b8ce96d0a750;l=947 ../../third_party/abseil-cpp/absl/synchronization/m

[clang] 59437cb - [M68k] Fix empty builtin va_list kind

Author: Min-Yih Hsu Date: 2021-04-16T11:09:22-07:00 New Revision: 59437cb7d7c30054f0e77b2369c0aeffed3ccb14 URL: https://github.com/llvm/llvm-project/commit/59437cb7d7c30054f0e77b2369c0aeffed3ccb14 DIFF: https://github.com/llvm/llvm-project/commit/59437cb7d7c30054f0e77b2369c0aeffed3ccb14.diff L

[PATCH] D100118: [clang] RFC Support new builtin __arithmetic_fence to control floating point optimization, and new clang option fprotect-parens

kpn added a comment. I thought that adding a new fence required changing every optimization pass in LLVM. That's why the constrained intrinsics were implemented they way they are where no fence is needed. Aren't you going to have miscompiles using this new fence until all that optimization wor

[PATCH] D100118: [clang] RFC Support new builtin __arithmetic_fence to control floating point optimization, and new clang option fprotect-parens

kpn added a comment. In D100118#2695365 , @kpn wrote: > I thought that adding a new fence required changing every optimization pass > in LLVM. That's why the constrained intrinsics were implemented they way they > are where no fence is needed. > > Aren'

  1   2   >