jansvoboda11 added inline comments.
================
Comment at: clang/lib/Tooling/DependencyScanning/ModuleDepCollector.cpp:62
std::function<const ModuleDeps &(ModuleID)> LookupModuleDeps) const {
- // TODO: Build full command line. That also means capturing the original
- // command line into NonPathCommandLine.
-
- std::vector<std::string> Ret{
- "-fno-implicit-modules",
- "-fno-implicit-module-maps",
- };
+ CompilerInvocation CI = getFullCommandLineCompilerInvocation(*this);
----------------
jansvoboda11 wrote:
> dexonsmith wrote:
> > I think guaranteed copy elision means this won't be a deep copy of the
> > return, but it might be nice to add a move constructor for
> > `CompilerInvocation` so it's more obvious.
> That's intentional. The deep copy is performed inside the function.
>
> Shouldn't the move constructor of `CompilerInvocation` be defaulted?
s/defaulted/implicitly-defined/
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D100534/new/
https://reviews.llvm.org/D100534
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
