khchen added inline comments.

================
Comment at: clang/include/clang/Basic/riscv_vector.td:1304
+    // Reinterpret between different SEW under the same LMUL
+    foreach dst_sew = ["(FixedLog2SEW:3)", "(FixedLog2SEW:4)", 
"(FixedLog2SEW:5)",
+                       "(FixedLog2SEW:6)"] in {
----------------
craig.topper wrote:
> Would this make more sense as just FixedSEW:8, FixedSEW:16, etc. I don't 
> think the Log2 is helping here. We need it for LMUL because of the fractional 
> lmul, but not SEW.
Agreed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100391/new/

https://reviews.llvm.org/D100391

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to