[PATCH] D99565: [X86] Support replacing aligned vector moves with unaligned moves when avx is enabled.

LiuChen3 updated this revision to Diff 337057. LiuChen3 added a comment. 1. Rebase; 2. Emit unaligned move in ISEL; 3. Only do the conversion on AVX machine. I am still working on fast-isel. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99565/new/

[PATCH] D99565: [X86] Support replacing aligned vector moves with unaligned moves when avx is enabled.

LiuChen3 added a comment. In D99565#2682809 , @lebedev.ri wrote: > I'm still uncomfortable with changing current status quo, even though i > obviously don't get to cast the final vote here. > > One should not use aligned loads in hope that they will cause

[PATCH] D99565: [X86] Support replacing aligned vector moves with unaligned moves when avx is enabled.

LiuChen3 added a comment. In D99565#2678073 , @craig.topper wrote: > I think I wouldn't mind if we just didn't emit aligned loads/store > instructions for AVX/AVX512 from isel and other places in the compiler in the > first place. As noted, if the load

[PATCH] D99565: [X86] Support replacing aligned vector moves with unaligned moves when avx is enabled.

craig.topper added inline comments. Comment at: clang/include/clang/Driver/Options.td:1649 +Group, Flags<[CoreOption, HelpHidden]>, +HelpText<"Do not emit unaligned move instructions unless users explicitly uses.">; def fassociative_math : Flag<["-"], "fassociative-mat

[clang] 95c614a - [NFC][SYCL] Drop idle triple component from regression tests.

Author: Alexey Bader Date: 2021-04-13T08:00:21+03:00 New Revision: 95c614afcd4de71d00a240d6a4a02c036c972ed0 URL: https://github.com/llvm/llvm-project/commit/95c614afcd4de71d00a240d6a4a02c036c972ed0 DIFF: https://github.com/llvm/llvm-project/commit/95c614afcd4de71d00a240d6a4a02c036c972ed0.diff

[PATCH] D100161: Redistribute energy for Corpus

gtt1995 added a comment. If not sorted by size , Just a simple grouping of corpus, the effect is similar to entropic. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100161/new/ https://reviews.llvm.org/D100161

[PATCH] D99565: [X86] Support replacing aligned vector moves with unaligned moves when avx is enabled.

LiuChen3 updated this revision to Diff 337064. LiuChen3 added a comment. Address Craig's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99565/new/ https://reviews.llvm.org/D99565 Files: clang/include/clang/Driver/Options.td clang/lib/D

[PATCH] D100368: [X86] Support some missing intrinsics

LiuChen3 created this revision. Herald added a subscriber: pengfei. LiuChen3 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Support for _mm512_i32logather_pd, _mm512_mask_i32logather_pd, _mm512_i32logather_epi64, _mm512_mask_i32logather_ep

[PATCH] D100057: Remove warning "suggest braces" for aggregate initialization of an empty class with an aggregate base class.

hankadusikova updated this revision to Diff 337067. hankadusikova marked 3 inline comments as done. hankadusikova added a comment. changes suggested by @rsmith Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100057/new/ https://reviews.llvm.org/D1000

[PATCH] D100372: [Clang][ARM] Define __VFP_FP__ macro unconditionally

vhscampos created this revision. Herald added subscribers: danielkiss, kristof.beyls. vhscampos requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Clang only defines __VFP_FP__ when the FPU is enabled. However, gcc defines it unconditionally.

[clang-tools-extra] ecc6965 - Revert "Revert "[clangd] Provide a way to disable external index""

Author: Kadir Cetinkaya Date: 2021-04-13T11:24:32+02:00 New Revision: ecc6965b2342397a215b00e8e476d8d37d080322 URL: https://github.com/llvm/llvm-project/commit/ecc6965b2342397a215b00e8e476d8d37d080322 DIFF: https://github.com/llvm/llvm-project/commit/ecc6965b2342397a215b00e8e476d8d37d080322.dif

[clang] b757bc1 - [OpenCL][NFC] Rename isOpenCLVersionContainedInMask

Author: Sven van Haastregt Date: 2021-04-13T10:27:37+01:00 New Revision: b757bc14e673c8f8b987cadfe165853fb3de10f1 URL: https://github.com/llvm/llvm-project/commit/b757bc14e673c8f8b987cadfe165853fb3de10f1 DIFF: https://github.com/llvm/llvm-project/commit/b757bc14e673c8f8b987cadfe165853fb3de10f1.

[PATCH] D100124: [Clang][NVPTX] Add NVPTX intrinsics and builtins for CUDA PTX redux.sync instructions

steffenlarsen added a comment. In D100124#2684303 , @JonChesterfield wrote: > Interesting. Reduction across lanes in warp? If so, this is probably a way to > handle the last step reduction for openmp reductions It is! I can imagine that it would be use

[PATCH] D100368: [X86] Support some missing intrinsics

RKSimon added a comment. Add _mm512_i32loscatter_epi64 and _mm512_mask_i32loscatter_epi64 for completeness? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100368/new/ https://reviews.llvm.org/D100368 __

[PATCH] D97196: [clang-tidy] Add new check 'bugprone-unhandled-exception-at-new'.

balazske updated this revision to Diff 337078. balazske marked 8 inline comments as done. balazske added a comment. Rebase, changed documentation, small fix in the code, more tests added. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97196/new/ htt

[PATCH] D97196: [clang-tidy] Add new check 'bugprone-unhandled-exception-at-new'.

balazske added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/bugprone-unhandled-exception-at-new.rst:7 +Finds calls to ``new`` that may throw ``std::bad_alloc`` exception and +the exception handler is missing. + aaron.ballman wrote: > Thi

[PATCH] D100374: [clang] [AArch64] Fix Windows va_arg handling for larger structs

mstorsjo created this revision. mstorsjo added reviewers: rnk, efriedma, TomTan, maxim-kuvyrkov. Herald added subscribers: danielkiss, pengfei, kristof.beyls. mstorsjo requested review of this revision. Herald added a project: clang. Aggregate types over 16 bytes are passed by reference. Contrary

[PATCH] D100294: [AArch64][SVE] Fix dup/dupq intrinsics for C++.

This revision was automatically updated to reflect the committed changes. Closed by commit rGfa936b610fd0: [AArch64][SVE] Fix dup/dupq intrinsics for C++. (authored by sdesmalen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100294/new/ https://rev

[clang] fa936b6 - [AArch64][SVE] Fix dup/dupq intrinsics for C++.

Author: Sander de Smalen Date: 2021-04-13T10:55:20+01:00 New Revision: fa936b610fd019b73de82f61de83bae553251fdb URL: https://github.com/llvm/llvm-project/commit/fa936b610fd019b73de82f61de83bae553251fdb DIFF: https://github.com/llvm/llvm-project/commit/fa936b610fd019b73de82f61de83bae553251fdb.di

[PATCH] D100297: [AArch64][SVE] Always use overloaded methods instead of preprocessor macro.

c-rhodes accepted this revision. c-rhodes added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100297/new/ https://reviews.llvm.org/D100297 ___

[clang] eae2d4b - [Windows Itanium][PS4] handle dllimport/export w.r.t vtables/rtti

Author: Ben Dunbobbin Date: 2021-04-13T11:41:10+01:00 New Revision: eae2d4b8520c768291dcff2169b78486af324d17 URL: https://github.com/llvm/llvm-project/commit/eae2d4b8520c768291dcff2169b78486af324d17 DIFF: https://github.com/llvm/llvm-project/commit/eae2d4b8520c768291dcff2169b78486af324d17.diff

[PATCH] D93203: [PS4] handle dllimport/export w.r.t vtables/rtti

This revision was automatically updated to reflect the committed changes. Closed by commit rGeae2d4b8520c: [Windows Itanium][PS4] handle dllimport/export w.r.t vtables/rtti (authored by Ben Dunbobbin ). Herald added a project: clang. Herald added a subscriber: cfe-commits.

[clang] 5ad15f4 - Require commas between double square bracket attributes.

Author: Aaron Ballman Date: 2021-04-13T06:43:01-04:00 New Revision: 5ad15f4d1c6f56d25904265023d123a7d0b9d59d URL: https://github.com/llvm/llvm-project/commit/5ad15f4d1c6f56d25904265023d123a7d0b9d59d DIFF: https://github.com/llvm/llvm-project/commit/5ad15f4d1c6f56d25904265023d123a7d0b9d59d.diff

[PATCH] D97196: [clang-tidy] Add new check 'bugprone-unhandled-exception-at-new'.

balazske added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone-unhandled-exception-at-new.cpp:20 +using badalloc3 = std::bad_alloc &; + +void *operator new(std::size_t, int, int); aaron.ballman wrote: > Another interesting test c

[PATCH] D98499: [clangd] Introduce ASTHooks to FeatureModules

kadircet updated this revision to Diff 337101. kadircet marked 7 inline comments as done. kadircet added a comment. - Pass FeatureModuleSet rather than astListeners in ParseInputs. - Create listeners only when building ASTs. - Use a callback function in StoreDiags to notify about diagnostics. Re

[PATCH] D100378: [AST] Use IntrusiveRefCntPtr for Introspection LocationCall.

njames93 created this revision. njames93 added a reviewer: steveire. njames93 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D100378 Files: clang/include/clang/Tooling/Node

[PATCH] D96090: [analyzer] Replace StoreManager::CastRetrievedVal with SValBuilder::evalCast

ASDenysPetrov added a comment. @NoQ Many thanks for your evaluation! > Wait, no, nvm, please disregard this. It wasn't like this forever, i just > happened to catch code in an intermediate state after D90157 > . Either way, it's definitely getting much > bette

[PATCH] D100346: [Clang] String Literal and Wide String Literal Encoding from the Preprocessor

aaron.ballman added a reviewer: rsmith. aaron.ballman added a comment. Thank you for this patch, I think this is useful functionality! In D100346#2684736 , @ThePhD wrote: > The string literals work for people because, despite not being > preprocessor-co

[PATCH] D100378: [AST] Use IntrusiveRefCntPtr for Introspection LocationCall.

njames93 added inline comments. Comment at: clang/lib/Tooling/NodeIntrospection.cpp:60 + if (LHS.first == RHS.first) +return LHS.second->name() < RHS.second->name(); + return LHS.first < RHS.first; This is a slight change in behaviour, The old implementatio

[PATCH] D100368: [X86] Support some missing intrinsics

LiuChen3 added a comment. In D100368#2685189 , @RKSimon wrote: > Add _mm512_i32loscatter_epi64 and _mm512_mask_i32loscatter_epi64 for > completeness? It seems we doesn't support KNCNI in LLVM. Am I right? Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D98499: [clangd] Introduce ASTHooks to FeatureModules

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/FeatureModule.h:106 + struct ASTListener { +virtual ~ASTListener() = default; + comment: listeners are de

[PATCH] D100209: [OpenCL] Do not add builtins with unavailable types

Anastasia added inline comments. Comment at: clang/lib/Sema/OpenCLBuiltins.td:54 +// Extension associated to a type. +class TypeExtension : AbstractExtension<_Ext>; + I am trying to understand why would we need a special abstraction for the type? Would it not be

[PATCH] D97764: [clang][patch] To solve PR26413, x86 interrupt routines may only call routines with no_saved_reg

mibintc added a comment. I received a bug report that this patch creates error diagnostics for calls to a builtin, like calling 'abort', 'exit' or one of the target builtins like __builtin_ia32_packssw then that call should be allowed without remark but this patch causes the compilation to fail

[PATCH] D100368: [X86] Support some missing intrinsics

craig.topper added a comment. In D100368#2685559 , @LiuChen3 wrote: > In D100368#2685189 , @RKSimon wrote: > >> Add _mm512_i32loscatter_epi64 and _mm512_mask_i32loscatter_epi64 for >> completeness? > > It seems

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

Anastasia added inline comments. Comment at: clang/include/clang/AST/Type.h:488 (A == LangAS::opencl_global && (B == LangAS::opencl_global_device || B == LangAS::opencl_global_host)) || // Consider pointer size a

[PATCH] D97669: [clang][AVR] Add avr-libc/include to clang system include paths

Anastasia added a comment. In D97669#2678460 , @benshi001 wrote: > In D97669#2676826 , @Anastasia wrote: > >> In D97669#2665865 , @benshi001 >> wrote: >> >>> In D97669#26615

[PATCH] D95976: [OpenMP] Simplify offloading parallel call codegen

ggeorgakoudis updated this revision to Diff 337141. ggeorgakoudis added a comment. Herald added a subscriber: hiraditya. Add tests, update OpenMPOpt, rebase to main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95976/new/ https://reviews.llvm.org/D

[PATCH] D90157: [analyzer] Rework SValBuilder::evalCast function into maintainable and clear way

ASDenysPetrov added a comment. @NoQ > Even though NFC commits don't require tests, this doesn't mean they shouldn't > add them! While developing this, I wasn't able to reproduce any regression or unpassed cases on the projects from CodeChecker list (//Bitcoin_v0.20.1, Curl_curl-7_66_0, Memcha

[PATCH] D97764: [clang][patch] To solve PR26413, x86 interrupt routines may only call routines with no_saved_reg

craig.topper added a comment. In D97764#2685655 , @mibintc wrote: > I received a bug report that this patch creates error diagnostics for calls > to a builtin, like calling 'abort', 'exit' or one of the target builtins like > __builtin_ia32_packssw then

[PATCH] D100209: [OpenCL] Do not add builtins with unavailable types

svenvh added inline comments. Comment at: clang/lib/Sema/OpenCLBuiltins.td:54 +// Extension associated to a type. +class TypeExtension : AbstractExtension<_Ext>; + Anastasia wrote: > I am trying to understand why would we need a special abstraction for the > typ

[PATCH] D96090: [analyzer] Replace StoreManager::CastRetrievedVal with SValBuilder::evalCast

ASDenysPetrov added a comment. > Already approved a month ago D97277 :-) > That's the next step. In addition to the above: Comment at: clang/lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp:68 +// FIXME: This function should be eliminated and

[PATCH] D100347: Fix the const overload of IgnoreExprNodes

d added a comment. In D100347#2684934 , @gribozavr2 wrote: > Thanks for the fix! Do you have commit access? Trying `arc land` I realize I do not... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100347/new

[PATCH] D100347: Fix the const overload of IgnoreExprNodes

d added a comment. @gribozavr2 it's also unclear to me where the tests for this are so I couldn't add a new test, is that OK? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100347/new/ https://reviews.llvm.org/D100347 _

[PATCH] D100368: [X86] Support some missing intrinsics

RKSimon added a comment. That's why I said "completeness" :) Comment at: clang/lib/Headers/avx512fintrin.h:9692 + (scale)) +/// Stores 8 packed double-precision (64-bit) floating-point elements in \a v1 +/// to memory locations starting at location \a base

[PATCH] D100347: Fix the const overload of IgnoreExprNodes

d added a comment. More importantly, the bug exists in LLVM 12, what is the policy of patching the back branches in this project? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100347/new/ https://reviews.llvm.org/D100347 _

[PATCH] D100161: Redistribute energy for Corpus

gtt1995 added a comment. Maybe uniform-random approach change efficacy! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100161/new/ https://reviews.llvm.org/D100161 ___ cfe-commits mailing list cfe-commits

[PATCH] D97764: [clang][patch] To solve PR26413, x86 interrupt routines may only call routines with no_saved_reg

mibintc added a comment. In D97764#2685742 , @craig.topper wrote: > In D97764#2685655 , @mibintc wrote: > >> I received a bug report that this patch creates error diagnostics for calls >> to a builtin, like callin

[PATCH] D97764: [clang][patch] To solve PR26413, x86 interrupt routines may only call routines with no_saved_reg

craig.topper added a comment. In D97764#2685841 , @mibintc wrote: > In D97764#2685742 , @craig.topper > wrote: > >> In D97764#2685655 , @mibintc wrote: >> >>> I received a b

[PATCH] D100388: [BROKEN][clang] Try to fix thunk function types

lebedev.ri created this revision. lebedev.ri added a reviewer: rsmith. lebedev.ri added a project: LLVM. Herald added subscribers: dexonsmith, cryptoad, mgorny, dschuff. Herald added a reviewer: alexshap. lebedev.ri requested review of this revision. Herald added subscribers: cfe-commits, sstefan1,

[PATCH] D96090: [analyzer] Replace StoreManager::CastRetrievedVal with SValBuilder::evalCast

This revision was automatically updated to reflect the committed changes. Closed by commit rG7736b08c2872: [analyzer] Replace StoreManager::CastRetrievedVal with SValBuilder::evalCast (authored by ASDenysPetrov). Changed prior to commit: https://reviews.llvm.org/D96090?vs=329982&id=337153#toc

[clang] 7736b08 - [analyzer] Replace StoreManager::CastRetrievedVal with SValBuilder::evalCast

Author: Denys Petrov Date: 2021-04-13T18:10:06+03:00 New Revision: 7736b08c287274361f2cdf13512015708af4d335 URL: https://github.com/llvm/llvm-project/commit/7736b08c287274361f2cdf13512015708af4d335 DIFF: https://github.com/llvm/llvm-project/commit/7736b08c287274361f2cdf13512015708af4d335.diff

[PATCH] D99568: [clang][invocation] Fix copy constructor, add copy assignment to CompilerInvocation

jansvoboda11 updated this revision to Diff 337155. jansvoboda11 added a comment. Remove copy-assignment changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99568/new/ https://reviews.llvm.org/D99568 Files: clang/include/clang/Frontend/Compiler

[PATCH] D100346: [Clang] String Literal and Wide String Literal Encoding from the Preprocessor

ThePhD updated this revision to Diff 337158. ThePhD added a comment. Change `NOTE:` to `FIXME:`. Update the text for the documentation to be more explicit. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100346/new/ https://reviews.llvm.org/D100346 Files: clang/docs/LanguageExtensions

[PATCH] D89013: [libcxx] Support per-target __config_site in per-target runtime build

phosek updated this revision to Diff 337166. phosek edited the summary of this revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89013/new/ https://reviews.llvm.org/D89013 Files: clang/lib/Driver/ToolChains/Fuchsia.cpp clang/lib/Driver/Too

[PATCH] D98499: [clangd] Introduce ASTHooks to FeatureModules

kadircet updated this revision to Diff 337168. kadircet marked 2 inline comments as done. kadircet added a comment. - Inline helper to call-sites - Add comments about destruction of ast listeners. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98499/

[PATCH] D100209: [OpenCL] Do not add builtins with unavailable types

Anastasia added inline comments. Comment at: clang/lib/Sema/OpenCLBuiltins.td:54 +// Extension associated to a type. +class TypeExtension : AbstractExtension<_Ext>; + svenvh wrote: > Anastasia wrote: > > I am trying to understand why would we need a special abstr

[clang-tools-extra] bce3ac4 - [clangd] Introduce ASTHooks to FeatureModules

Author: Kadir Cetinkaya Date: 2021-04-13T17:45:09+02:00 New Revision: bce3ac4f224aa7da0b253852ce8a28ad5a39c31f URL: https://github.com/llvm/llvm-project/commit/bce3ac4f224aa7da0b253852ce8a28ad5a39c31f DIFF: https://github.com/llvm/llvm-project/commit/bce3ac4f224aa7da0b253852ce8a28ad5a39c31f.dif

[clang-tools-extra] b5b2c81 - [clangd] Propagate data in diagnostics

Author: Kadir Cetinkaya Date: 2021-04-13T17:45:09+02:00 New Revision: b5b2c81055cfd0cc6a2a1d1ff2c8017d422586dc URL: https://github.com/llvm/llvm-project/commit/b5b2c81055cfd0cc6a2a1d1ff2c8017d422586dc DIFF: https://github.com/llvm/llvm-project/commit/b5b2c81055cfd0cc6a2a1d1ff2c8017d422586dc.dif

[PATCH] D98499: [clangd] Introduce ASTHooks to FeatureModules

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbce3ac4f224a: [clangd] Introduce ASTHooks to FeatureModules (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D98505: [clangd] Propagate data in diagnostics

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb5b2c81055cf: [clangd] Propagate data in diagnostics (authored by kadircet). Changed prior to commit: https://reviews.llvm.org/D98505?vs=333982&id

[PATCH] D98498: [clangd] Enable modules to contribute tweaks.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbb6d96ced80f: [clangd] Enable modules to contribute tweaks. (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] bb6d96c - [clangd] Enable modules to contribute tweaks.

Author: Kadir Cetinkaya Date: 2021-04-13T17:45:08+02:00 New Revision: bb6d96ced80f288475cd374c3c7a25ee8cad2bb2 URL: https://github.com/llvm/llvm-project/commit/bb6d96ced80f288475cd374c3c7a25ee8cad2bb2 DIFF: https://github.com/llvm/llvm-project/commit/bb6d96ced80f288475cd374c3c7a25ee8cad2bb2.dif

[clang] 01ddfa9 - [analyzer] [NFC] Eliminate dispatchCast, evalCastFromNonLoc and evalCastFromLoc functions from SValBuilder

Author: Denys Petrov Date: 2021-04-13T18:56:04+03:00 New Revision: 01ddfa95bd14b35c5706cc5d69fe64b4b60526e3 URL: https://github.com/llvm/llvm-project/commit/01ddfa95bd14b35c5706cc5d69fe64b4b60526e3 DIFF: https://github.com/llvm/llvm-project/commit/01ddfa95bd14b35c5706cc5d69fe64b4b60526e3.diff

[PATCH] D97277: [analyzer] [NFC] Eliminate dispatchCast, evalCastFromNonLoc and evalCastFromLoc functions from SValBuilder

This revision was automatically updated to reflect the committed changes. Closed by commit rG01ddfa95bd14: [analyzer] [NFC] Eliminate dispatchCast, evalCastFromNonLoc and evalCastFromLoc… (authored by ASDenysPetrov). Changed prior to commit: https://reviews.llvm.org/D97277?vs=328106&id=337177#t

[PATCH] D100346: [Clang] String Literal and Wide String Literal Encoding from the Preprocessor

ThePhD marked 4 inline comments as done. ThePhD added a comment. In D100346#2685530 , @aaron.ballman wrote: > ... > > What about for folks using this from C where there isn't `constexpr` > functionality to help them? The unfortunate bit is that C won't

[PATCH] D100346: [Clang] String Literal and Wide String Literal Encoding from the Preprocessor

ThePhD updated this revision to Diff 337178. ThePhD set the repository for this revision to rG LLVM Github Monorepo. ThePhD added a comment. Oops, almost forgot the doc fixes for the *wide__* macro! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1003

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

bader updated this revision to Diff 337180. bader marked 16 inline comments as done. bader added a comment. Applied more code review suggestions. Rebased on ToT. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89909/new/ https://reviews.llvm.org/D89

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

bader added inline comments. Comment at: clang/include/clang/AST/Type.h:493 + // Default is a superset of SYCL address spaces. + (A == LangAS::Default && +(B == LangAS::sycl_private || B == LangAS::sycl_local || Anastasia wrote: >

[clang] 595c375 - Fix the const overload of IgnoreExprNodes

Author: Jesse Zhang Date: 2021-04-13T17:59:59+02:00 New Revision: 595c3758e47042c876e7390d09642ea050ba6dbf URL: https://github.com/llvm/llvm-project/commit/595c3758e47042c876e7390d09642ea050ba6dbf DIFF: https://github.com/llvm/llvm-project/commit/595c3758e47042c876e7390d09642ea050ba6dbf.diff L

[PATCH] D100347: Fix the const overload of IgnoreExprNodes

This revision was automatically updated to reflect the committed changes. Closed by commit rG595c3758e470: Fix the const overload of IgnoreExprNodes (authored by d, committed by gribozavr). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100347/new/ h

[PATCH] D100347: Fix the const overload of IgnoreExprNodes

gribozavr2 added a comment. > Trying arc land I realize I do not... Pushed as 595c3758e47042c876e7390d09642ea050ba6dbf . > it's also unclear to me where the tests for this are so I couldn't add a new > test, is that OK? Yes,

[PATCH] D95976: [OpenMP] Simplify offloading parallel call codegen

ggeorgakoudis updated this revision to Diff 337183. ggeorgakoudis added a comment. Add aux-triple to one test, check unit test builder on windows Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95976/new/ https://reviews.llvm.org/D95976 Files: cla

[clang] 62328f2 - Implement WG21 P2156R1/WG14 N2557 on duplicate attributes

Author: Aaron Ballman Date: 2021-04-13T12:30:04-04:00 New Revision: 62328f2f29b432dadbd327ff91ba3914c478e3fc URL: https://github.com/llvm/llvm-project/commit/62328f2f29b432dadbd327ff91ba3914c478e3fc DIFF: https://github.com/llvm/llvm-project/commit/62328f2f29b432dadbd327ff91ba3914c478e3fc.diff

[PATCH] D100161: Redistribute energy for Corpus

morehouse added a comment. If the effect is similar to entropic, why do we need this patch as well? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100161/new/ https://reviews.llvm.org/D100161 ___ cfe-comm

[PATCH] D100396: [SYCL] Enable `opencl_global_[host,device]` attributes for SYCL

bader created this revision. Herald added subscribers: Naghasan, ldrumm, dexonsmith, kerbowa, Anastasia, ebevhan, yaxunl, nhaehnle, jvesely, jholewinski. bader requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Mo

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

bader marked 2 inline comments as done. bader added inline comments. Comment at: clang/include/clang/AST/Type.h:488 (A == LangAS::opencl_global && (B == LangAS::opencl_global_device || B == LangAS::opencl_global_host)) ||

[PATCH] D98902: [Clang][OpenMP][NVPTX] Fixed failure in openmp-offload-gpu.c if the system has CUDA

kkwli0 accepted this revision. kkwli0 added a comment. This revision is now accepted and ready to land. No more comments from the community. I think it is okay to accept this revision. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98902/n

[clang] 53d474a - [Clang][OpenMP][NVPTX] Fixed failure in openmp-offload-gpu.c if the system has CUDA

Author: Shilei Tian Date: 2021-04-13T13:22:49-04:00 New Revision: 53d474abc92c42bed5d0cab5c79ee9ea5666aad1 URL: https://github.com/llvm/llvm-project/commit/53d474abc92c42bed5d0cab5c79ee9ea5666aad1 DIFF: https://github.com/llvm/llvm-project/commit/53d474abc92c42bed5d0cab5c79ee9ea5666aad1.diff L

[PATCH] D98902: [Clang][OpenMP][NVPTX] Fixed failure in openmp-offload-gpu.c if the system has CUDA

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG53d474abc92c: [Clang][OpenMP][NVPTX] Fixed failure in openmp-offload-gpu.c if the system has… (authored by tianshilei1992). Repository: rG LLVM Gi

[PATCH] D99568: [clang][invocation] Fix copy constructor of CompilerInvocation

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99568/new/ https://reviews.llvm.org/D99568

[PATCH] D100346: [Clang] String Literal and Wide String Literal Encoding from the Preprocessor

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D100346#2686015 , @ThePhD wrote: > In D100346#2685530 , @aaron.ballman > wrote: > >> ... >>

[PATCH] D100346: [Clang] String Literal and Wide String Literal Encoding from the Preprocessor

ThePhD added a comment. In D100346#2686342 , @aaron.ballman wrote: > Okay, I'm sold. Thank you for the detailed explanation! The changes LGTM. Do > you have commit privileges or would you like me to commit on your behalf? (If > you'd like me to commit,

[PATCH] D93822: [clang-tidy] Add check for implicit widening of multiplication result

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from some small nits in the documentation. Comment at: clang-tools-extra/clang-tidy/bugprone/ImplicitWideningOfMultiplicationResultCheck.cpp:130 +

[PATCH] D100402: [WebAssembly] Codegen for i64x2.extend_{low,high}_i32x4_{s,u}

tlively created this revision. tlively added reviewers: aheejin, dschuff. Herald added subscribers: wingo, ecnelises, sunfish, hiraditya, jgravelle-google, sbc100. tlively requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. R

[PATCH] D100346: [Clang] String Literal and Wide String Literal Encoding from the Preprocessor

aaron.ballman closed this revision. aaron.ballman added a comment. In D100346#2686407 , @ThePhD wrote: > In D100346#2686342 , @aaron.ballman > wrote: > >> Okay, I'm sold. Thank you for the detailed explanation! T

[clang] 701d70d - String Literal and Wide String Literal Encoding from the Preprocessor

Author: ThePhD Date: 2021-04-13T14:18:07-04:00 New Revision: 701d70d4c25c4e02b303ba6dee1495708496f615 URL: https://github.com/llvm/llvm-project/commit/701d70d4c25c4e02b303ba6dee1495708496f615 DIFF: https://github.com/llvm/llvm-project/commit/701d70d4c25c4e02b303ba6dee1495708496f615.diff LOG: S

[PATCH] D93822: [clang-tidy] Add check for implicit widening of multiplication result

lebedev.ri updated this revision to Diff 337214. lebedev.ri marked 2 inline comments as done. lebedev.ri added a comment. Address final nits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93822/new/ https://reviews.llvm.org/D93822 Files: clang-t

[PATCH] D93822: [clang-tidy] Add check for implicit widening of multiplication result

lebedev.ri added a comment. @aaron.ballman thank you so much for the review! Comment at: clang-tools-extra/clang-tidy/bugprone/ImplicitWideningOfMultiplicationResultCheck.cpp:130 + StringRef TyAsString = + IndexExprType->isSignedIntegerType() ? "ssize_t" : "size_t"; + --

[clang-tools-extra] 46b8ea2 - [clang-tidy] Add check for implicit widening of multiplication result

Author: Roman Lebedev Date: 2021-04-13T21:41:22+03:00 New Revision: 46b8ea2fff90b44b7ae558999721cf30f9b83aa9 URL: https://github.com/llvm/llvm-project/commit/46b8ea2fff90b44b7ae558999721cf30f9b83aa9 DIFF: https://github.com/llvm/llvm-project/commit/46b8ea2fff90b44b7ae558999721cf30f9b83aa9.diff

[PATCH] D93822: [clang-tidy] Add check for implicit widening of multiplication result

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG46b8ea2fff90: [clang-tidy] Add check for implicit widening of multiplication result (authored by lebedev.ri). Repository: rG LLVM Github Monorepo

[PATCH] D99812: [PowerPC] [GlobalISel] Implementation of formal arguments lowering in the IRTranslator for the PPC backend

gandhi21299 marked 2 inline comments as done. gandhi21299 added a comment. I am looking towards more feedback on this patch, please do follow up at your convenience. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99812/new/ https://reviews.llvm.org

[PATCH] D100057: Remove warning "suggest braces" for aggregate initialization of an empty class with an aggregate base class.

aaron.ballman added a comment. Do you need someone to commit this on your behalf? If so, what email address and name would you like me to use for commit attribution? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100057/new/ https://reviews.llvm.or

[PATCH] D100405: Ship `llvm-cxxfilt` in the toolchain.

delcypher created this revision. delcypher added reviewers: steven_wu, arphaman, dexonsmith. Herald added subscribers: yaxunl, mgorny. delcypher requested review of this revision. Herald added a project: clang. Originally done for rdar://problem/57155465. rdar://76602859 Repository: rG LLVM G

[PATCH] D100405: Ship `llvm-cxxfilt` in the toolchain.

steven_wu accepted this revision. steven_wu added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100405/new/ https://reviews.llvm.org/D100405 _

[clang] 4c0bc69 - Ship `llvm-cxxfilt` in the toolchain.

Author: Dan Liew Date: 2021-04-13T11:58:33-07:00 New Revision: 4c0bc69490a57f2f8f9ede948e6d66cc0900879a URL: https://github.com/llvm/llvm-project/commit/4c0bc69490a57f2f8f9ede948e6d66cc0900879a DIFF: https://github.com/llvm/llvm-project/commit/4c0bc69490a57f2f8f9ede948e6d66cc0900879a.diff LOG:

[PATCH] D100405: Ship `llvm-cxxfilt` in the toolchain.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4c0bc69490a5: Ship `llvm-cxxfilt` in the toolchain. (authored by delcypher). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D99543: [clang-tidy] Allow opt-in or out of some commonly occuring patterns in NarrowingConversionsCheck.

ymandel accepted this revision. ymandel added a comment. This revision is now accepted and ready to land. But please wait for additional "Accept" from either `hokein` or `aaron.ballman`. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99543/n

[clang] c058a71 - Correct the tablegen for checking mutually exclusive stmt attrs

Author: Aaron Ballman Date: 2021-04-13T15:20:30-04:00 New Revision: c058a7122787c8e503cf6306b8da03c0e56a41a5 URL: https://github.com/llvm/llvm-project/commit/c058a7122787c8e503cf6306b8da03c0e56a41a5 DIFF: https://github.com/llvm/llvm-project/commit/c058a7122787c8e503cf6306b8da03c0e56a41a5.diff

[PATCH] D40660: Enable auto-linking on Windows

mstorsjo edited subscribers, added: libcxx-commits, mstorsjo; removed: llvm-commits, cfe-commits. mstorsjo added a comment. I see that @smeenai brought up the inconsistency between `_DLL` and `_LIBCPP_DISABLE_VISIBILITY_ANNOTATIONS` already back when this was reviewed. I'm running into problems

[clang] 64c24f4 - Remove warning "suggest braces" for aggregate initialization of an empty class with an aggregate base class.

Author: Hana Dusíková Date: 2021-04-13T15:45:09-04:00 New Revision: 64c24f493e5f4637ee193f10f469cdd2695b4ba6 URL: https://github.com/llvm/llvm-project/commit/64c24f493e5f4637ee193f10f469cdd2695b4ba6 DIFF: https://github.com/llvm/llvm-project/commit/64c24f493e5f4637ee193f10f469cdd2695b4ba6.diff

  1   2   >