aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land.
In D100346#2686015 <https://reviews.llvm.org/D100346#2686015>, @ThePhD wrote: > In D100346#2685530 <https://reviews.llvm.org/D100346#2685530>, @aaron.ballman > wrote: > >> ... >> >> What about for folks using this from C where there isn't `constexpr` >> functionality to help them? > > > >> ... > > I'm not sure all of that belongs in this patch, though, and I think I'd wait > for the other patches about `iconv` literal converters to drop before having > the fullness of that conversation. Okay, I'm sold. Thank you for the detailed explanation! The changes LGTM. Do you have commit privileges or would you like me to commit on your behalf? (If you'd like me to commit, what email address and name would you like me to use for commit attribution?) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100346/new/ https://reviews.llvm.org/D100346 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
