craig.topper added a comment.

In D97764#2685655 <https://reviews.llvm.org/D97764#2685655>, @mibintc wrote:

> I received a bug report that this patch creates error diagnostics for calls 
> to a builtin, like calling 'abort', 'exit' or one of the target builtins like 
> __builtin_ia32_packssw then that call should be allowed without remark but 
> this patch causes the compilation to fail.  We could require that all 
> builtin's be declared with "no caller saved reg" but that's a big 
> modification. I'm planning to make a change which igores builtin calls, but 
> continue to error on any implicitly declared or user declared functions 
> without the "no caller saved reg" attribute.

Builtins like __builtin_ia32_packssw aren't usually called directly. The user 
should be calling the always_inline wrapper functions in x86intrin.h. Would 
that also fail?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97764/new/

https://reviews.llvm.org/D97764

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to