[PATCH] D100046: [AArch64] ACLE: Fix issue for mismatching enum types with builtins.

sdesmalen updated this revision to Diff 336760. sdesmalen added a comment. Removed `forgetBuiltin` and the code using it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100046/new/ https://reviews.llvm.org/D100046 Files: clang/include/clang/Basic

[PATCH] D100046: [AArch64] ACLE: Fix issue for mismatching enum types with builtins.

sdesmalen added a comment. Thanks for taking time from your weekend to look into this @tambre, much appreciated! Comment at: clang/lib/Sema/SemaDecl.cpp:10953-10967 if (unsigned BuiltinID = NewFD->getBuiltinID()) { ASTContext::GetBuiltinTypeError Error; Look

[PATCH] D100046: [AArch64] ACLE: Fix issue for mismatching enum types with builtins.

tambre accepted this revision. tambre added a comment. This revision is now accepted and ready to land. Thanks, LGTM! Probably worth mentioning what I had in my comment in the commit message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100046/new

[clang] 6e51991 - [clang][AST] Handle overload callee type in CallExpr::getCallReturnType.

Author: Balázs Kéri Date: 2021-04-12T09:44:17+02:00 New Revision: 6e5199104914c2415092315388ed09fbd9d629f7 URL: https://github.com/llvm/llvm-project/commit/6e5199104914c2415092315388ed09fbd9d629f7 DIFF: https://github.com/llvm/llvm-project/commit/6e5199104914c2415092315388ed09fbd9d629f7.diff L

[PATCH] D95244: [clang][AST] Handle overload callee type in CallExpr::getCallReturnType.

This revision was automatically updated to reflect the committed changes. balazske marked an inline comment as done. Closed by commit rG6e5199104914: [clang][AST] Handle overload callee type in CallExpr::getCallReturnType. (authored by balazske). Changed prior to commit: https://reviews.llvm.or

[PATCH] D95244: [clang][AST] Handle overload callee type in CallExpr::getCallReturnType.

balazske marked an inline comment as done. balazske added inline comments. Comment at: clang/lib/AST/Expr.cpp:1386 QualType CalleeType = Callee->getType(); + if (const auto *FnTypePtr = CalleeType->getAs()) { hokein wrote: > nit: looks like an accident chan

[PATCH] D100046: [AArch64] ACLE: Fix issue for mismatching enum types with builtins.

tambre added a comment. Summary also looks good. 👍 You probably don't need to wait for more approvals. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100046/new/ https://reviews.llvm.org/D100046 ___ cfe-c

[clang] 62fa9b9 - [DebugInfo] Fix the mismatching between C++ language tags and Dwarf versions.

Author: Esme-Yi Date: 2021-04-12T07:42:54Z New Revision: 62fa9b9388aa114e3b1a58bbdbcd966ae3492ba5 URL: https://github.com/llvm/llvm-project/commit/62fa9b9388aa114e3b1a58bbdbcd966ae3492ba5 DIFF: https://github.com/llvm/llvm-project/commit/62fa9b9388aa114e3b1a58bbdbcd966ae3492ba5.diff LOG: [Debu

[clang] 731bf28 - [OpenCL] Accept .rgba in OpenCL 3.0

Author: Sven van Haastregt Date: 2021-04-12T09:30:06+01:00 New Revision: 731bf28a6092286dde6972803b35c026e32bd6b1 URL: https://github.com/llvm/llvm-project/commit/731bf28a6092286dde6972803b35c026e32bd6b1 DIFF: https://github.com/llvm/llvm-project/commit/731bf28a6092286dde6972803b35c026e32bd6b1.

[PATCH] D99969: [OpenCL] Accept .rgba in OpenCL 3.0

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG731bf28a6092: [OpenCL] Accept .rgba in OpenCL 3.0 (authored by svenvh). Changed prior to commit: https://reviews.llvm.org/D99969?vs=335557&id=3367

[PATCH] D99565: [X86] Support replacing aligned vector moves with unaligned moves when avx is enabled.

LiuChen3 added a comment. In D99565#2678073 , @craig.topper wrote: > I think I wouldn't mind if we just didn't emit aligned loads/store > instructions for AVX/AVX512 from isel and other places in the compiler in the > first place. As noted, if the load

[clang] eae3b2a - [clang][cli] Fix round-trip of OPT_plugin_arg

Author: John Brawn Date: 2021-03-30T18:33:10+01:00 New Revision: eae3b2a715d7fd1aea0ce1c78ac7a04957b72728 URL: https://github.com/llvm/llvm-project/commit/eae3b2a715d7fd1aea0ce1c78ac7a04957b72728 DIFF: https://github.com/llvm/llvm-project/commit/eae3b2a715d7fd1aea0ce1c78ac7a04957b72728.diff LO

[clang] 6bf806b - [AArch64] ACLE: Fix issue for mismatching enum types with builtins.

Author: Sander de Smalen Date: 2021-04-12T11:16:28+01:00 New Revision: 6bf806b3e2fddf79fa0326df1da341de9da35d08 URL: https://github.com/llvm/llvm-project/commit/6bf806b3e2fddf79fa0326df1da341de9da35d08 DIFF: https://github.com/llvm/llvm-project/commit/6bf806b3e2fddf79fa0326df1da341de9da35d08.di

[PATCH] D100046: [AArch64] ACLE: Fix issue for mismatching enum types with builtins.

This revision was automatically updated to reflect the committed changes. Closed by commit rG6bf806b3e2fd: [AArch64] ACLE: Fix issue for mismatching enum types with builtins. (authored by sdesmalen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1000

[PATCH] D100294: [AArch64][SVE] Fix dup/dupq intrinsics for C++.

sdesmalen created this revision. Herald added subscribers: psnobl, kristof.beyls, tschuett. Herald added a reviewer: efriedma. sdesmalen requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch changes the builtin prototype to use 'b' (bo

[PATCH] D97196: [clang-tidy] Add new check 'bugprone-unhandled-exception-at-new'.

balazske added a comment. Ping. The check now handles only check of allocation failure at `new`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97196/new/ https://reviews.llvm.org/D97196 ___ cfe-commits m

[PATCH] D90835: [RFC][clang-tidy] Ignore diagnostics due to macro expansion from not-interested headers

DmitryPolukhin added a comment. I think there is no sense to invent another HeaderFilterRegex like option to control which headers should be excluded. HeaderFilterRegex should be good enough because if you would like to see warning from the header, most probably you can fix code in the header o

[clang] c965e14 - Revert "[DebugInfo] Fix the mismatching between C++ language tags and Dwarf versions."

Author: Esme-Yi Date: 2021-04-12T10:36:46Z New Revision: c965e14a12955355ead9ea093989a8fcbf03a8c1 URL: https://github.com/llvm/llvm-project/commit/c965e14a12955355ead9ea093989a8fcbf03a8c1 DIFF: https://github.com/llvm/llvm-project/commit/c965e14a12955355ead9ea093989a8fcbf03a8c1.diff LOG: Rever

[PATCH] D99250: [DebugInfo] Fix the mismatching of C++ language tags and Dwarf versions.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG62fa9b9388aa: [DebugInfo] Fix the mismatching between C++ language tags and Dwarf versions. (authored by Esme). Repository: rG LLVM Github Monorep

[PATCH] D99250: [DebugInfo] Fix the mismatching of C++ language tags and Dwarf versions.

DavidSpickett added a comment. This change has caused a test failure in lldb. On our Arm bots: http://lab.llvm.org:8011/#/builders/96/builds/6582 Also on Linux x86_64: http://lab.llvm.org:8011/#/builders/68/builds/10277 Not windows though because `test/API/commands/frame/language/TestGuessLangu

[PATCH] D99250: [DebugInfo] Fix the mismatching of C++ language tags and Dwarf versions.

Esme added a comment. In D99250#2682598 , @DavidSpickett wrote: > This change has caused a test failure in lldb. On our Arm bots: > http://lab.llvm.org:8011/#/builders/96/builds/6582 > Also on Linux x86_64: http://lab.llvm.org:8011/#/builders/68/builds/1

[PATCH] D93543: clang-tidy: Leave the possibility of opting out having coloured diagnostic messages.

Abpostelnicu updated this revision to Diff 336797. Abpostelnicu added a comment. Add `-use-color` argument to make it sane with `clang-tidy --use-color` argument. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93543/new/ https://reviews.llvm.org/D9

[clang] dff922f - Reland [DebugInfo] Fix the mismatching between C++ language tags and Dwarf versions.""

Author: Esme-Yi Date: 2021-04-12T11:05:55Z New Revision: dff922f39b9bf49b243f6f00c7c9a2e3de77e20e URL: https://github.com/llvm/llvm-project/commit/dff922f39b9bf49b243f6f00c7c9a2e3de77e20e DIFF: https://github.com/llvm/llvm-project/commit/dff922f39b9bf49b243f6f00c7c9a2e3de77e20e.diff LOG: Relan

[PATCH] D100297: [AArch64][SVE] Always use overloaded methods instead of preprocessor macro.

sdesmalen created this revision. Herald added subscribers: psnobl, kristof.beyls, tschuett. Herald added a reviewer: efriedma. sdesmalen requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This fixes a subtle issue where: svprf(pg, ptr, SV_A

[PATCH] D100298: [Clang][Coroutine][DebugInfo] Follow-up: reduce a tests ordering requirements

jmorse created this revision. jmorse added a reviewer: dongAxis1944. Herald added subscribers: ChuanqiXu, lxfind. jmorse requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Hi, The test added in D97533 (and mo

[PATCH] D97533: [Clang][Coroutine][DebugInfo] remove useless debug info for coroutine parameters

jmorse added a comment. NB, while I flagged that CHECK-NEXT added too much ordering, I forgot that CHECK still requires some ordering. It causes us some difficulties downstream; there's a follow-up patch here D100298 for consideration. Repository: rG LLVM

[PATCH] D99231: [AST] Add introspection support for more base nodes

steveire updated this revision to Diff 336804. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99231/new/ https://reviews.llvm.org/D99231 Files: clang/include/clang/AST/DeclCXX.h clang/include/clang/Tooling/NodeI

[PATCH] D99231: [AST] Add introspection support for more base nodes

steveire added inline comments. Comment at: clang/include/clang/AST/DeclCXX.h:2270 SourceLocation getEllipsisLoc() const { -assert(isPackExpansion() && "Initializer is not a pack expansion"); +if (!isPackExpansion()) + return {}; njames93 wrote: >

[PATCH] D99262: [analyzer] Fix dead store checker false positive

martong added a comment. In D99262#2673842 , @vsavchenko wrote: > Support nested init lists Thanks for addressing the nested lists! (And sorry for the late reply, I was on vacation) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D99565: [X86] Support replacing aligned vector moves with unaligned moves when avx is enabled.

lebedev.ri added a comment. I'm still uncomfortable with changing current status quo, even though i obviously don't get to cast the final vote here. One should not use aligned loads in hope that they will cause an exception to detect address misalignment. That's UBSan's job. `-fsanitize=undefin

[PATCH] D99568: [clang][invocation] Fix copy constructor, add copy assignment to CompilerInvocation

jansvoboda11 added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99568/new/ https://reviews.llvm.org/D99568 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D100276: [clang] p1099 using enum part 1

urnathan added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:12144 NameInfo.getName().getNameKind() != DeclarationName::CXXConstructorName) { +// FIXME: 2021-04-07: When was this hack needed? Can it be deleted now? // HACK: Work around a bug in lib

[PATCH] D100276: [clang] p1099 using enum part 1

urnathan added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:12144 NameInfo.getName().getNameKind() != DeclarationName::CXXConstructorName) { +// FIXME: 2021-04-07: When was this hack needed? Can it be deleted now? // HACK: Work around a bug in lib

[PATCH] D99231: [AST] Add introspection support for more base nodes

steveire updated this revision to Diff 336813. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99231/new/ https://reviews.llvm.org/D99231 Files: clang/include/clang/AST/DeclCXX.h clang/include/clang/Tooling/NodeI

[PATCH] D99262: [analyzer] Fix dead store checker false positive

vsavchenko added a comment. In D99262#2682803 , @martong wrote: > In D99262#2673842 , @vsavchenko > wrote: > >> Support nested init lists > > Thanks for addressing the nested lists! (And sorry for the late reply, I

[PATCH] D100225: [Clang][AArch64] Coerce integer return values through an undef vector

sdesmalen added a comment. After reading the summary/intent of the patch, I thought the same thing as @rjmccall. Simply returning an i32 for the above example and removing the rounding-up seems right to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[clang] bcbea2a - [NFC] Remove redundant string copy

Author: Nathan James Date: 2021-04-12T15:13:59+01:00 New Revision: bcbea2ab84df87983fa9b30e94ea25eda0eb2338 URL: https://github.com/llvm/llvm-project/commit/bcbea2ab84df87983fa9b30e94ea25eda0eb2338 DIFF: https://github.com/llvm/llvm-project/commit/bcbea2ab84df87983fa9b30e94ea25eda0eb2338.diff

[PATCH] D98798: Produce warning for performing pointer arithmetic on a null pointer.

jamieschmeiser updated this revision to Diff 336828. jamieschmeiser added a comment. Fix indenting. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98798/new/ https://reviews.llvm.org/D98798 Files: clang/lib/Sema/SemaExpr.cpp clang/test/Sema/pointer-addition.c Index: clang/test/Sem

[PATCH] D100298: [Clang][Coroutine][DebugInfo] Follow-up: reduce a tests ordering requirements

probinson added a comment. I am not 100% convinced this has the desired effect. I believe what it does is: - Search for the first occurrence of each of "val" "moParam" and "mcParam" - After the last of the above occurrences, ensure there are no other occurrences of "val" "moParam" or "mcParam"

[PATCH] D98070: [clang-tidy] Add option to ignore macros in readability-function-cognitive-complexity check.

massberg updated this revision to Diff 336831. massberg added a comment. Add test with global IgnoreMacros=true and readability-function-cognitive-complexity.IgnoreMacros unset. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98070/new/ https://revi

[clang-tools-extra] 63bc9e4 - [clangd] Provide a way to disable external index

Author: Kadir Cetinkaya Date: 2021-04-12T16:43:23+02:00 New Revision: 63bc9e443502ab6def2dec0b5ffe64a522f801cc URL: https://github.com/llvm/llvm-project/commit/63bc9e443502ab6def2dec0b5ffe64a522f801cc DIFF: https://github.com/llvm/llvm-project/commit/63bc9e443502ab6def2dec0b5ffe64a522f801cc.dif

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

Anastasia added inline comments. Comment at: clang/include/clang/AST/Type.h:493 + // Default is a superset of SYCL address spaces. + (A == LangAS::Default && +(B == LangAS::sycl_private || B == LangAS::sycl_local || bader wrote: >

[PATCH] D98070: [clang-tidy] Add option to ignore macros in readability-function-cognitive-complexity check.

lebedev.ri accepted this revision. lebedev.ri added a comment. This revision is now accepted and ready to land. K, thx. Comment at: clang-tools-extra/docs/clang-tidy/checks/readability-function-cognitive-complexity.rst:31 + any macro arguments are ignored, even if they shoul

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

Anastasia added inline comments. Comment at: clang/test/CodeGenSYCL/address-space-parameter-conversions.cpp:80 + // Ensure that we still get 3 different template instantiations. + tmpl(GLOB); + // CHECK-DAG: [[GLOB_LOAD4:%[a-zA-Z0-9]+]] = load i32 addrspace(1)*, i32 addrspace

[PATCH] D100266: [RISCV][Clang] Add vmv and vfmv series intrinsic functions.

khchen added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:1001 +["x", "Uv", "UvUe"]]>; +} Jim wrote: > I am not sure that indent is needed inside let expression. In some cases, it > don't have inden

[PATCH] D97683: [clang-tidy] Add include to misc-uniqueptr-reset-release

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97683/new/ https://reviews.llvm.org/D97683 __

[PATCH] D97196: [clang-tidy] Add new check 'bugprone-unhandled-exception-at-new'.

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/UnhandledExceptionAtNewCheck.cpp:28-30 +// Generic catch handler should match anything. +if (CatchS->getCaughtType().isNull()) + return true; I think this should

[PATCH] D99250: [DebugInfo] Fix the mismatching of C++ language tags and Dwarf versions.

DavidSpickett added a subscriber: omjavaid. DavidSpickett added a comment. Ah, @omjavaid already put in a fix. I think you can just reland the change now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99250/new/ https://reviews.llvm.org/D99250 ___

[PATCH] D100310: Add field designated initializers logic in Tooling/Rename

dcastagna created this revision. Herald added a subscriber: jfb. dcastagna requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. clang Tooling, and more specifically Refactoring/Rename, have support code to extract source locations given a Unifie

[PATCH] D100294: [AArch64][SVE] Fix dup/dupq intrinsics for C++.

kmclaughlin accepted this revision. kmclaughlin added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100294/new/ https://reviews.llvm.org/D100294

[PATCH] D98070: [clang-tidy] Add option to ignore macros in readability-function-cognitive-complexity check.

massberg updated this revision to Diff 336848. massberg added a comment. Add note that the new IgnoreMarcos options isn't guaranteed to be forward compatible. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98070/new/ https://reviews.llvm.org/D98070

[PATCH] D100282: [Coroutines] Move CoroEarly pass to before AlwaysInliner

lxfind updated this revision to Diff 336850. lxfind added a comment. Set the attributes in Clang instead of CoroEarly Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100282/new/ https://reviews.llvm.org/D100282 Files: clang/lib/CodeGen/CGCoroutine

[PATCH] D99683: [HIP] Support ThinLTO

tejohnson added a comment. In D99683#2677357 , @yaxunl wrote: > Any other concerns? Thanks. I have some concerns around the fragility of this, for the reasons I mentioned earlier where it may not always be able to import everything needed. > We will doc

[PATCH] D98070: [clang-tidy] Add option to ignore macros in readability-function-cognitive-complexity check.

massberg marked an inline comment as done. massberg added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/readability-function-cognitive-complexity.rst:31 + any macro arguments are ignored, even if they should count to the complexity. + Default is `fal

[PATCH] D100310: Add field designated initializers logic in Tooling/Rename

jlebar accepted this revision. jlebar added a comment. This revision is now accepted and ready to land. I can't argue with this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100310/new/ https://reviews.llvm.org/D100310 ___

[PATCH] D99683: [HIP] Support ThinLTO

tejohnson requested changes to this revision. tejohnson added a comment. This revision now requires changes to proceed. To do what I suggested in the prior comment, you'd probably want to add a new index-wide flag (since we don't read IR in the thin link). See for example how EnableSplitLTOUnit

[PATCH] D100148: [Driver] Fix compiler-rt lookup for x32

glaubitz added a comment. Hi! Can we get this patch merged as-is or do we need anything else? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100148/new/ https://reviews.llvm.org/D100148 ___ cfe-commits ma

[PATCH] D98070: [clang-tidy] Add option to ignore macros in readability-function-cognitive-complexity check.

alexfh accepted this revision. alexfh added a comment. LG with a couple of nits. Comment at: clang-tools-extra/clang-tidy/readability/FunctionCognitiveComplexityCheck.cpp:230 + explicit FunctionASTVisitor(const bool IgnoreMacros) + : IgnoreMacros(IgnoreMacros){}; + -

[clang] 38cf112 - Allow applying attributes to subset of allowed subjects.

Author: Artem Belevich Date: 2021-04-12T09:33:33-07:00 New Revision: 38cf112a6bc8502ff8cce6ef524cf04c07f90f96 URL: https://github.com/llvm/llvm-project/commit/38cf112a6bc8502ff8cce6ef524cf04c07f90f96 DIFF: https://github.com/llvm/llvm-project/commit/38cf112a6bc8502ff8cce6ef524cf04c07f90f96.diff

[PATCH] D100136: Allow applying attributes to subset of allowed subjects.

This revision was automatically updated to reflect the committed changes. Closed by commit rG38cf112a6bc8: Allow applying attributes to subset of allowed subjects. (authored by tra). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100136/new/ https://

[PATCH] D98070: [clang-tidy] Add option to ignore macros in readability-function-cognitive-complexity check.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8a944d82cd14: [clang-tidy] Add option to ignore macros in readability-function-cognitive… (authored by massberg, committed by alexfh). Repository:

[clang-tools-extra] 8a944d8 - [clang-tidy] Add option to ignore macros in readability-function-cognitive-complexity check.

Author: Jens Massberg Date: 2021-04-12T18:46:12+02:00 New Revision: 8a944d82cd14001a92ef088229041ee0fb1fd1e6 URL: https://github.com/llvm/llvm-project/commit/8a944d82cd14001a92ef088229041ee0fb1fd1e6 DIFF: https://github.com/llvm/llvm-project/commit/8a944d82cd14001a92ef088229041ee0fb1fd1e6.diff

[clang-tools-extra] 8883cb3 - Fix nits.

Author: Alexander Kornienko Date: 2021-04-12T18:46:13+02:00 New Revision: 8883cb3e4004aebddf9bd0f92ea47ba897397794 URL: https://github.com/llvm/llvm-project/commit/8883cb3e4004aebddf9bd0f92ea47ba897397794 DIFF: https://github.com/llvm/llvm-project/commit/8883cb3e4004aebddf9bd0f92ea47ba897397794

[PATCH] D100085: [X86] Support -march=rocketlake

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100085/new/ https://reviews.llvm.org/D100085 ___

[PATCH] D100310: Add field designated initializers logic in Tooling/Rename

dcastagna updated this revision to Diff 336878. dcastagna added a comment. Fixed clang-format pre-merge lints Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100310/new/ https://reviews.llvm.org/D100310 Files: clang/include/clang/Tooling/Refactori

[PATCH] D100266: [RISCV][Clang] Add vmv and vfmv series intrinsic functions.

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100266/new/ https://reviews.llvm.org/D100266 ___

[PATCH] D99790: [CGCall] Annotate `this` argument with alignment

sanwou01 added a comment. +1 on eagerly awaiting a fix. a 3% regression on astar (AArch64, LTO) bisects to @lebedev.ri 's revert: https://reviews.llvm.org/rG6270b3a1eafaba4279e021418c5a2c5a35abc002 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D9

[PATCH] D100161: Redistribute energy for Corpus

morehouse added a subscriber: metzman. morehouse added a comment. Thanks for sharing your data. Took a quick look and seems promising. I would like to try this on FuzzBench before accepting the patch though. FuzzBench has a very nice experimental framework for evaluating changes like this. >

[PATCH] D100161: Redistribute energy for Corpus

morehouse added a comment. Also, the descriptions states: > Divide the corpus into n parts according to size. Is it really according to size? IIUC when there are multiple worker processes, any new coverage they have simply gets appended to `Files`. So `Files` is not necessarily sorted by siz

[PATCH] D99517: Implemented [[clang::musttail]] attribute for guaranteed tail calls.

haberman updated this revision to Diff 336894. haberman added a comment. - Switch to isa<> for type check. - Merge branch 'main' into musttail Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99517/new/ https://reviews.llvm.org/D99517 Files: clang/

[PATCH] D99517: Implemented [[clang::musttail]] attribute for guaranteed tail calls.

haberman marked an inline comment as done. haberman added inline comments. Comment at: clang/lib/Sema/SemaStmt.cpp:697-699 + } else if (VD && dyn_cast(VD->getType())) { +// Call is: obj->*method_ptr or obj.*method_ptr +const auto *MPT = VD->getType()->castAs(); -

[clang] 0a92aff - Replace uses of std::iterator with explicit using

Author: Hamza Sood Date: 2021-04-12T10:47:14-07:00 New Revision: 0a92aff721f43406691e38a0965fd0c917121d09 URL: https://github.com/llvm/llvm-project/commit/0a92aff721f43406691e38a0965fd0c917121d09 DIFF: https://github.com/llvm/llvm-project/commit/0a92aff721f43406691e38a0965fd0c917121d09.diff LO

[PATCH] D67586: Replace uses of std::iterator with explicit using

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0a92aff721f4: Replace uses of std::iterator with explicit using (authored by hamzasood, committed by MaskRay). Herald added a project: clang. Herald

[PATCH] D100310: Add field designated initializers logic in Tooling/Rename

dcastagna updated this revision to Diff 336900. dcastagna added a comment. Actually run git clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100310/new/ https://reviews.llvm.org/D100310 Files: clang/include/clang/Tooling/Refactoring/Re

[PATCH] D100148: [Driver] Fix compiler-rt lookup for x32

hvdijk added a comment. In D100148#2683325 , @glaubitz wrote: > Hi! Can we get this patch merged as-is or do we need anything else? Sorry, miscommunication. I was thinking you could use this to update D99988 to actually

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

bader marked an inline comment as done. bader added inline comments. Comment at: clang/include/clang/AST/Type.h:488 (A == LangAS::opencl_global && (B == LangAS::opencl_global_device || B == LangAS::opencl_global_host)) ||

[PATCH] D100148: [Driver] Fix compiler-rt lookup for x32

glaubitz added a comment. In D100148#2683710 , @hvdijk wrote: > In D100148#2683325 , @glaubitz > wrote: > >> Hi! Can we get this patch merged as-is or do we need anything else? > > Sorry, miscommunication. I was

[PATCH] D100148: [Driver] Fix compiler-rt lookup for x32

hvdijk added a comment. In D100148#2683748 , @glaubitz wrote: > Understood. However, I'm not really sure what else we need. Do we just take > the architecture definition from here to pass the proper flags to the > compiler or do we also need to add > so

[PATCH] D99732: [AST] Pick last tentative definition as the acting definition

pestctrl added a comment. Ping! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99732/new/ https://reviews.llvm.org/D99732 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D100187: [OPENMP]Fix PR49115: Incorrect results for scan directive.

ABataev updated this revision to Diff 336909. ABataev added a comment. Rebase + fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100187/new/ https://reviews.llvm.org/D100187 Files: clang/lib/CodeGen/CGStmtOpenMP.cpp clang/lib/Sema/SemaOpenM

[PATCH] D99568: [clang][invocation] Fix copy constructor, add copy assignment to CompilerInvocation

dexonsmith added a comment. In D99568#2682815 , @jansvoboda11 wrote: > Ping. Thanks for the ping; I'd completely missed your follow-up. Just fixing AnalyzerOptions for now sounds great. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D100310: Add field designated initializers logic in Tooling/Rename

dcastagna updated this revision to Diff 336912. dcastagna added a comment. clang-format again Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100310/new/ https://reviews.llvm.org/D100310 Files: clang/include/clang/Tooling/Refactoring/RecursiveSymb

[clang-tools-extra] fc1e146 - Fix documentation typo.

Author: Richard Smith Date: 2021-04-12T11:39:08-07:00 New Revision: fc1e146e4412334d6c70173c345a698a01b122b8 URL: https://github.com/llvm/llvm-project/commit/fc1e146e4412334d6c70173c345a698a01b122b8 DIFF: https://github.com/llvm/llvm-project/commit/fc1e146e4412334d6c70173c345a698a01b122b8.diff

Re: [PATCH] D100310: Add field designated initializers logic in Tooling/Rename

I guess you need me or Michael to push this. Happy to do so once you're happy with it. On Mon, Apr 12, 2021 at 11:33 AM Daniele Castagna via Phabricator < revi...@reviews.llvm.org> wrote: > dcastagna updated this revision to Diff 336912. > dcastagna added a comment. > > clang-format again > > >

[PATCH] D99903: [Clang][Sema] better -Wcast-function-type diagnose for pointer parameters and parameters with cv-qualifiers

ychen added a comment. ping.. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99903/new/ https://reviews.llvm.org/D99903 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[PATCH] D100310: Add field designated initializers logic in Tooling/Rename

dcastagna added a comment. Thank you Justin. I'm happy with this now that I finally managed to get rid of the lint errors. Let's wait for Micheal's opinion or until tomorrow and then we can push it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1003

[PATCH] D99580: [CLANG] [DebugInfo] Convert File name to native format

amccarth added a comment. Sorry, I think I've lost track of some context while I was on vacation. I don't understand why several of the tests are now unsupported on Windows. Some of those seem like important tests. If canonicalizing the file names to the platform's native style creates new t

[clang] 06c8b29 - Enable creation of large response file on z/OS

Author: Sean Perry Date: 2021-04-12T15:06:05-04:00 New Revision: 06c8b29d23ac2e3a44f2a2f3af85b15dc8aab3c2 URL: https://github.com/llvm/llvm-project/commit/06c8b29d23ac2e3a44f2a2f3af85b15dc8aab3c2 DIFF: https://github.com/llvm/llvm-project/commit/06c8b29d23ac2e3a44f2a2f3af85b15dc8aab3c2.diff LO

[PATCH] D100197: Enable creation of large response file on z/OS

This revision was automatically updated to reflect the committed changes. Closed by commit rG06c8b29d23ac: Enable creation of large response file on z/OS (authored by SeanP, committed by abhina.sreeskantharajan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[clang] 661cc71 - [PassManager][PhaseOrdering] lower expects before running simplifyCFG

Author: Sanjay Patel Date: 2021-04-12T15:07:53-04:00 New Revision: 661cc71a1c50081389d73b2baae02f51df670ba1 URL: https://github.com/llvm/llvm-project/commit/661cc71a1c50081389d73b2baae02f51df670ba1 DIFF: https://github.com/llvm/llvm-project/commit/661cc71a1c50081389d73b2baae02f51df670ba1.diff

[PATCH] D93822: [clang-tidy] Add check for implicit widening of multiplication result

aaron.ballman added a comment. FWIW, it looks like tests are still failing on Windows according to the CI pipeline. Comment at: clang-tools-extra/clang-tidy/bugprone/ImplicitWideningOfMultiplicationResultCheck.cpp:126 + QualType SizeTy = IndexExprType->isSignedIntegerType()

[PATCH] D100057: Remove warning "suggest braces" for aggregate initialization of an empty class with an aggregate base class.

rsmith accepted this revision. rsmith added a comment. Thanks, I think this makes sense as a generalization of the existing "idiomatic aggregate initialization" rule. Some suggested cleanups but otherwise LGTM. Comment at: clang/lib/Sema/SemaInit.cpp:1001 /// the braces in ag

[PATCH] D100310: Add field designated initializers logic in Tooling/Rename

mkuper added a comment. I defer to Justin, he knows AST much better than I do. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100310/new/ https://reviews.llvm.org/D100310 ___ cfe-commits mailing list cfe-

[clang] 7dd6068 - [clang-rename] Handle designated initializers.

Author: Daniele Castagna Date: 2021-04-12T13:15:14-07:00 New Revision: 7dd60688992526bb7ee0c7846e9abd591fc3e297 URL: https://github.com/llvm/llvm-project/commit/7dd60688992526bb7ee0c7846e9abd591fc3e297 DIFF: https://github.com/llvm/llvm-project/commit/7dd60688992526bb7ee0c7846e9abd591fc3e297.di

[PATCH] D100310: Add field designated initializers logic in Tooling/Rename

This revision was automatically updated to reflect the committed changes. Closed by commit rG7dd606889925: [clang-rename] Handle designated initializers. (authored by dcastagna, committed by jlebar). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1003

[PATCH] D100124: [Clang][NVPTX] Add NVPTX intrinsics and builtins for CUDA PTX redux.sync instructions

tra added inline comments. Comment at: clang/include/clang/Basic/BuiltinsNVPTX.def:460-468 +TARGET_BUILTIN(__nvvm_redux_sync_add_s32, "SiSii", "", SM_80) +TARGET_BUILTIN(__nvvm_redux_sync_min_s32, "SiSii", "", SM_80) +TARGET_BUILTIN(__nvvm_redux_sync_max_s32, "SiSii", "", SM_80)

[PATCH] D100251: [IR][sanitizer] Set nounwind on module ctor/dtor, additionally set uwtable if -fasynchronous-unwind-tables

nickdesaulniers added a comment. > -fno-exceptions -fno-asynchronous-unwind-tables -g produces .debug_frame > while > -fno-exceptions -fno-asynchronous-unwind-tables -g -fsanitize=address > produces .eh_frame. Does this patch change that behavior? Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D100251: [IR][sanitizer] Set nounwind on module ctor/dtor, additionally set uwtable if -fasynchronous-unwind-tables

MaskRay added a comment. In D100251#2684074 , @nickdesaulniers wrote: >> -fno-exceptions -fno-asynchronous-unwind-tables -g produces .debug_frame >> while >> -fno-exceptions -fno-asynchronous-unwind-tables -g -fsanitize=address >> produces .eh_frame. >

[PATCH] D100251: [IR][sanitizer] Set nounwind on module ctor/dtor, additionally set uwtable if -fasynchronous-unwind-tables

nickdesaulniers added a comment. In D100251#2684083 , @MaskRay wrote: > In D100251#2684074 , > @nickdesaulniers wrote: > >>> -fno-exceptions -fno-asynchronous-unwind-tables -g produces .debug_frame >>> while >>>

[PATCH] D100343: [AST][NFC] Remove temporary ASTTU file from Introspection generation.

njames93 created this revision. njames93 added a reviewer: steveire. Herald added a subscriber: mgorny. njames93 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We can use the Preprocessor to remap this file, cleaning up the cmake code. R

  1   2   >